d36adbacaf
The former contents of the VM isolate are now included into each isolate group. This makes each isolate group's heap independent, and in particular allows each heap to be allocated to a separate pointer cage (not done in this CL). The duplicated stubs that allowed PC relative calls are removed, since the originals can now be the target of PC relative calls. The bootstrapping needing to load an AppJIT or AppAOT snapshot is reduced to allocating the oddballs. The code is entirely dropped in the AOT runtime, but the JIT runtime still has it to allow for flags to affect the compilation of the stub code. Further refactoring might be able to remove this for the JIT runtime too, with only gen_snapshot knowing how to bootstrap. Class serialization no longer distinguishes predefined classes. The page containing null is marked as never-evacuate. null, false and true must not move because the compiler relies on their low bits having certain patterns for some optimizations. (Previously, the entire VM isolate heap never moved.) Compaction is disabled for IA32. Due to register pressure, some stub calls must not use a scratch register and embed the address of Code. The page containing the call-through-safepoint stub is frozen when running with --write-protect-code and the stub is created at runtime (instead of loaded from an AppJIT or AppAOT snapshot). This stub must remain executable even during a safepoint, as a foreign call might during return during a safepoint and only block after the stub directs it to the runtime. The snapshot symbols are renamed to kDartSnapshotData and kDartSnapshotText. There is no need to distinguish the VM isolate's snapshot, and snaphots are per isolate group not per isolate. Aliases with the old names are added to ease migration. Some global flags that were automatically set based on the VM isolate's snapshot are now isolate group flags and automatically set by the isolate group's snapshot. TEST=ci Change-Id: Iee82016057d609112e9b021d178fc3d4d18b5044 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500621 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
230 lines
11 KiB
Bash
Executable File
230 lines
11 KiB
Bash
Executable File
#!/bin/sh
|
|
# Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
# This bot keeps benchmarks working. See messages below for details.
|
|
|
|
# If you need to change this script, you must also send a changelist to the
|
|
# benchmark system before submitting the change to this script. If you benchmark
|
|
# anything, you must test that basic benchmarking works in this file.
|
|
|
|
# Person responsible for maintaining this bot and available for questions.
|
|
owner=sortie
|
|
|
|
if [ $# -lt 1 ]; then
|
|
cat << EOF
|
|
Usage: $0 COMMAND ..."
|
|
|
|
Where COMMAND is one of:"
|
|
|
|
noop - Just print description.
|
|
clean - Remove out/ directory.
|
|
linux-x64-build - Build linux-x64 for benchmarking.
|
|
linux-x64-archive - Archive linux-x64.
|
|
linux-x64-benchmark - Try linux-x64 benchmarking.
|
|
EOF
|
|
exit 1
|
|
fi
|
|
|
|
echo "This bot tests the interfaces the benchmark system expects to exist."
|
|
echo " "
|
|
echo "The command being run is: $0 $@"
|
|
echo " "
|
|
echo "Please reach out to $owner@ if you have any questions."
|
|
echo " "
|
|
echo "If this bot fails, you have made an incompatible change to the interfaces"
|
|
echo "expected by the benchmark system. Please, before landing your change,"
|
|
echo "first upload a changelist for review that updates the benchmark system"
|
|
echo "accordingly, then according to the approval of that changelist, update"
|
|
echo "update this bot to test the new interface the benchmark system expects."
|
|
echo "You are responsible for not breaking the benchmarks."
|
|
echo " "
|
|
|
|
on_shell_exit() {
|
|
EXIT_CODE=$?
|
|
set +x
|
|
if [ $EXIT_CODE != 0 ]; then
|
|
echo " "
|
|
echo "This bot failed because benchmarks would fail. Please see the message"
|
|
echo "near the top of this log. Please reach out to $owner@ if you have any"
|
|
echo "questions about this bot."
|
|
fi
|
|
}
|
|
trap on_shell_exit EXIT
|
|
|
|
PS4='# Exit: $?
|
|
################################################################################
|
|
# Command: '
|
|
|
|
set -e # Fail on error.
|
|
set -x # Debug which shell commands are run.
|
|
|
|
for command; do
|
|
if [ "$command" = noop ]; then
|
|
:
|
|
elif [ "$command" = clean ]; then
|
|
rm -rf out
|
|
rm -rf tmp
|
|
rm -f linux-x64.tar.gz
|
|
rm -f linux-x64_profile.tar.gz
|
|
elif [ "$command" = linux-x64-build ]; then
|
|
# NOTE: These are duplicated in tools/bots/test_matrix.json, keep in sync.
|
|
./tools/build.py --mode=release --arch=x64 create_sdk runtime gen_snapshot dartaotruntime dart2js_platform.dill kernel-service.dart.snapshot ddc_stable_test ddc_canary_test dart2wasm_benchmark
|
|
elif [ "$command" = linux-x64-archive ]; then
|
|
export GZIP=-1
|
|
strip -w \
|
|
-K 'kDartVmSnapshotData' \
|
|
-K 'kDartVmSnapshotInstructions' \
|
|
-K 'kDartCoreIsolateSnapshotData' \
|
|
-K 'kDartCoreIsolateSnapshotInstructions' \
|
|
-K 'kDartCoreSnapshotData' \
|
|
-K 'kDartCoreSnapshotText' \
|
|
-K '_ZN4dart3bin7Builtin22_builtin_source_paths_E' \
|
|
-K '_ZN4dart3bin7Builtin*_paths_E' \
|
|
-K '_ZN4dart3bin18core_snapshot_dataE' \
|
|
-K '_ZN4dart3bin18core_snapshot_textE' \
|
|
-K '_ZN4dart3binL17vm_snapshot_data_E' \
|
|
-K '_ZN4dart3binL24isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL27core_isolate_snapshot_data_E' \
|
|
-K '_ZN4dart3binL27vm_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL29core_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart7Version14snapshot_hash_E' \
|
|
-K '_ZN4dart7Version4str_E' \
|
|
-K '_ZN4dart7Version7commit_E' \
|
|
-K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/dart
|
|
strip -w \
|
|
-K 'kDartVmSnapshotData' \
|
|
-K 'kDartVmSnapshotInstructions' \
|
|
-K 'kDartCoreIsolateSnapshotData' \
|
|
-K 'kDartCoreIsolateSnapshotInstructions' \
|
|
-K 'kDartCoreSnapshotData' \
|
|
-K 'kDartCoreSnapshotText' \
|
|
-K '_ZN4dart3bin7Builtin22_builtin_source_paths_E' \
|
|
-K '_ZN4dart3bin7Builtin*_paths_E' \
|
|
-K '_ZN4dart3bin18core_snapshot_dataE' \
|
|
-K '_ZN4dart3bin18core_snapshot_textE' \
|
|
-K '_ZN4dart3binL17vm_snapshot_data_E' \
|
|
-K '_ZN4dart3binL24isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL27core_isolate_snapshot_data_E' \
|
|
-K '_ZN4dart3binL27vm_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL29core_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart7Version14snapshot_hash_E' \
|
|
-K '_ZN4dart7Version4str_E' \
|
|
-K '_ZN4dart7Version7commit_E' \
|
|
-K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/gen_snapshot
|
|
strip -w \
|
|
-K 'kDartVmSnapshotData' \
|
|
-K 'kDartVmSnapshotInstructions' \
|
|
-K 'kDartCoreIsolateSnapshotData' \
|
|
-K 'kDartCoreIsolateSnapshotInstructions' \
|
|
-K 'kDartCoreSnapshotData' \
|
|
-K 'kDartCoreSnapshotText' \
|
|
-K '_ZN4dart3bin7Builtin22_builtin_source_paths_E' \
|
|
-K '_ZN4dart3bin7Builtin*_paths_E' \
|
|
-K '_ZN4dart3bin18core_snapshot_dataE' \
|
|
-K '_ZN4dart3bin18core_snapshot_textE' \
|
|
-K '_ZN4dart3binL17vm_snapshot_data_E' \
|
|
-K '_ZN4dart3binL24isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL27core_isolate_snapshot_data_E' \
|
|
-K '_ZN4dart3binL27vm_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL29core_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart7Version14snapshot_hash_E' \
|
|
-K '_ZN4dart7Version4str_E' \
|
|
-K '_ZN4dart7Version7commit_E' \
|
|
-K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/run_vm_tests
|
|
strip -w \
|
|
-K 'kDartVmSnapshotData' \
|
|
-K 'kDartVmSnapshotInstructions' \
|
|
-K 'kDartCoreIsolateSnapshotData' \
|
|
-K 'kDartCoreIsolateSnapshotInstructions' \
|
|
-K 'kDartCoreSnapshotData' \
|
|
-K 'kDartCoreSnapshotText' \
|
|
-K '_ZN4dart3bin7Builtin22_builtin_source_paths_E' \
|
|
-K '_ZN4dart3bin7Builtin*_paths_E' \
|
|
-K '_ZN4dart3bin18core_snapshot_dataE' \
|
|
-K '_ZN4dart3bin18core_snapshot_textE' \
|
|
-K '_ZN4dart3binL17vm_snapshot_data_E' \
|
|
-K '_ZN4dart3binL24isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL27core_isolate_snapshot_data_E' \
|
|
-K '_ZN4dart3binL27vm_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart3binL29core_isolate_snapshot_buffer_E' \
|
|
-K '_ZN4dart7Version14snapshot_hash_E' \
|
|
-K '_ZN4dart7Version4str_E' \
|
|
-K '_ZN4dart7Version7commit_E' \
|
|
-K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/dartaotruntime
|
|
tar -czf linux-x64.tar.gz \
|
|
--exclude .git \
|
|
--exclude .gitignore \
|
|
--exclude pkg/front_end/testcases \
|
|
-- \
|
|
out/ReleaseX64/dart2js_platform.dill \
|
|
out/ReleaseX64/dart2wasm_outline.dill \
|
|
out/ReleaseX64/dart2wasm_platform.dill \
|
|
out/ReleaseX64/vm_outline.dill \
|
|
out/ReleaseX64/vm_platform.dill \
|
|
out/ReleaseX64/gen/kernel_service.dill \
|
|
out/ReleaseX64/dart-sdk \
|
|
out/ReleaseX64/dart \
|
|
out/ReleaseX64/dartvm \
|
|
out/ReleaseX64/gen_snapshot \
|
|
out/ReleaseX64/kernel-service.dart.snapshot \
|
|
out/ReleaseX64/dart2wasm.snapshot \
|
|
out/ReleaseX64/wasm-opt \
|
|
out/ReleaseX64/run_vm_tests \
|
|
third_party/d8/linux/x64 \
|
|
third_party/firefox_jsshell/ \
|
|
out/ReleaseX64/dartaotruntime \
|
|
out/ReleaseX64/gen/utils/ddc \
|
|
out/ReleaseX64/ddc_outline.dill \
|
|
sdk \
|
|
pkg/compiler/test/codesize/swarm \
|
|
third_party/pkg \
|
|
.dart_tool/package_config.json \
|
|
pkg \
|
|
benchmarks \
|
|
|| (rm -f linux-x64.tar.gz; exit 1)
|
|
elif [ "$command" = linux-x64-benchmark ]; then
|
|
rm -rf tmp
|
|
mkdir tmp
|
|
cd tmp
|
|
tar -xf ../linux-x64.tar.gz
|
|
cat > hello.dart << EOF
|
|
main() {
|
|
print("Hello, World");
|
|
}
|
|
EOF
|
|
out/ReleaseX64/dart --profile-period=10000 hello.dart
|
|
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 hello.dart blob.bin
|
|
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
|
|
out/ReleaseX64/dart --profile-period=10000 --optimization-counter-threshold=-1 hello.dart
|
|
DART_CONFIGURATION=ReleaseX64 pkg/dart2wasm/tool/compile_benchmark hello.dart hello.wasm
|
|
DART_CONFIGURATION=ReleaseX64 pkg/dart2wasm/tool/run_benchmark hello.wasm
|
|
out/ReleaseX64/dart-sdk/bin/dart compile js --out=out.js -m hello.dart
|
|
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/seal_native_object.js sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
|
|
out/ReleaseX64/dart-sdk/bin/dart compile js --out=out.js -m hello.dart
|
|
LD_LIBRARY_PATH=third_party/firefox_jsshell/ third_party/firefox_jsshell/js -f sdk/lib/_internal/js_runtime/lib/preambles/seal_native_object.js -f sdk/lib/_internal/js_runtime/lib/preambles/jsshell.js -f out.js
|
|
out/ReleaseX64/dart-sdk/bin/dart compile js --benchmarking-production --out=out.js -m hello.dart
|
|
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/seal_native_object.js sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
|
|
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 hello.dart
|
|
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
|
|
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary hello.dart
|
|
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
|
|
out/ReleaseX64/dart-sdk/bin/dart pkg/analysis_server/benchmark/benchmarks.dart run --quick --repeat 1 analysis-server-cold
|
|
echo '[{"name":"foo","edits":[["pkg/compiler/lib/src/dart2js.dart","2016","2017"],["pkg/compiler/lib/src/options.dart","2016","2017"]]}]' > appjit_train_edits.json
|
|
out/ReleaseX64/dart --background-compilation=false --snapshot-kind=app-jit --snapshot=pkg/front_end/tool/incremental_perf.dart.appjit pkg/front_end/tool/incremental_perf.dart --target=vm --sdk-summary=out/ReleaseX64/vm_platform.dill --sdk-library-specification=sdk/lib/libraries.json pkg/compiler/lib/src/dart2js.dart appjit_train_edits.json
|
|
out/ReleaseX64/dart --background-compilation=false pkg/front_end/tool/incremental_perf.dart.appjit --target=vm --sdk-summary=out/ReleaseX64/vm_platform.dill --sdk-library-specification=sdk/lib/libraries.json pkg/front_end/benchmarks/ikg/hello.dart pkg/front_end/benchmarks/ikg/hello.edits.json
|
|
out/ReleaseX64/dart pkg/kernel/test/binary_bench.dart --golem AstFromBinaryLazy out/ReleaseX64/vm_platform.dill
|
|
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot InitialRSS
|
|
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot KernelServiceCompileAll
|
|
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot UseDartApi
|
|
out/ReleaseX64/dart --profile-period=10000 benchmarks/Example/dart/Example.dart
|
|
out/ReleaseX64/dart --profile-period=10000 benchmarks/IsolateSpawn/dart/IsolateSpawn.dart
|
|
cd ..
|
|
rm -rf tmp
|
|
else
|
|
echo "$0: Unknown command $command" >&2
|
|
exit 1
|
|
fi
|
|
done
|