Daco Harkes
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
51 lines
1.3 KiB
C++
51 lines
1.3 KiB
C++
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_THREAD_STACK_RESOURCE_H_
|
|
#define RUNTIME_VM_THREAD_STACK_RESOURCE_H_
|
|
|
|
#include <type_traits>
|
|
#include <utility>
|
|
|
|
#include "vm/allocation.h"
|
|
#include "vm/globals.h"
|
|
|
|
namespace dart {
|
|
|
|
class Isolate;
|
|
class IsolateGroup;
|
|
class ThreadState;
|
|
class Thread;
|
|
|
|
class ThreadStackResource : public StackResource {
|
|
public:
|
|
explicit ThreadStackResource(Thread* T)
|
|
: StackResource(reinterpret_cast<ThreadState*>(T)) {}
|
|
|
|
~ThreadStackResource();
|
|
|
|
Thread* thread() const {
|
|
return reinterpret_cast<Thread*>(StackResource::thread());
|
|
}
|
|
Isolate* isolate() const;
|
|
IsolateGroup* isolate_group() const;
|
|
};
|
|
|
|
template <typename T, typename... Args>
|
|
class AsThreadStackResource : public ThreadStackResource {
|
|
public:
|
|
static_assert(!std::is_base_of<StackResource, T>::value);
|
|
explicit AsThreadStackResource(Thread* thread, Args&&... args)
|
|
: ThreadStackResource(thread),
|
|
member_(thread, std::forward<Args>(args)...) {}
|
|
~AsThreadStackResource() {}
|
|
|
|
private:
|
|
T member_;
|
|
};
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_THREAD_STACK_RESOURCE_H_
|