Alexander Markov
6195ea86bc
In the VM, factory constructors always had an extra "type arguments" parameter, even if class is not generic. Factory constructor bodies were using class type parameters instead of function type parameters. This results in extra code when calling non-generic factories which is slightly inefficient in terms of code size and performance. Also, it creates an additional complexity throughout the system as factories should be special cased in many places. This change removes artificial "type arguments" parameter, treating factory constructors basically as static methods. This matches kernel AST representation. TEST=ci Change-Id: I957583cb2ce9a3c408699880a04036e06b01dd31 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/501762 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
76 lines
2.8 KiB
C++
76 lines
2.8 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/assert.h"
|
|
#include "vm/bootstrap_natives.h"
|
|
#include "vm/exceptions.h"
|
|
#include "vm/native_entry.h"
|
|
#include "vm/object.h"
|
|
|
|
namespace dart {
|
|
|
|
DEFINE_NATIVE_ENTRY(List_allocate, 1, 1) {
|
|
// Implemented in FlowGraphBuilder::VisitNativeBody.
|
|
UNREACHABLE();
|
|
return Object::null();
|
|
}
|
|
|
|
DEFINE_NATIVE_ENTRY(List_setIndexed, 0, 3) {
|
|
const Array& array = Array::CheckedHandle(zone, arguments->NativeArgAt(0));
|
|
GET_NON_NULL_NATIVE_ARGUMENT(Smi, index, arguments->NativeArgAt(1));
|
|
const Instance& value =
|
|
Instance::CheckedHandle(zone, arguments->NativeArgAt(2));
|
|
if ((index.Value() < 0) || (index.Value() >= array.Length())) {
|
|
Exceptions::ThrowRangeError("index", index, 0, array.Length() - 1);
|
|
}
|
|
array.SetAt(index.Value(), value);
|
|
return Object::null();
|
|
}
|
|
|
|
DEFINE_NATIVE_ENTRY(List_getLength, 0, 1) {
|
|
const Array& array = Array::CheckedHandle(zone, arguments->NativeArgAt(0));
|
|
return Smi::New(array.Length());
|
|
}
|
|
|
|
// ObjectArray src, int start, int count, bool needTypeArgument.
|
|
DEFINE_NATIVE_ENTRY(List_slice, 0, 4) {
|
|
const Array& src = Array::CheckedHandle(zone, arguments->NativeArgAt(0));
|
|
GET_NON_NULL_NATIVE_ARGUMENT(Smi, start, arguments->NativeArgAt(1));
|
|
GET_NON_NULL_NATIVE_ARGUMENT(Smi, count, arguments->NativeArgAt(2));
|
|
GET_NON_NULL_NATIVE_ARGUMENT(Bool, needs_type_arg, arguments->NativeArgAt(3));
|
|
intptr_t istart = start.Value();
|
|
if ((istart < 0) || (istart > src.Length())) {
|
|
Exceptions::ThrowRangeError("start", start, 0, src.Length());
|
|
}
|
|
intptr_t icount = count.Value();
|
|
// Zero count should be handled outside already.
|
|
if ((icount <= 0) || (icount > src.Length())) {
|
|
Exceptions::ThrowRangeError("count", count,
|
|
0, // This is the limit the user sees.
|
|
src.Length() - istart);
|
|
}
|
|
|
|
return src.Slice(istart, icount, needs_type_arg.value());
|
|
}
|
|
|
|
// Private factory, expects correct arguments.
|
|
DEFINE_NATIVE_ENTRY(ImmutableList_from, 1, 3) {
|
|
const Array& from_array =
|
|
Array::CheckedHandle(zone, arguments->NativeArgAt(0));
|
|
const Smi& smi_offset = Smi::CheckedHandle(zone, arguments->NativeArgAt(1));
|
|
const Smi& smi_length = Smi::CheckedHandle(zone, arguments->NativeArgAt(2));
|
|
const intptr_t length = smi_length.Value();
|
|
const intptr_t offset = smi_offset.Value();
|
|
const Array& result = Array::Handle(Array::New(length));
|
|
Object& temp = Object::Handle();
|
|
for (intptr_t i = 0; i < length; i++) {
|
|
temp = from_array.At(i + offset);
|
|
result.SetAt(i, temp);
|
|
}
|
|
result.MakeImmutable();
|
|
return result.ptr();
|
|
}
|
|
|
|
} // namespace dart
|