Brian Wilkerson
a16de199d7
This is a rediculously large CL, and if you want me to split it up I'm willing to do so. However, the changes were all made by running a script I wrote and then running the formatter over the code, so hopefully a spot-check will be sufficient. Change-Id: Ifc59b2cc3bf9e4edf0229a130cd587dc73f95615 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505042 Reviewed-by: Samuel Rawlins <srawlins@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
95 lines
1.7 KiB
Dart
95 lines
1.7 KiB
Dart
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analyzer/src/diagnostic/diagnostic.dart' as diag;
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../rule_test_support.dart';
|
|
|
|
void main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(AvoidEmptyElseTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class AvoidEmptyElseTest extends LintRuleTest {
|
|
@override
|
|
String get lintRule => LintNames.avoid_empty_else;
|
|
|
|
test_else_emptyStatement_hasElseIf() async {
|
|
await assertDiagnosticsFromMarkdown(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else if (x < y)
|
|
print('');
|
|
else [!;!]
|
|
print('');
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_emptyStatement_noElseIf() async {
|
|
await assertDiagnosticsFromMarkdown(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else [!;!]
|
|
print('');
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_noEmptyStatement_enclosed() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y) {
|
|
print('');
|
|
} else {
|
|
print('');
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_noEmptyStatement_notEnclosed() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else
|
|
print('');
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_noStatement_notEnclosed() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else
|
|
}
|
|
''',
|
|
[
|
|
// No lint
|
|
error(diag.expectedToken, 67, 4),
|
|
error(diag.missingIdentifier, 72, 1),
|
|
],
|
|
);
|
|
}
|
|
}
|