Paul Berry
d579b03f71
Changes the `front_end` and `_fe_analyzer_shared` code that reports the following diagnostics so that it uses `withArguments` rather than `withArgumentsOld`: - `expectedButGot` - `expectedButGot2` - `expectedAfterButGot` - `expectedToken` - `unmatchedToken` - `constFieldWithoutInitializer` - `finalFieldWithoutInitializer` - `superclassHasNoMethod` - `unavailableDartLibrary` - `unsupportedPlatformDartLibraryImport` These messages required special care because they are translated into analyzer diagnostics by the analyzer method `FastaErrorReporter.reportByCode`, and the logic to do the translation depends on the exact parameter names used by the messages. For some of the messages I've clarified the parameter names and updated `FastaErrorReporter.reportByCode` accordingly. For others, I left the parameter names as is. Change-Id: I6a6a696481c75f4cbb198d1e012aa1ca4294ed61 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476323 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
57 lines
2.2 KiB
Plaintext
57 lines
2.2 KiB
Plaintext
Problems reported:
|
|
|
|
parser/patterns/switchExpression_recovery_illegalFunctionExpressionInGuard:2:21: Expected ',' before this.
|
|
_ when () => true => 1,
|
|
^^
|
|
|
|
beginCompilationUnit(f)
|
|
beginMetadataStar(f)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(f)
|
|
beginTopLevelMethod(, null, null)
|
|
handleNoType()
|
|
handleIdentifier(f, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
beginMetadataStar(x)
|
|
endMetadataStar(0)
|
|
beginFormalParameter(x, MemberKind.TopLevelMethod, null, null, null)
|
|
handleNoType(()
|
|
handleIdentifier(x, formalParameterDeclaration)
|
|
handleFormalParameterWithoutValue())
|
|
endFormalParameter(null, null, null, null, x, null, null, FormalParameterKind.requiredPositional, MemberKind.TopLevelMethod)
|
|
endFormalParameters(1, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginSwitchExpression(switch)
|
|
handleIdentifier(x, expression)
|
|
handleNoTypeArguments())
|
|
handleNoArguments())
|
|
handleSend(x, x)
|
|
handleParenthesizedCondition((, null, null)
|
|
beginSwitchExpressionBlock({)
|
|
beginSwitchExpressionCase()
|
|
beginPattern({)
|
|
handleNoType(_)
|
|
handleWildcardPattern(null, _)
|
|
endPattern(_)
|
|
handleSwitchExpressionCasePattern(_)
|
|
beginParenthesizedExpressionOrRecordLiteral(()
|
|
endRecordLiteral((, 0, null)
|
|
handleLiteralBool(true)
|
|
endSwitchExpressionCase(_, when, =>, true)
|
|
handleRecoverableError(Message[Template(ExpectedButGot), Expected ',' before this., null, {expected: ,}], =>, =>)
|
|
beginSwitchExpressionCase()
|
|
beginPattern(,)
|
|
handleNoType(_)
|
|
handleWildcardPattern(null, _)
|
|
endPattern(_)
|
|
handleSwitchExpressionCasePattern(_)
|
|
handleLiteralInt(2)
|
|
endSwitchExpressionCase(_, null, =>, 2)
|
|
endSwitchExpressionBlock(2, {, })
|
|
endSwitchExpression(switch, })
|
|
handleExpressionFunctionBody(=>, ;)
|
|
endTopLevelMethod(f, null, ;)
|
|
endTopLevelDeclaration(;)
|
|
endCompilationUnit(1, )
|