Files
Daco Harkes 83017685b8 [dart2js] record_use for const instances
This brings the implementation on par with the VM & dart2wasm.

Implementation details:

* Dart2js now records pragmas on classes, not only members.
* The constant traversal is memoized, preventing potential exponential
  behavior (and removing duplicate recordings).

TEST=pkg/compiler/test/record_use/record_use_test.dart

Closes: https://github.com/dart-lang/native/issues/2893
Change-Id: Ia9c4a15c5f250c027d93aa3723042a3fc6a15350
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480240
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
2026-02-12 10:54:14 -08:00

123 lines
3.7 KiB
Dart

// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'dart:io';
import 'package:_fe_analyzer_shared/src/testing/features.dart';
import 'package:expect/async_helper.dart';
import 'package:compiler/src/closure.dart';
import 'package:compiler/src/common.dart';
import 'package:compiler/src/compiler.dart';
import 'package:compiler/src/elements/entities.dart';
import 'package:compiler/src/js_backend/annotations.dart';
import 'package:compiler/src/js_model/element_map.dart';
import 'package:compiler/src/js_model/js_world.dart';
import 'package:compiler/src/util/enumset.dart';
import 'package:kernel/ast.dart' as ir;
import '../equivalence/id_equivalence.dart';
import '../equivalence/id_equivalence_helper.dart';
main(List<String> args) {
asyncTest(() async {
Directory dataDir = Directory.fromUri(Platform.script.resolve('data'));
await checkTests(
dataDir,
const AnnotationDataComputer(),
args: args,
testedConfigs: allSpecConfigs,
);
});
}
class AnnotationDataComputer extends DataComputer<String> {
const AnnotationDataComputer();
/// Compute type inference data for [member] from kernel based inference.
///
/// Fills [actualMap] with the data.
@override
void computeMemberData(
Compiler compiler,
MemberEntity member,
Map<Id, ActualData<String>> actualMap, {
bool verbose = false,
}) {
JClosedWorld closedWorld = compiler.backendClosedWorldForTesting!;
JsToElementMap elementMap = closedWorld.elementMap;
MemberDefinition definition = elementMap.getMemberDefinition(member);
AnnotationIrComputer(
compiler.reporter,
actualMap,
elementMap,
member,
closedWorld.closureDataLookup,
closedWorld.annotationsData as AnnotationsDataImpl,
).run(definition.node);
}
@override
bool get supportsErrors => true;
@override
String computeErrorData(
Compiler compiler,
Id id,
List<CollectedMessage> errors,
) {
return '[${errors.map((error) => error.message!.message).join(',')}]';
}
@override
DataInterpreter<String> get dataValidator => const StringDataInterpreter();
}
/// AST visitor for computing inference data for a member.
class AnnotationIrComputer extends IrDataExtractor<String> {
final JsToElementMap _elementMap;
final ClosureData _closureDataLookup;
final AnnotationsDataImpl _annotationData;
AnnotationIrComputer(
DiagnosticReporter reporter,
Map<Id, ActualData<String>> actualMap,
this._elementMap,
MemberEntity member,
this._closureDataLookup,
this._annotationData,
) : super(reporter, actualMap);
String? getMemberValue(MemberEntity member) {
EnumSet<PragmaAnnotation>? pragmas =
_annotationData.memberPragmaAnnotations[member];
if (pragmas != null) {
Features features = Features();
for (PragmaAnnotation pragma in pragmas.iterable(
PragmaAnnotation.values,
)) {
features.add(pragma.name);
}
return features.getText();
}
return null;
}
@override
String? computeMemberValue(Id id, ir.Member node) {
return getMemberValue(_elementMap.getMember(node));
}
@override
String? computeNodeValue(Id id, ir.TreeNode node) {
if (node is ir.FunctionExpression || node is ir.FunctionDeclaration) {
ClosureRepresentationInfo info = _closureDataLookup.getClosureInfo(
node as ir.LocalFunction,
);
return getMemberValue(info.callMethod as FunctionEntity);
}
if (node is ir.LoadLibrary) {
return _annotationData.getLoadLibraryPriority(node);
}
return null;
}
}