Commit Graph

11 Commits

Author SHA1 Message Date
Zach Anderson afb490adbc [dart:io] Provide modern Dart-styled constants
This CL updates dart:io but not dart:_http. It updates the sdk sources,
the patch files, and tests.

Change-Id: I64c3da407f09fa2bc6eec582049c4ae3a8afbe6d
Reviewed-on: https://dart-review.googlesource.com/52990
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-05-03 17:00:14 +00:00
Johnni Winther 513ac0ffd7 Implement runDiff for Windows
Change-Id: Ic9191e3844e5bcd47c97867f4a7cec52c161fd7a
Reviewed-on: https://dart-review.googlesource.com/35280
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-18 12:57:45 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase.
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase."
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase.
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-11-14 11:13:04 +00:00
Konstantin Shcheglov 64ed9c942c Fix type argument for Result.
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2920283002 .
2017-06-05 09:43:07 -07:00
Peter von der Ahé c4481e2384 Add RuntimeError to default expectations and handle expectation groups correctly.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2913153002 .
2017-05-31 15:02:51 +02:00
Jacob Richman de54e18369 Run dartfmt on remaining unformated pkg packages
BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2743423009 .
2017-03-21 18:21:32 -07:00
Peter von der Ahé cb10fc984b Add a new kind of suite to ease test.dart integration.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2693893002 .
2017-02-14 10:45:44 +01:00
Zach Anderson 8a9a98073f [dart:io] flush() stdin before close()ing
Calls to close() on an IOSink do not imply that writes buffered by the
underlying StreamConsumer have been flushed. This CL adds a note
indicating this to the IOSink docs, and adds calls to flush() before
calls to close() for some calls to stdin.close() for spawned
processes in our tests.

related #28737

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2687963003 .
2017-02-10 09:55:16 -08:00
Peter von der Ahé f2faa44730 Move package:testing to SDK.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2624373003 .
2017-01-31 11:16:03 +01:00