dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
88,859 Commits 2 Branches 0 Tags
fe3f2188ffecbdbfb0b4b2ed587ddcb92ba57fcd
Commit Graph

1602 Commits

Author SHA1 Message Date
Ahmed Ashour 0c4c372d5e [analysis_server] associate RemoveNameFromDeclarationClause with various diagnostics 
Bug #50753

Change-Id: I3520a1ce3af3bfc651df582505835468705bdda2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 22:03:50 +00:00
Ahmed Ashour f12f1ad664 [analysis_server] ReplaceWithNullAware to handle IndexExpression 
Fixes #50691

Change-Id: I9bc6e1f72ff71623139ce94b3f3e94eba8ed4fd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 17:29:38 +00:00
Sam Rawlins 94f20d7731 Revert "Remove all support for all strong-mode analysis options" 
This reverts ea120b5d44

Change-Id: I97a1bf6ced06bf8bcab50a2fdb41732f13182a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276026
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 00:47:49 +00:00
Samuel Rawlins 6d05f249ff Revert "Remove preview-dart-2 option in analysis options" 
This reverts commit f30e5de558.

Reason for revert: https://dart-review.googlesource.com/c/sdk/+/274921 broke customer test, and this CL sits right on top of it.

Original change's description:
> Remove preview-dart-2 option in analysis options
>
> Fixes https://github.com/dart-lang/sdk/issues/50680
>
> AnalysisOptionsHintCode is moved from generated `option_codes.g.dart` to `option_codes.dart`, for non-generated diagnostics:
>
> * AnalysisOptionsHintCode.DEPRECATED_LINT_HINT and
> * AnalysisOptionsHintCode.DUPLICATE_RULE_HINT
>
> Change-Id: I131fb2901fca26ff971b6c9c519ab2f0b983a65c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275500
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia417aa5edc5b279a5fced43154de4cd5c9d3be2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276023
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-15 22:54:51 +00:00
Ahmed Ashour a6f4fbe17b [analysis_server] ConvertToMapLiteral to handle types with typedef 
Fixes #50581

Change-Id: Ieeb4c6730036e112bcf37353a18535f342fd28a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-15 22:09:46 +00:00
Ahmed Ashour f652c7962b [analysis_server] fix AddNullCheck with null-aware operators 
Fixes #50506

Change-Id: I8f7564ec7aaaf32888e9979254e450cd2633e307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-15 21:13:41 +00:00
Sam Rawlins f30e5de558 Remove preview-dart-2 option in analysis options 
Fixes https://github.com/dart-lang/sdk/issues/50680

AnalysisOptionsHintCode is moved from generated `option_codes.g.dart` to `option_codes.dart`, for non-generated diagnostics:

* AnalysisOptionsHintCode.DEPRECATED_LINT_HINT and
* AnalysisOptionsHintCode.DUPLICATE_RULE_HINT

Change-Id: I131fb2901fca26ff971b6c9c519ab2f0b983a65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-12-14 21:04:29 +00:00
Jens Johansen 959f0a299c [analyzer] Report memory usage on Windows too 
Change-Id: I6a31370c51e40a9593f8875d365a43d9f4111aaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-12-14 18:11:25 +00:00
Sam Rawlins ea120b5d44 Remove all support for all 'strong-mode' analysis options 
Fixes https://github.com/dart-lang/sdk/issues/50679

Change-Id: I3572faf51276f5c7551d35b7725c799567189413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-13 21:32:24 +00:00
Sam Rawlins fdf59ad1eb Remove all support for super-mixins option 
Bug: https://github.com/dart-lang/sdk/issues/50680
Change-Id: I96409d02e64d3e198e0fae4a55f58f871ce2aeac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275142
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-13 18:13:37 +00:00
Brian Wilkerson 2fbb93fc11 Do not apply the fix for avoid_function_literals_in_foreach_calls when body is not sync 
Change-Id: I0482c0d35a01afffd26073383b137697b829249c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274943
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-12 18:12:57 +00:00
Sam Rawlins 315ff0b8a2 analysis_server: quick fixes for records 
* allow rename_to_camel_case to apply to record type field names
* allow replace_final_with_const to apply to record literals.

Change-Id: Id373180dae9f7a78677e30c4dbc535bbb87ce3f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272486
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-10 23:12:23 +00:00
Brian Wilkerson bb7e2c9b95 Remove some unnecessary ignores in test code 
Change-Id: I55e332132b9f3e435d79dd03a7aa7459d796599a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274800
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-12-10 00:19:30 +00:00
Brian Wilkerson 44e11d9dd4 Add a utility to find adjacent siblings in a selection 
This will be used to allow multiple top-level declarations to be moved
together.

Change-Id: Ib1c59e9ff3e01891f8cb29b74e78183c36b1f02d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273828
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-08 20:48:58 +00:00
Ahmed Ashour 66990edcf5 [analysis_server] fix RemoveDeadCode with forParts 
Bug #43511

Change-Id: I82854382928cd29bfc7c646f0c202d28603f8836
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-08 06:33:09 +00:00
Brian Wilkerson 8569d24f3e Attempt to fix the windows bot 
Change-Id: Id1743f8998c2cb2553b5cfed801e9caef9c1d7c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274264
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-12-08 02:20:17 +00:00
Brian Wilkerson de36e1cfb7 Enable patterns in server tests 
Change-Id: I1d256b4c1c0cc20cb3e46087cd896d0920f82690
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274084
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-08 02:12:14 +00:00
Brian Wilkerson 7953da5cf1 Fix the windows bot 
Change-Id: I4d71fd70b2f0b4a4a3af3446f56fbd9b79fd0954
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-05 18:00:16 +00:00
Brian Wilkerson 6346e7fcd1 Update imports in files other than the source and destination when moving declarations 
Change-Id: I3675bddc9479744a4642bdbb66b8de013f0f01df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-02 23:22:16 +00:00
Oleh Prypin 328c261397 Expand RemoveReturnedValue fix to turn => null into {} 
This is targeted at the lint `avoid_returning_null_for_void` which already complains about expression function bodies but the fix doesn't do anything for them.

Change-Id: I14f3d7659301edae08482d9ffa6b72b483737e59
Bug: https://github.com/dart-lang/sdk/issues/45920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
 2022-12-01 22:04:48 +00:00
pq 636eec185b linter 1.31.0 
Cherry-picks update of `prefer_equal_for_default_values` to be a no-op in SDKs `>=2.19`.

See: https://github.com/dart-lang/linter/pull/3865

Change-Id: I2669f0279a0913bc8b3c5b0501a9869608883a14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-11-30 02:11:07 +00:00
Nate Bosch b2485c549f Allow AddExplicitCall for bulk and file fixes 
The edit regions should not overlap and the fixes are independent.

- Add `canBeAppliedInBulk` and `canBeAppliedToFile`.
- Add a BulkFixProcessorTest with multiple fixes in the same file.
- Add a FixKind for fixing implicit call tearofffs across the file.

Change-Id: I14260e4082fcd47c3a50514416b1c15b2c7e12c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271540
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-11-29 22:14:35 +00:00
Sam Rawlins e1acab8071 [analysis server] add fix for dangling_library_doc_comments 
Change-Id: I5bd3ce04fc85a698983cbbd04bab61fedadfca6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-11-29 20:00:41 +00:00
Sam Rawlins 01fba618ed New fix: RemoveNameFromDeclarationClause 
Change-Id: I5a877e9dcc54b4c42b37bca5de89ea7f94a1fe6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271563
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-23 20:24:00 +00:00
Sam Rawlins a030c643cb New fix: move_annotation_to_library_directive 
Change-Id: Ifef0a4d5a9c81faf21a6cb39b5fb0fbb525db139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270780
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-23 02:27:31 +00:00
Ahmed Ashour 208d65324a [analysis_server] fix AddMissingEnumCaseClauses with prefix 
Fixes #50484

Change-Id: I1bd325d460f0e286e602e215c0cce6a86eae2a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-21 22:29:37 +00:00
Ahmed Ashour 3556eb571e [analysis_server] RemoveDeadCode to handle forParts updaters 
Fixes #43511

Change-Id: I8d717038356444c70e082aab37911791de63bd6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266389
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-21 19:59:27 +00:00
Sam Rawlins 8e743ca83c Add fix for CompileTimeErrorCode.SUPER_FORMAL_PARAMETER_TYPE_IS_NOT_SUBTYPE_OF_ASSOCIATED 
Fixes https://github.com/dart-lang/sdk/issues/50524

Change-Id: I0d2a32c3c93e48979872592ba371865c695e76cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271060
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-21 19:44:02 +00:00
Sam Rawlins 6eef2c0649 Add fix for NON_FINAL_FIELD_IN_ENUM 
Change-Id: I4eb8125468290af44b65343d620ee2646c2594c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-11-21 18:42:51 +00:00
Sam Rawlins f7520deae2 New fix for removing an unnecessary library directive 
Change-Id: I4a57623d7e5b638d8fdf6ca174fdc5fb70187107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270541
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-18 04:27:50 +00:00
Ahmed Ashour d88ce93390 [analysis_server] add a failing test case for AddMissingEnumLikeCaseClauses 
Bug #50484

Change-Id: Ia5fe475e62eb9015abcc06a7c9a15c7c79e6bef9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270105
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-17 21:30:42 +00:00
Danny Tuppeny 35d3015ed5 [analysis_server] Allow folding of whole function declarations (not only bodies) 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4269.

Change-Id: I137a105d119c3387a2f319a34c420380e4b97e5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270401
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-17 20:03:17 +00:00
Konstantin Shcheglov c78ec3cd98 Remove the whole statement for any assignment to a SimpleIdentifier. 
Stop using PromotableElement in analysis_server/.

Change-Id: If543c1e5e73112335634ecab5b275322010b0b66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269203
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-11-16 22:38:00 +00:00
Ahmed Ashour 58ac7e15fe [analysis_server] offer AddSuperParameter fix 
Fixes #50293

Change-Id: I1cb05382bae6ff68ff5f9babb078e3ba95024d31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-15 21:43:03 +00:00
Brian Wilkerson 76945a3b81 Prepare to collect additional analytics 
Specifically, an additional initialization option and data about which
commands are later executed.

Change-Id: If71f696006527e9104d7765bdd43a913786cad97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-10 14:58:28 +00:00
Ahmed Ashour f915ad9e87 [analysis_server] fix ReplaceWithNullAware with cascade 
Fixes #50329

Change-Id: I15d667e1abf7e776b69b2a214aaf3b06653e6787
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-09 17:47:18 +00:00
Nate Bosch d6909d4740 Add a fix for implicit call tearoffs 
Towards https://github.com/dart-lang/language/issues/2399

Add `AddExplicitCall` correction producer and configure it to run for
`implicit_call_tearoffs` diagnostics.

Add parenthesis for any expressions with lower precedence than `.call`.

Add tests which include patterns returning and passing an implicit tearoff.

Change-Id: I482d2571b183bd0dfdf6c77f0cf530117add9eca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-11-09 02:14:48 +00:00
Brian Wilkerson e61ac810fe Fix the windows bot 
Change-Id: Id15e2a4191fc11cf145ba5a10f3970d7135b0863
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-08 17:50:40 +00:00
Brian Wilkerson cc95a4317d Handle import changes in move to file refactoring 
This also renames 'result' to 'unitResult' to be consistent with the
added 'libraryResult'.

Change-Id: If39cb86561163c5cee1e7397ee848f99cc0d4436
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268082
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 22:50:17 +00:00
pq ca52c30092 linter 1.29.0 
Downstream fixes:

* https://github.com/flutter/flutter/pull/113794
* https://github.com/flutter/plugins/pull/6669
* https://github.com/flutter/engine/pull/37321
* https://github.com/dart-lang/linter/pull/3775
* https://github.com/dart-lang/linter/pull/3776

* cl/482614222
* cl/482654980
* cl/482744309
* cl/485129394
* cl/485139323
* ...

Upstream:

* https://github.com/dart-lang/sdk/issues/50263

Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 22:02:42 +00:00
Brian Wilkerson 289aa509cd Add a new warning when a colon is used as the separator for a default value 
This also installs the existing fix for the new hint.

Change-Id: I32c4f3f50d1dfce4e2e37554cca7b81a84ca74d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254467
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 21:20:27 +00:00
Keerti Parthasarathy 81ebaee9a2 Fix for unecessary string escape in a string interpolation 
BUG: https://github.com/dart-lang/sdk/issues/50150

Change-Id: Ia3ab2e4cca951cb8006f6b59d5e3bea2c38ef4e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267460
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 16:17:30 +00:00
Ahmed Ashour 919a0460fb [analysis_server] fix data-driven constructor matching 
Fixes #50363

Change-Id: Ib7f7e3f9320c39135d4ddbeebd751b04c142b9cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-02 19:29:27 +00:00
Ahmed Ashour 1928cd3f82 [analysis_server] fix packageName of DataDriven fix files 
Fixes #50358

Change-Id: Id852dc2c53cb562c33ec2728b4cf07d518d6a298
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267364
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-02 18:34:17 +00:00
Ahmed Ashour 925268bebe [analysis_server] fix WrapInUnawaited for FunctionExpressionInvocation 
Fixes #50310

Change-Id: Id43270ff7487aae602421427c45816181464aec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-31 17:30:41 +00:00
Ahmed Ashour 98afb38b6a [analysis_server] add fixes for MISSING_OVERRIDE_OF_MUST_BE_OVERRIDDEN_* 
Fixes #50312

Change-Id: I0c599dede1c2c0710d35997144db5457360b096b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-28 14:42:57 +00:00
pq 309d9ceff1 stop bulk-fixing hash_and_equals 
Change-Id: Iada0e09677c11bec15c360821298c3735dde9d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266280
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-10-27 19:17:08 +00:00
Ahmed Ashour fa4417bcb7 [analysis_server] RemoveDeadCode to remove following statements after dead do while 
If the `do` statement has a `break`, then don't mark the following statements as dead, and don't offer a fix (for now).

Bug #43511
Bug #49091

Change-Id: I5e39aaee3dd49dc15ef2e4356b913e77e73baa75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263900
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-27 15:51:44 +00:00
Ahmed Ashour 931961eac8 [analyzer] dead code with for statement updaters 
TEST=ci

Bug #43511

Change-Id: Ie7ad75b1810d1483558ea18818f30c02730da312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-26 20:31:00 +00:00
Danny Tuppeny 77a480ca49 [analysis_server] Handle type arguments on named type references for initial Call Hierarchy item 
Change-Id: I5e30c808ddda7ff7817f7be7dd0ecff9a725854c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265501
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-25 16:31:10 +00:00