f9d4df6331
CQ. Enable avoid_redundant_argument_values in analyzer/
...
Change-Id: I8e5f5f6629249d1fdfddcfe87d20680b37198765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-02-26 19:55:13 +00:00
fe6950eceb
enable flutter_style_todos
...
Change-Id: Ic82963b754404d54e37f5fb03819aebc3fa67954
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-11-15 23:04:19 +00:00
73ab31b98a
analyzer: Move the Source class to be public API.
...
Deprecate accessing LineInfo, Source, or SourceRange via the
old library (pkg/analyzer/lib/src/generated/source.dart).
Migrate all SDK code to the new library.
Fixes https://github.com/dart-lang/sdk/issues/46420
Change-Id: Ic7c98a5820415c92a457f9fa2756351b05520cd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-11-14 17:10:37 +00:00
a3df9a1ed1
[analyzer] Don't do string concat in String.startsWith
...
When analyzing rwf-materials (562 contexts) with a filled cache I get
these numbers:
Before this CL (i.e. parent CL):
102829 ms
100934 ms
100991 ms
With this CL:
99671 ms
98499 ms
99678 ms
Difference at 95.0% confidence
-2302 +/- 2041.63
-2.26609% +/- 2.00979%
(Student's t, pooled s = 900.749)
Change-Id: I30025b15f7b8c637d83b2cef234c0e7a602535f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305680
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-05-26 06:27:47 +00:00
777ce9b368
Use UriCache to ensure there is only one instance of Uri for each string.
...
I tested this on rwf-materials/01-setting-up-your-environment
Short version:
1. 475060 less live objects.
2. 37.5 MB less heap usage.
Before:
[Analysis contexts: 35]
[time: 20575 ms]
[4781 ms] Downloaded heap snapshot, 641.5832576751709 MB.
[26763 ms] Created HeapSnapshotGraph.
externalSize: 7168
shallowSize: 1796013552
Objects: 23954314
[26764 ms] Created Analysis.
All objects.
size count class
-------- -------- --------
284017 kb 2194914 _OneByteString dart:core
269992 kb 2088293 _List dart:core
229846 kb 2066511 _Uint32List dart:typed_data
154248 kb 4935956 _GrowableList dart:core
63042 kb 158891 _Uint8List dart:typed_data
56224 kb 1199459 Reference package:analyzer/src/summary2/reference.dart
42643 kb 682297 _InfoMethodDeclaration package:analyzer/src/summary2/informative_data.dart
40358 kb 234812 PropertyAccessorElementImpl_ImplicitGetter package:analyzer/src/dart/element/element.dart
38075 kb 203067 ConstFieldElementImpl package:analyzer/src/dart/element/element.dart
34247 kb 438367 _SimpleUri dart:core
32181 kb 686528 _InfoFormalParameter package:analyzer/src/summary2/informative_data.dart
29730 kb 475686 _Closure dart:core
27722 kb 6868 _TwoByteString dart:core
25594 kb 409517 _Map dart:collection
17778 kb 81273 ClassElementImpl package:analyzer/src/dart/element/element.dart
16479 kb 411893 Context
14672 kb 93903 LibraryImportElementImpl package:analyzer/src/dart/element/element.dart
14074 kb 90077 ParameterElementImpl package:analyzer/src/dart/element/element.dart
13316 kb 284078 _InfoFieldDeclaration package:analyzer/src/summary2/informative_data.dart
12932 kb 19671 Instructions
-------- --------
1739370 kb 23741574
Instances of: _SimpleUri
size count class
-------- -------- --------
34247 kb 438367 _SimpleUri dart:core
size unique-size count class data
-------- -------- -------- -------- --------
313 kb 0 kb 10024 _OneByteString dart:core
189 kb 0 kb 4033 _OneByteString package:flutter/foundation.dart
100 kb 0 kb 2137 _OneByteString package:flutter/widgets.dart
76 kb 0 kb 1626 _OneByteString package:flutter/rendering.dart
68 kb 0 kb 2207 _OneByteString dart:ui
62 kb 0 kb 1994 _OneByteString dart:async
62 kb 0 kb 1989 _OneByteString dart:math
43 kb 0 kb 935 _OneByteString package:flutter/services.dart
43 kb 0 kb 1378 _OneByteString theme.dart
42 kb 0 kb 907 _OneByteString package:flutter/gestures.dart
39 kb 0 kb 1278 _OneByteString framework.dart
38 kb 0 kb 1243 _OneByteString debug.dart
29 kb 0 kb 466 _OneByteString package:vector_math/vector_math_64.dart
27 kb 0 kb 594 _OneByteString package:flutter/scheduler.dart
27 kb 0 kb 577 _OneByteString package:meta/meta.dart
25 kb 0 kb 549 _OneByteString material_state.dart
25 kb 0 kb 549 _OneByteString material_localizations.dart
25 kb 0 kb 822 _OneByteString colors.dart
23 kb 0 kb 510 _OneByteString package:flutter/material.dart
23 kb 0 kb 752 _OneByteString basic.dart
-------- -------- --------
11153 kb 258 kb 201628
After:
[Analysis contexts: 35]
[time: 20763 ms]
[4711 ms] Downloaded heap snapshot, 620.3819370269775 MB.
[25756 ms] Created HeapSnapshotGraph.
externalSize: 5984
shallowSize: 1758470480
Objects: 23479254
[25756 ms] Created Analysis.
All objects.
size count class
-------- -------- --------
278669 kb 2110355 _OneByteString dart:core
270129 kb 2088300 _List dart:core
229910 kb 2066512 _Uint32List dart:typed_data
154248 kb 4935956 _GrowableList dart:core
63049 kb 159021 _Uint8List dart:typed_data
56224 kb 1199459 Reference package:analyzer/src/summary2/reference.dart
42643 kb 682297 _InfoMethodDeclaration package:analyzer/src/summary2/informative_data.dart
40358 kb 234812 PropertyAccessorElementImpl_ImplicitGetter package:analyzer/src/dart/element/element.dart
38075 kb 203067 ConstFieldElementImpl package:analyzer/src/dart/element/element.dart
32181 kb 686528 _InfoFormalParameter package:analyzer/src/summary2/informative_data.dart
29730 kb 475686 _Closure dart:core
27722 kb 6868 _TwoByteString dart:core
25594 kb 409517 _Map dart:collection
17778 kb 81273 ClassElementImpl package:analyzer/src/dart/element/element.dart
16479 kb 411893 Context
14672 kb 93903 LibraryImportElementImpl package:analyzer/src/dart/element/element.dart
14074 kb 90077 ParameterElementImpl package:analyzer/src/dart/element/element.dart
13316 kb 284078 _InfoFieldDeclaration package:analyzer/src/summary2/informative_data.dart
12937 kb 19673 Instructions
11985 kb 191772 InterfaceTypeImpl package:analyzer/src/dart/element/type.dart
-------- --------
1700325 kb 23223116
Instances of: _SimpleUri
size count class
-------- -------- --------
359 kb 4598 _SimpleUri dart:core
size unique-size count class data
-------- -------- -------- -------- --------
0 kb 0 kb 1 _OneByteString file:///Users/scheglov/dart/rwf-materials/01-setting-up-your-environment/project
0 kb 0 kb 1 _OneByteString file:///Users/scheglov/dart/rwf-materials/01-setting-up-your-environment/project
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/platform_interface/platfor
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_remote_config_platform_interface/src/platform_interface/platfor
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/method_channel/method_chan
0 kb 0 kb 1 _OneByteString package:firebase_core_platform_interface/src/platform_interface/platform_interfa
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_analytics_platform_interface/src/method_channel/method_channel_
0 kb 0 kb 1 _OneByteString package:firebase_remote_config_platform_interface/src/method_channel/method_chan
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_crashlytics_platform_interface/src/platform_interface/platform_
0 kb 0 kb 1 _OneByteString package:firebase_crashlytics_platform_interface/src/method_channel/method_channe
0 kb 0 kb 1 _OneByteString package:firebase_analytics_platform_interface/src/platform_interface/platform_in
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/method_channel/utils/conve
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_core_platform_interface/src/platform_interface/platform_interfa
-------- -------- --------
260 kb 260 kb 4598
Change-Id: I31e0c5ee979e360021bf65a532424f0bd19a0820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279450
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-01-23 18:05:44 +00:00
e139fb1527
Tidy some lint issues in analyzer
...
* Move many identifiers from snake_case or SCREAMING_SNAKE_CASE to
camelCase. I think I restricted the changes to private API.
* Add an ignore in generated files for constant_identifier_names;
we often just mirror names found in YAML files or whatever, where
things are not necessarily named according to Effective Dart
standards.
* Avoid some implementation imports which I think were accidental.
* Use single quotes in some more places.
Bug: https://github.com/dart-lang/sdk/issues/48784
Change-Id: I439fe50cb9f8f8f5e9c74ce594aea15e394ee7da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-08-10 21:23:21 +00:00
139385c615
Breaking changes for analyzer version 4.0.0
...
Change-Id: I26961f29f9171e94db2f5c95f1f8af5fd01bb9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-04-07 06:52:27 +00:00
9a79d61c36
Do not rename method parameter names in overrides
...
Change-Id: I8c2f91a56c767c89dc4d0bea22b64dec147870c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237852
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-03-21 17:32:22 +00:00
a4929aed29
Prefer initializing formals in analyzer
...
Change-Id: I3bc4c3511bb4c9c1d700710894d57ea22379b0c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237850
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-03-20 22:01:26 +00:00
106482b08a
Remove unused CustomUriResolver.
...
Change-Id: I698bf56c08ed042bec15110ebcf0e9a77cfd5fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235766
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-03-07 22:34:53 +00:00
33e174084a
Replace Uri.scheme == with Uri.isScheme
...
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.
TEST=No behavior changes.
Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nate Bosch <nbosch@google.com >
2022-02-08 21:38:57 +00:00
3b89039454
Deprecate Source.isInSystemLibrary
...
Change-Id: Ifb76cc37e5b0aa86713675cf27086f6ce7625fbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-19 20:30:37 +00:00
d6d45d96f8
Deprecate Source.modificationStamp
...
Change-Id: Id7f361beff1c4e3f9edc743c58cce7888d330c1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-19 19:33:07 +00:00
fb05622b3b
Deprecate Source.uriKind
...
We almost can remove it.
Unfortunately surveyor/lib/src/analysis.dart uses it, so we need to
update it first.
Change-Id: I239d24506f99183147bf45744a6f8d66d3eb4f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-11-19 18:29:07 +00:00
7e6b3d83b8
Mark all Source.encoding implementations deprecated.
...
Change-Id: If12b9af54def3754a701477241d8364c283921ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220823
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-19 16:03:27 +00:00
9d7df725f6
Deprecated restoreAbsolute(), use pathToUri().
...
Change-Id: Id705e4f0eda7beba4c3d2dd2f6ba4b82691ef1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-11-18 21:17:17 +00:00
f1ded6af56
Remove import dart:core
...
Fixes #47092
TEST=existing
Change-Id: I3c5c0a1ec5e0426642a5dc70aa9a0391a143ed93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212298
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-09-06 11:57:40 +00:00
37a91c04b1
Fix PathFilter created when the analysis options file with excludes is not in the context root.
...
Change-Id: I242473d5fddbe5e3abaa994766959e207453ffb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197114
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2021-04-28 16:48:13 +00:00
4765ef5037
Remove 'actualUri' from UriResolver.resolveAbsolute()
...
Change-Id: I87edfa780e891a5e1ecdd1a9a548509e4cfa641a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-09 22:17:08 +00:00
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
528238465f
Remove the PerformanceTag class and related code.
...
Change-Id: I55b39e8fa6de7a3a946333bc84cc4ba0a09ecba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-08-16 23:59:42 +00:00
d169af6f7d
Analyzer: remove unnecessary this
...
Change-Id: I85a769e0c32159ac2a6422d3a60d160bda40d9b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156488
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-08-01 06:16:31 +00:00
648b5e9c68
Use ///-style doc comments in analyzer/lib
...
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I573cb81dca6462c571bd6bf7bf309a46fd628967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152610
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 17:58:50 +00:00
fd60cbc21f
Issue 42190. Fix PackageMapUriResolver and path with non-ASCII characters.
...
Bug: https://github.com/dart-lang/sdk/issues/42190
Change-Id: I4a5fea9f808a08d547b7b6e97ba8b93ee9dd16e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-09 16:32:16 +00:00
21354dccc9
Remove SdkExtUriResolver.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820
R=brianwilkerson@google.com
Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-20 01:08:49 +00:00
becb0c0b85
Revert "Remove SdkExtUriResolver."
...
This reverts commit 7ef8822c2abrianwilkerson@google.com
>
> Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I0c9a26662a6fe6abac558313c14949886364d28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 01:07:34 +00:00
7ef8822c2a
Remove SdkExtUriResolver.
...
R=brianwilkerson@google.com
Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 00:22:15 +00:00
5dfa750393
Convert all function parameters and typedefs to generic syntax
...
Change-Id: I18f8644ecbe61555b2929ed09d446733d33ec2a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128521
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-12-16 23:36:38 +00:00
40718899fe
Fix pedantic 0.9 lints around collection literals and spreads
...
Change-Id: I64277c36fbeb4ea7a1bb429a8e0a40203520c883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128380
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-14 00:15:41 +00:00
364dd8936b
Fix unnecessary_new in analyzer.
...
R=brianwilkerson@google.com
Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 01:11:30 +00:00
5f0de26d48
Clean up the remaining copyright notices
...
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-03-24 20:11:28 +00:00
469e1e2e64
Remove unnecessary library directives
...
Change-Id: I7a157080e4d7fd80d64489a13de4e996b5870930
Reviewed-on: https://dart-review.googlesource.com/c/79474
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-13 00:44:04 +00:00
9c585bf5df
Document that ResourceProvider requires absolute, normalized paths, and enforce this.
...
This allows us to avoid performing normalization, and work with paths
as is. So, this speeds up SourceFactoryImpl.restoreUri() from 7.5% to 3.7%
R=brianwilkerson@google.com
Change-Id: I085f3db40af6543fbb524a82fad48aa051e87937
Reviewed-on: https://dart-review.googlesource.com/77017
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-28 17:18:49 +00:00
6e322f794c
No longer run pub list-package-dirs from the analysis server.
...
Change-Id: Id02bdfc25cb8827873ff607f7c4d4a3401c9a199
Reviewed-on: https://dart-review.googlesource.com/67205
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-27 23:05:41 +00:00
7054d92a02
Remove some classes from the analyzer public API
...
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-24 15:28:15 +00:00
b936ffb329
Move several libraries out of the public API
...
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-17 17:35:27 +00:00
0c928771fc
Revert "Connect analyzer's AnalysisError object to front_end's CompilationError."
...
This reverts commit fc5270df72TBR=scheglov@google.com , brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2503803003 .
2016-11-15 10:00:34 -08:00
fc5270df72
Connect analyzer's AnalysisError object to front_end's CompilationError.
...
AnalysisError implements CompilationError but provides additional
services, such as extensibility via the `getProperty` method.
Note: CompilationError.location has been renamed to
CompilationError.span to avoid confusion (since its type is
`SourceSpan`, not `SourceLocation`).
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2498133002 .
2016-11-14 15:30:10 -08:00
5bd4de469e
Clean up warnings and hints
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2324463006 .
2016-09-09 09:09:59 -07:00
910b2ba016
Convert resource providers to use FileSource
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2245133005 .
2016-08-16 20:10:59 -07:00
edb847ab42
Implement a replacement for FileBasedSource (and _MemoryFileSource)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2252573002 .
2016-08-16 07:59:55 -07:00
Konstantin Shcheglov