dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
50,451 Commits 2 Branches 0 Tags
fb02cf80ee6b7600a664a876f7d4e2ac092e35c1
Commit Graph

17095 Commits

Author SHA1 Message Date
Konstantin Shcheglov fb02cf80ee Constructors should not have type parameters when resynthesize from Kernel. 
Factory constructors are represented as static Procedure(s) with
type parameters. This does not match to the language specification and
Analyzer element model. We need to pretend that these type parameters
are absent, so that we pick up the same named type parameters from the
enclosing class.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Id26cf0e9c08699ac46978e14640e01089a1efcbc
Reviewed-on: https://dart-review.googlesource.com/9080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 23:55:42 +00:00
Konstantin Shcheglov f7c4667a54 Triage other NonErrorResolverTest_Kernel tests. 
R=brianwilkerson@google.com

Bug:
Change-Id: I43070a8afa740dcbb7fd49fb834563fe7c5030cd
Reviewed-on: https://dart-review.googlesource.com/9100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 23:47:58 +00:00
Paul Berry f406efd265 In InterfaceResolver, favor inheriting the first member with the proper type. 
We have to generate a forwarding stub whenever the inherited member
isn't the same as the one that ClassHierarchy would have chosen, and
ClassHierarchy favors inheriting the first member.  So this will avoid
creation of unnecessary forwarding stubs.

Change-Id: If2411c6ed0474da66544735b196f8042f98c2591
Reviewed-on: https://dart-review.googlesource.com/9063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-27 22:38:47 +00:00
Paul Berry 46734c96f9 Create forwarding stubs properly for getters, setters, and fields. 
Change-Id: Ife2be67a29d46957e56ff34faab83c15f9f8579b
Reviewed-on: https://dart-review.googlesource.com/9062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-27 22:29:02 +00:00
Paul Berry c0a2789b00 Clear class inference info after type inference is complete. 
This should allow more memory to be reclaimed by GC.

Change-Id: I9fe8ad5ffb1b92910457630579bb0822fad9a3cc
Reviewed-on: https://dart-review.googlesource.com/9061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-27 22:23:21 +00:00
Régis Crelier 8cf9ef22c4 Revert "Dart Core Lib change to support generic functions in class NoSuchMethodError." 
This reverts commit db15f5d73b.

Dart2js and Kernel tests are comparing text that has changed because of
the core lib change.

Change-Id: I1d33716a3d6e6a077aa1f1a9ad7cc37825d31fa6
Reviewed-on: https://dart-review.googlesource.com/9082
Reviewed-by: Siva Chandra <sivachandra@google.com>
 2017-09-27 21:08:20 +00:00
Devon Carew fd4528fffb Make closing labels slightly less noisy. 
Bug:
Change-Id: If916adb1cceab14c9260f288bf59878c6955f3ce
Reviewed-on: https://dart-review.googlesource.com/9000
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 18:52:25 +00:00
Emily Fortuna 8bd22ffd28 Fix log parsing script to handle group names with spaces in them. 
Bug:
Change-Id: If538d7e18af850e973ce0236e6949b7dbe36ba09
Reviewed-on: https://dart-review.googlesource.com/8733
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-27 18:13:54 +00:00
Régis Crelier db15f5d73b Dart Core Lib change to support generic functions in class NoSuchMethodError. 
Change-Id: If7d1a8c07e4bee7ec68fede80a9d17cae0044d31
Reviewed-on: https://dart-review.googlesource.com/5329
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-27 17:57:41 +00:00
Paul Berry c13eb60426 Implement logic for creating forwarding stubs and propagating covariance annotations. 
This logic isn't hooked up yet; it's just unit tested.

Change-Id: Iacaf4fbc7c31be68c4c38cea60eca080c2aa1637
Reviewed-on: https://dart-review.googlesource.com/8734
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-27 17:57:34 +00:00
Paul Berry 240fd56709 Change main function in erasure_test to take optional args. 
This will allow the test to be run inside google3, where the test
framework calls main with no arguments.

Change-Id: Ia3135b634b4752be816b53209c39d24d72edb6b3
Reviewed-on: https://dart-review.googlesource.com/8960
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-27 16:24:44 +00:00
William Hesse 0cfcea3b78 Revert "Use function.name, instead of copying it into a new property." 
This reverts commit 174c37b9ed.

Reason for revert: This is failing on all the dart2js --fast-startup bots, as far as I can see. For example, https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-jsshell-2-4-be/8417

Original change's description:
> Use function.name, instead of copying it into a new property.
> 
> Change-Id: I8004d31f65a36873f97ab607b4a81d8cc8b6a717
> Reviewed-on: https://dart-review.googlesource.com/8221
> Reviewed-by: Stephen Adams <sra@google.com>

TBR=floitsch@google.com,sra@google.com

Change-Id: Ie6d52919b6789aec9f394167256f6642c09ab275
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8980
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-27 15:51:31 +00:00
Florian Loitsch 174c37b9ed Use function.name, instead of copying it into a new property. 
Change-Id: I8004d31f65a36873f97ab607b4a81d8cc8b6a717
Reviewed-on: https://dart-review.googlesource.com/8221
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-27 15:09:33 +00:00
Samir Jindel cf0d17df57 [kernel-coq] Correct statement of subtyping consistency, extend to statements. 
Bug:
Change-Id: I48f073fa592ccdac56fb63b33b7d9961be5fc3fe
Reviewed-on: https://dart-review.googlesource.com/8220
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-09-27 13:39:05 +00:00
Dan Rubel f0caee1b24 Improve import directive recovery and report analyzer errors 
- New handleRecoverImport event
    for clauses in import directive that are out of order
- New error codes for
    Duplicate prefix
    Prefix after combinator

Change-Id: I0fea7ad4b4014a0b8578d3982e0515fe85044854
Reviewed-on: https://dart-review.googlesource.com/7980
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 12:56:46 +00:00
Johnni Winther 01ca690a67 Add test for break to labeled statements. 
Change-Id: Ia1d7e5f93426d2781c7b3b583af10d88af142f28
Reviewed-on: https://dart-review.googlesource.com/8044
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-27 09:38:53 +00:00
Johnni Winther 7818726c3d Handle strings and maps in inferrer 
Change-Id: Ic89f1f3b72dc243d239371886ff7d944153909c9
Reviewed-on: https://dart-review.googlesource.com/8040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-27 09:07:15 +00:00
Jens Johansen dc5df933e4 Use kernel indexes to jump past procedure bodies. 
Before this CL we skipped procedure bodies in kernel_loader.cc by
parsing the body (but not storing anything).
With this CL we now skip them directly (i.e. don't read them at all)
in kernel_loader.cc by using the newly available extra indexes in kernel.

Change-Id: I48cf0599b2a85102c9008ff7c455785151ef3c9c
Reviewed-on: https://dart-review.googlesource.com/5764
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2017-09-27 06:19:35 +00:00
Vijay Menon 9ab7137ede Regen ddc sdk 
TBR=leafp@google.com

Change-Id: Ia5721ff75771f3eec20eaf664d3977cbbc126b70
Reviewed-on: https://dart-review.googlesource.com/8741
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-09-27 03:03:25 +00:00
Sigmund Cherem 920d44c3d4 Include dart.io in dart2js platform 
Change-Id: I7bd4356556023ff4a56d876684ea63bad1917b07
Reviewed-on: https://dart-review.googlesource.com/8341
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-27 02:06:10 +00:00
Stephen Adams 2ea83486e1 dart2js kernel: generate constants for default arguments in Function.apply 
Change-Id: I5bd0a8deaf16069749a574eb2ed132738e2e0747
Reviewed-on: https://dart-review.googlesource.com/8280
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-27 00:35:53 +00:00
Emily Fortuna 614e4cc53f Add some fixes to getting JS-Interop compiling with angular apps. 
Bug:
Change-Id: I9c5b068f33ee9cca75d95b9fb01ce19557267958
Reviewed-on: https://dart-review.googlesource.com/8400
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-27 00:10:04 +00:00
Konstantin Shcheglov 7c3dbd0b5d Resynthesize LibraryElement.public/exportNamespace. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ie2a938759ae4a8b3db00b9ffdcf3af176a2e9c6f
Reviewed-on: https://dart-review.googlesource.com/8727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 22:25:46 +00:00
Konstantin Shcheglov a48239f527 Update expectations for inferred synthetic functions. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ic1f805ffc935436c816223370b2aa4d5af499a4c
Reviewed-on: https://dart-review.googlesource.com/8726
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 22:15:35 +00:00
Konstantin Shcheglov fff9215519 Mark a test @assertFailingTest. 
TBR

R=brianwilkerson@google.com

Bug:
Change-Id: Id135af0d25cd93791f59462b6f24563522c8ad21
Reviewed-on: https://dart-review.googlesource.com/8728
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 21:51:12 +00:00
Konstantin Shcheglov f7dfecf118 Replace generic comments in analyzer's MockSdk with the real generic syntax. 
Actual SDK already uses generic syntax.
This also fixes some failures in Kernel tests :-)

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ie9bd5a058150522210671feb7009c233f5240add
Reviewed-on: https://dart-review.googlesource.com/8706
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 21:39:57 +00:00
Emily Fortuna fe9d02855b Add html tests for dart2js kernel testing. 
Bug:
Change-Id: I4d28af58a655f76ea639c8f048e86738afb2e108
Reviewed-on: https://dart-review.googlesource.com/8720
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-26 21:19:57 +00:00
Konstantin Shcheglov 5e732cb8b0 Issue 29666. Validate that AnalysisDriver is given absolute paths. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/29666
Change-Id: I707e9694b7d1216dd8ebad80bd5db91bde03de74
Reviewed-on: https://dart-review.googlesource.com/8704
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 21:04:45 +00:00
Konstantin Shcheglov 7f33f78026 Issue 30875. Don't damage _redirecting# when adding kernels to DillLoader. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30875
Change-Id: Iede037673458131a357050ab61eb9930b70d372b
Reviewed-on: https://dart-review.googlesource.com/8381
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 20:41:14 +00:00
Konstantin Shcheglov 73447d0f24 Use NoneTarget with native enabled. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30839
Change-Id: I7ad415f42022eab784de1c53d4bb9afe67b78b2f
Reviewed-on: https://dart-review.googlesource.com/8404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-26 20:27:44 +00:00
Samir Jindel 1cac4c7924 [kernel-coq] Extend interfaces to contain getters. 
Bug:
Change-Id: If8411f356496017cf371349b3edfae3972725662
Reviewed-on: https://dart-review.googlesource.com/8121
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-09-26 17:39:15 +00:00
Paul Berry 1916dc75e6 Move command_line.dart and most of compile_platform.dart into lib/ 
This should make it possible to run compile_platform_test.dart inside
google3, where package layout conventions are more strictly enforced
(files in test/ cannot import files in tool/).

Change-Id: I2299e0340b0edfc1a684a635de8cf87ecb9f241f
Reviewed-on: https://dart-review.googlesource.com/8701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-26 17:34:01 +00:00
Vijay Menon 0a9253ef30 Regen SDK 
Looks like merge conflicts on crossing CLs.

TBR=leafp@google.com

Change-Id: Iee2c42e53d03c57fc07f18b46635f423927a1b17
Reviewed-on: https://dart-review.googlesource.com/8700
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-09-26 17:00:11 +00:00
Paul Berry 9b45cc7e4d Implement ForwardingNodes.resolve(). 
This method figures out which method a given forwarding node resolves
to, accounting properly for the fact that when there is multiple
inheritance, the inherited method is the one with the most specific
type.

Change-Id: Ia412e2d195dd697e35c1c08480b51f2a6bd1cac5
Reviewed-on: https://dart-review.googlesource.com/8360
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-26 16:48:11 +00:00
Paul Berry 13d155cc9c Change messages_test to use package_root to find messages.yaml 
This allows the test to pass in situations where it is not run from
the root of the SDK directory.

Change-Id: I855ec4529af6f18db41964f6976232358e94c920
Reviewed-on: https://dart-review.googlesource.com/8680
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-26 16:41:21 +00:00
Vijay Menon 2ba49b4ac0 Utility for building / running on d8 
Change-Id: I8ba4c7ce37d9a5fcf7742ecfdac4c0df48dc9497
Reviewed-on: https://dart-review.googlesource.com/7845
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-26 16:09:51 +00:00
Leaf Petersen 8c924f2923 Tighten the is check in handleError. 
Bug:
Change-Id: I23f49f65a395579293f0567e8069ccd931e00c4a
Reviewed-on: https://dart-review.googlesource.com/7842
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-26 13:38:05 +00:00
Dmitry Stefantsov 9df589eeae Mark pkg/analyzer_plugin/test/plugin/folding_mixin_test as Slow 
The bot had several timeouts during the day.  It may be similar to what
was fixed in
https://github.com/dart-lang/sdk/commit/5263d17f7480ff0648fa319ba1a8ed62d5116111
Change-Id: Ife4a1e6d2b40992d260ae03287d844ee9cceb79b
Reviewed-on: https://dart-review.googlesource.com/8600
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-09-26 13:32:26 +00:00
Jens Johansen 6982d1d517 [kernel] Make binary.md up to date 
0a76d327e3 updated the binary without
updating binary.md.

Bug:
Change-Id: Ia7ba1cec4b45ebf3dca2a1c1db0a1709a881483e
Reviewed-on: https://dart-review.googlesource.com/8521
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-09-26 13:27:52 +00:00
Leaf Petersen e350bb4565 Eliminate fuzzy arrow uses in SDK libraries. 
Bug:
Change-Id: Ia1a00966b8d77c5aa812ed19eca136c47132ae58
Reviewed-on: https://dart-review.googlesource.com/8540
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-26 12:56:05 +00:00
Lasse R.H. Nielsen 736e310ed5 Reapply "Simplify logic for creating a single IsolateRunner in analyzer." 
This reverts commit 83de2423ae.

Reason for revert: Error causing the revert did not seem to be related to this change anyway.

Original change's description:
> Revert "Simplify logic for creating a single IsolateRunner in analyzer."
> 
> This reverts commit 7867fed521.
> 
> Reason for revert: 
> Type error caught by DDC where the type of the function passed to isolate.run isn't what the runner expects.
> 
> Original change's description:
> > Simplify logic for creating a single IsolateRunner in analyzer.
> > 
> > Change-Id: I8583f9947fde8f4cf87d7feb64c8eb170a19e81d
> > Reviewed-on: https://dart-review.googlesource.com/6941
> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> 
> TBR=lrn@google.com,scheglov@google.com
> 
> Change-Id: I5a0e46e345673dee447fd848c064dd0039832fb1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/7280
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

TBR=lrn@google.com,scheglov@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic3793a85d979b695dc62bafd19c490aa24547682
Reviewed-on: https://dart-review.googlesource.com/8060
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-26 12:26:10 +00:00
Aske Simon Christensen 394f854fec Catch URI parse failure and report error 
Closes https://github.com/dart-lang/sdk/issues/29977
Closes https://github.com/dart-lang/sdk/issues/29987
Change-Id: I448089036b20572d1cc8cb9d5e79cfd402caf273
Reviewed-on: https://dart-review.googlesource.com/8440
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-26 11:26:20 +00:00
Leaf Petersen e0c2e8191f Eliminate fuzzy arrow from conversions_dart2js.dart 
Bug:
Change-Id: Ide970d2a5353e53af9f0a73748b12b2fb770ebcb
Reviewed-on: https://dart-review.googlesource.com/7941
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-26 10:37:48 +00:00
Johnni Winther c0c63bf16e Fix handling of function type parameters 
Closes #30826

Change-Id: I804bff2a204aa210ba59f691c5d680d8a53aadeb
Reviewed-on: https://dart-review.googlesource.com/7553
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-26 08:23:34 +00:00
Jens Johansen 308a1af6ab [kernel] Add more random access; don't read procedure bodies up front 
This adds more indexes to the kernel format so we know where classes
and procedures starts and stops. This allows for more random access.
E.g. one could now read the program index and jump directly to
library $i_1$, then read the library index and jump directly to class $i_2$,
read the class index and jump directly to procedure $i_3$.

The utilization (in this CL) is to not (always) read the procedure body
up front when loading kernel code on the dart side (ast_from_binary).
The observation is that - when running through the VM - almost none
of the bodies from the platform file are actually used.

This lowers the start-up cost which is noticeable for small programs
(e.g. hello world, or tests).
In this CL this is only done on the dart side and not on the C++ side,
that's for another CL.

Startup time:
dart2js: -1.84253% +/- 1.22157%
hello world: -11.1188% +/- 5.57892%

Running "time python tools/test.py -m release -cdartk language -j6":
real: -11.72% +/- 0.35%
user: -14.59% +/- 0.24%
sys: -12.71% +/- 0.61%

File size change (compiling with fasta to dill file incl. platform):
hello world: 0.88% (35,934 bytes).
dart2js: 0.97% (200,967 bytes).

Change-Id: I1f0ec121bc75bb17f11d3fade03da9815037d0bb
Reviewed-on: https://dart-review.googlesource.com/5262
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-09-26 08:14:17 +00:00
Johnni Winther 9914532f05 Handle logical and/or in inferrer 
Change-Id: Ia26df587b936b7b1e48018d102adb95a293c68d6
Reviewed-on: https://dart-review.googlesource.com/7860
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-26 07:27:01 +00:00
Sigmund Cherem 4c893290e4 Reapply "Check whether type-arguments and type-parameters length match from the body builder." 
This reverts commit 1ca12788c6.

Patchset 1 is the reverted CL, patchset 2 shows the changes.

Bug:
Change-Id: I4ffcb9ec20f2ac3c59d09adc3a6693f52c71601d
Reviewed-on: https://dart-review.googlesource.com/6360
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-26 04:09:37 +00:00
Konstantin Shcheglov 08a3c80553 Triage failing tests and open issues for failing because of Fasta. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ic16133d8b0bdb11d5195efe2b34a93d2f526a8b0
Reviewed-on: https://dart-review.googlesource.com/7482
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-26 01:31:34 +00:00
Konstantin Shcheglov 748eb3d4c6 Make the whole expression #invalidConst if a part of it is invalid. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I39c3eba2011bb3f2f3254f7a9ba1cb79d47645c3
Reviewed-on: https://dart-review.googlesource.com/8320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-25 22:22:39 +00:00
Konstantin Shcheglov 556920dec3 Fix for resynthesizing libraries with unresovled URIs. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I23da60fede6539f1b154a8ed3b73506926126889
Reviewed-on: https://dart-review.googlesource.com/7484
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-25 22:22:19 +00:00