dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
58,778 Commits 2 Branches 0 Tags
f7f31efab00ed3936aed567c358c8d99bcff704a
Commit Graph

151 Commits

Author SHA1 Message Date
Brian Wilkerson f7f31efab0 Disable the reading of a UUID during training 
Change-Id: Idb4d1d2ea4c7a862ff3d54718d2bf924492f3779
Reviewed-on: https://dart-review.googlesource.com/77422
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-01 19:07:59 +00:00
Brian Wilkerson 2723fcfb82 Remove more dead code from server 
Change-Id: Ib0af3295bc064fab0a271337a42f3925ccf205dc
Reviewed-on: https://dart-review.googlesource.com/77420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-01 15:43:12 +00:00
Brian Wilkerson 10f05f45b9 Remove more dead code from server 
Change-Id: I09d7c2e96d41f095cb456a5eccb04eaa447430cd
Reviewed-on: https://dart-review.googlesource.com/77263
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-01 01:21:38 +00:00
Jaime Wren 0b5a7c847d Add support for intermittent filesystems to the analysis server, this PR is a synced version of Devons PR https://dart-review.googlesource.com/c/sdk/+/72980, without the DAS protocol change. 
Change-Id: I6ad1d423c2616ae31fc3f5954782d05e3d8adbda
Reviewed-on: https://dart-review.googlesource.com/73689
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-09-20 22:54:59 +00:00
Jaime Wren 9f5aecb22b Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files. 
Change-Id: I3a2aaec08b6529c6cbd23d8d16b4b9ca8dd4da59
Reviewed-on: https://dart-review.googlesource.com/75402
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-09-20 20:35:43 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default. 
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-08-28 19:29:17 +00:00
Devon Carew b63b73d46d Cosmetic tweaks to how we train the analysis server. 
Change-Id: I78785450820c3773cb17ce69561806c82d68ddf4
Reviewed-on: https://dart-review.googlesource.com/71182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-22 16:57:37 +00:00
Jens Johansen fd00c0a4f7 Train analysis server with cfe too 
Prior to this change the analysis server was trained in non-cfe mode
only, meaning that the playing field wasn't even.
This CL updates the training so both modes are trained, reducing the
cold server benchmark in cfe mode from ~76 to ~71 seconds on my machine.
This is still *way* more than the non-cfe version, but still.

Before:
```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 15779864}, analysis-server-cold-memory: {bytes: 254571344}}
  {analysis-server-cold-analysis: {micros: 15181035}, analysis-server-cold-memory: {bytes: 272837552}}
  {analysis-server-cold-analysis: {micros: 15029866}, analysis-server-cold-memory: {bytes: 312474240}}
Finished in 49 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":15029866},"analysis-server-cold-memory":{"bytes":254571344}}}


$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 76810701}, analysis-server-cold-memory: {bytes: 1634409696}}
  {analysis-server-cold-analysis: {micros: 74706698}, analysis-server-cold-memory: {bytes: 1565364624}}
  {analysis-server-cold-analysis: {micros: 75798888}, analysis-server-cold-memory: {bytes: 1759452128}}
Finished in 228 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":74706698},"analysis-server-cold-memory":{"bytes":1565364624}}}
```


Now:

```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 15064119}, analysis-server-cold-memory: {bytes: 302396944}}
  {analysis-server-cold-analysis: {micros: 14909304}, analysis-server-cold-memory: {bytes: 273778864}}
  {analysis-server-cold-analysis: {micros: 14934034}, analysis-server-cold-memory: {bytes: 353252928}}
Finished in 45 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":14909304},"analysis-server-cold-memory":{"bytes":273778864}}}



$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 70252048}, analysis-server-cold-memory: {bytes: 1650741520}}
  {analysis-server-cold-analysis: {micros: 70853869}, analysis-server-cold-memory: {bytes: 1579162320}}
  {analysis-server-cold-analysis: {micros: 71155850}, analysis-server-cold-memory: {bytes: 1579512288}}
Finished in 213 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":70252048},"analysis-server-cold-memory":{"bytes":1579162320}}}
```

Change-Id: I8fb75624c86605e7028a2b8483df85ebbd958b0d
Reviewed-on: https://dart-review.googlesource.com/70260
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-08-20 07:15:47 +00:00
Devon Carew 97fddfc414 Don't have the analysis server ignore unrecognized flags. 
Change-Id: Iced499446cfbc3908e0d7f3f31abd97a7435bfe6
Reviewed-on: https://dart-review.googlesource.com/70421
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-16 22:39:18 +00:00
Devon Carew 6a4f1b76ac Remove the --preview-dart-2 option from dartanalyzer and the analysis server. 
Change-Id: I268b9d5f79b30d0e4a0f8e6bb81a7738c98e5eea
Reviewed-on: https://dart-review.googlesource.com/69802
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-14 04:24:47 +00:00
Brian Wilkerson 978f12c17f Use void in place of Null in analysis_server 
Change-Id: Ifef805cb3c0111e237a6147f71a968958d5651e5
Reviewed-on: https://dart-review.googlesource.com/69560
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-13 13:16:53 +00:00
Devon Carew ab0d27b694 Ignore an exception when deleting the temporary driver cache directory. 
Change-Id: I019adc6211af2db861900aaa80a126a48419be77
Reviewed-on: https://dart-review.googlesource.com/66620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-25 14:35:08 +00:00
Devon Carew 80f851a711 Normalize the analysis server snapshot. 
Bug: https://github.com/dart-lang/sdk/issues/33944
Change-Id: I2eaefb81e1a06e9ed9cc7bd263d8a3ee667df75f
Reviewed-on: https://dart-review.googlesource.com/66403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-25 06:35:42 +00:00
Devon Carew c1552c3728 Ensure we terminate training if we get an exception from the analysis server. 
Change-Id: Iddd9ca5af50594e2dcc23833ae5d6a75a2cf09f8
Reviewed-on: https://dart-review.googlesource.com/66411
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-25 05:06:25 +00:00
Devon Carew 7ddc4ce8ba Train the analysis server snapshot on pkg/analyzer_cli. 
Change-Id: I07dcaec344d681a4abf8f09558d83a68efdd70e8
Reviewed-on: https://dart-review.googlesource.com/65575
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-18 21:32:09 +00:00
Peter von der Ahé 64a1f8f69c Prepare for upcoming void usage semantics 
Change-Id: I30d92ffb88338036aebed4e6891ce8e5737bf81f
Reviewed-on: https://dart-review.googlesource.com/65322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-07-17 15:36:38 +00:00
Devon Carew c19233dcce Plumb in more of the analytics impl into the analysis server; allow clients to enble analytics. 
Change-Id: Id546ce60e3ec49d37d6c5545f98a46bff009e6c1
Reviewed-on: https://dart-review.googlesource.com/62701
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-28 16:28:25 +00:00
Devon Carew 17b53a2835 Test out no_implicit_casts on the analyzer source base. 
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-28 02:20:43 +00:00
Devon Carew 64fd6653cf Update deprecated references. 
Change-Id: I99b827502fef1c4dc2d8ccdece74df59765dcb54
Reviewed-on: https://dart-review.googlesource.com/61300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-20 16:28:38 +00:00
Devon Carew de5f9ea95f Add --use-fasta-parser flags to dartanalyzer and the analysis server. 
Change-Id: Id7272c0d86806f2cbdfc982ee90923b018e08866
Reviewed-on: https://dart-review.googlesource.com/60453
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-16 13:21:24 +00:00
Brian Wilkerson f6d2c2378a Add awaits in async methods to restore previous semantics 
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-08 19:58:07 +00:00
Brian Wilkerson a6ad152315 Fix constant-related deprecation warnings in analyzer packages 
Change-Id: I6e4186d2a877275db2f04881a6aa6d154d4f8693
Reviewed-on: https://dart-review.googlesource.com/55820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-17 21:24:38 +00:00
Devon Carew d078e6599d Remove some flutter specific analysis code. 
Change-Id: Ib48f8527c40d9f9cb9349cadcf94e7bc82330222
Reviewed-on: https://dart-review.googlesource.com/49831
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-10 23:54:46 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson 9df1d66b57 Flip analyzer and server to preview-dart-2 by default 
Change-Id: I5d009debf962ba49ae715a87aa117538f552fbdb
Reviewed-on: https://dart-review.googlesource.com/47122
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-19 20:57:17 +00:00
Konstantin Shcheglov 1d184ace7b Fixes for packages:args deprecated uses. 
Mostly addOption() -> addMultiOption().

Change-Id: Iab40059aab45a371e0def89fbdfcd08bd1487d47
Reviewed-on: https://dart-review.googlesource.com/47121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-19 20:15:37 +00:00
Devon Carew 80a571d546 Take the --preview-dart-2 defaults from the context and options classes, not the cli tool defaults. 
Also, allow --no-preview-dart-2 from dartanalyzer.

Change-Id: Ic304a29e640bbddb50892c28712a131a2b306930
Reviewed-on: https://dart-review.googlesource.com/45881
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 22:30:24 +00:00
Jaime Wren cd878bc433 Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon. 
See https://github.com/dart-lang/sdk/issues/31640

Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-01-08 22:37:05 +00:00
Konstantin Shcheglov e2e15f0642 Issue 31364. Add support for --preview-dart-2 flag in Analysis Server. 
You don't want to turn it on yet.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/31364
Change-Id: I37639181e500298d38beee6d9f91330c7465b14a
Reviewed-on: https://dart-review.googlesource.com/20640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-14 08:22:15 +00:00
Paul Berry c084df4747 Remove deprecated DirectoryBasedDartSdk. 
This class has been deprecated for over a year, and I believe all uses
of it have been removed.

Change-Id: I42c39339b08bb98271000c2a459d3045388ec9ce
Reviewed-on: https://dart-review.googlesource.com/17520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-10-31 17:13:40 +00:00
Konstantin Shcheglov 472f64b005 Check for _serverFuture is null in HttpAnalysisServer. 
R=brianwilkerson@google.com

Bug:
Change-Id: I54dc00d5a0b29e60a0825e6dcc46daae382ad302
Reviewed-on: https://dart-review.googlesource.com/8243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-25 21:08:59 +00:00
Florian Loitsch bb026e5d29 Fix typing error. 
Change-Id: Ib10a42863316ce6f15648345cf980236871c2f01
Reviewed-on: https://dart-review.googlesource.com/7361
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-20 16:16:27 +00:00
P.Y. Laligand 59516d9794 Added an analysis server argument to set the location of the session cache. (#30583) 2017-08-31 10:25:50 -07:00
Devon Carew 13346cab3d Put the analytics UI behind a flag. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/3003783002 .
 2017-08-24 11:17:37 -07:00
danrubel 84a36f1b77 flag to limit file and package URI completion suggestions 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/3003233002 .
 2017-08-23 13:39:32 -04:00
Brian Wilkerson e4d44b2dcd Remove more references to the old plugin system 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004523003 .
 2017-08-23 09:25:07 -07:00
Brian Wilkerson b941f148a7 Remove uses of the old plugin model from the analysis server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3001413002 .
 2017-08-23 07:42:13 -07:00
danrubel b47bfa88be remove unused analysis server flag 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2974013002 .
 2017-07-11 08:10:42 -04:00
danrubel def1ee6604 add analysis server --flutter-repo startup flag 
This adds a new flag used by `flutter analyze --watch` when analyzing
the flutter repository. When specified, this flag causes analysis server
to enable the public_member_api_docs lint even though it is not enabled
in the analysis_options file. `flutter analyze --watch` needs the results
of this lint to summarize the number of public members missing dartdoc,
but enabling it in the analysis_options causes too much noise in the IDE.

See https://github.com/flutter/flutter/issues/10721 for more background

R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2976473003 .
 2017-07-10 16:50:04 -04:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
 2017-07-05 23:29:46 -07:00
Konstantin Shcheglov 077b6b687d Remove incremental: logger, validator, options. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2968473002 .
 2017-06-29 11:51:12 -07:00
Brian Wilkerson 55d735911b Remove the unused operations queue 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2957643002 .
 2017-06-23 09:04:13 -07:00
Brian Wilkerson fcb23e967c Remove the unused class SingleContextManager 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2945313002 .
 2017-06-21 11:21:25 -07:00
Brian Wilkerson e0216fef7f Remove ability to disable new analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
 2017-06-19 08:13:14 -07:00
Brian Wilkerson c0617d2015 Add access to AST ane element model data to the status pages 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2928033006 .
 2017-06-11 09:44:15 -07:00
Devon Carew 64af69ac51 Bind the diagnostics server on ipv4 ports. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2930003002 .
 2017-06-09 10:43:51 -07:00
Devon Carew 79c2668d2b add memory usage to the diagnostics page 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2927783002 .
 2017-06-07 11:28:34 -07:00
Devon Carew 4f2867d86c Add clientID and clientVersion to the diagnostics page. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2925463002 .
 2017-06-03 17:53:52 -07:00
Devon Carew 7e32f3bd7c Remove dead code related to the diagnostics server. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2918553002 .
 2017-06-01 10:31:27 -07:00