dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
69,875 Commits 2 Branches 0 Tags
f4cdc98ede0ebc7420c19d35eedf07e767633ad3
Commit Graph

205 Commits

Author SHA1 Message Date
Brian Wilkerson a32e4363cb Fix some lints from function typed parameters that were not converted automatically 
Change-Id: I926b54c298d398e9a316b9c042fcae98f9210815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 18:01:13 +00:00
Brian Wilkerson 5584c96fde Enable prefer_single_quotes in analysis_server 
All of the changes except in the analysis options file are from dartfix.

Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 17:52:52 +00:00
Brian Wilkerson 93ebbe2c7a Enable use_function_type_syntax_for_parameters in analysis_server 
Change-Id: I93cddc986c23e53557c647befc92d118b3d6ed43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132459
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-19 17:11:11 +00:00
Brian Wilkerson e5705943d8 Enable prefer_conditional_assignment in several packages 
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.

Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-06 05:19:19 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Devon Carew e7f0402ebf [analyzer] disable crash reporting for the AngularDart analysis plugin 
Change-Id: I49dddc4901c9cada643c5c024b8580f06c81a0d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129331
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-22 23:04:57 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Konstantin Shcheglov 3172748cb0 Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider. 
It does not look that these are used anymore.

Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 19:54:51 +00:00
Devon Carew 3204295ce1 [analyzer] send the plugin name with crash reports 
Change-Id: I674fe2a80a628bd3c509686f205101be8e081f19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126605
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 22:07:21 +00:00
Devon Carew f6a76586de [analyzer] send additional data to crash reporting 
Change-Id: I9f2da85e1c283ed4942ba076c98003aef80b7051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126203
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 00:16:50 +00:00
Devon Carew 18b7580944 [analyzer] for 'Failed to handle request' errors, send the exception to crash reporting as well 
Change-Id: Id50543fe6cac0e60ec32bfc6860064b210514dca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125988
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-25 20:20:46 +00:00
Brian Wilkerson f31fb0386b Catch exceptions during ranking and disable smart ranking 
Change-Id: Ib24a5a16da0fdfaf6d8504adab5c087ecec3abf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-19 20:06:29 +00:00
Mike Fairhurst 8db87ad6e5 [analysis_server] Report lowest exception to API/crash reporting 
Change-Id: I6db4612e0342c0f5208e7bce420964c7f0de1966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124912
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-14 16:33:46 +00:00
Johnni Winther 6ed0fcaa12 [analysis_server] Remove last dependency on front_end+kernel 
Change-Id: I0a8d1692ac1c8297bc7848a3f37fe97f8a8d3b29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123735
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-13 10:07:48 +00:00
Mike Fairhurst 942419e6ba [analysis_server] Funnel sendServerErrorNotification through logException 
Change-Id: I266a8b3c404da8c9892aa6e1a49e1f1c9bdcf530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-12 21:45:24 +00:00
Devon Carew d355778418 [analyzer] rate limit the crash reports we send 
Change-Id: I9f6af7fbcec653a2a9396d1098bea678777d4b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124761
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-12 21:37:22 +00:00
Devon Carew be2866b9b1 [analyzer] update lib/crash_reporting.dart 
Change-Id: Ie3b3ffc8a0e0351341f28ff26bbb3c82deb0b5dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124640
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-08 23:29:58 +00:00
Mike Fairhurst e68ca9b652 [analyzer] move crash reporting to server because telemetry isn't pulished 
Change-Id: I8fb293632267e7991c578076a43bfbd277fc1ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-07 22:19:07 +00:00
Mike Fairhurst 5134490b78 [analysis_server] add crash reporting 
Change-Id: I8005e87f75eecb0e8320d6db124256c8c7c509d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123549
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-05 21:07:33 +00:00
Mike Fairhurst 1d774abeea [analysis_server] Remove old crash reporting 
Change-Id: Ib725b678dc0c9aa1ec0afec68d586690942c872b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-11-05 20:55:33 +00:00
Mike Fairhurst 7ba5584c2e [analysis_server] Fix outdated desin Service->Server, use Service->Logger. 
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.

Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 21:31:26 +00:00
Konstantin Shcheglov 32a9a5f181 Add '--enable-experiment' to DAS. 
Bug: https://github.com/dart-lang/sdk/issues/39103
Change-Id: I37e1897efd044143fd9c2c96611cfa38efc056c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-28 16:17:03 +00:00
Ari Aye 95bd6a2888 Fix --completion-model flag 
Either setting --completion-model=/path/to/model/folder explicitly or
setting --enable-completion-model should turn on ML code completion.
This preserves the behavior that --no-enable-completion-model will
override --completion-model but fixes the bug where an omitted
--enable-completion-model flag will also override --completion-model.

Change-Id: I49a40a29c3444192e551fdcc4a51690f26969685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121803
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:24:13 +00:00
Devon Carew ec86737818 [analyzer] fix an issue where the field analysisServerOptions.enableCompletionModel was not used 
Change-Id: Ib7dd53eb9ff97a0a646b487e4e5d71da0ced07c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120920
Reviewed-by: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-10 21:52:03 +00:00
Devon Carew 50d6a3d022 [analyzer] move the ml model from sdk/model to sdk/bin/model 
Change-Id: I64aad93770c5c0870c1a5052bb5a1192738f1cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120901
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-09 19:26:34 +00:00
Konstantin Shcheglov e32706ec05 Remove '--use-summary2' from DAS. 
R=brianwilkerson@google.com

Change-Id: I22d99ae50e19d5e1b624a0d807cead676411f58d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-17 19:28:01 +00:00
Konstantin Shcheglov c324228c10 Support for ServerService.LOG and 'server.log' notification. 
R=brianwilkerson@google.com

Change-Id: I100105f651998d7837fb807d05531deac7ab3873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115061
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-30 20:04:38 +00:00
Konstantin Shcheglov af2e729fca Record request / response statistics. 
If following flags are specified for DAS, in IntelliJ in Registry as
"dart.server.additional.arguments":

--new-analysis-driver-log=file:/Users/scheglov/tmp/das.log
--include-protocol-to-driver-log

then abbreviated requests, and request execution statistics is
written to the file. We also write abbreviated notifications.

The goal is to be able to see what work was requested, what was
analyzed, and identify why some requests took long to get responses.


R=brianwilkerson@google.com

Change-Id: I98e99a73f10f2842c5efb350189a9675f29f45df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-21 16:47:21 +00:00
Ari Aye 8d1dc8c99b Add a cli flag to enable ML code completion using the default SDK path 
This will make it easier for beta testers to enable ML ranking for
code completion. Setting the --completion-model flag explicitly will
still work but there will also be a shorthand --enable-completion-model
which is equivalent to --completion-model=/path/to/dart-sdk/model/lexeme.

I tested this manually through IntelliJ.

Change-Id: Icd445e233f1eddec29d025769279dc03979cdb79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113127
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 23:09:42 +00:00
Ari Aye 6d2902576b Emit a server.error event if we fail to start the completion model isolate 
Change-Id: Ibcdd4478b7717cf10534d63d94800baa88cc3c04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112408
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-09 14:41:02 +00:00
lambdabaa 33ce54e45d Don't try to start ML completion isolate on 32 bit systems 
Instead of asking tflite_native to try to load a 32 bit dynamic library only to have it notice that none exist, we can simply disable ML ranking in analysis server.

Change-Id: Ibd001430d3e37f2fe854c72ef9f3f5466c96f46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-30 15:03:47 +00:00
lambdabaa fc82ed2286 Isolate-based CompletionRanking 
Screenshots: https://i.imgur.com/IOLKOCU.png, https://i.imgur.com/dM9VsNr.png

Change-Id: Ieae0f9066b7a349bb4adff6b327b67bcae49aab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-29 13:45:23 +00:00
Ari Aye 939cce78b9 Create analysis server flag --completion-model 
This flag will take a path to a folder where completion language model
files can be located. Omitting this flag will signal to analysis server
that it should not use ML ranking for code completion, and the plan is
for this capability to initially be opt-in / disabled by default.

Change-Id: Ied18cd1e378c11607778fc116a7e0c3d72091e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-24 23:15:39 +00:00
pq 52abcd3dd2 apply prefer_equal_for_default_values 
Change-Id: I9b6fd3ee18ec834a5db3d0d25455b6db9ea4fbe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 19:31:40 +00:00
Konstantin Shcheglov d24b407568 Add --use-summary2 flag to AnalysisServer. 
So that we can start dogfooding it.

I noticed that we logged too much data, so I reworked what we
log in LibraryContext.

Currently performance will be subpar, due to using content hash as
file's API signature. So, any change to a file, even in a method
body will cause the whole library cycle (and everything that depends
on it) invalidation. I will implement computing API signatures for
parsed unit (hopefully reusing something already existing) in a
following CL.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ifb77e29188484b6784edbaa6a6d5daca6800ef2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104603
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-04 02:58:29 +00:00
Devon Carew 9081f28fbb [analyzer] fix a copy paste doc issue and 2 unused imports 
Change-Id: I20f4ae5454c2bceafd3b86e279357dee3b321006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103644
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-05-24 16:31:25 +00:00
Dan Rubel dfbc3923e4 add default CompilerContext in analysis server 
This should uncover the underlying error occurring in
Fix https://github.com/dart-lang/sdk/issues/37055

Change-Id: I633da211b943e5c4262a2f3d83ef0a2217c5b8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-23 22:46:15 +00:00
Konstantin Shcheglov 181685b852 Allow disabling individual server features. 
Change-Id: I4d06eaf76300c6784b88bd64ad322c306a276488
Bug: https://github.com/dart-lang/sdk/issues/36881
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103182
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-21 18:40:26 +00:00
Danny Tuppeny b7521f5e1b Fix lints not appearing when using LSP Server 
Change-Id: Ib3b4396a611be32b91b08d68c962302899a1ad88
Bug: https://github.com/dart-lang/sdk/issues/36931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-05-13 15:03:30 +00:00
Konstantin Shcheglov eeb19b0416 Remove usages of ExtensionManager and package:plugin in general. 
R=brianwilkerson@google.com

Change-Id: I489e72464474b3d40d7678f44562f65934f93288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:08 +00:00
Danny Tuppeny 34614ef995 Exit LSP server with exitCode=1 if there was no shutdown notification 
This adds a new server state "shutting down" which rejects requests. The LSP spec says clients should send the shutdown notification, then the exit notification. If an exit notification is received without a shutdown, then the exit code is set to 1.

Change-Id: I50aa186d699a646ee1422f5b3ddaae4bc089b632
Reviewed-on: https://dart-review.googlesource.com/c/93952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-25 11:58:24 +00:00
Jaime Wren 48f7364d7b Remove the UX experiment 2 flag from the Dart Analysis Server. 
The detachable file system manager feature is now a feature of the Dart Analysis Server, when starter.detachableFileSystemManager has been set.

Support originally added in https://dart-review.googlesource.com/c/sdk/+/73689/ under the --ux-experiment-2 flag.

Change-Id: I26e82e44891d31bf1a1b7399ef5d79e98bc62e7c
Reviewed-on: https://dart-review.googlesource.com/c/93283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-02-14 20:33:59 +00:00
Jaime Wren 486238df49 Remove the UX experiment 1 flag from the Dart Analysis Server. 
This work lead to https://github.com/JetBrains/intellij-plugins/pull/597 which will land in the Dart Plugin, 2019.1.x versions.

PR that introduced this experiment: https://dart-review.googlesource.com/c/sdk/+/75402/

Change-Id: Ia3c3a1e28da190346407504c35c57b98534d9a2c
Reviewed-on: https://dart-review.googlesource.com/c/93122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-02-13 22:49:09 +00:00
Danny Tuppeny 3b5a149df7 Use nonBlocking stdio for LSP 
Change-Id: I20f7ed183d08b7fc778b4cb643eff6f82c9f3f48
Reviewed-on: https://dart-review.googlesource.com/c/90001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-01-21 15:51:39 +00:00
Danny Tuppeny 17a439633d Add a custom LSP method dart/diagnosticServer to start server/return port 
Change-Id: I9d9be244251099c947b2998f0a45ec29ef29ad83
Reviewed-on: https://dart-review.googlesource.com/c/90012
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-17 16:37:49 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Danny Tuppeny 1d096d8499 Enable the analyzer Diagnostics server for LSP 
Change-Id: I3a555c301e8c09b1d8af8f952f9f65102961d3b7
Reviewed-on: https://dart-review.googlesource.com/c/88801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-09 16:04:12 +00:00
lambdabaa 5f25d1546c Guard analysis server against missing .instrumentation directory location on disk 
Currently if analysis server fails to resolve this directory, it will
crash the entire process with

NoSuchMethodError: The method 'getChild' was called on null.

_readUuid() was already failing over to generating a new random
identifier if it was either unable to find a uuid.txt file or
create one, so this change just triggers that behavior additionally
in the case that the parent directory is missing.

R=brianwilkerson@google.com

Change-Id: Ieafde2df5afd7e30a3830f241af02bf305c911ec
Reviewed-on: https://dart-review.googlesource.com/c/88428
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-01-07 17:31:06 +00:00
Danny Tuppeny 23d73687d2 Add logging of request in instrumentation log 
Change-Id: I4e39278a86637e099812ce61199b6a36d687722c
Reviewed-on: https://dart-review.googlesource.com/c/85395
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-11-27 17:51:48 +00:00
Paul Berry 3ae0dcaa18 Merge commit '5ef1465c55be601f601e1f565c9b9d2f94d76aff' into analyzer 
Conflicts:
	pkg/analysis_server/lib/src/analysis_server.dart
	pkg/analysis_server/lib/src/server/driver.dart
 2018-11-12 06:39:27 -08:00