dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
78,268 Commits 2 Branches 0 Tags
f3740ced59abc400e718bdfa4bd8020e9516d0fa
Commit Graph

89 Commits

Author SHA1 Message Date
Konstantin Shcheglov 3172748cb0 Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider. 
It does not look that these are used anymore.

Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 19:54:51 +00:00
Konstantin Shcheglov 6f38a73618 Remove most of the task model. 
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a

R=brianwilkerson@google.com

Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 18:26:50 +00:00
Brian Wilkerson 5f0de26d48 Clean up the remaining copyright notices 
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 20:11:28 +00:00
Konstantin Shcheglov eeb19b0416 Remove usages of ExtensionManager and package:plugin in general. 
R=brianwilkerson@google.com

Change-Id: I489e72464474b3d40d7678f44562f65934f93288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:08 +00:00
Brian Wilkerson 210361ae63 Move IgnoreInfo out of the task model code base 
Change-Id: Ib164e66ed96325042c9ab18de6489ab2d1c700ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96263
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-11 13:20:14 +00:00
Konstantin Shcheglov 927e758e96 Stop using package:html in analyzer. 
Related to https://github.com/dart-lang/sdk/issues/35802

R=brianwilkerson@google.com

Change-Id: I875a8dc657900137c5a7b59f2820b30a81b23405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 18:36:41 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson 5460ddbab5 Move three more libraries out of the public API 
Change-Id: I8e6aeaea35c739fb26e22ffcfc30a343ebbb5424
Reviewed-on: https://dart-review.googlesource.com/51363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-16 22:15:28 +00:00
Brian Wilkerson dd897d35a2 Move the task API out of the public API 
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-16 18:18:08 +00:00
Brian Wilkerson 1560f19844 Fixes to make analyzer preview-dart-2 safe, part 1 of many 
Change-Id: I8f88168a1fab61b3d0d808b5d9e09e6391325302
Reviewed-on: https://dart-review.googlesource.com/46953
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 13:15:46 +00:00
Brian Wilkerson b7f1a96ae5 Change the way tasks are registered 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2566893002 .
 2016-12-11 15:59:46 -08:00
Brian Wilkerson 718a17db85 Revert "Change the way tasks are registered" (TBD) 
Review-Url: https://codereview.chromium.org/2564303002 .
 2016-12-11 11:32:12 -08:00
Brian Wilkerson 84577c55bb Change the way tasks are registered 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2568723002 .
 2016-12-11 11:25:40 -08:00
Brian Wilkerson 86c62a6bad Remove the command-line plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2565993002 .
 2016-12-11 10:59:19 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
 2016-12-11 08:38:29 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
Brian Wilkerson ecc84b26a4 Break up another large file 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
 2016-09-15 07:49:27 -07:00
Konstantin Shcheglov 09b851c97f Don't perform final fields and top-level variables type propagation. 
A similar feature is now implemented in strong mode, and users who
need it, should switch to strong mode.

When we are ready to drop propagated types altogethoer, we could
deprecate or remove UnlinkedVariable.propagatedTypeSlot in IDL.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26794

Review URL: https://codereview.chromium.org/2288223003 .
 2016-08-29 15:18:12 -07:00
Konstantin Shcheglov 6df5ea27a5 Revert 6ad38498c8 (PARSED_UNIT). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2231473002 .
 2016-08-09 10:14:18 -07:00
Konstantin Shcheglov 6ad38498c8 Extract unresolved AST parsing (PARSED_UNIT1) from full parsing, which includes UriBasedDirective(s) resolution. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2229603003 .
 2016-08-08 14:45:27 -07:00
Brian Wilkerson 23b02bc351 Add support to the task model for the @required annotation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1977903002 .
 2016-05-13 11:11:48 -07:00
Brian Wilkerson d87f9c09de Update to use the latest version of the plugin package 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1965083002 .
 2016-05-11 09:54:29 -07:00
Konstantin Shcheglov 0f0b38dab3 Implement stable resolution of generic types without type arguments to their bounds. 
R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/26265

Review URL: https://codereview.chromium.org/1927323002 .
 2016-04-29 08:25:55 -07:00
Konstantin Shcheglov d1104de8db Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. 
In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096

Review URL: https://codereview.chromium.org/1854863002 .
 2016-04-01 14:00:38 -07:00
Brian Wilkerson deae702994 Format everything in analyzer 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842563003 .
 2016-03-28 18:16:43 -07:00
Brian Wilkerson 5309d86424 First batch of changes to make analyzer package strong mode error free 
Review URL: https://codereview.chromium.org/1808123005 .
 2016-03-18 07:47:58 -07:00
Konstantin Shcheglov 010e0e6b71 Separate CONSTANT_EXPRESSION_RESOLVED flag from RESOLVED_UNITx. 
We only need to know that we can eveluate the constant.
In non-summaries world we have the resolved unit anyway.
But in case of summaries we don't, but we know that all the constant
expressions are resynthesized as resolved (even if lazily).

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1673913002 .
 2016-02-05 18:04:24 -08:00
Konstantin Shcheglov 217cd8181b Remove unused READY_RESOLVED_UNIT10 and READY_RESOLVED_UNIT11. 
...as well as the corresponding tasks that produce them.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1668993002 .
 2016-02-04 13:09:42 -08:00
Brian Wilkerson 032aa11711 Add minimal yaml support to the engine 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1622313003 .
 2016-01-25 09:00:56 -08:00
Brian Wilkerson 1f3dabd9c7 Ensure that a complete library element has constants evaluated (issue 24890) 
R=danrubel@google.com, eernst@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1486663003 .
 2015-12-14 07:51:07 -08:00
Brian Wilkerson f0d249e269 Clean up package imports and library names 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
 2015-12-10 08:11:56 -08:00
pq ee310b6aff Options processing API update (#25126). 
Updates processing API to accept untyped options maps.

Required to support processing options merged from embedders and local analysis options.

See: https://github.com/dart-lang/sdk/issues/25126

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1506963002 .
 2015-12-07 11:27:17 -08:00
Brian Wilkerson e94c820411 Revert "Ensure that a complete library element has constants evaluated (issue 24890)" 
Review URL: https://codereview.chromium.org/1480603002 .
 2015-11-25 07:13:08 -08:00
Brian Wilkerson c8cec941ef Ensure that a complete library element has constants evaluated (issue 24890) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1468293003 .
 2015-11-25 06:37:45 -08:00
Konstantin Shcheglov aa9668b264 Propagate types for import/export closure before resolving. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1465303002 .
 2015-11-23 12:52:03 -08:00
Konstantin Shcheglov 8c324a5b8d Propagate types of final/const top-level variables and fields. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23001

Review URL: https://codereview.chromium.org/1460213005 .
 2015-11-21 09:40:37 -08:00
pq 68dc36a3e7 OptionsValidator plugin extension and linter service. 
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.

You'll notice that the warning code I added is NOT in `errors.dart`.  I did that in anticipation of plugin-specifc warnings living elsewhere.  If that's not the right angle, happy to un-do!

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1418333002 .
 2015-10-26 08:50:55 -07:00
Konstantin Shcheglov c43f292dd9 Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results. 
This improves warm VM analysis time (i.e. 99% of all analyzis that happens in IDEs) from 7200 ms to 6600 ms.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1417143003 .
 2015-10-24 08:35:26 -07:00
Konstantin Shcheglov 4653d9bb76 Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx. 
This helps to improve analysis time from about 39100 to 37000 ms.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1406923006 .
 2015-10-23 14:56:25 -07:00
Konstantin Shcheglov 041e61a0f6 Ensure that RESOLVED_UNITx ready once for every library. 
...instead of ensuring this separately for complete closures of every library.

This improves initial analysis performance from about 44 seconds to 39.
This also makes WorkOrder.moveNext less expensive - to about 5.6% during initial analysis.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1412273004 .
 2015-10-23 13:25:56 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
pq bf0ba96027 Analysis Options processing task and manager. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1413973003 .
 2015-10-20 15:38:55 -07:00
Paul Berry 395b82c041 Fix additional test failures caused by cae05d6bd4 
TBR=pquitslund@google.com

Review URL: https://codereview.chromium.org/1403633008 .
 2015-10-15 07:06:46 -07:00
Paul Berry ec144a055a Fix type of EninePlugin List<ResultDescriptor> getters. 
These getters were improperly typed as List<TaskDescriptor>.  Due to the
fact that the underlying lists they were returning were List<dynamic>,
and the fact that new warnings for for-in loops haven't been implemented
yet (see commit 89607f06e9), no warnings
or runtime errors alerted us to the incorrect type.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1406583002 .
 2015-10-13 10:45:28 -07:00
Leaf Petersen 4ca8a3f19b Strong mode checker integration. This integrates jmesserly's CL, and adds a task for computing strong mode errors and an annotated unit. 
BUG=
R=brianwilkerson@google.com, jmesserly@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1396273004 .
 2015-10-13 10:16:35 -07:00
Paul Berry 3ae9e62284 Create a breadcrumb trail for analyzing of task model extensions. 
This change paves the way for modifying
pkg/analyzer/tool/task_dependency_graph.dart so that it will be able to
understand the extensibility mechanisms in the task model.
Specifically, it adds the ExtensionPointId annotation, which
task_dependency_graph.dart will be able to use to locate the
TaskDescriptors that are plugged into each task model extension point.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1401543002 .
 2015-10-09 11:05:14 -07:00
pq e19f10fbec Add context to OptionsProcessor callback API. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392143002 .
 2015-10-08 10:47:06 -07:00
Leaf Petersen 651221bb82 Resolve ordering issues. 
This CL changes the way that the task model does strong mode inference to use the strongly connected components in the import/export graph.  Library cycles are computed and inference is staged by forcing each stage of inference to happen across an entire library cycle at once, and to force all external dependencies of a library cycle to have completed inference before inference for the library cycle can begin.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1386023002 .
 2015-10-07 16:14:35 -07:00
pq fe76c6f3c4 Lint support for the new task model. 
Related bug: https://github.com/dart-lang/analyzer_cli/issues/64

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1385293002 .
 2015-10-06 16:45:45 -07:00
Brian Wilkerson 0f30af628a Fix computation of errors to not run extra tasks 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1370323003 .
 2015-09-30 11:55:17 -07:00