5dffba506e
Use bleeding edge analyzer to analyze DDC
...
Note, we were getting this from building the SDK from scratch, but we
can just call it directly. :-)
Travis try-run here:
https://travis-ci.org/dart-lang/sdk/builds/197045751
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2669623002 .
2017-01-31 12:05:37 -08:00
c88a17ff55
Some test cleanup
...
These tests occasionally time out on travis. uri_test as well, but
there are two tests with that name, so I added code to disambiguate in
the logs.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2666593002 .
2017-01-31 10:23:26 -08:00
d5e5feb686
Shut up bad analyzer warning
...
This is a workaround for #28507
TBR=leafp@google.com
Review-Url: https://codereview.chromium.org/2667753003 .
2017-01-31 10:08:47 -08:00
80066aa2d6
Fix typo in StreamSink.close documentation ( #28572 )
...
provding -> providing.
2017-01-31 04:11:38 -08:00
f6151f902e
Fix dynamic calls on JS interop classes.
...
BUG=
Review-Url: https://codereview.chromium.org/2668543002 .
2017-01-30 14:19:07 -08:00
f3c33b047d
Remove spurious call to captureStackTrace.
...
Just creating an Error object is sufficient on FF,
Chrome, Safari, and Edge. Note that captureStackTrace
was not supported by other browsers so those browsers
were going down the even slower path of throwing an
exception.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2668503002 .
2017-01-30 13:30:31 -08:00
154cd39db8
Fix test status
...
Started breaking with leaf's cl on Fri.
Note, a very recent test (I think) is not strong clean any more. Rewrite it?
TBR=leafp@google.com ,rnystrom@google.com
Review-Url: https://codereview.chromium.org/2662873002 .
2017-01-30 08:08:16 -08:00
c3870fc93f
Fix mocking native classes and add a regression test.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2656363003 .
2017-01-27 14:34:19 -08:00
959a375541
Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2664493005 .
2017-01-27 14:23:34 -08:00
50ccf6d9b5
Fix DOM constructors in inline JS
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2659063002 .
2017-01-27 09:47:13 -08:00
fd94337b42
Fix for Animation and other polyfills
...
The polyfill code needs to run before dart_sdk is loaded. Otherwise, the registerExtension step on these types does not work.
Also fixes #27605
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2649613003 .
2017-01-25 16:18:49 -08:00
a91cc9cc9e
Use microtasks in dart.async
...
Not quite sure about this, but it makes ordering match for the example in #28509
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2653253002 .
2017-01-25 16:14:01 -08:00
0e00b3e5c8
fix #28008 , fix #28009 implement FutureOr<T>
...
This implements FutureOr<T> in strong mode, otherwise it's ignored (treated as `dynamic`.
Also fixes strong mode's inference subtype function incorrectly treating `void` as a malformed type. This had the consequence of allowing `void` to be inferred as a type argument.
R=leafp@google.com , paulberry@google.com
Review-Url: https://codereview.chromium.org/2647833002 .
2017-01-25 15:32:57 -08:00
d90ed8c295
Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of methods with names that are rewritten in DDC e.g. "_get" instead of "[]" Fix some mirror system handling of symbols with names that are rewritten in DDC
...
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2623053004 .
2017-01-24 11:16:21 -08:00
b206c84210
Reland c9e1b88 and 56726fc with a DDC fix.
...
Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""
This reverts commit b701ad6453R=brianwilkerson@google.com , vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2647323006 .
2017-01-24 09:13:26 -08:00
a27adee736
Update tests for FF 51
...
A handful of tests started working in FF 51.
TBR=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2655673003 .
2017-01-24 08:32:17 -08:00
d6063ca391
Closes https://github.com/dart-lang/sdk/issues/28291
...
Fix extending a JS class and add a test to ensure it
continues to work from DDC. Note this behavior will never
be supported in Dartium and is not yet supported by Dart2JS.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2654583002 .
2017-01-24 07:20:31 -08:00
b701ad6453
Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider."
...
This reverts commit c9e1b888a356726fcce0TBR=scheglov@google.com
Review-Url: https://codereview.chromium.org/2648213007 .
2017-01-24 06:21:38 -08:00
c9e1b888a3
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.
...
Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.
For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.
R=brianwilkerson@google.com , paulberry@google.com , vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2652823002 .
2017-01-23 16:54:17 -08:00
5c722b4118
Issue 28478. Add new strong mode bounds failing tests.
...
R=brianwilkerson@google.com , vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2651503004 .
2017-01-23 15:15:13 -08:00
9964772025
Cleanup build_sdk error checking
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2646313003 .
2017-01-23 13:56:06 -08:00
bf5597c95a
Fix "classs" typos ( #28469 )
2017-01-23 17:00:24 +01:00
fa2823925b
Hard fail on ddc sdk build error
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2645953006 .
2017-01-20 15:55:26 -08:00
a7f7a311c0
Fix for covariant
...
We've been silently failing to rebuild the SDK since covariant was added.
Looking at making SDK build break fail the presubmit!
TBR=leafp@google.com ,jacobr@google.com
Review-Url: https://codereview.chromium.org/2648863002 .
2017-01-20 15:20:44 -08:00
e8cf6b43a3
Mark dartbug/27526 tests as failing in DDC.
...
R=vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2641073006 .
2017-01-19 20:20:37 -08:00
8ae2f82dce
Eliminate redundant signatures.
...
The check to see that a method signature was redundant was not
handling generics correctly. This CL fixes it, so that we no
longer emit redundant signatures for methods on generic
classes. This should help with startup and code size a bit.
Fixes https://github.com/dart-lang/sdk/issues/28432
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2640793007 .
2017-01-19 12:44:39 -08:00
590a188066
Use "Object" as the reified type of covariant override parameters.
...
This ensures the runtime type is of the tear-off expression's static
type, even when accessed through a superclass.
I also moved the two tests into a subdirectory so they are easier to
find. (It is inscrutable to me why we would have a single directory
with 1,868 test files in it.) That involved enabling recursive
directory listing in codegen_test, which exposed a couple of things.
Fix #27484 .
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2641543003 .
2017-01-18 14:48:42 -08:00
5b34e47f40
Fix subtyping check on number
...
language_strong/null_is_test started failing on Konstantin's recent change. Another test started passing.
Does this fix make sense to you guys?
TBR=leafp@google.com ,scheglov@google.com
Review-Url: https://codereview.chromium.org/2638393004 .
2017-01-18 13:27:27 -08:00
21e1ebc3aa
Fixes to status
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2643793002 .
2017-01-18 06:16:56 -08:00
c83dac537f
Throw TypeError on arg mismatch
...
Improvement on #28286 - this is still not quite right as we'll throw a
TypeError instead of a NSM in certain cases depending on the order.
The spec will only throw a TypeError if NSM doesn't apply.
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2636313002 .
2017-01-17 16:26:22 -08:00
83f8ca4652
Fix status
...
See #27259
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2634303002 .
2017-01-17 06:01:04 -08:00
14cf17d898
Fix FF tests
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2638493002 .
2017-01-13 15:17:39 -08:00
1f5562e29c
More test refactoring to catch failures
...
Skip fewer tests. Many are now passing. Mark the rest as fail and test that they're still failing.
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2634433002 .
2017-01-13 09:02:45 -08:00
f710e7209a
Make ddc legacy loader more defensive
...
This should match what we need internally.
R=alanknight@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2634463002 .
2017-01-13 08:01:56 -08:00
0703ec5b1a
Track crashing tests
...
tbr'ing to fix bots
TBR=brianwilkerson@google.com ,rnystrom@google.com
Review-Url: https://codereview.chromium.org/2629173003 .
2017-01-12 16:00:15 -08:00
580186a655
Defend against false positives
...
If a seemingly non-async test returns a Future, wait on it. I noticed this on an earlier CL today related to the await_in_cascade_test - the test was broken, but we were falsely passing.
This still doesn't handle false negatives (e.g., tests that are expected to fail). That's why many of these are marked skip_fail. If the exception happens after main returns, we currently don't see it.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2629023002 .
2017-01-11 14:34:07 -08:00
22f561e914
Reapply "Add support for generic function type syntax, part 1"
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2622303006 .
2017-01-11 14:10:05 -08:00
85b1e7abbe
Revert "Add support for generic function type syntax, part 1"
...
Review-Url: https://codereview.chromium.org/2624283003 .
2017-01-11 13:30:52 -08:00
1cd918533d
Add support for generic function type syntax, part 1
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2613383003 .
2017-01-11 13:12:10 -08:00
df45dacb88
Fixes #28338
...
Fix await/cascade bug and corresponding test.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2628053002 .
2017-01-11 12:37:18 -08:00
46b7f79fd5
Defer all recursive mixins
...
This defers mixins along with the supertype. It passes Leaf's example on the bug. Will add that as a proper test.
Fixes #28334
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2625913003 .
2017-01-11 10:32:23 -08:00
e5a45ffb5c
Fix ddc USAGE doc.
...
The only substantive change is adding the missing
"--dart-sdk-summary=build" parameter to building the SDK. I went ahead
and prettied up the Markdown too while I was at it.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2620203002 .
2017-01-11 09:51:37 -08:00
be95523221
Cleanup references to the old DDC repo
...
Reachable issues migrated over.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2621543004 .
2017-01-10 12:56:29 -08:00
33c8f425b6
Disable auto "debugger" call for tests
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2621823002 .
2017-01-09 15:42:42 -08:00
038a66b305
Regen DDC error expectations
...
Is this due to recent inference changes?
TBR=jmesserly@google.com ,leafp@google.com
Review-Url: https://codereview.chromium.org/2619923002 .
2017-01-09 15:32:05 -08:00
badfd146d2
Fix type error in js_dart2js.dart caught by DDC.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2611423002 .
2017-01-09 07:42:49 -08:00
7ab0daeedf
Make EventStreamSubscription DDC safe.
...
EventStreamSubscription.listen does a cast which is only working in
DDC because we're ignoring the failure. This wraps the listener to
check the argument rather than casting the function. Also picks up a
few misc changes to the main SDK that hadn't been merged into DDC.
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2609633002 .
2017-01-09 04:13:36 -08:00
83fc4b6b46
Put a TypeProvider on the TypeSystem implementations.
...
Adding a TypeProvider instance to TypeSystem to avoid needing to
thread it through the various APIs, and to avoid having to change
the API every time a method which previously did not need to
access the TypeSystem suddenly does.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2590883004 .
2017-01-09 02:40:10 -08:00
d1030e9be0
Don't hardcode 'dart' as the executable name to spawn.
...
I don't think it's on the PATH on the buildbots.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2617013003 .
2017-01-05 16:44:09 -08:00
95d5bf471c
fix analyzer failing resolve loop variable nodes
...
for example: `var item; for (item in list) { ... }`
this happens anytime ResolutionCopier is used on these, because it drops the staticElement reference for `item` in the above example.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2612983002 .
2017-01-05 10:47:43 -08:00
Vijay Menon