dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
62,721 Commits 2 Branches 0 Tags
f21d521d0ec78e9a02eff3250cd94de412662ebe
Commit Graph

2727 Commits

Author SHA1 Message Date
Konstantin Shcheglov 9b77e4c507 Include constructors into available suggestions. 
R=brianwilkerson@google.com

Change-Id: I44a9ad96f40ff1c5bd42f41bdf03defae7608360
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 01:26:39 +00:00
Konstantin Shcheglov 1926f69e4d Include available classes when includeConstructorSuggestions is true. 
R=brianwilkerson@google.com

Change-Id: I333ac2d1e19c077f31f02b2504b3041fd04acf7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-28 17:26:55 +00:00
Brian Wilkerson 3a3731665f Initial implementation of server support for training data 
Change-Id: I4943b8c30575e78c1028d9d0be174f535db99303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97841
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-26 20:32:20 +00:00
Brian Wilkerson b0823ca558 Add a quick fix for the MISSING_ENUM_CONSTANT_IN_SWITCH diagnostic (issue 36290) 
Change-Id: I6a18fff7c61c93b3444899213da9c447122b76c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97780
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 17:23:38 +00:00
Brian Wilkerson 96a078ce76 Add quick fixes for new SDK constraint checks 
Change-Id: I1a3d3b61e8f12b50bb3ad31b5d91612ef6b3e8aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 21:54:41 +00:00
Brian Wilkerson 11a148c85e Add the ability to associate a URL with a diagnostic 
Change-Id: I06f694311130a36b1db4b4baf2e7d46d999f07b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97554
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 13:32:05 +00:00
Brian Wilkerson 3019a8873a Check for completeness of test_all in analysis server and analyzer plugin 
Change-Id: Ia25b1f93d5f2f3942f0c76d74556228a41410182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97352
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-21 13:24:03 +00:00
Konstantin Shcheglov ca5ac975fe Fix for crash in _DartNavigationComputerVisitor._addUriDirectiveRegion when part has invalid URI. 
R=brianwilkerson@google.com

Change-Id: Ia6c62c344cd195449168e5971165a3d37ffc7f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 14:53:17 +00:00
Brian Wilkerson 8e550f6a4c Support super completions from superclass constraints in a mixin 
Change-Id: Iea4a540989113be85abf98f69cb63843da310a15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-15 13:21:54 +00:00
Konstantin Shcheglov eeb19b0416 Remove usages of ExtensionManager and package:plugin in general. 
R=brianwilkerson@google.com

Change-Id: I489e72464474b3d40d7678f44562f65934f93288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:08 +00:00
Paul Berry 31c47567dc Remove AnalysisOptionsForLink and plumb analysis options through linker. 
This is a non-breaking change; the only way linking is exposed to
clients is through `SummaryBuilder`, which can get the analysis
options from the context.

Fixes #35747.

Change-Id: I273408f33a881ac32ab248cbc8f3e0644630563b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96829
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-13 22:39:53 +00:00
Konstantin Shcheglov 2d48159e38 Issue 36187. Fix for getSuggestionDetails() fails in part file. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36187
Change-Id: I428ab29a08eff43d5538d025b59374e4f8cad154
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96831
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-13 21:26:01 +00:00
Konstantin Shcheglov 81fa14eb3c Hollow out AnalysisContextImpl. 
R=brianwilkerson@google.com

Change-Id: I4ebc67de74cc4bbda63c9f0a8f7c11dbc3f25b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96720
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-13 15:18:22 +00:00
pq bb7b5fcd37 add missing fix tests 
Change-Id: I5c01d0a551050ce9bca36003efa0f6743a7965c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-12 16:39:27 +00:00
pq 48a5c3825a assist to convert to absolute imports 
Change-Id: I2fd6ca7ec1184d56dfe97d430dc9a6c28a8c64bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-12 16:35:21 +00:00
Brian Wilkerson ed9e70c771 Add completion support for the ui-as-code features 
Change-Id: I7835e7169fc702f69f01db0dd1f598a663dff196
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96223
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-09 17:37:16 +00:00
pq 303b8bab3a fix for null_closures 
Change-Id: I413b71dd1acdeaca4c4950b3e6914c1695b72018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95981
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-09 00:02:46 +00:00
pq 1e1d19bb02 fix for replace_colon_with_equals 
Change-Id: Ifc4f20d6de04d506b783661ce7f0dbcc01440ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96135
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-08 21:35:35 +00:00
Paul Berry b72ab0790d Add an Iterable type to the nonstandard SDK test. 
With the new "UI as code" functionality, the analyzer requires any SDK
it analyzes to contain an Iterable type.

Change-Id: Ib098b135665b970040abf9e319b93f36fe09bea8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96122
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 20:13:38 +00:00
pq 8d88316246 fix for unawaited_futures 
Change-Id: I9ef54b1d30dd651ebd2fe20c4ce89808879da529
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-08 14:20:56 +00:00
Konstantin Shcheglov 4b609422e9 Make AVAILABLE_SUGGESTION_SETS and related APIs non-experimental. 
R=brianwilkerson@google.com

Change-Id: I1facae905319f050636126b021f56f353f81d6f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95661
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-07 21:29:36 +00:00
pq ccf756dae5 Integration testing to ensure server lint name representations are correct. 
If lint names do not match, associated fixes are never shown.

See https://dart-review.googlesource.com/c/sdk/+/95743 for the kind of bug this should guard against.


Change-Id: I27b33c56b9f9242497a03972129806863d2287a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 21:01:06 +00:00
pq da831bda20 fix lint name for unnecessary_overrides 
Change-Id: Id6c879d52bb8cbe0c46d1701b382716846947926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 18:11:57 +00:00
pq cab4a7b48d fix lint name for unnecessary_brace_in_string_interps 
Change-Id: I7df7540b4b4574df8e807b313988ed6a4bf6a26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 15:33:33 +00:00
pq 00aeae4ca8 add fix for no_duplicate_case_values 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: Ia09f2530c9a943b8b80fda63fb313b752748264a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-07 15:26:26 +00:00
pq 593405afda add fix for use_rethrow 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: I7e79ad37681afdbd94d7968451a768e74217578e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95708
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-07 15:25:26 +00:00
pq 85dec3423c add fix for unnecessary_new lint 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: I945d393b0b46cf87b5400be1bfdb501c31646988
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95669
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 20:55:00 +00:00
pq 5441ff672b add fix for unnecessary_const lints 
See: https://github.com/dart-lang/linter/issues/1374.

Change-Id: Ieeddf25718ddde77a9e52cb93cbcf34ca2c1f81f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95542
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 15:28:59 +00:00
danrubel 96e982f054 Improve await-outside-async error recovery 
Fix https://github.com/dart-lang/sdk/issues/36048

Change-Id: If40baa44a0aefa301c042bc1002d92e577bd3b9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95302
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 17:08:31 +00:00
Konstantin Shcheglov 3124125008 Move Flutter utility methods into a class, which can be instantiated either with regular package:flutter, or with package_flutter_web. 
The factory constructors does not yet choose one, will do in a
following CL.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36056
Change-Id: I7fabe9da571ea80ce993d9303217ccd8b085e8a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95283
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 05:51:41 +00:00
lambdabaa 1c27b817fc New protocol to inspect analysis server state at code completion time 
This change adds a new, experimental completion domain request
`completion.listTokenDetails`. Its purpose is to allow
other programs to observe and make smarter decisions contingent
upon analyzer's internal knowledge of a Dart program.

Bug: 36083
Change-Id: I5ab477221efeac076eccc873a29cf6feae91052e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95100
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 20:33:44 +00:00
Danny Tuppeny 15f1fc212c Add a flag to allow only analyzing project folders that contain open files 
Change-Id: I7239043292315871d77739858b8342c434ac837c
Reviewed-on: https://dart-review.googlesource.com/c/93430
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 10:29:16 +00:00
Brian Wilkerson 4a144e631f Fix production of outline for incomplete generic function types (issue 36059) 
Change-Id: Ie8e5279fb7b9094377197ee9d0f568f8baad3d10
Reviewed-on: https://dart-review.googlesource.com/c/95080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-02 01:37:32 +00:00
Paul Berry 7dec865054 Add set literal support to the flutter outline computer 
Change-Id: I1d5f3dfdc4987bd7dc91dbd78ff5649667aa23b0
Reviewed-on: https://dart-review.googlesource.com/c/94760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 15:35:36 +00:00
lambdabaa ae70ce855f Include the completion suggestion labels as explicit relevance tags 
R=scheglov@google.com

Bug: 35680
Change-Id: I7525eac8bd95b28e32f714a4c519f6154805f861
Reviewed-on: https://dart-review.googlesource.com/c/94346
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-27 23:39:00 +00:00
Danny Tuppeny 01cc5a6305 Ensure unknown fields in LSP payloads are ignored 
Change-Id: I3f4a2763b2a8714a80108a895c1887b5a36d2a3d
Reviewed-on: https://dart-review.googlesource.com/c/94500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-27 15:00:17 +00:00
Danny Tuppeny f484e1b05e Call canParse() for all LSP requests before passing to handlers 
Any requests with params that don't pass canParse() will result in an InvalidParams error being returned without the handler being invoked.

Change-Id: Ic3e84b9259a467179baa2309fb58ee207f1225fa
Reviewed-on: https://dart-review.googlesource.com/c/94298
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-27 08:12:02 +00:00
Danny Tuppeny 8fb52650e5 Ensure LSP canParse type-checks optional values 
Previously we were only outputting the validation code if the value was required. This changes it to also validate in the case it's not required, but only if it's not-null.

Without this change, the test that parses `'overwrite': 1` fails (a boolean is expected), but with it, it passes.

Change-Id: Ic4afe1f6a8f78add2385831907b226022b7ecaec
Reviewed-on: https://dart-review.googlesource.com/c/94293
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-27 08:12:02 +00:00
Danny Tuppeny 26d91cf4b6 If LSP initialize fails in tests, throw 
Previously if a test didn't expect initialize to error (and didn't check for it), the test failure would be hard to diagnose. With this, if you don't explicitly opt-in to allowing failure, an error during initialize will just throw and fail the test.

Change-Id: I01283a70b3571415ec16f2fc4d781c08a953a6a1
Reviewed-on: https://dart-review.googlesource.com/c/94291
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-27 08:12:02 +00:00
Danny Tuppeny d1876531f2 Fix LSP canParse to allow nulls where the spec allows 
Change-Id: I8a34fbf03e45c85a70d44a54b1715b87f84f9c3b
Reviewed-on: https://dart-review.googlesource.com/c/94290
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-27 08:12:02 +00:00
Danny Tuppeny d4ff20f005 Remove unwanted @soloTest 
Change-Id: I0804a7d409af0aaaea0b799a23a3b443cc1c23f4
Reviewed-on: https://dart-review.googlesource.com/c/94383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-26 15:35:12 +00:00
Danny Tuppeny a52ac7d27b Correct LSP canParse functions for classes containing restricted enums 
This fixes a mistake where enum classes were resolved to their base types (string, num) before being output in canParse methods of their containing class. This meant for "restricted" enum types (those that should not allow any value), canParse would incorrectly return true for out-of-bound values as long as they were the correct type.

Change-Id: I44e37a60b49287cf7202d5a578ee9c08cf898078
Reviewed-on: https://dart-review.googlesource.com/c/94280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-26 07:38:12 +00:00
Danny Tuppeny 73e544ed0b Improve errors when LSP integration tests fail to spawn server 
When the server fails to start up (writing to stderr) the tests currently would just hang waiting for responses to messages. This will just throw the message as an exception, failing the test with a more useful message, for example:

```
00:07 +0 -1: ServerTest | test_exit_afterShutdown [E]
  Analysis Server wrote to stderr:

  file:///Users/dantup/Dev/Google/dart-sdk/sdk/third_party/pkg/linter/lib/src/analyzer.dart:106:27: Error: The method 'registerDefault' isn't defined for the class 'Registry'.
   - 'Registry' is from 'package:analyzer/src/lint/registry.dart' ('file:///Users/dantup/Dev/Google/dart-sdk/sdk/pkg/analyzer/lib/src/lint/registry.dart').
  Try correcting the name to the name of an existing method, or defining a method named 'registerDefault'.
      Registry.ruleRegistry.registerDefault(lint);
                            ^^^^^^^^^^^^^^^
```

Change-Id: If64b68b17a0d379f8879891f0346704d4ad360e8

Remove unused imports

Change-Id: I745499f7b038c81320c127410967d939c7756e51
Reviewed-on: https://dart-review.googlesource.com/c/94222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-25 17:13:52 +00:00
Danny Tuppeny 380cec1708 Wait for LSP server to be ready before sending exit command in integration test 
Otherwise we'll need to increase the timeout to account for server startup (which will mask if the exit really is taking a longer time than it should).

Change-Id: I5c770efa62dc2a66946fd7a6c07665d3f1b80ee4
Reviewed-on: https://dart-review.googlesource.com/c/94260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-25 17:12:57 +00:00
Danny Tuppeny 6af24a2490 Move LSP diagnostic server test -> integration 
This tests we can spawn the diagnostic server on-demand. The test was previously marked failing because it needed to be a real inrtegration test.

Change-Id: I52638682d7fb1807584601f7ff933f30b1bd6d70
Reviewed-on: https://dart-review.googlesource.com/c/93949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-25 12:03:58 +00:00
Danny Tuppeny 34614ef995 Exit LSP server with exitCode=1 if there was no shutdown notification 
This adds a new server state "shutting down" which rejects requests. The LSP spec says clients should send the shutdown notification, then the exit notification. If an exit notification is received without a shutdown, then the exit code is set to 1.

Change-Id: I50aa186d699a646ee1422f5b3ddaae4bc089b632
Reviewed-on: https://dart-review.googlesource.com/c/93952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-02-25 11:58:24 +00:00
Brian Wilkerson 010052cb2b Add an assist to convert conditional expressions to a null aware operator (issue 35691) 
Change-Id: Ic9aa8d3fa0408653088c9eb91c14083622ede60f
Reviewed-on: https://dart-review.googlesource.com/c/94124
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-24 22:46:14 +00:00
Brian Wilkerson f97f759ef3 Update the implementation of for loops 
Change-Id: I492e8ce5303713cca0c742deeb53f670ebd21f84
Reviewed-on: https://dart-review.googlesource.com/c/93849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-21 21:23:19 +00:00
Konstantin Shcheglov bdb52a8f33 Fix 'Organize Directives' handling end-of-line comments. 
R=brianwilkerson@google.com

Change-Id: Iaec35a52c74229f00560ccfc7613c2f2e9cf4d41
Reviewed-on: https://dart-review.googlesource.com/c/93841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-21 01:04:18 +00:00
Konstantin Shcheglov 266ce73e28 Remove CompletionSuggestion.elementUri, replaced with AvailableSuggestionSet. 
R=brianwilkerson@google.com

Context: https://github.com/JetBrains/intellij-plugins/pull/633#issuecomment-465725310
Change-Id: I03a1b7e7ec7cc0a5b0797dc960b72ca314a32132
Reviewed-on: https://dart-review.googlesource.com/c/93745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 21:34:18 +00:00