dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
83,734 Commits 2 Branches 0 Tags
f15518dffc2c6df7ee43ad2a00a963cb8ce69cff
Commit Graph

6624 Commits

Author SHA1 Message Date
fredbroz da97de73cb [analyzer] Add fix for avoid_void_async lint 
Closes https://github.com/dart-lang/sdk/issues/47959

Change-Id: I32838d7889cbaf9491d24672f19995cd6f75c2fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 19:57:35 +00:00
Konstantin Shcheglov 5198169e1a Suggest the exception and stack trace as local variables. 
Change-Id: Icffb93295db3be2e0b83c1ff2dd5dc01f1ce901d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 19:49:45 +00:00
Konstantin Shcheglov 52290eba28 Add CompletionSuggestion.libraryUri, keep isNotImported. 
Change-Id: I1bce246c2d8eaa968a47ae6ba82114592b991a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 22:49:10 +00:00
Konstantin Shcheglov f69d1f887f Use CompletionSuggestionBuilder, and HasCompletionData to store location independent data. 
Change-Id: I767bfc1c31b5aebc8f4e27267520f705701e7724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 17:33:19 +00:00
Brian Wilkerson a4b3b8edec Add an assist to convert a normal parameter to a super initializing parameter 
Change-Id: Icf5d44a3a155e67f76165eca711094d368cdca64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-04 01:03:36 +00:00
Konstantin Shcheglov ddff5ac88c Tests for completion in NamedExpression. 
Change-Id: I5a7ba57a1279797f7e625890a64c42091708f60e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-03 22:24:16 +00:00
fredbroz d48a637bf5 [Analyzer] Add fix for use_raw_strings lint 
Closes https://github.com/dart-lang/sdk/issues/47955

Bug: https://github.com/dart-lang/sdk/issues/47955
Change-Id: If321097598fcdcd79c246032f64332e91ee7f57c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-03 15:55:56 +00:00
Konstantin Shcheglov f5acc570e8 Fix CompletionDriver tests on Windows. 
Change-Id: I43bf2c80b244906c2568e05fd24d4dd49953feb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-02 18:28:25 +00:00
Sam Rawlins b9b1252752 For existing fixes, add super-parameter and named-args-anywhere tests 
Bug: https://github.com/dart-lang/sdk/issues/48067, https://github.com/dart-lang/sdk/issues/47578
Change-Id: Iaef317459c7e6901296475163959ad92a6c880b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231070
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-02 17:47:49 +00:00
Danny Tuppeny 4a5b0b3030 [analysis_server] Fix slash direction in auto-import details for LSP completions 
Fixes some failing tests on the Windows bots that were getting backslashes but expecting forward.

Change-Id: Idd89a45d7be87385d497e221a1941e4c48d597af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-02 17:26:09 +00:00
Keerti Parthasarathy eb4f5077ab Check for private elements while rename 
Change-Id: I3423cd746e675315a3abd1b728bc6cd978384beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-02-02 03:08:46 +00:00
Konstantin Shcheglov 1b16157413 Switch AbstractCompletionDriverTest to PubPackageAnalysisServerTest. 
Change-Id: I39e14c746b1b50af12508e6b30785cdd97920c2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-31 18:25:54 +00:00
Konstantin Shcheglov 972455663d Run tests for completion in FieldFormalParameter with both protocols. 
Change-Id: I0e26e602c5b5fa9e85878cea4a62323e38d6ba91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-31 17:31:54 +00:00
Konstantin Shcheglov 31885cd7e9 Run SuperFormalParameter completion tests with both protocols. 
Change-Id: I0cc230731b5ca9bbf6a2b32a921f64d6b717e25f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230881
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-29 02:25:53 +00:00
Konstantin Shcheglov b298b5d4c0 More locations for enum completion tests. 
Change-Id: I68c302a56279b19c178556454d6f672650b26cab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-28 20:17:32 +00:00
Sam Rawlins 7a6326e49c Update fix statuses for 2.15, 2.16, 2.17 codes 
* many super-parameter codes can have a fix of "remove 'super.'"
* many constructor-tearoff codes can have a fix of "remove type
  arguments"
* did not evaluate the FfiCodes or PubspecWarningCodes

Change-Id: I3421f226ec88621d9927970cb607e13577c8f234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-01-28 17:19:22 +00:00
Sam Rawlins c49ccf09f1 Add a file to track all codes and fix status 
Also sort a few files.

In general only "has fix(es)" and "needs evaluation" has been marked so far.

Evaluations will come later.

Change-Id: Ibc2207a17ac158db795920216af2a7e9f376658c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-01-28 06:13:21 +00:00
Konstantin Shcheglov 6dd2790b57 Use cached enclosingClassElement for extension completion. 
This improves time to compute completion metrics from 61 to 48 seconds.

We used to spend 21% of all time in `[Stub] InstanceOf`.
Now 2%, unfortunately it does not show back pointers.

Change-Id: I3c6c62cabfa86bac138d95d4830b605693e086d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 23:34:42 +00:00
Konstantin Shcheglov 985d476218 Use Map.identity() to associate data with CompletionSuggestion(s). 
CompletionSuggestion.hashCode is very, very expensive.

With some other changes the difference is 67 vs 47 seconds.

Change-Id: Ie792b5ccbfd32a1896166594fdeeb89193d4d061
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-27 22:11:41 +00:00
Brian Wilkerson 9268feca62 Update the completion_metrics tool to support the new protocol 
Change-Id: Iaa6ee477e97967c901a1c0442a8a3e8425b89a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 21:27:51 +00:00
Danny Tuppeny 7a4c3c1c46 [analysis_server] Handle workspace folders with trailing slashes in LSP server 
Fixes https://github.com/dart-lang/sdk/issues/48234.

Change-Id: Ic10ab8054681779dd5ea6a1617e2f8a4057aee57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 17:09:30 +00:00
Danny Tuppeny 7ad1786e45 [analysis_server] Refactor completion handlers in preparation for using NotImportedContributor 
Change-Id: I18608b110093e87887f8e9118340e323fe829248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-26 20:07:28 +00:00
Konstantin Shcheglov 540c053ca8 Add HighlightRegionType.EXTENSION 
Change-Id: I375df19b8ee5f6570fcc7d440b9d71b148bcef73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-26 16:11:59 +00:00
Konstantin Shcheglov afd8df4d54 Fix for suggesting enum constructors, tests for both protocols. 
Change-Id: I71721cf0e2c3c772b1662f2abe065837c5405ad2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229950
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-26 00:44:59 +00:00
Sai Sandeep Mutyala 4e77df92de Add a fix for the leading_newlines_in_multiline_strings lint. 
Bug: https://github.com/dart-lang/sdk/issues/47960
Change-Id: Id775cfc3a2c5a8635ad26c8b4a611c94e770b6b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-25 17:24:01 +00:00
Konstantin Shcheglov e3a2e59f18 Don't use 'whereType' in NotImportedContributor. 
Bug: https://github.com/dart-lang/sdk/issues/47680
Change-Id: I7e90f52e7658eef4b9280f485b457d86ac0f4e9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-25 06:41:09 +00:00
Brian Wilkerson 1708703d15 Complete the refactoring of ElementMatcher 
There are quite a few TODOs left in the code, and I'll address them in
future CLs, but this appears to be consistent with the behavior of the
previous implementation and finishes the majority of the refactoring
changes.

Change-Id: I68093f6ac115f8b8b9b10bf93239fe4e2b9c6390
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-25 05:36:36 +00:00
Konstantin Shcheglov 06e9046e34 Issue 48074. Display inherited default value for super-parameters. 
Bug: https://github.com/dart-lang/sdk/issues/48074
Change-Id: I964141c9b2a1ccf4a2d08d6bfff7675aa6df9d5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-25 01:54:27 +00:00
Konstantin Shcheglov 61de22db59 Test for enum constants with isNotImportedFeature, simplify it. 
Change-Id: I1e00cd7291a4e018d1fc4820862c7e4c9d84be15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229325
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-22 00:11:00 +00:00
Konstantin Shcheglov f58733ef6d Run CompletionDriver based tests with both protocols. 
Change-Id: I29132ef8ec7fe9f373b57961338012b6163e6707
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-21 16:36:30 +00:00
Konstantin Shcheglov 47eff41cdb Issue 48184. Fix suggesting local function returning void in named argument. 
Bug: https://github.com/dart-lang/sdk/issues/48184
Change-Id: I5f6c8f2443782dec3c75c44cb7baeea8ed8b5e0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 23:45:57 +00:00
Konstantin Shcheglov 8781ab0151 Update CompletionWithSuggestionsTest for better alignment with the new protocol. 
A few tests added, mostly removing CompletionSuggestionKind.INVOCATION
because it is set just for any available declaration by the completion
driver, but this is not what we use for local elements and the new
protocol.

Change-Id: I87da134fd94da75005a98e17e81f43ee56451baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 22:44:08 +00:00
Konstantin Shcheglov c736694ba2 Decrease relevance of not-yet-imported suggestions. 
Change-Id: I00f309bee05f79ae400878a000a197ac1732b97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 22:03:57 +00:00
Danny Tuppeny 32b3e18e92 [analysis_server] Insert "required" keyword in created methods/added named parameters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3770.

Change-Id: I954b9bbcac72ffc7a7b6e168214971bf1786872a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-20 17:00:37 +00:00
Konstantin Shcheglov 6d5543e01b [analyzer] Update generated experiments 
experimental_features.yaml was updated in
https://dart-review.googlesource.com/c/sdk/+/219789
but unfortunately the analyzer code wasn't regenerated.

This CL updates the generated files and adds capability of checking
consistency to the generator. A check of consistency is add next to
the check for consistency used in presubmit for the CFE counterpart.

Was: https://dart-review.googlesource.com/c/sdk/+/224520
Change-Id: I59be4335ee81743aca5dc48eaa0df278d64d3692
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 00:07:36 +00:00
Danny Tuppeny 5455047ed0 [analysis_server] Suppress code completion in comments before dartdocs 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3783.

Change-Id: I8539d8b525534ad85b42618a6a3e9888fb43c851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-19 17:25:36 +00:00
Danny Tuppeny 5bf643b24a [analysis_server] Include static type in LSP hovers 
Fixes https://github.com/dart-lang/sdk/issues/48147.
Fixes https://github.com/Dart-Code/Dart-Code/issues/1160.

Change-Id: Icc4bbb5b89a75a14579f72b2c74929e7a05ac688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-19 16:45:15 +00:00
Brian Wilkerson df2e8fedbb Start to refactor ElementMatcher 
This is the first of multiple smaller CLs to refactor `ElementMatcher`.

I was starting to fix a bug and realized that the current implementation
allows the number of components to be out of sync with the element kind.
The primary goal is to prevent that by eventually merging the methods
`_componentsForNode` and `_kindsForNode` into a single method
(`buildMatchersForNode`).

In the process I realized that we can sometimes match either a top-level
declaraation or an instance member from a superclass, and that means
that we need multiple matchers (otherwise I think the number of
components will continue to be out-of-sync with the element kinds).

This CL also includes the failing test that started the whole
investigation into refactoring this class.

Change-Id: I0c3a56f29f0f6c6d0cad6ac80145b26201931518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-18 23:39:27 +00:00
Konstantin Shcheglov 1b447a1335 Navigation support for super-formal parameters. 
Change-Id: I8070b303ea4d7bce45afe63668f9ec85686dd1b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-18 17:53:25 +00:00
Danny Tuppeny 08c42b3178 [analysis_server] Fix some minor LSP codegen issues 
Change-Id: Ie6171416cca75ec623d600ddea2e1efefd8156ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-18 17:35:05 +00:00
Danny Tuppeny f0475f6015 [analysis_server] Add LSP semantic token modifier for instance fields/methods 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3778.

Change-Id: I112ebf727925e2b576e91e719489ca7502e55058
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-18 16:58:25 +00:00
Danny Tuppeny 92da2376bc [analysis_server] Handle override completion before getters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3784.

Change-Id: I422f7758f0ae713a37c4b15672828ada67ce9d65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-18 16:16:16 +00:00
Konstantin Shcheglov a8c63a8773 Semantic highlighting for super-formal parameters. 
Change-Id: Ib3a663c9bec7909451c082bcc8943df08339a35f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-17 00:11:24 +00:00
Konstantin Shcheglov e8098caeab Field formal parameter identifier is a declaration. 
Change-Id: I70bdf7af8f2663a056b8b9be65f5ea23a105d2f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 20:37:53 +00:00
Konstantin Shcheglov eca60b2480 Fixes for analysis_server tests on Windows. 
Change-Id: I2a0edfa036c3095620944d866ea498f702b8bd13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 20:32:32 +00:00
Danny Tuppeny 650b9627b7 [analysis_server] Rebuild analysis contexts if changes occur between creation and watchers being ready 
See https://github.com/Dart-Code/Dart-Code/issues/3438.

Change-Id: I3ca038d8c878b118a465b6f230c62912d63990eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 00:18:41 +00:00
Danny Tuppeny 9abb0d17c8 [analysis_server] Use existing line/col information in preference to LineInfos for LSP diagnostic mapping 
See https://github.com/dart-lang/sdk/issues/48092.

Change-Id: Ifdacf33b30c19859aa33be83300329454637ba5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-14 19:26:31 +00:00
Konstantin Shcheglov 6e30e5a7f6 Add 'Extract local variable' fix for UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE. 
Bug: https://github.com/dart-lang/sdk/issues/47588
Change-Id: Ice823f239b3b152d9583cecb143ea78a62361539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-13 01:03:22 +00:00
Konstantin Shcheglov 981c16ea52 Add @useResult to completion checks. 
Change-Id: Ia9fad74c02e6c69265a54e7058722b0ccec6ac27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227840
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-12 20:26:12 +00:00
Konstantin Shcheglov b1be1c96dc Remove assertLibrariesToImport() from completion tests. 
With `Element.libraryUri` we don't need it anymore.
Each suggestion has its own copy, which we check as necessary.

Change-Id: If8b2fe8e92635268ff06fd4c5e44c29e96dea6c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227584
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-01-11 22:25:14 +00:00