Nate Bosch
28d697a6c1
Enforce override annotations in dart2js
...
Update the excludes in the test directory analysis options to match the
files that were not updated to add override annotations.
Update the excludes in `testing.json` to match the analysis options.
With a consistent analysis options test config the diagnostics in
editors will match what is enforced by the test.
Also clean up the no longer required `enableSuperMixins` config.
Change-Id: If0e23642c25e0b5c1aced6a5a8c8c05a6da538f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96836
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nate Bosch <nbosch@google.com >
2019-03-14 18:47:05 +00:00
Johnni Winther
3cd0a1f5e4
Remove old_frontend and mirrors tests
...
Change-Id: I1e10d65c25298eb084619ed156daa3d2069f92e1
Reviewed-on: https://dart-review.googlesource.com/53741
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-05-07 10:07:40 +00:00
Johnni Winther
969c0de335
Avoid crash on EOF error in file with Windows line encoding
...
+ start using spans from CFE (now that they're available)
Change-Id: I4fe82070d32948a64fb0fab527bd4cc857eebeb4
Reviewed-on: https://dart-review.googlesource.com/49841
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-04-09 12:16:20 +00:00
Konstantin Shcheglov
2401b16846
Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE even if the superclass has noSuchMethod().
...
See the bug.
This does not make it a compile time error though.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/31593
Change-Id: Iefef8eecec43b6b8afaac74198bffbeae1c8b104
Reviewed-on: https://dart-review.googlesource.com/28120
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-04 20:32:05 +00:00
Johnni Winther
e8e3fb5224
Reenable source map tests
...
- and fixes regressions + add more coverage for the regressed parts
Change-Id: Ied0aa54389164650b4fcd8f0363ddabb60c00a77
Reviewed-on: https://dart-review.googlesource.com/20204
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-14 08:18:44 +00:00
Bob Nystrom
1d8c3af663
Delete old tests that aren't used and/or useful any more.
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2976313002 .
2017-07-18 14:12:57 -07:00
Peter von der Ahé
69d6e8e55a
All strong mode cleaning of dart2js.
...
Fixes https://github.com/dart-lang/sdk/issues/29886
Supersedes CLs 2939193003, 2950433002, and 2947583002.
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2944843002 .
2017-06-19 14:06:38 +02:00
Peter von der Ahé
2e6e44a69b
Strong mode cleaning of many dart2js tests.
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2939063002 .
2017-06-16 09:31:29 +02:00
Peter von der Ahé
ba2cde4607
Switch the defaults: strong mode is now default, but we stil check tests in Dart mode.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2938943003 .
2017-06-15 14:16:39 +02:00
Peter von der Ahé
ddf5fc23f1
Improve analysis coverage.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2904483002 .
2017-05-24 15:52:42 +02:00
Sigmund Cherem
7ece6d94a2
fix bots: do not analyze front_end when analyzing dart2js, they need to be
...
analyzed with incompatible options (strong vs not-strong). pkg/front_end is
anyways analyzed in the front_end tests, so I believe this is safe to exclude
here.
BUG=
Review-Url: https://codereview.chromium.org/2853183002 .
2017-05-01 19:39:50 -07:00
Peter von der Ahé
5bdc1199ca
Fix dart2js warnings and add test to ensure it stays clean.
...
Filed https://github.com/dart-lang/sdk/issues/29224 to track all the problems that require ignore.
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2791993002 .
2017-04-03 15:08:40 +02:00