dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,232 Commits 2 Branches 0 Tags
f005bd5a3eded7dffe90e6fb2e7ea12db631fe21
Commit Graph

2526 Commits

Author SHA1 Message Date
Konstantin Shcheglov 4270982dd1 TypeSystem tests code motion. 
Drop `Strong` prefix, extract LeastUpperBoundFunctionsTest.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I2ab28f23e28698f4c2063eb07362ae6df2938054
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-10 14:47:53 +00:00
Mike Fairhurst 527dffd21b Use StringSource in type provider tests to prevent bad path lookups. 
Prevent windows from doing a path lookup for 'dart:core' which will
crash. All we need is a string source with a uri..

Change-Id: I742060633f3bd89323ad3e3f0f19ae80c1aedbae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104806
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-06-06 19:38:27 +00:00
Dan Rubel 4181185070 parse nullable function typed formal parameter 
Change-Id: I502d4c6649a8974883b9ded038ce8927d34eea10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-06-05 13:37:01 +00:00
danrubel 6f2f92f578 improve extension method declaration recovery 
Address comment in https://dart-review.googlesource.com/c/sdk/+/103580

Change-Id: Ie92e4fa752eaf851fec9465565d640524b569760
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-31 23:30:25 +00:00
Dan Rubel 2938630937 update parser to handle "!." in nnbd expressions 
Fix https://github.com/dart-lang/sdk/issues/37111

Change-Id: I6e156a804085c9be12e5e7a0d0019cfeb77c9128
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104187
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-31 11:37:44 +00:00
Konstantin Shcheglov 13ff60ec02 Use Substitution for typeAfterSubstitution with summary2. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If8c4a4ad7db406fa4af9f22456ec40d153588db9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-30 15:33:17 +00:00
Mike Fairhurst 2268c65cbe First subtyping rules for nullable types 
Change-Id: Ibaaea75f8b5e83f1fb7039332093121854108da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103548
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-05-29 22:13:11 +00:00
Konstantin Shcheglov 76750c58f2 Issue 35553. Report WRONG_TYPE_PARAMETER_VARIANCE_IN_SUPERINTERFACE. 
Locally I see that out of 198 language_2/superinterface_variance/ tests:

* With summary2 we pass 197, and fail 1 test.

* With summary1 we pass 165, and Crash in 33 tests.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35553
Change-Id: I79b5d7d2931c2d0c42ae6f12c19324deb7af784f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-29 17:13:30 +00:00
Brian Wilkerson 98a4dba4b3 Update Element.appendTo to more closely match Dart syntax 
Change-Id: I74bf13f3b072c734b018517e6d06e182a0736bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-29 17:06:40 +00:00
Brian Wilkerson 2e51423c3d Convert the way function types are displayed to better match the syntax of Dart 
Change-Id: Id5068bd52b3a35c70cb0d2ccc735469e2f8a0d3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-05-28 20:48:51 +00:00
danrubel fee615c5a5 consolidate multiple modifier error codes 
This consolidates the following error codes into MODIFIER_OUT_OF_ORDER

* COVARIANT_AFTER_VAR
* EXTERNAL_AFTER_CONST
* EXTERNAL_AFTER_FACTORY
* EXTERNAL_AFTER_STATIC
* STATIC_AFTER_CONST
* STATIC_AFTER_FINAL
* STATIC_AFTER_VAR

Change-Id: I3f8c41bacc65ebc5d9255806cbee89cddb5ffeb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-28 17:01:16 +00:00
Konstantin Shcheglov 527c165426 Deprecate 'abstract' setter in elements, replace with 'isAbstract'. 
I deprecated 'abstract', but I don't see any uses of it outside of
analyzer, which I have fixed. So, maybe we should remove them right now?

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ifd86a6b0148be49df6455672742f825ffd50f661
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103661
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-05-28 04:16:43 +00:00
Dan Rubel f4f2c77d4a improve missing body error messages 
This builds on the prior CL to improve the error messages
for missing switch statement body, missing finally clause body,
and others.

Change-Id: Ia2def1f3a75d5581356c12aee4705ef21870f749
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103571
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-24 17:03:25 +00:00
Dan Rubel ec1ddcdb83 improve extension message missing body error message 
This improves the missing class, mixin, and extension method body
error messages and lays the groundwork for improving other
missing body error messages such as switch statement, finally clause,
and others.

Change-Id: I0a4d1338fe91eee3cfe7d61652e168df1302d212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103570
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-24 17:03:25 +00:00
Lasse R.H. Nielsen eca6c8953f Allow async as an identifier everywhere. 
Fixes #37063

Bug: http://dartbug.com/37063
Change-Id: I2253c3088fbe33eca1072f2480cf0cf3cc363362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-05-24 08:21:14 +00:00
Dan Rubel 1ffcccd9cc add extension method header parser recovery 
Change-Id: Ia7424a467014471c01eb30604a062430de42f84d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-23 21:43:29 +00:00
Brian Wilkerson 28f701982b Add diagnostic location info to more tests 
Change-Id: Id5d0e617a55abc2e1ed3d0bac7ae56544aa348e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103543
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-05-23 16:18:50 +00:00
Dan Rubel d92341be08 first cut parse extension methods 
This is an incomplete parser implementation of extension methods.
Subsequent CLs will flesh out the details.

Change-Id: I8c891827e97b451388cadc9cedea3afb7a8cf922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-23 10:54:34 +00:00
Dan Rubel 0c891451a8 cleanup parser forwarding and test listeners 
Change-Id: I593f8bf862179684a031c9538def62c8415c0d77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-22 22:11:40 +00:00
danrubel add95652d2 fix AstBuilder invalid getter recovery 
This fixes the Astbuilder recovery when encountering "get <identifier> :"
in a class body to build a method node rather than a constructor node.

Fix https://github.com/dart-lang/sdk/issues/36961

Change-Id: I48242838d72c3a6c18e78a469b6e07fd1481d0c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-22 00:28:55 +00:00
Konstantin Shcheglov cf15dc17e0 With summary2 FunctionTypedFormalParameter has type parameters. 
This re-applies changes to tests from https://dart-review.googlesource.com/c/sdk/+/100620

R=brianwilkerson@google.com

Change-Id: If6721d2febb39b52277fdb39845bb2486cb6eb47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-17 23:31:16 +00:00
Paul Berry 8d52c0d08e Store library nullability status in LibraryElement; adjust TypeParameterElement.type based on it. 
Change-Id: I0a9673b3b2f46bbf5c3aea429e90c6ddafa978e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102224
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-05-17 21:27:21 +00:00
Konstantin Shcheglov 42c35d7bd6 Optimize summary2. 
1. Don't store tokens.
2. Start moving toward storing only semantic information.
3. Don't use DeclarationSplicer, DeclarationResolver.
4. GenericFunctionType(s) don't work, we need a way to associate AST
location to summary location. I think it is solvable.

Change-Id: If0bf9f20f8092068488322129853b788dd947eb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102127
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-11 15:49:39 +00:00
Brian Wilkerson 5cffcd9e2c Add the class NonNullableTypeProvider to access SDK classes in opted-in context 
Change-Id: Id0cd7c8cd6f93701a5e603753b10a27236292d41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102202
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-10 18:51:38 +00:00
Paul Berry 63001295c0 optionally report scanner errors before parsing 
The fasta parser handles error tokens produced by the scanner
but the old parser expect error tokens to have been already
translated into error messages. This updates the analyzer scanner
to optionally translate scanner errors.

Change-Id: I62383965285511c93e8fbf6a4cada97e9e4e3c04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102143
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-10 17:49:57 +00:00
danrubel b4e2c0246c update parser to handle leading error tokens 
This is the first of several CLs that move error tokens to the head
of the token stream so that parser handling of error tokens
can be simplified and less error prone.

In this particular CL:
- update parser to handle error tokens at the head of the token stream
- remove several places that analyzer was preprocessing error tokens
   now that the parser handles them

Change-Id: Iddf60ab2879567a345a692b64043bd42f1871947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-09 18:36:31 +00:00
Paul Berry 39858b1225 Remove CompilationUnitImpl.isNonNullableLibrary 
And plumb FeatureSet into more of the analysis engine.

Change-Id: I40f7061d48c5eb2a597f95a32738bd3133fe21d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101224
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-05-08 21:36:59 +00:00
danrubel a83fbc5edb remove unused enable lazyAssignmentOperators flag 
Change-Id: I4112fe4ad5a08916d124216753a995d607a9892d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-07 13:06:39 +00:00
danrubel 79f4ecf191 report error on const method with empty body 
Fix https://github.com/dart-lang/dart_style/issues/810

Change-Id: I5ff31f0cdcc89f9b05b9079698a752b875518da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-06 20:00:38 +00:00
danrubel 4655f63670 update analyzer.Scanner to track featureSet 
Change-Id: Ide1ed3fc83831ab2a957b6e823f515135611614b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101440
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-06 17:46:52 +00:00
Paul Berry 81ced1c9bf Make a separate file for tests of implicit_this_reference_in_initializer 
Change-Id: I98838dee538158a3776cdeedc195d74f00ece9d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-05-04 14:50:26 +00:00
Konstantin Shcheglov c38b65d2bc Use FreshTypeParameters from type_algebra with summary2. 
FunctionTypeImpl.fresh() works in inscrutable ways, and does not work
correctly for synthetic FunctionType(s).

This change breaks 2 or 3 tests with summary2, because of using
FunctionTypeImpl.recoverTypeArguments() in ErrorVerifier
_checkForImplicitDynamicInvoke().

CheckerTest | test_implicitDynamic_function
CheckerTest | test_implicitDynamic_method

I prototyped a way to stop recovering type arguments some time ago.
https://dart-review.googlesource.com/c/sdk/+/98984

R=brianwilkerson@google.com

Change-Id: I0077e9d91663912cbd4f6c1bf0c2acea5a5056e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-03 14:26:34 +00:00
Konstantin Shcheglov 70e00c9a37 Handle ClassTypeAlias without valid Function. 
R=brianwilkerson@google.com

Change-Id: Ibc160658b75f7d5a450548e12aa5dc96be674f06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101072
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 21:01:30 +00:00
danrubel 1682b4aac5 replace parser language version comment processing 
This CL removes duplicate language version processing from parser
now that the scanner does this work.

In addition...
- update parser tests to listen for languageVersion scanner event
- remove languageVersion field from CompilationUnitImpl and AstBuilder
- add Scanner.buildConfig for translating a FeatureSet into a ScannerConfiguration
- remove old language version parser tests
- cleanup parser nnbd tests

Change-Id: I6ead6a3ab6d5d424e9a7dfbf69da110e43c63982
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100990
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-02 00:55:43 +00:00
Konstantin Shcheglov a7c0a75442 Disable DeclarationResolver tests with summary2. 
R=brianwilkerson@google.com

Change-Id: I83ad273ba2a0862e659f407f5749e7ae11b507c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 20:06:05 +00:00
Brian Wilkerson 52608e3174 Convert more tests to DriverResolutionTest 
Change-Id: Ib1c3018362f868626d788bc63ba33e5fe5900d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 17:02:19 +00:00
Brian Wilkerson 481d6b9f30 Fix the windows bots 
Change-Id: Ia3f796a174c03912975b37fb9904eea0a05f04c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100926
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-30 22:53:22 +00:00
Dan Rubel 7cb1365f7f replace individual scanner flags with scanner configuration 
Change-Id: I3d4522a8bcabcbc139de09e08d44baf2eeae4a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100882
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-30 21:29:02 +00:00
Dan Rubel a20e7eee15 update scanner config based on language comment 
... and add ScannerConfiguration.nonNullable const

Change-Id: I6917c535e40e94cb591f2c4f5582dc0127be17f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-30 21:28:02 +00:00
Konstantin Shcheglov de1966db11 Separately handle InterfaceType and FunctionType while collecting free type parameters. 
FuntionType(s) with summary2 are not Element + typeArguments,
they are just types.

R=brianwilkerson@google.com

Change-Id: I52887e6b31cd4e2f9749ff67943159f3c93722fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100888
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-30 20:59:52 +00:00
Brian Wilkerson 5152269d28 Convert another test class from ResolverTestCase to DriverResolutionTest 
Change-Id: I621f55712f19be3b0d7ff4aadf1420f55d2ef53c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100824
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-30 17:21:01 +00:00
Konstantin Shcheglov ea708965ab Find type alias self-references during linking. 
Elements are not available for FunctionType(s), and during linking
we have the whole library cycle, so can compute self-references.

R=brianwilkerson@google.com

Change-Id: I2e145c4efae77ac5dbff2782f4b3590339187c0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100796
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-30 14:41:58 +00:00
Paul Berry e2d0f5a50b Add featureSet parameter to Parser constructor. 
And deprecate old parser configuration setters.

Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-29 16:42:19 +00:00
Konstantin Shcheglov f598581e41 Support for type parameters in function typed formal parameters. 
See also https://github.com/dart-lang/sdk/issues/28515

R=brianwilkerson@google.com

Change-Id: I4365a159a969b5cb77b755a9dad8602a9992ab7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-27 18:05:16 +00:00
Paul Berry 986978ad8e Additional FeatureSet plumbing for parser_fasta_test.dart 
Change-Id: I6d0ff3f1b4a342717fd809f828db75401f9f0337
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-26 20:16:45 +00:00
Brian Wilkerson c6cc447e98 Convert StaticWarningCodeTest to use DriverResolutionTest 
Change-Id: I2e5f282d79e7048984edbcd866ac4a8312e82b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100626
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-26 18:18:35 +00:00
Paul Berry c5e57cc078 Plumb FeatureSet through resolver 
Change-Id: I796b09469c2167122f535718e5ffacb1dc4dd012
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-24 17:21:37 +00:00
Paul Berry 296505e2e3 Sort declarations in pkg/analyzer/test/generated/parser_test.dart 
Change-Id: Iee4ae779ddc94c0022ff04273bb54b84d2ec0eb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100403
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-24 17:18:32 +00:00
Brian Wilkerson e42c5d12fe Cleanup tests by removing references to enabled experiments and by reducing duplication 
Change-Id: Ic7eb96e1724d2a51469e41760856d4194e3379e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-24 13:20:36 +00:00
Paul Berry cee1e41fe8 Plumb new FeatureSet class into Scanner. 
And change clients of the scanner (within the SDK) to use it.

Long term, it would be better to store the FeatureSet object directly
in the Scanner and remove the existing flags `enableGtGt` and
`enableNonNullable`.  However there are analyzer clients that
currently use these flags.  So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags.  Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.

Change-Id: I9e662f4ed45668d9acd4f56e42d7d8dae6180d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99975
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-23 16:13:43 +00:00