dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
81,176 Commits 2 Branches 0 Tags
ef850dbdecc4efd014ee62887eed466422907eaf
Commit Graph

6698 Commits

Author SHA1 Message Date
Alexander Thomas df4f40e4ef [infra] Fix pkg/dart2js_info package-config.json exclusion on Windows 
This is a follow-up to https://dart-review.googlesource.com/c/sdk/+/209900

Cq-Include-Trybots: luci.dart.try:pkg-linux-release-try,pkg-mac-release-try,pkg-win-release-try
Change-Id: Ic03c6d830727b377477b7780ab9dbf242c16d368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209906
Reviewed-by: William Hesse <whesse@google.com>
 2021-08-11 11:07:32 +00:00
Alexander Thomas c04a71e455 [infra] Temporarily remove package_deps.dart from the test matrix 
It currently fails because pkg/dart2js_info isn't wired up, yet.

Change-Id: I10a2d43385fe3d900a62fa7438ed37b9e366dffb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209902
Reviewed-by: William Hesse <whesse@google.com>
 2021-08-11 09:10:06 +00:00
Alexander Thomas 7fe597bd8e [infra] Exclude pkg/dart2js_info from package_config.json 
pkg/dart2js_info will soon contain a checked-in version of dart2js_info
that will eventually replace third_party/pkg/dart2js_info. Until that
happens, pkg/dart2js_info should be ignored.

Change-Id: I337d69b6ee58b1ec0f436a199c81828dfd391ec8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209900
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2021-08-11 07:32:40 +00:00
Gabriel Castro 799b39ad42 dart:html static extension members generation 
Initial changes to add functionality to the dart:html generation
script to generate classes with the JSInterop static extension pattern

Change-Id: I9dca21db7500ab25ac96b16eda11fe605f915abe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208461
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com>
 2021-08-10 18:15:30 +00:00
Alexander Thomas c040c050d6 [release] Bump language version to 2.15 
TEST=Standard CQ.
Change-Id: Ib50b4d23f25ea4bd074904a87068a4a8774932aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209561
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-08-10 13:06:53 +00:00
Erik Ernst 58d917e757 Correct uri rule in Dart.g 
The spec parser previously assumed that an import or export directive
would use a single-line string. However, multi-line strings like
"""lib.dart""" and raw strings like r'''lib.dart''' are allowed as well,
and also mixed forms like "lib" r'''.dart'''.

This CL changes Dart.g such that those forms are supported.

Change-Id: I40abe1a2f095907803371fc4224bd10bbca38c9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208880
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2021-08-05 08:32:38 +00:00
Stephen Adams 5ff2459d88 Remove obsolete internal dart2js annotations 
These annotations have all been replaced with @pragma('dart2js:xxx')
versions:

@ForceInline, @NoInline, @NoThrows, @NoSideEffects, @AssumeDynamic.

Change-Id: Ia4730670c6864ccbe0fa4120108c3c16ab887c23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208863
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-08-04 23:27:18 +00:00
Alexander Aprelev 6d683d57b6 [infra/win] Add vm-kernel-precomp-win-debug-x64c to test matrix. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/208680.

This fixes https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-kernel-precomp-win-debug-x64c/2/overview errors

Change-Id: I4307206ae6da41113a9c614a291979531547acc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208882
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2021-08-04 19:26:07 +00:00
Ryan Macnak bbefc05748 [vm] Rewrite isolate message serialization. 
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/25559
Bug: https://github.com/dart-lang/sdk/issues/27285
Bug: https://github.com/flutter/flutter/issues/84691
Change-Id: I04608c5d337144195748d5f3509a29eb3116585d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207865
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-07-29 16:55:55 +00:00
Devon Carew c17e2a13da update the tooling to generate libraries.json from libraries.yaml 
Change-Id: I960187ae02834f42a2b7fce2135a8b84b1f21979
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-07-27 23:02:50 +00:00
Devon Carew c7156f82a5 fix the presubmit check for the flutter/plugins repo 
Change-Id: Id098bfa2eb77809998d3672e452c2c3e746aedb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-07-23 17:55:39 +00:00
Srujan Gaddam 2628eaa88c Modify go.sh to use dart format 
`dartfmt` is deprecated in favor of `dart format`.

Change-Id: I4154ff9d863213d3925aacce892ffde06dee40f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207801
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2021-07-22 20:49:25 +00:00
Srujan Gaddam 6085e065e9 [dart:html] Add doc changes to templates and source files 
https://dart-review.googlesource.com/c/sdk/+/205068 and
https://dart-review.googlesource.com/c/sdk/+/205300 were added
to fix doc issues in dart:html. This CL adds those changes to
the source and template files and fixes some grammar.

Change-Id: I59ab35c5076fba5d67e4e99cff503bb98eb55549
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207800
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2021-07-22 19:59:54 +00:00
Ben Konyi ba50910764 [ Presubmit ] Only update .dart_tool/package_config.json when package 
contents don't match

Should reduce the frequency of trivial merge conflicts due to differing
times of the "generated" property.

Change-Id: I1f481d48be0aa21c923c63aedb7d9888d8618bcc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207503
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-20 19:51:50 +00:00
Daco Harkes 31bdde436f [tool] idefiles remove analysis_options.yaml generation 
This caused issues when running analyzer tests locally.

Bug: https://github.com/dart-lang/sdk/issues/35562

Instead, SDK devs should use DartCode's option to ignore files in
VSCode:
https://github.com/dart-lang/sdk/issues/35562#issuecomment-543140783

For other IDEs there is no documented solution.

Change-Id: Ibf3f47d1035ea5d98c1db8fd1209677453588327
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207021
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2021-07-15 10:53:29 +00:00
Ryan Macnak 2642c7c9ce [vm] Fix gcc build. 
TEST=local build
Change-Id: I9503dfbb1b9ba6ef2b5fb8423c13d5066e5af98b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206140
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2021-07-13 01:55:45 +00:00
Erik Ernst 284695f193 Fix instance variable declaration to allow covariant late final 
Change Dart.g to be in sync with the language specification after
https://github.com/dart-lang/language/pull/1728.

Change-Id: I7587da87ec6a0300810949a34e90af5560cbeac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206261
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2021-07-12 07:33:09 +00:00
Mayank Patke 3b6e2cec30 [dart2js] Remove --libraries-spec and --platform-binaries from test 
matrix.

Change-Id: I50235f28f572890d7304e8e6bb39a8133c126880
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206333
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2021-07-09 16:04:06 +00:00
Erik Ernst 6facd6dfda Adjust Dart.g to allow constructor tearoffs 
This CL updates the grammar Dart.g such that it
supports constructor tearoffs, as well as explicit
instantiations of generic functions and methods,
and parameterized types as type literals.

Change-Id: I2e30d0eb185b84fc2103c21ba962f4cbff40905a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197161
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2021-07-08 13:10:45 +00:00
Alexander Thomas 074d7da47f [infra] Remove update homebrew scripts 
They have been moved to dart-lang/homebrew-dart.

Change-Id: I9f81e804f07a7e8426b8034a45e5be5b57bebffa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205784
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-07-03 10:08:22 +00:00
Janice Collins 1426aff54e Update dartdoc to 1.0.0 and lock down dartdoc warnings. 
Borrowed the list of warnings directly from Flutter.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v1.0.0

Change-Id: Ic93229218a470c9ef469b89982dc2a3510d502da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205340
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2021-06-29 19:31:28 +00:00
Alexander Thomas 41aa60ea2b [infra] Add explicit gen_snapshot build target to macOS arm64 AOT builds 
macOS arm64 builds only create the x64 gen_snapshot by default because
they are cross-compiled in Rosetta. Adding the gen_snapshot target
ensures that we have a gen_snapshot for arm64 as well.

These bots require clang which currently isn't provisioned on shards, so
they are running on the main bot.

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-nnbd-mac-release-arm64-try
Change-Id: I842f37019a65dfb30e522d2d9bead5e62bb3ff79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204505
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2021-06-25 19:35:32 +00:00
Tess Strickland 843bd00c71 [bots] Run vm unit tests using qemu as well as FFI tests. 
Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try
Change-Id: I3c104ce5594d8f427fdf247364e6952a45132820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204786
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2021-06-25 11:35:25 +00:00
Alexander Thomas a6f29eda6d [infra] Remove obsolete "global" key from the test_matrix.json 
Follow-up to https://dart-review.googlesource.com/c/recipes/+/203620.

Change-Id: I179a1084212ec66cf7a74be8bcf81f15a4493d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204120
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-06-23 14:53:52 +00:00
Alexander Thomas b687e7e757 [infra] Fix pub integration test on arm64 macs 
Cq-Include-Trybots: luci.dart.try:pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-linux-debug-try,pkg-mac-release-try,pkg-win-release-try
Change-Id: Iccd49bf2ef18250e4b1c755594d3382eff38cee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204504
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-06-22 13:48:33 +00:00
Alexander Thomas 09fbf1ce60 [infra] Add more arm64 configurations to the test matrix 
Change-Id: I2a2030edb08ef32c4e33806df8ed029bab682496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204142
Reviewed-by: Jonas Termansen <sortie@google.com>
 2021-06-22 09:18:12 +00:00
Alexander Thomas aea28aba05 [infra] Pass architectures to dart_sdk.py explicitly 
* Add fallbacks to package smith to match the build recipes.

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-arm64-try,dart-sdk-mac-try,dart-sdk-win-try
Change-Id: I2d9da9e02119227bf59d4c200c886df4afc87487
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202963
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2021-06-10 10:32:09 +00:00
Sigmund Cherem 91745979a6 [dart2js] re add test coverage for O0 and modern config 
In commit 912005267d we renamed `dart2js_2` as
`web_2`, but for some strage reason, I didn't update the name on these two
configurations.

Change-Id: I9d91b37989247f03b52267d44a9deae39c95ed00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202400
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2021-06-09 22:46:59 +00:00
Joshua Litt 9b4764066e [dart2js] Add new class to help manage releasable features. 
Change-Id: Ib20f5565f08081f67cd2b394b5d3ebd213f913dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202733
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2021-06-09 16:15:01 +00:00
Alexander Thomas a87ea2b474 [sdk] Use os.uname() to figure out the host architecture on macOS 
platform.machine() might return x86_64 if run under rosetta causing the
script to assume that we're building x64 instead of arm64.

Change-Id: I169890f41ca71b08f3068da609cbe0579743051b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202770
Reviewed-by: William Hesse <whesse@google.com>
 2021-06-08 15:40:10 +00:00
Alexander Thomas 1a0a1e1e8e [infra] Add xcodebuild/...XARM64 directories to the vm-kernel fileset 
Change-Id: Id5549b3fe7073ae576e621fe3ac478cc65856662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202765
Reviewed-by: William Hesse <whesse@google.com>
 2021-06-08 12:50:03 +00:00
Alexander Thomas 2c11a48c5e [sdk] Fix BuildArchitectures on macOS 
Change-Id: Ieb1a0047d8edeadf5f24b058bf8828888412f00c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202763
Reviewed-by: Karl Klose <karlklose@google.com>
 2021-06-08 10:17:03 +00:00
Alexander Thomas 45e11715db [infra] Initial support for native arm64 builds on macOS 
Change-Id: Ia17f0839c87923deb877259069cab0d702d27aa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202483
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2021-06-07 14:04:32 +00:00
Kevin Moore 063d0ef286 pkg:wasm moved to GitHub 
Remove code from SDK

See https://github.com/dart-lang/wasm

Change-Id: Ie5a68216f67605b20b8288793de752bac1f1b396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202542
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
 2021-06-04 22:35:17 +00:00
Kevin Moore d8ac73aab2 pkg:wasm - add static analysis to test_matrix 
- disallow implicit casts
- move generation code to `tool` directory (as is convention)
- rename template files so they are not analyzed
- deleted test/test_all.dart (not needed)

Change-Id: Ie319dfbb34dc662a346b4145dff0ef1213dcebc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202140
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
 2021-06-02 21:37:50 +00:00
Alexander Thomas b50889e739 [sdk] Update checked-in SDKs to 2.13.1 
* This adds a mac amd64 SDK as the arm64 SDK to bootstrap arm64
  development on macOS.

Change-Id: I519e5ad2343360bc2e692b52d95c94076bfd9e87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201833
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-06-02 09:29:45 +00:00
Devon Carew 46b04e6c4a Analyze flutter/plugins as part of the flutter-analyze try bot. 
Bug: https://github.com/dart-lang/sdk/issues/45873
Change-Id: I3d603ce31ca0fd5402cb359f376f810f78f21a5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-06-01 22:22:20 +00:00
Ryan Macnak 26f50368d2 [build] Check that a second Ninja invocation does nothing. 
Not checking Windows, where the set of linker outputs is not constant.

Change-Id: I1241aa4108f7feebc2638ca762743464fcb48a52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201165
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-05-26 17:48:30 +00:00
Michael Thomsen cac00e9d95 Add deprecations notices to dart2native 
Related to: https://github.com/dart-lang/sdk/issues/46100

Change-Id: I2bcd4aadfbc96fa6ba265aec04cd60e3e81eef41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199429
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-05-25 13:20:30 +00:00
Ryan Macnak 7def42c489 Reland "[infra] Update to a clang with libc++.a for Mac ARM64." 
Adjust Android build.

Bug: https://github.com/dart-lang/sdk/issues/42773
Bug: https://github.com/flutter/flutter/issues/75348
Change-Id: Iae98c03e8e155793648825b3155572412303434b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200903
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-05-24 21:31:20 +00:00
Ben Konyi 7250fd6379 Reland "[ package:dds ] Add null safety support" 
This reverts commit b8c5ecd5aa.

TEST=N/A

Change-Id: I38bbebe1e38bc9dbfdde764eff847aafb3e39353
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200926
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-24 16:59:23 +00:00
Devon Carew 077c24b4f7 also analyze flutter samples in doc comments 
Change-Id: I9b4b71a4dee64bb80517c1962ef4922c822b876b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200904
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-05-20 22:09:55 +00:00
Jacob MacDonald 0cbadee344 add the frontend_server_client package to the sdk 
unblocks https://github.com/dart-lang/pub/pull/3008

Change-Id: I14ed70371001b0ca709469172afd2b97679a1e2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200920
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
 2021-05-20 17:44:35 +00:00
Clement Skau 14d5ca1721 [tools] Change CoreDumpArchiver to not default throw 
This prevents missing core dumps from crashing bots a la:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8846992204042276416/+/u/vm_tests_shard_1/task_stdout_stderr:_vm_tests_shard_1

Bug: https://github.com/dart-lang/sdk/issues/36469
Change-Id: If66e40d8cb2df7ece7c1274fbbdcbffda445056d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200865
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2021-05-20 11:49:16 +00:00
Clement Skau 67f097a161 [tools] Update all iteritems -> items 
This migrates old python2 dict.iteritems() to python3 dict.items().
iteritems was removed in python3 meaning these script will otherwise not
run.
Note that this remains backwards compatible since dict.items() also
existed in python2, though the implementation was more memory intensive
for large dicts (which these likely aren't).

This is similar to https://dart-review.googlesource.com/c/sdk/+/200184

Change-Id: I4fe5c90d21de97d0ecceb27fa6efa7d7deb14098
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200864
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2021-05-20 11:36:52 +00:00
Devon Carew 16d173f7d2 [analyzer_cli] switch pkg/analyzer_cli to using package:lints 
Change-Id: Ibc9c6edb6f745a6b177ceca133af5c868734b3f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200481
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-05-18 21:45:23 +00:00
Martin Kustermann 3558ca3a58 [vm/concurrency] Add missing dart:async import to run_stress_test_shards.dart 
This is a follow-up to https://dart-review.googlesource.com/c/sdk/+/200424

TEST=Attempt at fixing remaining issues with "iso-stress-linux" builder.

Change-Id: I7a8300f3e4104e6ec7695b9300e11fb515ee6049
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200426
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2021-05-18 17:53:43 +00:00
Clement Skau 9b16765cbb [tool] Fixes crash in tools/minidump.py 
Fixed by migrating to dict.items() which is available in both python2
and python3.

TEST=Manual testing in python2 and python3.

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-win-release-x64-try
Bug: https://github.com/dart-lang/sdk/issues/46029
Change-Id: I1c8363dfc44dc39f2430f84c4f22631a2e7203cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200184
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2021-05-17 10:30:30 +00:00
Emmanuel Pellereau b8c5ecd5aa Revert "[ package:dds ] Add null safety support" 
This reverts commit a527411e51.

Reason for revert: depends on package 'devtools_shared' that is not yet migrated.

Original change's description:
> [ package:dds ] Add null safety support
>
> Fixes https://github.com/dart-lang/sdk/issues/45756
>
> TEST=service + DDS tests
>
> Change-Id: I6dd14d7f9fdee479a830c3b053dc3b00aa635202
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199800
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Devon Carew <devoncarew@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icdaef3ac55d7ef302acd3f9c2538a41e52e4253a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200180
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2021-05-17 08:12:20 +00:00
Ben Konyi a527411e51 [ package:dds ] Add null safety support 
Fixes https://github.com/dart-lang/sdk/issues/45756

TEST=service + DDS tests

Change-Id: I6dd14d7f9fdee479a830c3b053dc3b00aa635202
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199800
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-05-14 15:47:38 +00:00