dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
81,176 Commits 2 Branches 0 Tags
ef850dbdecc4efd014ee62887eed466422907eaf
Commit Graph

66 Commits

Author SHA1 Message Date
Danny Tuppeny 5447c3981e [dds] Add support for conditional breakpoints in DAP 
Change-Id: I5f28337b0371f4efb52b2ba169bf27e1d61425c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209702
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-10 19:33:20 +00:00
Danny Tuppeny 215efd6642 [dds] Mark not-debuggable frames as deemphasized in DAP 
This allows user code to stand out better in the stack trace when debugging SDK/External packages is disabled.

Change-Id: I1740001f2aa085e3bc2069d788e1c53e71386866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209641
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-10 16:54:23 +00:00
Danny Tuppeny de5986ef24 [dds] Add tests for DAP exception behaviour 
Change-Id: I524a7bdebd0c4f572db67550cd42f4ba5118cfc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-09 22:44:09 +00:00
Danny Tuppeny 3d3a48ff9a [dds] Add support for DAP sourceRequest to download source from the VM 
Change-Id: Icb639c7008d51d6ffbecb95e362cc07c81993424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209103
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-09 16:48:08 +00:00
Ben Konyi 4d4f69ab95 Reland "[ package:dds ] Add locking when modifying DDS state via client requests" 
This reverts commit 0b0bb9940d.

Fixes https://github.com/dart-lang/sdk/issues/46826

TEST=dds/test/regress_45569_test.dart and service_2/break_on_function_many_child_isolates_test/dds

Change-Id: I84ac047adb7b20a5392744993b22895bffacce9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209262
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
 2021-08-07 15:16:49 +00:00
Danny Tuppeny a6176ec3dd [dds] Support delegating running the debugee to the editor in DAP using runInTerminal 
Change-Id: I9fd435ee43ca9ae0d1e38bdffd9121157d33b730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208654
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-06 16:42:17 +00:00
Ben Konyi 0b0bb9940d Revert "[ package:dds ] Add locking when modifying DDS state via client requests" 
This reverts commit 0ecfc7da6f.

Reason for revert: https://github.com/dart-lang/sdk/issues/46826

Original change's description:
> [ package:dds ] Add locking when modifying DDS state via client requests
>
> Fixes https://github.com/dart-lang/sdk/issues/46696
>
> Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
> Reviewed-by: Anna Gringauze <annagrin@google.com>

TBR=bkonyi@google.com,annagrin@google.com

Change-Id: Iec89181372a2fc1b8a461e616bbcd23dd6bbd72d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209280
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-05 21:32:42 +00:00
Ben Konyi 0ecfc7da6f [ package:dds ] Add locking when modifying DDS state via client requests 
Fixes https://github.com/dart-lang/sdk/issues/46696

Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
Reviewed-by: Anna Gringauze <annagrin@google.com>
 2021-08-05 17:56:01 +00:00
Ben Konyi ada4278fd5 Revert "Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"" 
This reverts commit 1796160606.

Reason for revert: Still seeing failures.

Original change's description:
> Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"
>
> This reverts commit 4160747ef6.
>
> It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.
>
> TBR=asiva@ (discussed offline)
>
> TEST=Existing service tests + get_cached_cpu_samples_test
> Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: Ic522ab61b430673533c94ecd0c91bee569a0add6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208960
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-04 17:32:38 +00:00
Ben Konyi 1796160606 Reland "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commit 4160747ef6.

It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.

TBR=asiva@ (discussed offline)

TEST=Existing service tests + get_cached_cpu_samples_test
Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-03 19:18:59 +00:00
Danny Tuppeny 874f1db1f9 [dds] Support debugging "just my code" in DAP using 'debugExternalPackageLibraries=false' 
Change-Id: I82556df94722b72240383f57524a5692d176ca11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208646
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-03 14:38:49 +00:00
Alexander Markov 4160747ef6 Revert "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commits 746b8f1f5c and
9ee2259fde.

Reason for revert: https://github.com/dart-lang/sdk/issues/46746

Original change's description:
> [ package:dds ] Add support for caching CPU samples based on UserTag
>
> DDS can be configured to listen for CPU sample events and cache samples
> that were collected while certain UserTags are active. These cached
> samples are stored in a ring buffer and are stored until the isolate
> shuts down.
>
> TEST=pkg/dds/test/get_cached_cpu_samples_test.dart
>
> Change-Id: Ib20770f59f1672c703413486f87795b3bb23f676
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207206
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>

TEST=ci
TBR=bkonyi@google.com,rmacnak@google.com,kenzieschmoll@google.com

Change-Id: I1b6655ad7e3b10e1145ff545cc90ecf3bc6e092d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208341
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-07-28 18:00:25 +00:00
Ben Konyi 746b8f1f5c [ package:dds ] Add support for caching CPU samples based on UserTag 
DDS can be configured to listen for CPU sample events and cache samples
that were collected while certain UserTags are active. These cached
samples are stored in a ring buffer and are stored until the isolate
shuts down.

TEST=pkg/dds/test/get_cached_cpu_samples_test.dart

Change-Id: Ib20770f59f1672c703413486f87795b3bb23f676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207206
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-07-28 00:33:33 +00:00
Danny Tuppeny 248e943b97 [dds] Expand truncated strings from dart:developer log() calls in DAP output 
Change-Id: I31338b00daff33a5428e4b2229273ee8289f1c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206540
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Danny Tuppeny 33c3cfc28a [dds] Support changing DAP debug settings after the session has started 
Change-Id: I287457296408ae49950cef501780054260b57566
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205540
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Danny Tuppeny 6b4fc2670c [dds] Switch DAP server mode to directly using stdin/stdout 
Change-Id: Id2a8d8c9274b96cf32788e11d4452954a4f9c091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205500
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Ben Konyi a99b92c252 [ package:dds ] Avoid races while handling errors during startup 
Avoids a LateInitializationError that could occur when the VM service
connection goes down during DDS startup. Done by delaying error
reporting until after DDS has completed its initial startup flow,
ensuring that all relevant state has already been initialized when we
try to cleanup.

Fixes https://github.com/flutter/flutter/issues/86361

Change-Id: I2b357bfb95c759d301ab48bce9fe1c28871d5e08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206672
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2021-07-14 23:51:46 +00:00
Danny Tuppeny 8f01499793 [dds] Support IPv6 for DAP with --ipv6 flag 
Change-Id: I07c66b79e832f200bf5f27c20930e1ba6a2ebda7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205261
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-02 00:04:52 +00:00
Danny Tuppeny c84c21e741 [dds] Support using port=0 for DAP and print the bound host/port in JSON to stdout 
Change-Id: Ib1e99f1004b59cba6fa6970dbddbf5cbe87a8b32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205160
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-28 19:58:32 +00:00
Danny Tuppeny 06fc5c522e [dds] Spawn DDS in-process with DAP 
+ Switch to package:args CommandRunner
+ Add switches to enable/disable DDS/auth tokens
+ Improve verbose logging for debugging tests
+ Fix a race condition in initial unpausing of Isolates

Change-Id: I7f7ee0ef798e198ee07c1c663bce3edb0b5c7fc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204143
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-24 18:07:49 +00:00
Danny Tuppeny 1563d3fdd3 [dds] Add support for DAP threadsRequest 
Change-Id: I8dc128f0fc4dae16c53bc9deaf3b866d7198110f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203902
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-21 20:44:40 +00:00
Danny Tuppeny 97f013773c [dds] Support custom requests in DAP and verify DDS is available 
Change-Id: I41be607668feaab30ae10b4fe725ad3f89e4a8ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203861
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-21 20:40:20 +00:00
Danny Tuppeny 7a73faa0a2 [dds] Use different port numbers for DAP integration tests 
Bots are failing with:

SocketException: Failed to create server socket (OS Error: Address already in use, errno = 48), address = localhost, port = 9200

This could be multiple test libraries being run in parallel and starting from the same port.

Change-Id: Ic7d14c3bb9a4e19295849933fadd6ad6daaea464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203500
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-14 18:41:13 +00:00
Danny Tuppeny d5e92e1c7a [dds] Add expression eval support to DAP 
Change-Id: I0c55b4dde12d40467f8243e4b0c0ccc882eb045d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203243
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-13 19:10:42 +00:00
Danny Tuppeny 4ce805bfa7 [dds] Add DAP support for Scopes/Variables 
Change-Id: Idaaa08693824c389ebc83bd5f7e29d61d70cbb84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202700
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-12 23:52:41 +00:00
Danny Tuppeny 6ebcabaaf2 [dds] Add support for breakpoints and stepping to DAP 
Change-Id: Iebd2c5630f826effac56ece3b4ffb3252b9ac556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201834
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-11 17:51:01 +00:00
Danny Tuppeny 48a67a24f5 [dds] Improve error logging if DAP tests fail to connect 
+ re-enable tests

Change-Id: I0262db03ee0df9714d2086dc40265bea2962ee5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202760
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-07 20:52:13 +00:00
Danny Tuppeny cfd5cf3cd6 [dds] Skip DAP tests 
These tests appear to be consistently failing on some bots but the code they're testing is not currently in-use. These tests will be fixed and re-enabled before the code becomes used.

Change-Id: I235c8390381c0f82d4f60078e969d5c035ee2e94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202740
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-06-07 16:09:25 +00:00
Danny Tuppeny a50c12093e [dds] Support running scripts with DAP in debug mode 
This starts the app paused, connects t the VM service and resumes. It handles dart:developer log() events, but no other debugging functionality yet (for ex. breakpoints, stepping).

Change-Id: Ib50680c775da5d13df95771eec62e77a4af75a08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201566
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-02 18:28:55 +00:00
Danny Tuppeny 0374c8f720 [dds] Add support for running DAP integration tests with an out-of-process server 
Change-Id: Iffa9154951a6e5e4dc1fad783f8710dad5f1a5a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201563
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-02 18:17:13 +00:00
Danny Tuppeny f9b6901baf [dds] Add a basic DAP server that can run simple Dart scripts 
Change-Id: I0f10b81b0b9ad3875727f606dd1a5a44798486b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201263
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-26 17:22:00 +00:00
Ben Konyi 7250fd6379 Reland "[ package:dds ] Add null safety support" 
This reverts commit b8c5ecd5aa.

TEST=N/A

Change-Id: I38bbebe1e38bc9dbfdde764eff847aafb3e39353
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200926
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-24 16:59:23 +00:00
Emmanuel Pellereau b8c5ecd5aa Revert "[ package:dds ] Add null safety support" 
This reverts commit a527411e51.

Reason for revert: depends on package 'devtools_shared' that is not yet migrated.

Original change's description:
> [ package:dds ] Add null safety support
>
> Fixes https://github.com/dart-lang/sdk/issues/45756
>
> TEST=service + DDS tests
>
> Change-Id: I6dd14d7f9fdee479a830c3b053dc3b00aa635202
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199800
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Devon Carew <devoncarew@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icdaef3ac55d7ef302acd3f9c2538a41e52e4253a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200180
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2021-05-17 08:12:20 +00:00
Ben Konyi a527411e51 [ package:dds ] Add null safety support 
Fixes https://github.com/dart-lang/sdk/issues/45756

TEST=service + DDS tests

Change-Id: I6dd14d7f9fdee479a830c3b053dc3b00aa635202
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199800
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-05-14 15:47:38 +00:00
Ben Konyi b99466d472 Reland "[ VM / DDS / CLI ] Add DevTools support to the standalone VM" 
This reverts commit 5cbf10febe.

TEST=pkg/dds/devtools_observatory_connection_test.dart

Change-Id: I682d009f784b930094dae9b7d4e9a66efffb6ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198561
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-11 17:55:26 +00:00
Ben Konyi 14554239bf [ package:dds ] Fix issue where streamListen could be sent multiple 
times to the VM service for the same stream

Fixes https://github.com/dart-lang/sdk/issues/45569

Change-Id: I8742363b54fd5c8c07331636150af8e68c11b832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196224
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-04-21 17:25:30 +00:00
Ben Konyi 96cf91bea3 [ package:dds ] Update DDS dependencies and set SDK requirement to >=2.12 
Also updated non-migrated libraries to include @dart=2.10.

Change-Id: Idcf4e54f9aa37b9b016133144af594cc932418a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192122
Reviewed-by: Gary Roumanis <grouma@google.com>
 2021-03-19 19:49:08 +00:00
Nate Bosch 7b4263c2b3 Update to the latest package:sse 
Change-Id: I8f2f25a72f459fbea4fdd9bf4e81a7d6f5704a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183182
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
 2021-02-05 20:57:38 +00:00
Ben Konyi a7c9e24aef [ package:dds ] Return a RpcException error with kServiceDisappeared 
code if DDS loses connection to the VM service while forwarding a
request.

Change-Id: I9bb2adc160f25658756cc7106b77cbcd3b9ccc27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180090
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-01-20 00:01:55 +00:00
Ben Konyi 6de68d541a [ package:dds ] Fix issue where handling a StateError due to a VM 
service connection loss could result in a null JSON RPC response.

This would cause package:vm_service to throw a NoSuchMethodError as it
currently assumes it will never receive a null result in a JSON RPC
response.

Related to https://github.com/flutter/flutter/issues/74051.

Change-Id: I86c1c9f7e46e34519f32dfed589c6b31aed39d7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179800
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-01-17 23:08:18 +00:00
Ben Konyi 613ab14a9a [ package:dds ] Disable package:test timeout for sse_smoke_test 
Fixes https://github.com/dart-lang/sdk/issues/44474

Fixed: 44474
Change-Id: I62e6847f2e6c14deee16c3676e5e18616baa4ad4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176780
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-01-13 21:06:03 +00:00
Ben Konyi d9ca0514bc [ Service ] Disconnect existing clients when DDS calls 
_yieldControlToDDS

Instead of DDS failing to connect when there are existing clients
connected to the VM service, the VM service will now disconnect these
clients when _yieldControlToDDS is invoked.

If an existing DDS instance is already connected, existing clients will *not*
be disconnected and instead an error will be returned containing the URI of
the existing DDS instance.

TEST= runtime/observatory/tests/service/dds_disconnects_existing_clients_test.dart

Change-Id: I08e126d99f51ff14205f359a60ca802c27fd206d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178725
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2021-01-12 02:05:00 +00:00
Ben Konyi 800ec511f5 [ DDS ] Add extension methods and getters for streams including event history 
Also fixes issue where `StreamHistory` events were not being parsed
correctly.

Fixes https://github.com/dart-lang/sdk/issues/44505

Change-Id: I36c3bccf229a02ea78168041a112a30046773d59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177720
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-01-07 17:04:38 +00:00
Ben Konyi 34b4c914a4 [ DDS ] Add getStreamHistory RPC and package:vm_service extensions 
Adds a DDS RPC which allows for stream history to be manually requested
in addition to being sent upon initial stream subscription.

Also adds an initial implementation of
package:dds/vm_service_extensions.dart, which adds DDS functionality to
the `VmService` class.

Fixes https://github.com/dart-lang/sdk/issues/44505

Change-Id: I198a6fd7fca15f131a6fdd95e7860a6f98ef06a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177182
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-12-30 02:30:15 +00:00
Devon Carew 13b1af4c2e [pkg/dds] refactor parts into private libraries 
Change-Id: Ic104627b676119742606f7b34b025c6f0d093db0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176600
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-12-29 00:59:24 +00:00
Ben Konyi 22f82bce92 [ package:dds ] Regenerate sse_smoke_driver.dart.js 
There was a syntax error in the generated code preventing the test from
completing.

Fixes https://github.com/dart-lang/sdk/issues/44474

Change-Id: Ifacfa0d9d3587ebfa52870372a35c1c2dbff4784
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176940
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-12-22 19:47:11 +00:00
Lasse R.H. Nielsen 6e29700e16 Update List constructor documentation, deprecate constructor. 
Emphasize that the operation is going away,
and mark constructor as deprecated.

TEST= Refactoring+deprecation only, covered by existing tests.

Change-Id: I82aa044cd2cf7bf347b624371399f44bda8f4a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173261
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-12-07 16:20:28 +00:00
Ben Konyi fc892d7fca [ package:dds ] Handle StateError when VM service disappears 
Fixes https://github.com/flutter/flutter/issues/70579

Change-Id: Ic32acaa038afcf67c98b77d20fd39d136bec13b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175163
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
 2020-12-05 01:19:12 +00:00
Ben Konyi a157ddbf94 [ DDS ] Add errorCode to DartDevelopmentServiceException to better 
communicate reason for error

Change-Id: I5041558ad6370f873dc23515fdad1ec8a2cf4ba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172880
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-11-18 23:45:41 +00:00
Ben Konyi c36ba8b50c [ package:dds ] Improve DDS error handling, add tests 
Added tests to try and emulate failures reported in flutter_tools crash
reports. Used these tests to update error handling and get a better
understanding of exception scenarios.

Change-Id: Ie72822dafcc6373ebfeea543d93b934c0d0687f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172420
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-11-17 00:00:45 +00:00