6393841036
[cfe] Account for InvalidType at nestedness level in UP and DOWN
...
Closes #46863 .
Bug: https://github.com/dart-lang/sdk/issues/46863
Change-Id: I0cc60251f80406baa955131978cd6cbd029b228e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209700
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2021-08-11 09:40:31 +00:00
cf411dc539
Add 'pkg/dart2js_info/' from commit '86ccc7749bd01278473d1d3843c442b5046b36fa'
...
git-subtree-dir: pkg/dart2js_info
git-subtree-mainline: 7fe597bd8e86ccc7749b
2021-08-11 10:17:15 +02:00
26bfbd4cf1
analyzer tests: Remove the WithNullSafety mixin
...
Two remaining test files are modified to use the TestCases structure.
In each case, the tests are unchanged, but the classes are renamed.
Additionally, each file had a *WtihNonFunctionTypes variant. Each of
these classes just specified more test cases that include some form of
"typeAlias" in the name, and can be safely merged with the null safety
test cases.
Fixes https://github.com/dart-lang/sdk/issues/44666
Bug: https://github.com/dart-lang/sdk/issues/44666
Change-Id: Id7db1038e64f8bbc12764cb558670b23427a5a86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-08-11 06:41:51 +00:00
79181abb70
Issue 46839. Stop using UNCHECKED_USE_OF_NULLABLE_VALUE.
...
Bug: https://github.com/dart-lang/sdk/issues/46839
Change-Id: Ia6a71438c265e54e83b148689e68e1e409d34cee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209500
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-08-11 02:56:32 +00:00
3a2e4d92a2
Remove ExperimentStatus.latestWithNullSafety
...
Change-Id: I0a813ce1a64f1d6201005280cf7a116deaf8da1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209581
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-08-11 02:37:44 +00:00
f66037acce
Migration: add support for Angular's @ViewChild() and @ContentChild() annotations.
...
Bug: https://github.com/dart-lang/sdk/issues/45661
Change-Id: Ie77d720677fb032585e17fe13358afe597e702bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209820
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-08-11 01:55:41 +00:00
3393591b3f
Rewrite AST w/ Constructor reference w/ explicit type args
...
This should handle all cases of constructor reference w/ explicit type
args; there aren't too many cases:
* named and unnamed constructors
* referencing class and referencing type alias
* prefixed class names and not-prefixed
* null-aware access (weird)
* bound on type parameter of class, and on type parameter of alias
error cases:
* cascade
* wrong number of type arguments
Bug: https://github.com/dart-lang/sdk/issues/46020
Change-Id: If257eb561a9ad854709b6e9a7d81faa9d084d6ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209622
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-08-10 23:54:49 +00:00
d6cecab694
[dart2js]: Improve deferred loading documentation
...
This moves the algorithm comment to be more visible at the top of the library,
and expands it with more details about how the algorithm works.
Change-Id: I74eeec52e71c55ba77df8d7d35473570c9d1f6e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209441
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2021-08-10 23:53:11 +00:00
4d0dc2ea8a
Migration: add support for Angular's @Optional() annotation.
...
Bug: https://github.com/dart-lang/sdk/issues/45661
Change-Id: I6c8c87c2a0d26dc8053ef66961a96e03cf5a2582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209780
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-08-10 21:32:51 +00:00
5447c3981e
[dds] Add support for conditional breakpoints in DAP
...
Change-Id: I5f28337b0371f4efb52b2ba169bf27e1d61425c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209702
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-10 19:33:20 +00:00
19fa4519bd
Analyzer: Refactor and rename test classes in 18 files to use TestCases model
...
The diffs may look large, but only due to sorting. No tests were added,
removed, or altered.
Change-Id: Id126e9a08056f6d3f99bad32d7060d65b07e4e90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-08-10 18:48:50 +00:00
2c32ff9331
Report error on function tearoff w/ type args on dynamic
...
From the spec:
> We do not allow dynamic explicit instantiation. If an
expression _e_ has type `dynamic` (or `Never`), then
`e.foo<int>` is a compile-time error for any name `foo`.
Bug: https://github.com/dart-lang/sdk/issues/46020
Change-Id: I041c3fcac77fe8edf64633a8d23dbaa89cf42f77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209623
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-08-10 18:36:11 +00:00
215efd6642
[dds] Mark not-debuggable frames as deemphasized in DAP
...
This allows user code to stand out better in the stack trace when debugging SDK/External packages is disabled.
Change-Id: I1740001f2aa085e3bc2069d788e1c53e71386866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209641
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-10 16:54:23 +00:00
b266aeebc3
Move some logic from ScopedVisitor to ResolverVisitor.
...
Of the two classes that inherit from ScopedVisitor (ResolverVisitor
and ScopeResolverVisitor), only ResolverVisitor needs to know about
the currently enclosing class, extension, and function. So we move
this tracking logic to the ResolverVisitor itself. This will help
pave the way for a cleaner separation between the ResolverVisitor and
ScopeResolverVisitor.
(The ScopeResolverVisitor *does* need to know the currently enclosing
closure, so that it can detect improper break/continue statements and
so that it can detect when a local variable is mutated in a closure,
but the tracking logic needed for this is much simpler than what the
ResolverVisitor needs for the "enclosing function". So a new
_enclosingClosure member has been added to ScopeResolverVisitor to
track this.)
Change-Id: I768c15ff4ffcabf564388f5471a6e8f88e677148
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209665
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-08-10 15:11:27 +00:00
98f0e78e3c
Make ScopeResolverVisitor responsible for setting break/continue targets.
...
This is part of a long term arc of work to consolidate all scope
lookup into a single analyzer visitor.
Change-Id: Ifc483a94173e05672b659348a3f37dd1c5b4468e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-08-10 15:11:27 +00:00
8cf79c9703
Rename VariableResolverVisitor.
...
This is the beginning of an arc of work to move the responsibility of
all the analyzer's scope-based resolution into a single class.
VariableResolverVisitor will become that class, so accordingly it's
being renamed to ScopeResolverVisitor.
In the long term, this shift of responsibility will bring the analyzer
and the CFE into better alignment by removing scope resolution logic
from the type analysis phase (the CFE performs all scope resolution
during parsing, and then has a single visit pass to do type analysis).
This should allow analyzer and CFE logic to be more readily shared.
Also, it should improve the performance of the analyzer by allowing
Scope objects to be built up in just a single visitor pass rather than
in multiple visitor passes.
Change-Id: I037346d28de6485cac783e2bc65e0de9d3a2ada6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-08-10 15:11:27 +00:00
b53ea6cb8e
Refactor scope lookup logic in preparation for consolidating scope analysis to a single visitor.
...
This CL refactors the scope lookup logic for simple identifiers so
that it happens in three phases:
- The actual lookup, handled by Scope.lookup
- Choosing which element is being referred to, handled by the
LexicalLookup class
- If lexical lookup failed, falling back on implicit `this` lookup,
handled by the ThisLookup class
In a future CL, this will allow us to consolidate the first phase,
along with all other scope-related operations, into a single visitor
so that the ResolverVisitor no longer needs to maintain scopes. This
should simplify the analyzer's scoping logic and help prepare for
sharing more code with the CFE (since it will make the analyzer's
visitors more closely parallel the analysis phases of the CFE).
Change-Id: I0c8a2aa60bfc5a935b6060adf64e5a4504bc268f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209664
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-08-10 15:11:27 +00:00
c040c050d6
[release] Bump language version to 2.15
...
TEST=Standard CQ.
Change-Id: Ib50b4d23f25ea4bd074904a87068a4a8774932aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209561
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-08-10 13:06:53 +00:00
7ad9feb2d6
Issue 46472. Don't resolve to static Object members via dynamic.
...
For instance members we do this because this is the best that we
know about the result, and any successful override will be more
specific. But static members never can be invoked this way. So, we
don't do recovery for recovery.
Bug: https://github.com/dart-lang/sdk/issues/46472
Change-Id: Ifbd274011e159c3c8ae35d343603c02bb7599d8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209420
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-08-10 12:53:23 +00:00
766113bc54
Update latestSdkLanguageVersion to 2.13
...
Bug: https://buganizer.corp.google.com/issues/195648511
Change-Id: I7f882edaec42c6224a0863be96a41e1abd5b3329
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209580
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-08-10 11:56:43 +00:00
934136d239
[cfe] Don't perform generic tear-off type check in opt-out code
...
Change-Id: I168eef4594fb7c54e1eabc52ba8f0e8d6c4e6b03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209560
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2021-08-10 10:29:12 +00:00
d9dc244eed
Analyzer: Refactor and rename test classes in 11 files to use TestCases model
...
The diffs may look large, but only due to sorting. No tests were added,
removed, or altered.
Change-Id: I55b591c45691319a02f272c7c6b424f0ff755d5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-08-09 23:30:39 +00:00
11822117c0
fix for avoid_null_checks_in_equality_operators
...
Fixes https://github.com/dart-lang/sdk/issues/45919
(The bulk fix test is not awesome but the lint doesn't fire multiply in one `==` so overlaps are infeasible.)
Change-Id: I6fec933f0ba62e794c1b71a6ccb255ed92c4887b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209661
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-08-09 23:21:29 +00:00
de5986ef24
[dds] Add tests for DAP exception behaviour
...
Change-Id: I524a7bdebd0c4f572db67550cd42f4ba5118cfc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209640
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-09 22:44:09 +00:00
8f853bc32f
Unit test some corner cases of annotation resolution.
...
Currently, if a type parameter of a class, mixin, or extension
declaration has an annotation, that annotation is resolved in the type
parameter scope of the class, mixin, or extension declaration (meaning
that static methods are not in scope), however if scope lookup fails,
then static methods are accessible via implicit `this`.
AFAICT, this odd behavior is not spec compliant, so I've filed
https://github.com/dart-lang/language/issues/1790 to discuss the
possibilty of changing it. However, for now I want to unit test the
behavior in order to ensure that if we make any changes to the
analyzer that affect it, the change won't go unnoticed.
Bug: https://github.com/dart-lang/language/issues/1790
Change-Id: I02df7e6e8939ecc6222085f28a6d6b7d072179c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209662
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-08-09 22:43:19 +00:00
c9ebc7c13f
[dart2js/kernel] Fix poor code with nested List.generate
...
Cloning of InstanceInvocation kernel ast nodes was dropping the
isInvariant and isBoundSafe flags, causing the nested List.generate
expansion to not be as well optimized. `-O3` and `-O4` were 'hiding'
the problem by removing the checks anyway.
Change-Id: Id20f2eb4ef5396691a2dd5cbdd847e2d361a21d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209442
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-08-09 20:38:50 +00:00
0b1ddaa598
[vm] Enable lowering of typedef constructor tear-offs
...
TEST=language/typedef/aliased_constructor_tear_off_test
Issue https://github.com/dart-lang/sdk/issues/46231
Change-Id: I10df62d4d170a4ae018a0e943ac6fc37d669d439
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208984
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2021-08-09 18:06:39 +00:00
3d3a48ff9a
[dds] Add support for DAP sourceRequest to download source from the VM
...
Change-Id: Icb639c7008d51d6ffbecb95e362cc07c81993424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209103
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-09 16:48:08 +00:00
9e928c8587
[dds] Handle DAP debug termination more reliably based on whether there's an active process
...
Change-Id: I8a14074f242dd0719624d610fa6d1768ecb4d152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209545
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-09 16:01:29 +00:00
9b586a3da6
analyzer: add constructor references from PrefixedIdentifier
...
Bug: https://github.com/dart-lang/sdk/issues/46020
Change-Id: Ifafea6edb6c9ce7fdf1c1f092ff278738c273bb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-08-09 15:03:48 +00:00
ae1e2bd3a6
Add HTTP access control headers to CHANGELOG and add @Since.
...
Change-Id: I860fbe6b821061695c50319204d8d6ba9c98a839
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209109
Auto-Submit: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2021-08-09 14:48:38 +00:00
04c44e8e67
Inline FeatureSetProvider.isNullSafetySdk, rename isNullSafetySdkAndLegacyLibrary.
...
Change-Id: I12397d77a1f77bc872f335550789322e4344d456
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209520
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-08-09 13:31:38 +00:00
dee7d252d4
Inline non-functional type alias
...
Reason: b/195648511, non-functional type aliases are not supported by
some internal infra
Change-Id: I1c164f4ecf23ac22a36cabc630bf7e8f762d4849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209541
Reviewed-by: Michal Terepeta <michalt@google.com >
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
2021-08-09 10:26:28 +00:00
bf2691c2fe
[VM] Moves FfiNative fields to function parent.
...
Previously the synthetic field that holds the FfiNative
function pointer was injected into the current library.
This change makes sure we instead add the field to the
relevant parent - Class or Library.
TEST=Added regression test for name collision.
Bug: https://github.com/dart-lang/sdk/issues/43889
Change-Id: Ifbf2d70de00e4748c179fe7d626c495675c2b338
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208502
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2021-08-09 09:13:38 +00:00
4d4f69ab95
Reland "[ package:dds ] Add locking when modifying DDS state via client requests"
...
This reverts commit 0b0bb9940dhttps://github.com/dart-lang/sdk/issues/46826
TEST=dds/test/regress_45569_test.dart and service_2/break_on_function_many_child_isolates_test/dds
Change-Id: I84ac047adb7b20a5392744993b22895bffacce9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209262
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2021-08-07 15:16:49 +00:00
b38ccf33e0
Combine test classes in ast_rewrite_test.dart
...
These two classes have the same FeatureSet, so should be combined.
Change-Id: If03e74d54ca35ed81fe532a7dc1974ecc52b6b25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-08-06 20:47:58 +00:00
e61ef3889e
Analyzer: Refactor and rename 8 test classes in 4 files to use TestCase model
...
The diffs may look large, but only due to sorting. No tests were added,
removed, or altered.
Change-Id: I55246391205a8a234c05b9e1aa3ec681a178f973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209361
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-08-06 20:47:49 +00:00
ee8ebcdc41
Clean up comments in function_expression_resolver.dart
...
In https://dart-review.googlesource.com/c/sdk/+/209240 , I accidentally
included a stray "TODO" comment that only made sense in the context of
a previous patch set. I also made a minor spelling error in a
comment.
This CL removes the stray TODO and fixes the spelling error. There is
no functional change.
Change-Id: If1c600a579101cea1015d34d9833eb21a2b1a675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-08-06 20:36:19 +00:00
7d1f26ff09
Deprioritize the fix to add a null check
...
I missed this as part of my previous CL.
Change-Id: I07f2d6a4e0b60433afb39ee1b0a4819147a494aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-08-06 20:05:48 +00:00
195f4c1236
Clean up hacks around resolution of documentation comments.
...
For some time, the visitors we use for resolution have been handling
documentation comments for most types of declarations by visiting them
*after* visiting parameters; this ensures that the parameters are in
scope at the time of visiting the documentation comment, so that the
documentation comment can refer to them.
However, a few types of declarations were done in a kludgy way:
constructor declarations, function declarations, function type
aliases, generic type aliases, and method declarations. In some cases
we would visit the documentation comment twice, once before setting up
the scope properly (in which case the visit method would just return
early), and then again at the right time using
ResolverVisitor.safelyVisitComment (which bypassed the early return).
On other cases the visitComment method had duplicate logic for setting
up the proper scopes.
With this change, we now consistently use the approach of visiting the
documentation comment after the scopes are properly set up for it.
Change-Id: Idd27946a947040d4bad37568915bf5915bff843f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209240
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-08-06 19:12:28 +00:00
4200f6d915
Enhance the replace_with_null_aware fix and apply it in more places
...
Change-Id: I80945b4814cca0eaeca2129e5365c0d7526a8247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-08-06 17:03:35 +00:00
a6176ec3dd
[dds] Support delegating running the debugee to the editor in DAP using runInTerminal
...
Change-Id: I9fd435ee43ca9ae0d1e38bdffd9121157d33b730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208654
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-08-06 16:42:17 +00:00
cccc0293c5
[ VM ] Send 'dart --help [--verbose]' output to stdout
...
This is consistent with the majority of other tools and the CLI
behavior.
Fixes https://github.com/dart-lang/sdk/issues/46412
TEST=pkg/dartdev/test/commands/flag_test.dart
Change-Id: I45a3ddc9728e9cc1a273d4d5f11db74cb8104745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204661
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2021-08-06 16:06:05 +00:00
b225582593
[ Service ] Disable CPU sample block streaming
...
See https://github.com/dart-lang/sdk/issues/46825
TEST=vm/cc/Profiler_* and service tests
Change-Id: I98faa1953a3bf3c28828dabaa0be6b033ada63fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209260
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2021-08-06 16:02:55 +00:00
f77f8e5871
[cfe] Add type checks on tearing off instance members
...
Closes #46784 .
Bug: https://github.com/dart-lang/sdk/issues/46784
Change-Id: I7637618be0686bbffe6eb18a19049ec5da6059aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208881
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2021-08-06 15:19:35 +00:00
c66ae0027b
[cfe] Handle invalid typedefs and redirecting factories in lowering
...
Change-Id: I61d776434621fd7022d034f17e228ec553a7ff47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209108
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-08-06 13:43:05 +00:00
0f04dc651d
Added checks to gather method data
...
Change-Id: I809e05ea3554ae9768d3f9cb25c824bbe36ca2bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203600
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2021-08-06 03:59:22 +00:00
53198d4d1c
Added check to gather parent class name and classes mixed with
...
Change-Id: I56f5cae15b0e4a94ade886e317f3974cd3de6532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203060
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2021-08-06 00:59:41 +00:00
ff85758d9c
Add desugar API mapping extension member name to ProcedureKind
...
Surfaces what ProcedureKind an extension member is based on the
CFE convention of '|set#' and '|get#' in the member name to
retain setter and getter information.
Change-Id: I527062e4a1e4e9f4346751ea2f9d636184e2d8e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209162
Commit-Queue: Riley Porter <rileyporter@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-08-06 00:37:51 +00:00
c951b72ed5
Issue 46753. Enhance LinterContext.resolveNameInScope() to suport type parameters.
...
Bug: https://github.com/dart-lang/sdk/issues/46753
Change-Id: Ide53294599496cb8011e86bced0b075e389e1040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-08-05 21:54:21 +00:00
Dmitry Stefantsov