Commit Graph

707 Commits

Author SHA1 Message Date
scheglov@google.com ef41e134fe Issue 5255. Override setter-only field with instance variable
http://code.google.com/p/dart/issues/detail?id=5255

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10986033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12880 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 20:43:14 +00:00
scheglov@google.com 4eb06ae32b Issue 5440. Fixes for exceptions during resolving
http://code.google.com/p/dart/issues/detail?id=5440

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10986026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12864 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 18:10:21 +00:00
scheglov@google.com 7f8731cb50 Issue 5292. Unreferenced imported identifiers should not be an error
http://code.google.com/p/dart/issues/detail?id=5292

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10979013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12847 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 16:34:48 +00:00
scheglov@google.com 1d60036e44 Issue 5327. Fix for invalid 'instantiation of a class with the inherited abstract members'
http://code.google.com/p/dart/issues/detail?id=5327

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10962047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12753 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 19:01:02 +00:00
scheglov@google.com 082dd8cc31 Issue 5302. Type alias type parameters should not conflict with formal parameters
http://code.google.com/p/dart/issues/detail?id=5302

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10961058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12752 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 18:56:40 +00:00
scheglov@google.com 018d23bb22 Issue 5295. Reference to undefined static setter should be a warning not an error
http://code.google.com/p/dart/issues/detail?id=5295

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10966047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12751 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 18:54:38 +00:00
brianwilkerson@google.com 48b5aa8f60 Allow static fields without types (issue 5149)
Review URL: https://codereview.chromium.org//10957040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12720 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 16:14:27 +00:00
scheglov@google.com c0a0b5db5e Issue 5293. Invocation of an undefined static method should be a warning, not an error
http://code.google.com/p/dart/issues/detail?id=5293

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10963028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12716 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 15:06:21 +00:00
scheglov@google.com 4792aeac49 Issue 5255. Remember 'overridden' for getters/setters and fields
http://code.google.com/p/dart/issues/detail?id=5255

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10961038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12714 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:43:16 +00:00
scheglov@google.com d6a06d9070 Issue 5240. Using a non-type in a const object expression is an error, not a warning
http://code.google.com/p/dart/issues/detail?id=5240

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10970024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12711 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:14:03 +00:00
scheglov@google.com 51adcdda3b Fixes for raw string and block clean ups
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//10962014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12709 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:11:51 +00:00
scheglov@google.com 3c4080aff2 Issue 5163. Constructor/member name conflict should be error
http://code.google.com/p/dart/issues/detail?id=5163

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10969024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12660 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 21:31:09 +00:00
pquitslund@google.com 1999601afd "No SDK, No Problem!" (take 2)
When there's no SDK,

  * don't start the analysis server
  * or the indexer
  * and don't try and constitute the dart model

(NOTE: this addresses the issue where we have no SDK on initial plugin install.)
Review URL: https://codereview.chromium.org//10960002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12647 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 17:18:44 +00:00
brianwilkerson@google.com 48b7ae58bd Preparation for reporting an error for deprecated raw strings (issue 4815)
Review URL: https://codereview.chromium.org//10941052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12643 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 14:46:27 +00:00
scheglov@google.com c78a9cf2cd Clean up to migrate parseInt() and parseDouble() to int.parse() and double.parse()
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//10959006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12641 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 14:29:56 +00:00
scheglov@google.com dda26cdfaa Issue 5162. Report error when initializing already initialized final field
http://code.google.com/p/dart/issues/detail?id=5162

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10943034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12594 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:37:06 +00:00
keertip@google.com 949ea1e14b fix PackageLibraryManager to resolve self links to right file
Review URL: http://codereview.chromium.org//10951031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12593 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:22:36 +00:00
scheglov@google.com 627f9805df Issue 5232. Type variables are in static scope, but using them is error
http://code.google.com/p/dart/issues/detail?id=5232

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10939037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12588 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 18:57:37 +00:00
scheglov@google.com f0ae22c830 Issue 5215. Invocation identical(x,y) is compile-time constant
http://code.google.com/p/dart/issues/detail?id=5215

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10942020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12569 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:55:44 +00:00
scheglov@google.com eb7e217a49 Issue 5116. Support both 'dynamic' and 'Dynamic'
http://code.google.com/p/dart/issues/detail?id=5116

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10939027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12567 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:40:22 +00:00
scheglov@google.com c095d071e9 Issue 5052. Analyzer should treat assert as a keyword
http://code.google.com/p/dart/issues/detail?id=5052

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10949015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12566 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:30:12 +00:00
scheglov@google.com b6da1f820e Issue 2862. Report warning if switch/case does not end with break, continue, return or throw
http://code.google.com/p/dart/issues/detail?id=2862

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10942019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12565 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:22:58 +00:00
karlklose@google.com d90d5b1698 Reapply 'Add runtimeType() to Object which returns canonicalized instances of Type'.
This CL fixes a bug in https://chromiumcodereview.appspot.com/10908142/ which generated unneeded type information leading to runtime regression.

Original committed in 12491 and reverted in

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//10941031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12540 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:56:06 +00:00
scheglov@google.com a17964f959 Issue 5153. Setter should not conflict with method
http://code.google.com/p/dart/issues/detail?id=5153

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10943012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12528 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 01:17:29 +00:00
pquitslund@google.com 666341c3f7 Expose translatedUri (for clients who want to normalize URIs).
Review URL: https://codereview.chromium.org//10945011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12507 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 17:31:41 +00:00
ricow@google.com 5bcc7e0092 Revert r12491
This is causing checked mode failures on the buildbot.
Review URL: https://codereview.chromium.org//10949003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12500 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:40:15 +00:00
karlklose@google.com 59e0304206 Add runtimeType() to Object which returns canonicalized instances of Type.
BUG=3903

Review URL: https://chromiumcodereview.appspot.com//10908142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12491 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:12:07 +00:00
brianwilkerson@google.com 342ea14996 Fix the length of this expression nodes (issue 5185)
Review URL: https://codereview.chromium.org//10928236

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12459 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 21:54:14 +00:00
brianwilkerson@google.com a9b557d9cd Add metadata for type variables (issue 4056)
Review URL: https://codereview.chromium.org//10933128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12446 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 17:46:59 +00:00
scheglov@google.com 6fffdf490a Issue 5148. Error on abstract method in concrete class needs to be a warning
http://code.google.com/p/dart/issues/detail?id=5148

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10914318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12445 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 17:09:27 +00:00
scheglov@google.com d6802247b5 Issue 5082. It is an error if argument to '?' is not a formal parameter
http://code.google.com/p/dart/issues/detail?id=5082

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10928230

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12438 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 15:09:52 +00:00
scheglov@google.com 14cb03ace9 Issue 5044. Keep FieldElement as Element for field access
http://code.google.com/p/dart/issues/detail?id=5044

Move inGetterContext() and inSetterContext() from Elements to ASTNodes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10918260

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12434 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 13:14:51 +00:00
scheglov@google.com 8184329d8b Issue 5075. Remove support for 'negate' and 'equals' operators
http://code.google.com/p/dart/issues/detail?id=5075

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//10910279

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12393 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 17:38:40 +00:00
scheglov@google.com a2395ed946 Issue 5084. Report error if a type name appears multiple times in an implements clause
http://code.google.com/p/dart/issues/detail?id=5084

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10918247

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12391 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 15:55:31 +00:00
scheglov@google.com b388161d1f Issue 3476. Final variables don't have to have constant initializers
http://code.google.com/p/dart/issues/detail?id=3476

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//10919290

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12382 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 13:04:19 +00:00
scheglov@google.com ea65bbb961 Issue 3553. Stop treating static final variables as constants
http://code.google.com/p/dart/issues/detail?id=3553
http://code.google.com/p/dart/issues/detail?id=3476

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10907215

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12336 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:49:07 +00:00
brianwilkerson@google.com cd57835f8f Add built-in identifiers 'library', 'import', 'export' and 'part' (issue 5120)
Review URL: https://codereview.chromium.org//10919266

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12335 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:27:51 +00:00
scheglov@google.com fba2c23084 New 'Clean Up' to convert old optional parameters to the new optional named where possible.
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10916268

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12282 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 20:57:10 +00:00
pquitslund@google.com 63476bc781 Merge of DartAstUtilities into DartNodes (and push into compiler.js).
Review URL: https://codereview.chromium.org//10905241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12277 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 18:44:35 +00:00
keertip@google.com a8e4699571 show category information for sdk libs
Review URL: https://chromiumcodereview.appspot.com//10911221

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12267 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 15:45:51 +00:00
scheglov@google.com c317d33753 Issue 5049. Consistently resolve instance/static/top-level property access
print(x) = getter
x += 1   = getter
x++      = getter
++x      = getter
x = 1    = setter

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10914215

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12231 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 00:48:06 +00:00
brianwilkerson@google.com 911a8f9e6f Missing file from previous CL
Review URL: https://chromiumcodereview.appspot.com//10919220

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12213 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 18:26:09 +00:00
brianwilkerson@google.com 2d80d699b1 Convert throw from a statement to an expression (issue 4872)
Review URL: https://chromiumcodereview.appspot.com//10913197

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12212 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 18:21:24 +00:00
brianwilkerson@google.com 6700e32533 Accept raw strings prefixed by 'r' (issue 4815)
Review URL: https://chromiumcodereview.appspot.com//10933024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12209 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 16:39:33 +00:00
scheglov@google.com 753903b60a Issue 5042. Fix for resolving [], []= and [] op=
http://code.google.com/p/dart/issues/detail?id=5042

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12205 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 15:17:53 +00:00
scheglov@google.com ed3c755f0d Issue 5044. Make all abstract fields resolve to setter or getter methods.
http://code.google.com/p/dart/issues/detail?id=5044

Also tweaks for be able to navigate (F3) in Editor to corresponding method/function.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12204 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 15:12:01 +00:00
bak@google.com d3b5cfba18 First partial step at removing interfaces in libraries.
- Changes interfaces without default implmenetations to abstract class.
  - Changed final fields in interfaces to getters.
  - Changed dart_analyzer to allow methods with empty bodies in abstract class.
  - Updated the co19 status file since two tests now are passing.
Review URL: https://chromiumcodereview.appspot.com//10917187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12201 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 14:57:09 +00:00
scheglov@google.com 4b35780112 Issue 5055. Visit field getter/setter only once.
http://code.google.com/p/dart/issues/detail?id=5055

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10910176

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12152 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 00:02:29 +00:00
scheglov@google.com b537a1c26e Issue 4752. When convert to getter, remove also ()
I've forgot to do this initially.
Mostly Parser and Core changes.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10916211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12140 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 18:27:56 +00:00
scheglov@google.com 06469daca1 Issue 5004. Type inference with 'is!' and 'continue'.
http://code.google.com/p/dart/issues/detail?id=5004

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913168

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12123 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 15:54:20 +00:00