Konstantin Shcheglov
79327c9f05
Make ResolvedUnitResult.content/unit non-nullable.
...
Change-Id: Ia79567d248f2c91290bfdf8204ea7e9f3dc85fa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206668
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-07-14 02:33:10 +00:00
pq
fe7ca0f4bc
fix tool link
...
Change-Id: I34b2a5a624190df3c41b7ece0640e2978445fd3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205885
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-07-02 22:00:05 +00:00
Brian Wilkerson
30d27c6f61
Migrate all remaining server libraries except the library in bin
...
Change-Id: I2041763971a85fb8e9530b64ef30d106091c9739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196547
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-04-24 04:19:22 +00:00
Konstantin Shcheglov
26d9fbbd04
Add getResolvedUnit2(), deprecate getResolvedUnit().
...
Change-Id: I0217fefb2747f2f9bd757bc041b53acaf3d1a8f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195495
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-16 21:33:54 +00:00
Danny Tuppeny
2dcbd22e0c
[analyzer] Don't send Dart's trigger/commit characters for non-Dart LSP completion registrations
...
Change-Id: I703b183ebd9aedaf87dbbce664107d5bcff14367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195509
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 19:44:27 +00:00
Konstantin Shcheglov
b903d73c9b
Migrate allowed status pages.
...
Change-Id: If81a0e66a22f9219535420041b6cd7efe1aa3341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194103
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-06 16:17:17 +00:00
Konstantin Shcheglov
e97f1bdbf0
Switch analysis_server to language 2.12, so null safety, but opt-out files.
...
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.
Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 23:39:37 +00:00
Konstantin Shcheglov
c8d6f85d0f
Enforce lint unnecessary_parenthesis in analysis_server.
...
Change-Id: Ib68c124988743b45807015e7274f429fff67fe44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-06 05:20:16 +00:00
Konstantin Shcheglov
3f5694c827
Issue 45141. Check for loadLibrary() using namespace.
...
Bug: https://github.com/dart-lang/sdk/issues/45141
Change-Id: Ifb0825d66a560d0136873942f9666d3dc630b6c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-05 22:21:54 +00:00
Danny Tuppeny
bacd31dcdf
[analyzer] Flatten capabilities into a wrapper to simplify checking capabilities
...
Change-Id: I184e8ce3379bbb6ae4d8e81d80979510a8f1f393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-04 19:51:09 +00:00
Konstantin Shcheglov
34bec2f1a5
Deprecate AnalysisDriver.contextRoot
...
Change-Id: I2dfb7f2f751e3c3ba7cdc11c94b9dfa5ddd35670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-25 19:35:11 +00:00
Devon Carew
c290fc0eaf
[analysis server] Fix an NPE in the diagnostic page
...
Change-Id: Ifafd1c75978aa9a5b6193139455926a6936b66ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2021-02-10 01:14:17 +00:00
pq
f438d72387
report sdk root in status
...
Change-Id: I9c9d09a2812566d88835b3dbc6808a515089cd4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-25 19:53:53 +00:00
Devon Carew
f5e26456bf
Remove the --completion-model flag from the analysis server.
...
Change-Id: I6bedbb0b5c4b8bedba18d2e3b788db0a9686f6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172026
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-11-16 03:31:18 +00:00
Konstantin Shcheglov
d219bde703
Enforce await_only_futures and fix violations (in more packages).
...
Change-Id: I1812f7721915178e42956f988b9276bf8db0bfaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-24 16:58:50 +00:00
Konstantin Shcheglov
ba78db411a
Remove DartSdk.analysisContext
...
Change-Id: I6a67344d928e6182a851741bbbc862284af710c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-13 00:56:36 +00:00
Mike Fairhurst
1134a0f17c
[analysis_server] Remove unused dart:async imports
...
Change-Id: I764ee78cb9e31bdb3abaa36ca4754e1fed180311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161447
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-09-02 17:29:52 +00:00
Simon Binder
366a3f37c6
Analysis server: Show current registration in LSP Diagnostics
...
Show the current registration and params in the capabilities page.
For me, this was useful to verify plugin registrations with a custom
document selector.
Change-Id: If8c009cb75a6c4b42661354ee90eb515eee2da06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-08-27 20:41:57 +00:00
Devon Carew
528238465f
Remove the PerformanceTag class and related code.
...
Change-Id: I55b39e8fa6de7a3a946333bc84cc4ba0a09ecba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-08-16 23:59:42 +00:00
Konstantin Shcheglov
8405d7c8e3
Remove dart2jsHint option, verifier, and tests.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I95b88940c862d463af03e85fcdf0f4bf81c2fbd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157641
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-08-10 19:19:43 +00:00
Konstantin Shcheglov
dfb3720cda
Changes to analysis_server/ to be compatible with the breaking changes to analyzer/.
...
Change-Id: I606072798633601d78f38c0035b579d93875ef3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-31 17:04:58 +00:00
Brian Wilkerson
174759cfbd
Add a way to get all of the lint codes used by a rule
...
Several of the lint rules have been producing diagnostics with more than
one lint code, but the code that deserializes diagnostics has only been
able to use one of the codes. That potentially leads to errors, though I
suspect the bug has been invisible because we serialize and deserialize
the messages. Nevertheless, it seems like we ought to do this correctly
and that it will eventually lead to a visible bug.
Change-Id: I41faaa45df63cb3c74042661e1c89e3fde3d72d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154843
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-07-17 18:39:37 +00:00
Konstantin Shcheglov
326f7b4a8f
Remove DartSdk.useSummary.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/149495
Reverted: https://dart-review.googlesource.com/c/sdk/+/149687
Change-Id: Ibd3f1af1aef83adc35f77cfbda66e07c5ae99922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 15:56:41 +00:00
Konstantin Shcheglov
db61737086
Simplify CompletionPerformance.
...
R=brianwilkerson@google.com
Change-Id: Iff0cf3b8b684f72d8a32b3fe4b9493295c11d59b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152985
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-30 22:45:27 +00:00
Konstantin Shcheglov
48f2d10d3e
Deprecate ClassElement.hasReferenceToSuper
...
Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-15 17:45:06 +00:00
Paul Berry
930cae0f13
Revert "Remove DartSdk.useSummary."
...
This reverts commit a2c3ecabce .
Reason for revert: Breaking change to de facto API
Original change's description:
> Remove DartSdk.useSummary.
>
> R=brianwilkerson@google.com
>
> Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I9998bedb74ea940371f18ac7dce42b2f5dcc3b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149687
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-06-02 15:20:32 +00:00
Konstantin Shcheglov
a2c3ecabce
Remove DartSdk.useSummary.
...
R=brianwilkerson@google.com
Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-30 19:07:32 +00:00
Konstantin Shcheglov
279024d823
Deprecate InstanceCreationExpression.staticElement
...
Change-Id: I3c2de8ce22944963418d543b887720db15badd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148981
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-26 22:56:42 +00:00
Kevin Moore
0acc564104
Fix a number of URIs referring to dartlang.org
...
Change-Id: Ie1373e93092023caf5e0bcfd6bb88bfb422d5daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
2020-05-13 18:24:12 +00:00
Simon Binder
10bd820169
analysis_server: Show plugins page in LSP diagnostics
...
Since the LSP server has basic support for server plugins, it seems
appropriate to enable the plugin page in its diagnostics.
Change-Id: If5fb601023e94a418250bca101240a69da1f0e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-05-11 22:36:00 +00:00
Brian Wilkerson
12dcfe63bb
Start removing extraneous awaits from server
...
Change-Id: I484227773e98d87c915f6dfe6e320dda1a7b8eaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144862
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-26 23:45:29 +00:00
Paul Berry
a6b0e4fa13
Fix an analysis_server lint (prefer single-quoted strings)
...
Change-Id: If154127c6625194a856c23729f5b4a26b8b7fe8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144472
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-24 10:55:34 +00:00
Konstantin Shcheglov
4490e2f541
Deprecate VariableElement.constantValue, use computeConstantValue().
...
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-24 00:37:52 +00:00
Mike Fairhurst
94178e920e
[nnbd_migration] Fix regression: respondOk not returning JSON.
...
This causes the current state to fail to parse the (empty) success
result and falsely thinks things like rerunning the migration/applying
the migration result in an error.
Change-Id: Id68e089000e0be65278f687cd06112756ccb2a3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144668
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-23 23:55:12 +00:00
Mike Fairhurst
3a6c863e23
[nnbd_migration] Respond in json for errors, simple successes.
...
Change-Id: I69015f21463b3060dd168654627f8e753ede52ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144340
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-23 05:47:18 +00:00
Konstantin Shcheglov
69526e6512
Depecate many AnalysisOptions fields.
...
Change-Id: Ibe219527d9abdad38bb99390d3023e7ee6bb8420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-15 18:36:52 +00:00
Konstantin Shcheglov
fb4b59e043
Deprecate isProxy / isOrInheritsProxy in ClassElement.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ied4011961d4dece33d527888d274893985d85f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141767
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-30 23:27:39 +00:00
Brian Wilkerson
8969b1839c
Enable omit_local_variable_types in analysis_server
...
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-30 03:58:44 +00:00
Brian Wilkerson
7e724e70b0
Sort non-generated files in analyis_server and add a test to ensure they stay that way
...
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-28 17:12:03 +00:00
Devon Carew
1e45051341
[analyzer] initial implementation of SDK, file based configuration of the analysis server
...
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-24 14:07:59 +00:00
Brian Wilkerson
f60536c194
Enable slash_for_doc_comments in analysis_server
...
Change-Id: Id2734d4c9ce591c5746bb9aa55810c78183db38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-14 17:17:17 +00:00
Devon Carew
0299903f3e
[nnbd preview] restore navigation in the code editor
...
Change-Id: I4f3678c8edc5ce606d727ce964806689bcf4a38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135383
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-12 01:12:05 +00:00
Konstantin Shcheglov
b63e3f9425
Replace AnalysisOptions.enabledExperiments with contextFeatures.
...
There should be just one source of FeatureSet, so that when we add
--default-language-version flag, we apply it to the FeatureSet, and
set as the default for the context.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: If140768bb51db1b0f736b91ab5d624e22100405e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135347
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-11 20:16:14 +00:00
Brian Wilkerson
5584c96fde
Enable prefer_single_quotes in analysis_server
...
All of the changes except in the analysis options file are from dartfix.
Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 17:52:52 +00:00
Danny Tuppeny
ad3449c804
Add a server diagnostic page for viewing overlays/contents
...
Fixes https://github.com/dart-lang/sdk/issues/40196 .
Bug: https://github.com/dart-lang/sdk/issues/40196
Change-Id: I2bfa9df792cf3a7ac8284df9b75a78bea5cde705
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-01-21 15:54:02 +00:00
Brian Wilkerson
93ebbe2c7a
Enable use_function_type_syntax_for_parameters in analysis_server
...
Change-Id: I93cddc986c23e53557c647befc92d118b3d6ed43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132459
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-19 17:11:11 +00:00
Jaime Wren
74bf68a99d
Improve printPercentage(..) in pkg/analysis_server/lib/src/status/pages.dart to take an optional fractionDigits to pass to num.toStringAsFixed(..)
...
Change-Id: I641cf541626ef149663fc3f652b9f1ca1dfb02a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-15 19:56:55 +00:00
Brian Wilkerson
91d6e1a0a7
Enable annotate_overrides in several packages
...
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.
Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-01 21:31:40 +00:00
Brian Wilkerson
7d41ae7d15
Enable unnecessary_this in several packages
...
Change-Id: I743066d66dbf1dff984e8f8bf5b7a472c9bc7ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-28 20:43:16 +00:00
Konstantin Shcheglov
21354dccc9
Remove SdkExtUriResolver.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820
R=brianwilkerson@google.com
Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-20 01:08:49 +00:00