dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
80,961 Commits 2 Branches 0 Tags
ee8ebcdc41daabe3e8d7633b6057cfbdaf5880ff
Commit Graph

36071 Commits

Author SHA1 Message Date
Paul Berry ee8ebcdc41 Clean up comments in function_expression_resolver.dart 
In https://dart-review.googlesource.com/c/sdk/+/209240, I accidentally
included a stray "TODO" comment that only made sense in the context of
a previous patch set.  I also made a minor spelling error in a
comment.

This CL removes the stray TODO and fixes the spelling error.  There is
no functional change.

Change-Id: If1c600a579101cea1015d34d9833eb21a2b1a675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-08-06 20:36:19 +00:00
Brian Wilkerson 7d1f26ff09 Deprioritize the fix to add a null check 
I missed this as part of my previous CL.

Change-Id: I07f2d6a4e0b60433afb39ee1b0a4819147a494aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-06 20:05:48 +00:00
Paul Berry 195f4c1236 Clean up hacks around resolution of documentation comments. 
For some time, the visitors we use for resolution have been handling
documentation comments for most types of declarations by visiting them
*after* visiting parameters; this ensures that the parameters are in
scope at the time of visiting the documentation comment, so that the
documentation comment can refer to them.

However, a few types of declarations were done in a kludgy way:
constructor declarations, function declarations, function type
aliases, generic type aliases, and method declarations.  In some cases
we would visit the documentation comment twice, once before setting up
the scope properly (in which case the visit method would just return
early), and then again at the right time using
ResolverVisitor.safelyVisitComment (which bypassed the early return).
On other cases the visitComment method had duplicate logic for setting
up the proper scopes.

With this change, we now consistently use the approach of visiting the
documentation comment after the scopes are properly set up for it.

Change-Id: Idd27946a947040d4bad37568915bf5915bff843f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209240
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-08-06 19:12:28 +00:00
Brian Wilkerson 4200f6d915 Enhance the replace_with_null_aware fix and apply it in more places 
Change-Id: I80945b4814cca0eaeca2129e5365c0d7526a8247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-08-06 17:03:35 +00:00
Danny Tuppeny a6176ec3dd [dds] Support delegating running the debugee to the editor in DAP using runInTerminal 
Change-Id: I9fd435ee43ca9ae0d1e38bdffd9121157d33b730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208654
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-06 16:42:17 +00:00
Ben Konyi cccc0293c5 [ VM ] Send 'dart --help [--verbose]' output to stdout 
This is consistent with the majority of other tools and the CLI
behavior.

Fixes https://github.com/dart-lang/sdk/issues/46412

TEST=pkg/dartdev/test/commands/flag_test.dart

Change-Id: I45a3ddc9728e9cc1a273d4d5f11db74cb8104745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204661
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-08-06 16:06:05 +00:00
Ben Konyi b225582593 [ Service ] Disable CPU sample block streaming 
See https://github.com/dart-lang/sdk/issues/46825

TEST=vm/cc/Profiler_* and service tests

Change-Id: I98faa1953a3bf3c28828dabaa0be6b033ada63fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209260
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-08-06 16:02:55 +00:00
Dmitry Stefantsov f77f8e5871 [cfe] Add type checks on tearing off instance members 
Closes #46784.

Bug: https://github.com/dart-lang/sdk/issues/46784
Change-Id: I7637618be0686bbffe6eb18a19049ec5da6059aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208881
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2021-08-06 15:19:35 +00:00
Johnni Winther c66ae0027b [cfe] Handle invalid typedefs and redirecting factories in lowering 
Change-Id: I61d776434621fd7022d034f17e228ec553a7ff47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209108
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-08-06 13:43:05 +00:00
Gabriel Castro 0f04dc651d Added checks to gather method data 
Change-Id: I809e05ea3554ae9768d3f9cb25c824bbe36ca2bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203600
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2021-08-06 03:59:22 +00:00
Gabriel Castro 53198d4d1c Added check to gather parent class name and classes mixed with 
Change-Id: I56f5cae15b0e4a94ade886e317f3974cd3de6532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203060
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2021-08-06 00:59:41 +00:00
Riley Porter ff85758d9c Add desugar API mapping extension member name to ProcedureKind 
Surfaces what ProcedureKind an extension member is based on the
CFE convention of '|set#' and '|get#' in the member name to
retain setter and getter information.

Change-Id: I527062e4a1e4e9f4346751ea2f9d636184e2d8e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209162
Commit-Queue: Riley Porter <rileyporter@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-08-06 00:37:51 +00:00
Konstantin Shcheglov c951b72ed5 Issue 46753. Enhance LinterContext.resolveNameInScope() to suport type parameters. 
Bug: https://github.com/dart-lang/sdk/issues/46753
Change-Id: Ide53294599496cb8011e86bced0b075e389e1040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-05 21:54:21 +00:00
Ben Konyi 0b0bb9940d Revert "[ package:dds ] Add locking when modifying DDS state via client requests" 
This reverts commit 0ecfc7da6f.

Reason for revert: https://github.com/dart-lang/sdk/issues/46826

Original change's description:
> [ package:dds ] Add locking when modifying DDS state via client requests
>
> Fixes https://github.com/dart-lang/sdk/issues/46696
>
> Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
> Reviewed-by: Anna Gringauze <annagrin@google.com>

TBR=bkonyi@google.com,annagrin@google.com

Change-Id: Iec89181372a2fc1b8a461e616bbcd23dd6bbd72d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209280
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-05 21:32:42 +00:00
Konstantin Shcheglov 39178e6b13 Issue 46206. Record redirectedConstructor even for non-const constructors. 
Bug: https://github.com/dart-lang/sdk/issues/46206
Change-Id: I9a121454e382988228d62130ef2f9cad7164135a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-05 19:53:21 +00:00
Gabriel Castro 9420dfd3ca Initial commit for information collection visitor. 
Accepts a .dill and recusivly visits component tree structure.
Added check for super call.

Change-Id: I926700afaeae6efddc9b70ca2121ae6cecdab33a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202880
Commit-Queue: Gabriel Castro <gabrielmcastro@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2021-08-05 19:49:21 +00:00
Ben Konyi 0ecfc7da6f [ package:dds ] Add locking when modifying DDS state via client requests 
Fixes https://github.com/dart-lang/sdk/issues/46696

Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
Reviewed-by: Anna Gringauze <annagrin@google.com>
 2021-08-05 17:56:01 +00:00
Danny Tuppeny b8b041ffb4 [analysis_server] Don't treat '// ignore:' comments as library-level when sorting organizing imports 
Change-Id: I3c1fe45401bda9cd15c4c78d238c05792e1d3362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-05 17:50:51 +00:00
Paul Berry ddfc60a41e Add a LibraryElement.accessibleExtensions getter. 
This saves the ExtensionMemberResolver from having to access the
current scope in order to find out what extensions are available.
This will help prepare for a follow-up CL in which I separate the
"scope lookup" and "type analysis" phases of resolution.

As a side benefit, the analysis server no longer needs to go through
`package:analyzer/src` in order to include extensions in completion
results.

Change-Id: I6098eae219b0f7ef52b7c68f1d64c149d9e66823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208922
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-05 17:44:42 +00:00
Alexander Markov 846af57d99 Migrate pkg/dart2native to null safety 
Change-Id: I87e4fd454b8e52acc17243495295ffee9dfd79bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208986
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2021-08-05 17:41:30 +00:00
Alexander Markov 81da4e07fd [cfe] Cleanup detection of cyclic redirecting factories 
This is a follow-up to [1]. Since that change we started detecting
cyclic factories earlier, so cycle detection can be removed from the
later stage of resolving calls to redirecting factories.

Similarly, detection of redirecting factories targeting generative
constructors of abstract classes was also moved to an earlier stage
and can be cleaned up.

[1] https://dart-review.googlesource.com/c/sdk/+/208681

Change-Id: Ib3d061438c7a898424ffd73f18e2a289a1f987fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209000
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2021-08-05 16:06:21 +00:00
Danny Tuppeny 0de7e86c2a [analysis_server] User outer-most matching node in getNavigation to fix constructor navigation 
Fixes https://github.com/dart-lang/sdk/issues/46725.

Change-Id: Ib4f3ec5fe776ad694a7ce7019591a73aab2c4257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208647
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-05 15:59:50 +00:00
Danny Tuppeny 55b93198e3 [analysis_server] Never move language version tokens when sorting imports 
Fixes https://github.com/dart-lang/sdk/issues/46404.

Change-Id: I2718cd13f2114fcc59fe86aa27b20ad90a29af33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-05 15:58:19 +00:00
Konstantin Shcheglov 6f917d00af Rebuild context on bazel BUILD file change. 
Bug: https://buganizer.corp.google.com/issues/195398835
Change-Id: I80a659a8ab6a3162703e6442970438af9b19be60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Michal Terepeta <michalt@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-05 12:47:40 +00:00
Johnni Winther 95164f40f4 [cfe] Handle Null and non-class typedefs in tear off lowering 
Change-Id: I94c9e720bcb4b85a9136ab438db7093305087ff6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209080
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-08-05 12:26:14 +00:00
Johnni Winther 839b5d40a6 [cfe] Enforce weakening on typedef tear off constant instantiations 
Closes #46808

Change-Id: Idb7e5cd9025081f25ff13cdd03f9dc812f999d70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209082
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-08-05 12:26:11 +00:00
Lasse R.H. Nielsen de999e8ea3 Add access-control-allow-* headers 
cc @kevmoo if you know who can handle this.

Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947

GitOrigin-RevId: ae62a578d11095dd225ecb02f83e29ce5bd99864
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198780
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-08-05 09:48:19 +00:00
Johnni Winther 0f6dba44ba [vm] Support linked libraries in transformer test 
+ move AOT testing from pkg/front_end to pkg/vm

TEST=pkg/vm/test/transformations/type_flow/transformer_test.dart

Change-Id: I26c8be87a1d06062b97f5fd3809d5a03255f3759
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208641
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2021-08-05 07:03:58 +00:00
Stephen Adams 5ff2459d88 Remove obsolete internal dart2js annotations 
These annotations have all been replaced with @pragma('dart2js:xxx')
versions:

@ForceInline, @NoInline, @NoThrows, @NoSideEffects, @AssumeDynamic.

Change-Id: Ia4730670c6864ccbe0fa4120108c3c16ab887c23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208863
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-08-04 23:27:18 +00:00
Sam Rawlins dcec1aca37 analyzer: Improve comments regarding "new"-named constructors. 
Feedback from https://dart-review.googlesource.com/c/sdk/+/208760

Change-Id: I0cc1bd79f41307d694af37e699f237e433d1ee42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-08-04 23:26:53 +00:00
Alexander Markov 32914654bd [vm] Treat redirecting factories as ordinary factories 
After https://dart-review.googlesource.com/c/sdk/+/208681
it is now possible to use bodies of redirecting factories in the VM
and treat redirecting factories like ordinary factories.

TEST=vm/cc/DartAPI_New
TEST=vm/dart/redirection_type_shuffling_test
TEST=co19/LanguageFeatures/Constructor-tear-offs

Fixes https://github.com/dart-lang/sdk/issues/33041
Fixes https://github.com/dart-lang/sdk/issues/29201
Issue https://github.com/dart-lang/sdk/issues/46231

Change-Id: If410d2913704a33035800144699fd6e8a2570a19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208684
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2021-08-04 21:50:48 +00:00
Sam Rawlins 7f5d1cc30d Correct some of the terminology surrounding the "default constructor." 
A constructor without a name is an "unnamed" constructor. A class which
has no constructors explicitly specified implicitly has one "default
constructor". See from the spec:

> Iff no constructor is specified for a class _C_, it implicitly has a
> default constructor `C(): super() {}`, unless _C_ is the built-in
> class `Object`.

This is the singular reference in the spec to this "default
constructor." There is text which refers to the implicit
superinitializer which refers to the superclass's unnamed constructor
which must have zero arguments:

> If no superinitializer is provided, an implicit superinitializer of
> the form `super()` is added at the end of _k_'s initializer list,
> unless the enclosing class is class `Object`.

Change-Id: I3202c3923d2c561d40c2251c1b13ea4fde8bda48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-08-04 20:27:58 +00:00
Alexander Markov 300a2ea952 [cfe] Create normal bodies for redirecting factories 
Replace bogus body created for redirecting factories with a
normal body which calls target factory or constructor and
forwards all arguments. Such a body can be used by back-ends
if they choose to treat redirecting factories as ordinary
factories.

TEST=ci
Fixes https://github.com/dart-lang/sdk/issues/41915
Issue https://github.com/dart-lang/sdk/issues/46231

Change-Id: I62c83bcc9005995e85de049d3d929ca86a75297f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208681
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-08-04 17:51:07 +00:00
Ben Konyi ada4278fd5 Revert "Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"" 
This reverts commit 1796160606.

Reason for revert: Still seeing failures.

Original change's description:
> Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"
>
> This reverts commit 4160747ef6.
>
> It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.
>
> TBR=asiva@ (discussed offline)
>
> TEST=Existing service tests + get_cached_cpu_samples_test
> Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: Ic522ab61b430673533c94ecd0c91bee569a0add6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208960
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-04 17:32:38 +00:00
Brian Wilkerson 878cd3a3f8 Improve the messaging around conflicting constructors 
Fixes: https://github.com/dart-lang/sdk/issues/46803
Change-Id: I0435ea15cfb4c57dfb865f66d251afbe1d9459a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 17:29:47 +00:00
Mark Zhou 86655608c0 [dartdevc] Refactoring expression eval tests. 
* Splitting expression eval tests into separate tests per module system to avoid timeouts
* Adding some extra timeouts to various Chrome operations in the e2e suite
* Running in non-headless Chrome on Windows to avoid strange flakiness problems
* Minor test suite reformatting

For timeouts, see: https://dart-review.googlesource.com/c/sdk/+/208347/21..22

Fixes #45713

Change-Id: Id51d412da1ffc66b443c73cdb50daa777bdce929
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207562
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2021-08-04 16:46:28 +00:00
Konstantin Shcheglov a468bd2e22 Tweaks for LinterExceptionHandler. 
Boolean parameters are easier to understand when they are named.
And the word "linter" does not add much, we already know this.

Change-Id: Ib34488acd43230ac516b5fe2d3928c96dfbc6a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-04 16:26:37 +00:00
Brian Wilkerson 7bc076c9e0 Fix a bug in data-driven fixes that caused imports to be added multiple times 
Change-Id: Idd0dadcaed4b59173573475d5b115e0fc6228184
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 16:20:07 +00:00
pq 1eb601b719 Update changelog to add UseResult.unless 
Change-Id: I4a74f2096efcd993d4fc168e0b7d509d8dcb327f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208867
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-08-04 16:03:59 +00:00
pq 9491cafc2f add UseResult.unless({... , this.parameterDefined}); 
Sample use:

```
@UseResult.unless(parameterDefined: 'count')
Matcher hasCount([int? count]) => Matcher();
```

See: https://github.com/dart-lang/sdk/issues/46727


Change-Id: I507659c09072157d67433f347d1fa6b511a93a7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208721
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 14:30:10 +00:00
Johnni Winther acd4bc256f Reland "[cfe] Perform eager canonicalization of instantiations without experiment" 
Change-Id: I3009f22b269a7946782e868ce5924ff3e1e52f00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-08-04 11:41:30 +00:00
Johnni Winther 43c00097c2 [cfe] Remove isOptOutTest work-around 
Change-Id: I7dd125508bba256eb4c78b02fb24e433f45b129a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205420
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-08-04 10:44:00 +00:00
Johnni Winther e7638e8e96 [cfe] Use wrapInProblem instead of buildProblem in inference 
Change-Id: I51fe495d162e26ac7cd97629272170c85cafea36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208642
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-08-04 10:07:24 +00:00
Johnni Winther e6e25ac7b0 [cfe] Migrate remaining front_end tools 
Change-Id: I75f936734a89ec5858390d96be7a5cdc4a300891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208402
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-08-04 08:49:51 +00:00
Johnni Winther 5dc4d65114 [kernel] Add InvalidExpression.expression 
... and use this to wrap expressions instead of Let

TEST=existing

Change-Id: I6d1f5cfa4693222840d6cb406790c39c6ae63e5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208580
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-08-04 08:40:18 +00:00
pq 9fced4c389 check for undefined parameter references in UseResult.unless targets 
Change-Id: Iaba4696c3f04efe0c104695ac51896bb81d06bb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208862
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 00:35:30 +00:00
pq b820538026 @UseResult verifier: check for passed "using" param 
Change-Id: I5d0ececce8702c8dace87a4fbf3922fa05ba74ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208822
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-03 19:31:39 +00:00
Sam Rawlins e64597aa1b analyzer: Report duplicate unnamed and "new"-named constructors 
Bug: https://github.com/dart-lang/sdk/issues/46020
Change-Id: I5a737b8b227fa205e66650dd40d697e4e3ef0125
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-08-03 19:27:02 +00:00
Ben Konyi 1796160606 Reland "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commit 4160747ef6.

It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.

TBR=asiva@ (discussed offline)

TEST=Existing service tests + get_cached_cpu_samples_test
Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-03 19:18:59 +00:00
Anna Gringauze 388e365d2f Fix failures in expression compiler worker test 
Closes: https://github.com/dart-lang/sdk/issues/46786
Change-Id: Ib2ec6130908fb6d4327a49d1b32c3789d52633ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208720
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Anna Gringauze <annagrin@google.com>
 2021-08-03 18:41:31 +00:00