0e1ddfb0f2
Disable completions for runtime expressions
...
Change-Id: I675c2c724e4b3ad987ef7d52c80786379e443781
Reviewed-on: https://dart-review.googlesource.com/c/78145
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-04 21:34:20 +00:00
2a6b566ca2
Move byte store to package:analyzer
...
Change-Id: I1fc41cc0b2e2848565a5411d0512a4ca086ab659
Reviewed-on: https://dart-review.googlesource.com/c/77761
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Auto-Submit: Peter von der Ahé <ahe@google.com >
2018-10-04 09:15:54 +00:00
45cb0815bc
Move PerformanceLogger to package:analyzer
...
Change-Id: I89a60ae9ab639c7907a92976e1eb8007d0f4ee9b
Reviewed-on: https://dart-review.googlesource.com/c/77760
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Auto-Submit: Peter von der Ahé <ahe@google.com >
2018-10-04 08:44:43 +00:00
2dfe46fba2
Additional work on MOVE_FILE and associated tests
...
- Update outgoing part-of relative uris (may need changing)
- Add a helper for verifying failed refactor statuses
- Use the original file location for checking if in an analysis root
- Remove tests for functionality we're not yet supporting
- Remove forced failures and @failingTest for tests that work
Bug: https://github.com/dart-lang/sdk/issues/33605
Change-Id: I405bfcb92ce2ce66710caf934fc03e10eb66aea3
Reviewed-on: https://dart-review.googlesource.com/c/77541
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-03 14:22:11 +00:00
ed42aab273
Move source.dart to package:analyzer
...
Change-Id: Ide66d4f69b8588f04967c510eae0a733b4b3f0c5
Reviewed-on: https://dart-review.googlesource.com/c/77860
Auto-Submit: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-10-03 12:56:49 +00:00
bd7b776bb4
Fix more quick fix tests
...
Change-Id: I07c9900be8dc3510d729f77b98c95acd06159043
Reviewed-on: https://dart-review.googlesource.com/c/77671
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-03 00:16:15 +00:00
edd86ef7a1
Generate quick fix for await in non-async (issue 34647)
...
Change-Id: Iabf8f11c8c477d1642e5122a5748b04bcdc5efa3
Reviewed-on: https://dart-review.googlesource.com/c/77669
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-02 20:46:36 +00:00
72d3798764
Improved completion support for mixins
...
Change-Id: I77aea1b03e00725c48458b0e6ee9b1936ea5685c
Reviewed-on: https://dart-review.googlesource.com/c/77661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-02 18:27:33 +00:00
7ca2f56112
Stop using and deprecate InheritanceManager.getMembersInheritedFromInterfaces().
...
R=brianwilkerson@google.com
Change-Id: Ia24248cc0d80960d2a4aa40e0da519804c68abbc
Reviewed-on: https://dart-review.googlesource.com/77483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-01 22:40:07 +00:00
f7f31efab0
Disable the reading of a UUID during training
...
Change-Id: Idb4d1d2ea4c7a862ff3d54718d2bf924492f3779
Reviewed-on: https://dart-review.googlesource.com/77422
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-01 19:07:59 +00:00
64f02226b3
Stop using InheritanceManager.getMembersInheritedFromClasses().
...
R=brianwilkerson@google.com
Change-Id: I2f719f6c3c5383ac76608b9fd5b7251f3af0d6bb
Reviewed-on: https://dart-review.googlesource.com/77463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-01 19:02:14 +00:00
2723fcfb82
Remove more dead code from server
...
Change-Id: Ib0af3295bc064fab0a271337a42f3925ccf205dc
Reviewed-on: https://dart-review.googlesource.com/77420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-01 15:43:12 +00:00
ce8a5ffab2
Remove remaining definitions of EMPTY_LIST in server
...
Change-Id: Ia7a9286f2fc7e151f99091169635b71fde88649a
Reviewed-on: https://dart-review.googlesource.com/77421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-01 15:42:55 +00:00
10f05f45b9
Remove more dead code from server
...
Change-Id: I09d7c2e96d41f095cb456a5eccb04eaa447430cd
Reviewed-on: https://dart-review.googlesource.com/77263
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-01 01:21:38 +00:00
5cc9ab02a8
Switch all refactoring to using ResolveResult instead of raw unit.
...
R=brianwilkerson@google.com
Change-Id: I3fa7c5c22966dd5d464e438e9300587d80c180b2
Reviewed-on: https://dart-review.googlesource.com/77267
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-01 01:17:58 +00:00
5bcf91d973
Remove some dead code
...
Change-Id: Ida5c2ad29f943d676a6f16a51d66892b037ad099
Reviewed-on: https://dart-review.googlesource.com/77240
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-09-30 16:32:38 +00:00
da3e844cac
Fix potential cast exceptions
...
Change-Id: I38f5565495b30393e0e559fe7fcae4c8bc247162
Reviewed-on: https://dart-review.googlesource.com/77226
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-09-28 22:06:24 +00:00
1bceca91b0
Remove the 'name' constructor parameter from CompilationUnitElementImpl()
...
It costed us about 1.2% of total analysis time.
The whole information about a unit is available in its Source.
R=brianwilkerson@google.com
Change-Id: Iffa253d1eae1a466c10766f66c6c677e19be124a
Reviewed-on: https://dart-review.googlesource.com/77220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-28 21:53:24 +00:00
9c585bf5df
Document that ResourceProvider requires absolute, normalized paths, and enforce this.
...
This allows us to avoid performing normalization, and work with paths
as is. So, this speeds up SourceFactoryImpl.restoreUri() from 7.5% to 3.7%
R=brianwilkerson@google.com
Change-Id: I085f3db40af6543fbb524a82fad48aa051e87937
Reviewed-on: https://dart-review.googlesource.com/77017
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-28 17:18:49 +00:00
0518b334ba
Address comments
...
Address comments in https://dart-review.googlesource.com/c/sdk/+/77021
Change-Id: I2a603d77002933692e6b14deba68b227cf4981e3
Reviewed-on: https://dart-review.googlesource.com/77023
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-27 21:24:53 +00:00
7c46a28505
Update convert class to mixin assist to remove "abstract"
...
Change-Id: I27ff36228b6c93d13a2f6d5f0a4c15414c130687
Reviewed-on: https://dart-review.googlesource.com/77022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-27 21:07:03 +00:00
45c7e4365c
Update dartfix to apply changes to file rather than displaying them
...
This CL updates dartfix to make the recommended changes after
prompting the user to confirm that these changes should be made.
If the source contains errors that might affect the correctness
of the automatically applied fixes, then a warning is issued
before prompting the user.
This CL also addresses comments in
https://dart-review.googlesource.com/c/sdk/+/77020
Change-Id: Ie609247616dd033aa16af8d7e6e38a9eb4cbf0d0
Reviewed-on: https://dart-review.googlesource.com/77021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-27 20:59:02 +00:00
edddc0ba58
Generate source changes for converting class to mixin
...
This uses the AssistProcessor to generate the source changes
and pass them to the client. In a subsequent CL, the client
will apply those changes instead of displaying them.
Additionally, this CL addresses comments in
* https://dart-review.googlesource.com/c/sdk/+/76760
* https://dart-review.googlesource.com/c/sdk/+/76520
Change-Id: I1e9cb4e079ec79a06db4c4d04a062c71107c0f21
Reviewed-on: https://dart-review.googlesource.com/77020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-27 19:32:20 +00:00
629d76eb46
Simple dartfix that suggests class to be converted to mixins
...
... and update protocol spec errors generated by edit.dartfix
Change-Id: I3708eb9ffa40f91ff9bf172d20d75346f481e4d8
Reviewed-on: https://dart-review.googlesource.com/76760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-27 15:44:45 +00:00
a0ff5f8b3f
Add stub implementation for analysis server edit.dartfix
...
Change-Id: Iefaec93366c5a6910e3c2e7dfebc91e8905922c2
Reviewed-on: https://dart-review.googlesource.com/76520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-26 14:31:27 +00:00
699282b5d3
Rename State class when StatefulWidget is renamed.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2545
Change-Id: I247db781e3b44910c823bb66d5f8773dc0d415cc
Reviewed-on: https://dart-review.googlesource.com/76080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-24 15:02:52 +00:00
2d53894e3f
Check that selection offset/length is valid in Extract Local refactoring.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34475
Change-Id: Id2b44494a8464000180a8ca93cfcc770b256f59f
Reviewed-on: https://dart-review.googlesource.com/76063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-24 14:55:33 +00:00
0b5a7c847d
Add support for intermittent filesystems to the analysis server, this PR is a synced version of Devons PR https://dart-review.googlesource.com/c/sdk/+/72980 , without the DAS protocol change.
...
Change-Id: I6ad1d423c2616ae31fc3f5954782d05e3d8adbda
Reviewed-on: https://dart-review.googlesource.com/73689
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-09-20 22:54:59 +00:00
9f5aecb22b
Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files.
...
Change-Id: I3a2aaec08b6529c6cbd23d8d16b4b9ca8dd4da59
Reviewed-on: https://dart-review.googlesource.com/75402
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-09-20 20:35:43 +00:00
4611ebaec5
Rename class when the refactoring is invoked on the class name in an instance creation.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34484
Change-Id: I9faa08e1741603dedcfe7cfacb2192d44dedc89d
Reviewed-on: https://dart-review.googlesource.com/75380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-18 19:09:37 +00:00
71ad670754
Provide quickfixes for imprecise integer literals.
...
Important to do, I think, because its easy for computers and hard for
humans.
Change-Id: Ic8c770c6a99f004d29c2fd24bddb122a70aeba3f
Reviewed-on: https://dart-review.googlesource.com/75240
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-18 17:52:17 +00:00
6c712f157b
Add a fix to create a mixin
...
Change-Id: Id0f31949a5639a00e884abc61b2cfcb5bc552b44
Reviewed-on: https://dart-review.googlesource.com/75130
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-09-17 12:43:41 +00:00
c5d77d1d8b
Support mixins in more places in index and search.
...
R=brianwilkerson@google.com
Change-Id: I523726e1c7f5efa2d6e2f4b91204da3f14f181b6
Reviewed-on: https://dart-review.googlesource.com/75120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-16 17:40:16 +00:00
a80b13e2f9
Add an assist to convert from a class to a mixin
...
Change-Id: Id47de8ffe8c381973c5a4ca53f7459782e62d37f
Reviewed-on: https://dart-review.googlesource.com/74963
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-09-15 16:12:22 +00:00
c568c9379f
Fix an npe (issue 34428)
...
Change-Id: Ibff06223efd5b2f9035e40b9d0925404cb5cc032
Reviewed-on: https://dart-review.googlesource.com/74301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-09-11 13:56:33 +00:00
e20064b8bf
Add syntax highlighting support for the new mixin syntax
...
Change-Id: I4d6cfdfe0cd8d9c5be82c6efabeb642c4ca87e72
Reviewed-on: https://dart-review.googlesource.com/70902
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-09-06 19:49:20 +00:00
732a5e3ea8
Give import prefix type 'dynamic' when it is used as an expression.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34209
Change-Id: I6c393af70342037c496adebefaaf66c7a685852a
Reviewed-on: https://dart-review.googlesource.com/73240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-05 19:47:00 +00:00
e9504d2857
Add outline support for the new mixin syntax
...
Change-Id: I75d020f613daf37812ccf805d75e35091a28c198
Reviewed-on: https://dart-review.googlesource.com/72524
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-08-31 21:53:15 +00:00
0fae13e6bf
Support for mixins in search.getElementDeclarations.
...
R=brianwilkerson@google.com
Change-Id: I88e90159ae28a2585fdbaacca2c4caab15891b83
Reviewed-on: https://dart-review.googlesource.com/72523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-31 20:19:18 +00:00
4461b7cbcc
Add folding support for the new mixin syntax
...
Change-Id: I8f37a391cc47a2203730c81acd5f1776cb386e2e
Reviewed-on: https://dart-review.googlesource.com/72521
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-31 17:33:36 +00:00
c22f0c6167
Add completion support for the new mixin syntax
...
Change-Id: I3a8744e03f32092c15f1e340e0ee6bef5245a859
Reviewed-on: https://dart-review.googlesource.com/72520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-31 16:59:18 +00:00
dbb1b2f4a6
Add 'Wrap with Container' quick assist.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I860a3a92024b349153266fd9e70b56beea426ee2
Bug: https://github.com/flutter/flutter-intellij/issues/2566
Reviewed-on: https://dart-review.googlesource.com/72260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-30 21:47:32 +00:00
e81c1c57de
Remove the workaround for a stale issue.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/25884
Change-Id: I87741664f00200170990e9a13d2f639c41671bda
Reviewed-on: https://dart-review.googlesource.com/71924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 15:33:17 +00:00
1f52372bfa
Remove CFE integration from analyzer, analysis_server, and analyzer_cli.
...
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.
Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 13:46:45 +00:00
f40ff153a9
Enable --use-fasta-parser with the analyzer by default.
...
Based on Devon's change at:
https://dart-review.googlesource.com/c/sdk/+/67090
Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2018-08-28 19:29:17 +00:00
19f6c826a4
Ensure we don't walk over closures when looking for argument lists
...
Bug: https://github.com/dart-lang/sdk/issues/34241
Change-Id: I21e9e8e1389e989aa3ad5ee98f63c497548ffd6b
Reviewed-on: https://dart-review.googlesource.com/71481
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-28 11:40:33 +00:00
83324a8db9
Fix for NPE when prefix completion after an expression without type.
...
R=brianwilkerson@google.com
Change-Id: I3ef1c1e1f981e3a5c9ed6da066a1d204c6b3816d
Reviewed-on: https://dart-review.googlesource.com/71620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-27 22:14:01 +00:00
aded927ff4
Fix cast exception in ArgListContributor (issue 34227)
...
Change-Id: Ib6db1fcab1b03059261fc35432794efd92524298
Reviewed-on: https://dart-review.googlesource.com/71188
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-22 19:04:35 +00:00
b63b73d46d
Cosmetic tweaks to how we train the analysis server.
...
Change-Id: I78785450820c3773cb17ce69561806c82d68ddf4
Reviewed-on: https://dart-review.googlesource.com/71182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-22 16:57:37 +00:00
fd00c0a4f7
Train analysis server with cfe too
...
Prior to this change the analysis server was trained in non-cfe mode
only, meaning that the playing field wasn't even.
This CL updates the training so both modes are trained, reducing the
cold server benchmark in cfe mode from ~76 to ~71 seconds on my machine.
This is still *way* more than the non-cfe version, but still.
Before:
```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
{analysis-server-cold-analysis: {micros: 15779864}, analysis-server-cold-memory: {bytes: 254571344}}
{analysis-server-cold-analysis: {micros: 15181035}, analysis-server-cold-memory: {bytes: 272837552}}
{analysis-server-cold-analysis: {micros: 15029866}, analysis-server-cold-memory: {bytes: 312474240}}
Finished in 49 seconds.
{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":15029866},"analysis-server-cold-memory":{"bytes":254571344}}}
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
{analysis-server-cold-analysis: {micros: 76810701}, analysis-server-cold-memory: {bytes: 1634409696}}
{analysis-server-cold-analysis: {micros: 74706698}, analysis-server-cold-memory: {bytes: 1565364624}}
{analysis-server-cold-analysis: {micros: 75798888}, analysis-server-cold-memory: {bytes: 1759452128}}
Finished in 228 seconds.
{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":74706698},"analysis-server-cold-memory":{"bytes":1565364624}}}
```
Now:
```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
{analysis-server-cold-analysis: {micros: 15064119}, analysis-server-cold-memory: {bytes: 302396944}}
{analysis-server-cold-analysis: {micros: 14909304}, analysis-server-cold-memory: {bytes: 273778864}}
{analysis-server-cold-analysis: {micros: 14934034}, analysis-server-cold-memory: {bytes: 353252928}}
Finished in 45 seconds.
{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":14909304},"analysis-server-cold-memory":{"bytes":273778864}}}
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
{analysis-server-cold-analysis: {micros: 70252048}, analysis-server-cold-memory: {bytes: 1650741520}}
{analysis-server-cold-analysis: {micros: 70853869}, analysis-server-cold-memory: {bytes: 1579162320}}
{analysis-server-cold-analysis: {micros: 71155850}, analysis-server-cold-memory: {bytes: 1579512288}}
Finished in 213 seconds.
{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":70252048},"analysis-server-cold-memory":{"bytes":1579162320}}}
```
Change-Id: I8fb75624c86605e7028a2b8483df85ebbd958b0d
Reviewed-on: https://dart-review.googlesource.com/70260
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-08-20 07:15:47 +00:00
Brian Wilkerson