dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
82,784 Commits 2 Branches 0 Tags
eda10ffe4bb1d1ea58ccbee8a89b6ae077208f27
Commit Graph

146 Commits

Author SHA1 Message Date
Ahmed Ashour c47cf76baf Fix typos 
Fixes https://github.com/dart-lang/sdk/issues/47505

Change-Id: Ic2e25800263e96b2b4282f89ec0be017c86d4adb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217361
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 10:51:53 +00:00
Konstantin Shcheglov 7ee2744a1f Issue 90868. Fix race condition in PluginManager.addPluginToContextRoot 
1. We start stopping the plugin in removedContextRoot.
2. We add the plugin to the map in addPluginToContextRoot.
3. We receive the notification that the plugin stopped, and remove the
   plugin by its path from the map.

The issue is that the map has already been updated to contain the newly
started plugin, with the same path. As a result, we forget that we have
a plugin started, and never stop it.


Bug: https://github.com/flutter/flutter/issues/90868
Change-Id: I46c294c555905f0e9f298044718b281cb890e8ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-28 20:54:02 +00:00
Brian Wilkerson 1ad68b9b16 Make local variables that hide fields be final (analysis_server) 
As per our earlier conversation, I looked for places where a local
variable was introduced to overcome field promotion and has the same
name as the field. Where possible I made them final; where not possible
I changed the name.

Change-Id: Iad3d2139693ca66f1eb22a3926c3b84a4115f13d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196552
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-24 18:12:07 +00:00
Brian Wilkerson fa1a28bf65 Migrate analysis_server.dart and other libraries in its cycle 
I plan to start migrating the associated tests next, but wanted to
unblock other work sooner (and minimize the size of the CL).

Change-Id: I83340208b116acca6f9a4c59d7dfceb625a39eb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195780
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-04-18 15:43:39 +00:00
Brian Wilkerson 14fea36798 Migrate some of the plugin support 
Change-Id: I5e8cdf215836470f8cf237f0da5155c0ac80e281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195042
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-04-12 20:07:16 +00:00
Brian Wilkerson 34873853d8 Migrate some of the plugin support in server 
Change-Id: I1294a33725ff0d0c3d2eb981c23211a8576f60f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194023
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-04 00:23:39 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Konstantin Shcheglov 114d7b980a Migrate analyzer_plugin package to null safety 
Bug: https://github.com/dart-lang/sdk/issues/45236
Change-Id: I01175a2b2b1eb3ce6cdf30ade794d8186c6e8ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 00:29:37 +00:00
Konstantin Shcheglov c8d6f85d0f Enforce lint unnecessary_parenthesis in analysis_server. 
Change-Id: Ib68c124988743b45807015e7274f429fff67fe44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 05:20:16 +00:00
Konstantin Shcheglov 34bec2f1a5 Deprecate AnalysisDriver.contextRoot 
Change-Id: I2dfb7f2f751e3c3ba7cdc11c94b9dfa5ddd35670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 19:35:11 +00:00
Sam Rawlins 6103487f9e Remove unused imports with shared prefixes 
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: I2c5477bbb36b17ad9ac4cf5e9584dd66f66afe1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-21 19:37:34 +00:00
Danny Tuppeny 31cc6df4fe [Analyzer] Compute code locations for LSP definitions 
Change-Id: Id52fefae11b0d779b860cb44e33bc36cc12e55bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161168
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-02 20:51:27 +00:00
Mike Fairhurst 0506475654 [analysis_server] Remove added space. 
Change-Id: I7a5c8fdfc318359904b9c4befe07ff0be186b446
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154125
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-11 04:17:32 +00:00
Mike Fairhurst dfd71a7e3d [analysis_server] Report plugin startup failures to instrumentation 
And don't report an issue stopping a plugin that crashed.

Change-Id: Ic079748e578a0a5331165bd60a3ed0e6cf44e3b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-07-10 20:04:26 +00:00
Danny Tuppeny 65671edd30 Support publishing errors (diagnostics) for plugins in LSP 
This splits Notification manager into an abstract base (which handles merging plugins notifications) and two concrete subclasses that can broadcast the notifications in the correct format for LSP vs DAS protocols.

Change-Id: I5fa2b643adc7bb46db0f06ddd2c997d8a736cbaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149162
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-29 17:39:06 +00:00
Brian Wilkerson 12dcfe63bb Start removing extraneous awaits from server 
Change-Id: I484227773e98d87c915f6dfe6e320dda1a7b8eaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144862
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-26 23:45:29 +00:00
Simon Binder aa529bc684 Support plugin notifications in LSP server 
This adds support for analysis domains that plugins contribute to by
sending notifications. I've only implemented folding so far, but most
of this CL is to cache results from plugins and to adapt sending server
capabilities.

Instead of using a NullNotificationManager, the LSP server now uses a
regular NotificationManager, except that results won't be forwarded to
clients. LSP handlers will fetch partial results from plugins and merge
them with data from the server that will be computed when needed.

I've extracted the server capabilities calculation from the init
handlers into ServerCapabilityComputer. It will also contain the
interestingFiles glob from active plugins and re-register capabilities
whenever plugins change.

Change-Id: I9869240cbfa284592e952498933e638b89a2a763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142981
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 20:36:07 +00:00
Danny Tuppeny b11da4d65e Get go-to-definition working with plugins for LSP 
Change-Id: I49c469a15a651718ed21850e6c1a8fac798392c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142378
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-09 17:01:19 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Brian Wilkerson 7e724e70b0 Sort non-generated files in analyis_server and add a test to ensure they stay that way 
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:03 +00:00
Brian Wilkerson f60536c194 Enable slash_for_doc_comments in analysis_server 
Change-Id: Id2734d4c9ce591c5746bb9aa55810c78183db38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-14 17:17:17 +00:00
Mike Fairhurst eff4807eef [analysis_server] Fix #36352, cannot stop a plugin that isn't running 
Report it as a silent exception. This way it will show up in log files
and (in the future) over crash reporting (since we haven't solved the
underlying cause), but *not* to users, because it currently appears to
be harmless.

In the future we should consider a "logged-only" type of exception, once
we are confident this isn't causing secondary issues, if we don't intend
to or think we are able to solve this at a deeper level.

Change-Id: I2ee339718fbd6e7c684ccc42718fbb57742f2dd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134467
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-02-05 17:13:59 +00:00
Brian Wilkerson 5b1065ac60 Enable avoid_init_to_null in analysis_server 
Change-Id: I1909b0d8939d9b436fce772bd97dc4835f1093ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-13 00:35:34 +00:00
Brian Wilkerson 32ce9c7872 Enable prefer_collection_literals in three packages 
Other than the following changes, all of the changes were made by dartfix:
- the analysis options files
- one line to enable the fix through dartfix (missed in an earlier CL)
- three places where a bug in the fix produced invalid code (issue and fix TBD)

Change-Id: If8660700792561805f4d1c96ccecd81abcebfeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131209
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-11 20:39:02 +00:00
Sam Rawlins 327b1eb24f analysis_server: Make private fields final where possible 
Change-Id: Ibdeb7e66f07bf81205d70ac5d1c4cb4aa5a97671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-01-08 22:08:02 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson c547f5d933 Enable prefer_generic_function_type_aliases in most of the packages 
Change-Id: I1338e731aa3f42f67fec605b20455a83fd5fce43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 00:43:14 +00:00
Brian Wilkerson 52c6620986 Enable unnecessary_const in analysis_server 
Change-Id: I44d9902cb23d005ebedd4bc37d57d3751a8ebdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 17:32:52 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Mike Fairhurst 58dde43b5e [analysis_server] don't create futures for stalled plugins. 
Also looks like "cannot stop a plugin that's already running" occurred
from this case, which was also an easy fix.

Change-Id: I113170e65ced26d1113cdb4e0cf206c8b1b68d31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-27 18:18:21 +00:00
pq 52abcd3dd2 apply prefer_equal_for_default_values 
Change-Id: I9b6fd3ee18ec834a5db3d0d25455b6db9ea4fbe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 19:31:40 +00:00
Konstantin Shcheglov 863f7df7aa Include debug info when dart:core is not resolved. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35226
Change-Id: I3064e1f2affae9b6fdd34b3740882cd06f293cba
Reviewed-on: https://dart-review.googlesource.com/c/94983
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-01 19:25:00 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov 2beed40848 Move Workspace and its implementations into src/workspace. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I172d95e55ced9925e8f428b9b07f432251ef5248
Reviewed-on: https://dart-review.googlesource.com/c/85462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-27 21:50:00 +00:00
Brian Wilkerson 20c75ccfb1 Remove more dead code from server 
Change-Id: I20689dc5fefd3a636f78b38929a886ea96d01e0f
Reviewed-on: https://dart-review.googlesource.com/c/80961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-20 00:30:51 +00:00
Peter von der Ahé ed42aab273 Move source.dart to package:analyzer 
Change-Id: Ide66d4f69b8588f04967c510eae0a733b4b3f0c5
Reviewed-on: https://dart-review.googlesource.com/c/77860
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:56:49 +00:00
Brian Wilkerson 978f12c17f Use void in place of Null in analysis_server 
Change-Id: Ifef805cb3c0111e237a6147f71a968958d5651e5
Reviewed-on: https://dart-review.googlesource.com/69560
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-13 13:16:53 +00:00
Mike Fairhurst 010828ada4 Fix issue with pub upgrade not running on existing plugins. 
Code trying to run "pub upgrade" was blocked behind "runPub" being
false. Instead, expect the pub command to run. If the folder exists, run
"pub upgrade," and if it doesn't, run 'pub get'.

Change-Id: Ia37bf11d08e921e31d2ed4410210d03b8dbe1b00
Reviewed-on: https://dart-review.googlesource.com/69440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-08-10 23:24:43 +00:00
Brian Wilkerson b0636e1b09 Improve an error message 
Change-Id: I95cbc725c019dc1efce8d56940d1db167c343138
Reviewed-on: https://dart-review.googlesource.com/67202
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-07-27 21:01:47 +00:00
Peter von der Ahé 64a1f8f69c Prepare for upcoming void usage semantics 
Change-Id: I30d92ffb88338036aebed4e6891ce8e5737bf81f
Reviewed-on: https://dart-review.googlesource.com/65322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-07-17 15:36:38 +00:00
Devon Carew 76d1a9b7d1 Fix a runtime types issue in the plugin channel with reported error messages. 
Bug: https://github.com/dart-lang/sdk/issues/33808
Change-Id: Ibe79fff9f9c4aecd36c24354f82740e4d00f5f01
Reviewed-on: https://dart-review.googlesource.com/64620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-11 19:12:35 +00:00
Brian Wilkerson 7be47cd30d Remove some dead code (including implicit setters) 
Change-Id: I524ced04dafe862afda0352ac36d65be383eaca5
Reviewed-on: https://dart-review.googlesource.com/60703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-19 13:29:46 +00:00
Brian Wilkerson f6d2c2378a Add awaits in async methods to restore previous semantics 
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-08 19:58:07 +00:00
Brian Wilkerson 7328988ad0 Remove some dead code from analysis_server 
Change-Id: I6407d800bca7f81e6bcf0fb1e0765e24fe310956
Reviewed-on: https://dart-review.googlesource.com/54980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-14 18:57:17 +00:00
Konstantin Shcheglov 818c4b5bfd Remove AbsolutePathContext and use package:path instead. 
I see however that linter/test/rule_test.dart uses it, but as far as I
can see, that's it. All other usages are from analyzer and
analysis_server.

R=brianwilkerson@google.com

Change-Id: I2b82870a4a4ec6f155326d8ee6dc1c1028f84793
Reviewed-on: https://dart-review.googlesource.com/52265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-20 21:01:06 +00:00
Brian Wilkerson 5460ddbab5 Move three more libraries out of the public API 
Change-Id: I8e6aeaea35c739fb26e22ffcfc30a343ebbb5424
Reviewed-on: https://dart-review.googlesource.com/51363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-16 22:15:28 +00:00
Mike Fairhurst a35bf88f9d Run pub upgrade on analyis plugins before (re)start. 
Change-Id: If3f550d2a5812e47fc527c237384abb9cb0b79a7
Reviewed-on: https://dart-review.googlesource.com/49837
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-11 19:16:36 +00:00
Kevin Moore af22f6a591 Track calls to 'pub get' from analysis_server 
Fixes https://github.com/dart-lang/sdk/issues/32712

Change-Id: I04825e03e57dd2c45de7a332942c0a8e6415286d
Reviewed-on: https://dart-review.googlesource.com/48800
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 22:29:49 +00:00
Brian Wilkerson d06dbb2ba8 Make most of the server Dart 2 safe 
Change-Id: Ic9e8ea2557d01c05caedc126486778865af0396d
Reviewed-on: https://dart-review.googlesource.com/48262
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-24 15:33:53 +00:00
Konstantin Shcheglov e1909cb52a Update Outline protocol - change offset/length, add codeOffset/codeLength. 
R=brianwilkerson@google.com

Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 01:52:57 +00:00