dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
68,381 Commits 2 Branches 0 Tags
ecaa3e643aafc0fbbbc3b671b8342602a07178ed
Commit Graph

4472 Commits

Author SHA1 Message Date
Ivan Inozemtsev 82c9950e9c Reland "Fix completion in Analysis Server LSP mode" 
This is a reland of ec8fc01d3b

Original change's description:
> Fix completion in Analysis Server LSP mode
>
> Looks like it was initially broken in
> https://dart-review.googlesource.com/c/sdk/+/122962
>
> Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I06e1dea28e4510334e3fc4f887455a81ccdec916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125975
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2019-11-22 14:28:54 +00:00
Ivan Inozemtsev a2bf8153af Revert "Fix completion in Analysis Server LSP mode" 
This reverts commit ec8fc01d3b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix completion in Analysis Server LSP mode
> 
> Looks like it was initially broken in
> https://dart-review.googlesource.com/c/sdk/+/122962
> 
> Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,dantup@google.com,ariaye@google.com,iinozemtsev@google.com

Change-Id: If4a86634335c3e962b37c1e97532f05ee8b9d28d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125974
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2019-11-22 10:35:45 +00:00
Ivan Inozemtsev ec8fc01d3b Fix completion in Analysis Server LSP mode 
Looks like it was initially broken in
https://dart-review.googlesource.com/c/sdk/+/122962

Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-22 10:25:31 +00:00
Jaime Wren fee8c5503c Mark the completion.registerLibraryPaths as deprecated in the Dart Analysis Server. 
Change-Id: Ia0b305d9ebaf1a5416994e1fa0959a29d043a87b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125930
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-11-21 22:16:38 +00:00
Konstantin Shcheglov f979bd9899 Merge RestrictedAnalysisContext into AnalysisContextImpl. 
We don't have any useful / old API(s) in AnalysisContextImpl,
so the distinction between these two does not exist.

Change-Id: I87ef84bc728cc1c2c0e269c695419c425afb6559
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:58:16 +00:00
Konstantin Shcheglov dcaf959589 Fix several unused elements, and unnecessary casts. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I81559cb241c0ca6918f6730538f44a7411907867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125986
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:37:52 +00:00
Sam Rawlins 535cbf5db9 NNBD preview: Text for return type with nullable return type in subclass 
Change-Id: Ia829b3f8cb7f09b10180478394608a05cdcdbb6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125984
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-21 21:07:25 +00:00
Brian Wilkerson 655ddc90b4 Print a URL that can be used to open the preview tool when a port is specified 
Change-Id: Ia22ce6fa6f42bbcc13c9688d35f7bc72028ae39f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125928
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-21 18:20:15 +00:00
Konstantin Shcheglov 615928c514 Stop referencing non-API TypeSystem in analyzer. 
Replace it with TypeSystem from lib/dart/element/type_system.dart,
or (internally) with TypeSystemImpl.

We keep the old TypeSystem where its is exposed from API:
- ResolveResult.typeSystem
- AnalysisSession.typeSystem
- AnalysisContext.typeSystem

  We will make changes to these as a breaking change later.

Change-Id: I40ca53ea77e440457c6d0f3832ec3b6286bacdf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 01:09:24 +00:00
Kevin Moore 8342ec2c71 Fix pub.dev URLs throughout SDK repo 
Change-Id: I5bcb7c40be12ee1dc887620281b4807469d67bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125729
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-11-20 11:30:48 +00:00
????? 6546460461 chore(doc): fix typo 
Closes #39128
https://github.com/dart-lang/sdk/pull/39128

GitOrigin-RevId: f03a58d8dd0a486021eb0d5e51e01383cef48f6e
Change-Id: Iedc2caca99963b26c73b43f65e32be59e750bca7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123061
Reviewed-by: Michael Thomsen <mit@google.com>
 2019-11-20 11:27:58 +00:00
Brian Wilkerson f31fb0386b Catch exceptions during ranking and disable smart ranking 
Change-Id: Ib24a5a16da0fdfaf6d8504adab5c087ecec3abf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-19 20:06:29 +00:00
Paul Berry 0d40d3736b Change mocks.dart to triple-slash comment style 
Change-Id: I157e67f3d893058fc00732dc8eda6fe2729fa805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125548
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-18 23:04:10 +00:00
Paul Berry bbe5d38c0e Add a script to analysis_server/tool for testing out NNBD migration. 
The tool is configured with a .json file so it can access directories
specific to the user's machine without needing hardcoded paths.

Change-Id: Ifb38e1d0334628b24c50ded3a30fd12822876093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-18 22:26:00 +00:00
Paul Berry c0144141ce Move TestPluginManager, MockServerChannel, and ServerError into utilities 
There's no reason these classes need to be in test, and I want to
re-use them in a tool for testing NNBD migrations.

Change-Id: I43686a44d5f8d83f0d1cc23315746250eb766681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125485
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 22:26:00 +00:00
Paul Berry 28d9eaf230 Migration: Go ahead and generate migration output files even when a port is given 
Change-Id: I5912834d4cdf53ea3baab0dd15acd2df982ca5a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 22:26:00 +00:00
Jaime Wren bc449f160b Fix for dartbug.com/39401 -- quick fix improvement around angular generated files 
Change-Id: I363b8f14363a53f01fd170e36752a3f0a9ec8e48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125412
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 20:58:35 +00:00
Sam Rawlins ed971fd0c7 NNBD migrator: Add Locations for each edit made in an NN fix 
Change-Id: I53342cb43910deea2f59f37d5795ddbb70cb6b0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125480
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 20:40:25 +00:00
Mike Fairhurst e34e734b56 [nnbd_migration] track causations for substitution nodes 
Change-Id: I7da4f2923d9b99b0bd6c16644a7adeaeda437340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125463
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-18 18:49:39 +00:00
Sam Rawlins 7905e78db2 NNBD preview: Better messaging for non-late uninitialized variable 
Change-Id: Ica0433154f0f72d6f79159a77e0b784bdb1d6f40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-18 18:28:23 +00:00
Paul Berry f69935b107 Migration: stop creating union edges for inferred types. 
Fixes #38341.

Change-Id: I77e6bebc28ca917a13e5fd9958f5a7b3e0284834
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-18 17:14:23 +00:00
Brian Wilkerson 1ae6f1b031 Support for creating and displaying edits in the preview tool 
Change-Id: I2284ceeb0229d7111022eb3759e39752264f1bc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125492
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 16:14:43 +00:00
Konstantin Shcheglov 8fbb053092 Issue 39021. Guard against invalid generic type alias, without function type. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39021
Change-Id: I0259ef04f95e1935ca273b5540aafb069c7ad455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125526
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 16:06:53 +00:00
Konstantin Shcheglov fe3fadbdba Issue 39025. ForEachPartsWithIdentifier does not define anything, don't pretend that it is a LocalVariableElement. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39025
Change-Id: Ieda56c73a1928434a29aa947c44fc29b66a79464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:44:13 +00:00
Konstantin Shcheglov 3a17bebf9c Issue 39028. Guard against mixin constructor in FieldFormalParameter completion. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39028
Change-Id: I78e4df6baa8424231aeb2c8044d9cb5c685dcdbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:36:48 +00:00
Jaime Wren f3ee4d0fe5 Add a failing test case for http://dartbug.com/39401 -- quick fix improvement around angular generated files 
Change-Id: I784baefaa41db4e45c183335b73e7bb33991070a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-11-15 22:30:16 +00:00
Sam Rawlins 15e5c23167 nnbd preview tool: Better text when inserting 'required' 
Helps with #39247

Change-Id: I3bb7b25c73d58fc49260d6e3019b58b2f3f6b80a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125440
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-15 22:20:16 +00:00
Mike Fairhurst a6635d006b [nnbd_migration] Show "exact nullability" in output directory. 
Change-Id: I29545fe358282aa05dee10ed7ff5e86ea899581e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125222
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-15 18:27:24 +00:00
Brian Wilkerson faa4eb7808 Partial support for an incremental workflow 
Change-Id: Ibc18be75d5b4aada7c27cdfae559bd829bd50215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125421
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-15 17:01:45 +00:00
Sam Rawlins 70892fff0c nnbd preview tool: text for uninitialized field 
Change-Id: Ie77c381c5e1f80e3efcf861d2cea15850fc9af54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125304
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-15 04:05:05 +00:00
Mike Fairhurst 812c8d830f [analysis_server] remove unused class WatchManager 
Change-Id: I3b0a4723447e4988611a09c6456b470931b0996f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125300
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-14 21:51:29 +00:00
Mike Fairhurst 8db87ad6e5 [analysis_server] Report lowest exception to API/crash reporting 
Change-Id: I6db4612e0342c0f5208e7bce420964c7f0de1966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124912
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-14 16:33:46 +00:00
Sam Rawlins 06aef10d76 nnbd preview: Remove descriptionPrefix; don't link Details which will link to some bizarre Never node 
Bug: https://github.com/dart-lang/sdk/issues/39247
Change-Id: I6f34ecf745e8db75534affdeadc3d47acac079b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125062
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-14 01:09:35 +00:00
Brian Wilkerson de498e9655 Add the generation date as a footer to the preview page 
Change-Id: Ic9e3141046c85facdae5883abf8767a29f90f6d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124907
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-13 23:44:00 +00:00
Paul Berry 8452d2d188 Migration: change behavior of dynamic. 
Previously, when the migration engine found a type that was implicitly
or explicitly dynamic, it assumed the type was meant to be nullable.
This seemed reasonable (since, after migration, `dynamic` indeed
allows null), but it caused unnecessary nullabilities to be
propagated.  With this change, the migration engine tracks whether
dynamic types can be nullable or not, just as it does for all other
types.  This cleans up a number of tricky corner cases in the
migration engine that were getting in the way of fixing up uses of
`always` and `never` nodes.

Note that if a `dynamic` type is determined to be non-nullable, it
will still be `dynamic` after migration; this change merely prevents
nullabilities from being needlessly propagated from that dynamic type
to other types.

Note that we still assume `dynamic` is nullable when it occurs in an
already-migrated library or as the result of a dynamic dispatch.

Change-Id: I380d0907f3489d0b84f3fdd7164113daae24274e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-11-13 23:10:15 +00:00
Konstantin Shcheglov 30690b1526 Issue 39357. Catch FormatError and report FLUTTER_SET_WIDGET_PROPERTY_VALUE_INVALID_EXPRESSION. 
Bug: https://github.com/dart-lang/sdk/issues/39357
Change-Id: Ia0d5eb7907dbe16ad03dd70a4f3ede226c2edaaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125129
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-13 22:41:55 +00:00
Sam Rawlins 26f160b9c4 nnbd preview: Fix positioning of #content HTML, allowing for footer 
Change-Id: I93ce26fe337758a047f02f8026eeab21b0004de5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125127
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-13 22:09:35 +00:00
Brian Wilkerson bc4ced0738 Fix the list of migrated files to not include non-migrated files 
Change-Id: I87010a5f1e318ef074791fd706d3d6a32262a0bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125142
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-13 20:31:44 +00:00
Sam Rawlins 858265d0b4 NNBD preview: Link to spans rather than anchors 
Fixes https://github.com/dart-lang/sdk/issues/39374

Change-Id: Ifcde796822a5c58608f5432874d70b0a17d69217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-13 19:42:44 +00:00
Sam Rawlins 39194779c1 nnbd preview tool: Add better text for dynamic values 
Change-Id: I926970d765a9cfb9b2d96f8180e8388516d8ebfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-13 18:36:00 +00:00
Brian Wilkerson ffbd2eb7ee Address comments from an earlier CL 
Change-Id: I6a47cb76e6babeea422791fb6b1887dd244c2f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-13 17:10:09 +00:00
Johnni Winther 6ed0fcaa12 [analysis_server] Remove last dependency on front_end+kernel 
Change-Id: I0a8d1692ac1c8297bc7848a3f37fe97f8a8d3b29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123735
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-13 10:07:48 +00:00
Konstantin Shcheglov c9ef7cc5e3 Deprecate Member.baseElement, use Element.declaration in analyzer. 
Change-Id: I91d23558c7d0bd8ffa2e251e5d615d4e026923b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124940
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 22:35:07 +00:00
Paul Berry 12265c4e42 Hacky prototype of how to fix the seventh item from #39247 
The issue is:

  lib/src/logger.html, line 107, inserted !:

  In this case the single reason detail reads "node with no info (type(2171))" with no destination.

The problem is that InstrumentationInformation.nodeInfoFor is only
considering a limited set of possible sources of nullability nodes
(the primary nodes of decorated types passed to the instrumentation
listener methods `implicitReturnType`, `implicitType`, and
`implicitTypeArguments`).  It needs to also consider decorated types
passed to `explicitTypeNullability`, `externalDecoratedType`, and
`externalDecoratedTypeParameterBound`, and it needs to walk these
decorated types recursively to discover all the nodes they point to.

Additionally, the logic in InstrumentationInformation.nodeInfoFor is
inefficient; it walks through all the implicit types in every source
file, which means that it is O(N) in the size of the code being
migrated.  Since it is called O(N) times, this is an overall runtime
complexity of O(N^2).

I've prototyped a possible fix using an expando to compute
NodeInformation for each node once at the time it's reported to
instrumentation.  This is incomplete and intended as a starting point
for discussion.  Work that still needs to be done:

- We don't produce a sensible description string for nullability nodes
  associated with AST nodes, so we present unhelpful text to the user
  like "A nullable value can't be used as the explicit type ???"; it
  would be nicer to say something like "A nullable value can't be used
  as positional argument 0 of Level.>=".  We may want to consider
  modifying the instrumentation API to make it easier to generate a
  useful string here.

- I haven't verified that the description string we produce for
  external decorated types is helpful.

- I haven't verified that the we produce a useful link for external
  decorated types.

- We should probably get rid of the data structure
  NodeInformation.explicitTypeNullability (which has similar
  inefficiencies) and change over code that was using it to use the
  new approach.

Change-Id: I2cf2fe47cd70d7e5cc6e3da309851288668e8a62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124902
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 22:18:01 +00:00
Mike Fairhurst 942419e6ba [analysis_server] Funnel sendServerErrorNotification through logException 
Change-Id: I266a8b3c404da8c9892aa6e1a49e1f1c9bdcf530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-12 21:45:24 +00:00
Mike Fairhurst 26cabb72c3 [analyzer] Add [SilentException] where previously not reported to users. 
New errors *not* changed to silent exceptions:

https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analyzer/lib/src/dart/sdk/sdk.dart
https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analysis_server/lib/src/analysis_server_abstract.dart

These seem worth keeping.

Change-Id: I534b07f6cf50c5b251867b647ed6df96a9134c56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-12 21:37:49 +00:00
Devon Carew d355778418 [analyzer] rate limit the crash reports we send 
Change-Id: I9f6af7fbcec653a2a9396d1098bea678777d4b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124761
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-12 21:37:22 +00:00
Brian Wilkerson 667f77ed60 Add an http server for the interactive preview mode 
Change-Id: I727cc2b3d393b426f09a06e7b89c115864581962
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124760
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-11-12 17:39:22 +00:00
Brian Wilkerson 63c67a6768 Ignore zero length regions in the preview tool 
The zero length regions are being produced when server indicates that
navigation ought to target an unnamed constructor, a closure, a library,
or any other unnamed element. This might be a bug in server's navigation
support, but I don't want to have to fix that before the preview tool
can be used in a UX study.

Change-Id: I35c9978d38937006ee00d76516f3ee607fca6850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124860
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 14:34:28 +00:00
Konstantin Shcheglov 6cde7ce224 Deprecate synthetic FunctionTypeImpl constructor. 
Change-Id: I7c2f834d7e9e532709b3d43b348e7588be659af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124595
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-11 19:38:53 +00:00