dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
89,340 Commits 2 Branches 0 Tags
ec6fcf34bb11353882ce18ff032dbd4aede2ca06
Commit Graph

271 Commits

Author SHA1 Message Date
Alexander Thomas b9b6511ca6 Spelling sdk 
Closes https://github.com/dart-lang/sdk/pull/50918

Co-authored-by: Josh Soref <jsoref@gmail.com>
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2023-01-20 12:37:49 +00:00
Danny Tuppeny 0f065ef477 [dds/dap] Support showing Record fields in debugger views 
Change-Id: I799d30995dc1d1f8cd0c0bad79bf7305e5dbc1ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279353
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-19 16:38:47 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Danny Tuppeny 4fdbe1b47d [dds] Pass existing DDS URI in existingDdsInstance exception 
Work towards a better fix for https://github.com/flutter/flutter/issues/118609.

Change-Id: I7db8bd74cc272a2bb1df3a04e6f1d7b82b877ddb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279175
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-18 20:36:07 +00:00
Danny Tuppeny 7734f11b3b [dds/dap] Switch SILENT_OBSERVATORY to SILENT_VM_SERVICE 
+ remove some other Observatory references.

Change-Id: I06d1085b2e0cc82f756bf45178b824382283762a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279085
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-16 18:37:25 +00:00
Ben Konyi 0a0c90e37a [DDS] Prepare for 2.7.2 release 
Change-Id: Ifb4cac218b2723e52b76936a6b8275fed6a3a3d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279121
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2023-01-16 16:31:28 +00:00
Ben Konyi 3a77ebda65 [ DDS ] Ignore method no found responses for streamCpuSamplesWithUserTag 
DWDS does not implement streamCpuSamplesWithUserTag and DDS can invoke
it without being prompted to by a client. This change gracefully handles
the absence of this RPC.

Related DWDS change: https://github.com/dart-lang/webdev/pull/1889

Change-Id: Ic821f39caefd25044c2c4a8b34a8271879c7bd5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279020
Reviewed-by: Elliott Brooks <elliottbrooks@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-13 17:55:01 +00:00
Danny Tuppeny 3949fe9aec [dds/dap] Forward toolEvents on to the DAP client 
Progress towards https://github.com/Dart-Code/Dart-Code/issues/4193.

Also related:
- https://github.com/flutter/flutter/pull/118098
- https://github.com/dart-lang/sdk/commit/4981cbffe2f66db3a0cc8eced18085e03fbbb8ba

Change-Id: I7b1394a5d5003c24b90733f1898fe368c0485937
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278515
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-13 17:49:12 +00:00
Derek Xu ac23909288 [pkg:dds] Update pkg:vm_service dependency to >=9.0.0 <11.0.0 
Change-Id: I6525b63c854dff454700425e142dc69a850169ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278946
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-01-13 15:56:23 +00:00
Ben Konyi ab5b7d7ad1 [ DDS / VM Service ] Simplify DevTools URI construction 
DevTools no longer expects a fragment (i.e., '#') in its path, which was
causing issues when attempting to redirect to an external DevTools
instance.

Also removes unnecessary query parameter encoding.

TEST=Existing tests

Change-Id: Ifbeba62c173141a754951527f44ab337318a21d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278669
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-11 21:22:50 +00:00
Derek Xu 9a7d8857ec [pkg:dds, pkg:dds_service_extensions] Update pkg:vm_service dependency to ^10.0.0 
Change-Id: I93d0690edf2bc9b21ac39707ed5dceb2488901b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-01-11 18:01:43 +00:00
Ben Konyi 52f62eaea8 [ package:dds ] Add support for registering external DevTools servers with DDS 
External DevTools instances can be registered with DDS at runtime, allowing for DDS
to redirect DevTools requests to the external DevTools server.

TEST=pkg/dds/test/external_devtools_instance_test.dart

Change-Id: I0bed34029b6ea7d935f77a031ff99b73b986b068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278663
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-10 16:03:41 +00:00
Danny Tuppeny 5b50a61918 [dds/dap] Fix handling of errors when fetching full strings 
Fixes https://github.com/dart-lang/sdk/issues/50802.

Change-Id: Ia2bda968708f34aa48c6b92b2f19c24c603fb85c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278349
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-06 16:54:03 +00:00
Ben Konyi 112e1213dc [ package:dds ] Prep for 2.6.0 release 
Change-Id: I7ffcd1c9cdf23906324ef77521216bb293259c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276620
Reviewed-by: Dan Chevalier <danchevalier@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-06 15:26:34 +00:00
Danny Tuppeny ec8918c20c [dds/dap] Handle errors parsing/casting launch/attach arguments and provide useful errors 
Fixes https://github.com/dart-lang/sdk/issues/50709.

Change-Id: I35a7593ced462ab81d52069db831e5f95a9a4ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275623
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-12-14 17:19:05 +00:00
Dan Chevalier fd6fa010ec [ VM Service / DDS ] Add custom service stream support (Revised) 
NOTES:
Original CL: https://dart-review.googlesource.com/c/sdk/+/274061
Revert CL: https://dart-review.googlesource.com/c/sdk/+/274802

Regression tests that failed after merging Original CL:
- https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/24046/overview
- https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release-arm64/5999/overview

----------
DESCRIPTION:
Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS.


The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code.

TEST=Made sure that regression from original PR could be reproduced, and then resolved by applying this change. Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients

https://github.com/flutter/devtools/issues/4533

Change-Id: I2b04a84b4daf11dd9d72f899928b5e1f62a5ae02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275121
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-12-13 16:31:37 +00:00
Dan Chevalier 3ed65601b0 Revert "[ VM Service / DDS ] Add custom service stream support" 
This reverts commit 4981cbffe2.

Reason for revert: Mac regression test failed.

Original change's description:
> [ VM Service / DDS ] Add custom service stream support
>
> Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS.
>
>
> The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code.
>
> TEST=Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients
>
> https://github.com/flutter/devtools/issues/4533
>
> Change-Id: I870dc634c9a9a7d2ee3a6605319c2a18517ad197
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274061
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Dan Chevalier <danchevalier@google.com>

TBR=bkonyi@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com,danchevalier@google.com

Change-Id: Ia1dce25444a6329c0553c931c9a6dbbec65ee583
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274802
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Dan Chevalier <danchevalier@google.com>
 2022-12-12 11:24:37 +00:00
Dan Chevalier 4981cbffe2 [ VM Service / DDS ] Add custom service stream support 
Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS.


The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code.

TEST=Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients

https://github.com/flutter/devtools/issues/4533

Change-Id: I870dc634c9a9a7d2ee3a6605319c2a18517ad197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274061
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Dan Chevalier <danchevalier@google.com>
 2022-12-09 20:18:30 +00:00
Danny Tuppeny c53f70509c [dds/dap] Filter private getters from debug views 
These will fail unless the current stack frame happens to be in the library that declares them, which results in a lot of exceptions being shown in variable views.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4296.

Change-Id: I5919e391f25a08920dcdf1bf648526d175af00f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274040
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-12-08 15:02:04 +00:00
Devon Carew 99026df0f8 [deps] update package:webdriver 
Change-Id: Iaa875c46f1425160063b5cc5f44e87a60c5e61dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2022-12-01 17:42:21 +00:00
Danny Tuppeny 4cd0ef7402 [dds/dap] Address code review nits 
Change-Id: I7a03650ba1d8df7b0f11db3408f9e55525b61aa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266580
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-10-31 17:23:52 +00:00
Sam Rawlins 1739cc6d89 Add BODY_MIGHT_COMPLETE_NORMALLY_CATCH_ERROR hint 
This is similar to BODY_MIGHT_COMPLETE_NORMALLY (the static error),
BODY_MIGHT_COMPLETE_NORMALLY_NULLABLE (the Hint for nullable return
types), and RETURN_OF_INVALID_TYPE_FROM_CATCH_ERROR, combining the
rules from each.

https://github.com/dart-lang/sdk/issues/49215 (but maybe doesn't close,
if the core issue is the VM issue)

Change-Id: I9a010e5a3f0f88abfdab479339e5e76759ae9d92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247863
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-27 18:21:47 +00:00
Danny Tuppeny 37be66028b [dds/dap] Allow debug adapters to register multiple mappings for org-dartland-sdk URIs 
Change-Id: Ibcb0f145d64c7cd7712c031737741b2dbc4aaab8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265500
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-26 14:26:01 +00:00
Danny Tuppeny 96294014e3 [dds/dap] Allow debug adapters to override the org-dartlang-sdk URI for the Dart SDK 
Change-Id: I74432315d4bfa8e9890e0bd86fa0fa67d591f7fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265322
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-25 14:03:29 +00:00
Danny Tuppeny bc7094dbc1 [dds/dap] Ensure "terminated" event is sent when detaching from processes 
Change-Id: I466f97c2d98649b77412396e462bf3ae9c9e7f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264481
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-18 13:26:35 +00:00
Danny Tuppeny ae352fe940 [dds/dap] Improve handling of lists in variables requests 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4204.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4213.

Change-Id: Ibd95a149e6f620efb690c24623bb6b9d04a794b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263620
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-17 21:51:36 +00:00
Danny Tuppeny 946eec8330 [dds/dap] Optimise computing line/col for stack frames 
See https://github.com/Dart-Code/Dart-Code/issues/4209 / https://github.com/Dart-Code/Dart-Code/issues/4208.

Change-Id: I62f029d50e7b0b1964868c9221ca7b0a387dc23a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263300
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-10 18:22:23 +00:00
Danny Tuppeny e2d63974a7 [dds/dap] Fix flaky test 
We shouldn't fail ("Future already completed") if the timing allows multiple errors from the bad input to arrive during the test run.

Change-Id: I358b8401b865c22d5808c22e463dea0e6416f6ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261602
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-28 13:47:46 +00:00
Danny Tuppeny 17bd00df50 [dds/dap] Attempt to fix flaky tests on Linux during shutdown while debugger is initializing 
Fixes https://github.com/dart-lang/sdk/issues/50058.

Change-Id: Ia0b498a4f1c943bc1f21f940c533584837ba5311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261401
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-09-27 15:43:13 +00:00
Danny Tuppeny fe8c22cc69 [dds/dap] Support sending standard and custom progress notifications 
This adds the ability to send DAP progress notifications to the client. In this change, the CLI adapter sends them when connecting to the debugger, although the main motivation is to provide feedback when Hot Reload/Hot Restart is in progress (which will be handled in the Flutter adapter once this rolls in).

Additionally, a flag allows sending custom notifications because VS Code's standard handling of notifications (which delays showing them for 500ms) does not work well for Flutter hot reload/hot restart (which can often complete in less time than that) so sending custom events allows the Dart extension to show the progress immediately instead.

Change-Id: I1c91da6dc023b3d2d6cf3c6e8b8bbb53ee5167d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261102
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-09-26 15:26:47 +00:00
Ben Konyi 4eda3397f3 [ DDS ] Fix IsolateManager.initialize() not correctly handling Sentinel responses 
Fixes https://github.com/flutter/flutter/issues/111926

Change-Id: Iabde854f74410c0eb85f1e4d4ac24f6756395ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260220
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jason Simmons <jsimmons@google.com>
 2022-09-20 18:51:05 +00:00
Ben Konyi db6311beca [ DDS ] Fix IsolateManager.initialize() not correctly handling Sentinel responses 
Fixes https://github.com/flutter/flutter/issues/111482

Change-Id: I11eff2c140ea621550f33e2ddf0ab8092e9248db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259400
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2022-09-15 13:56:43 +00:00
Danny Tuppeny 1b9adcb502 [dds/dap] Normalise Windows drive letters to avoid missing breakpoints 
See https://github.com/dart-lang/sdk/issues/32222.
See https://github.com/Dart-Code/Dart-Code/issues/4149.

Change-Id: I6f975734839ff7cad4d086d5363c0ab03390b966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258900
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-13 13:24:47 +00:00
Danny Tuppeny 70e8dc6ee4 [devtools] Ping browsers running DevTools before trying to reuse them 
It's possible the browser has been closed but is in the SSE timeout period and therefore looks active. Ping it to see if it's actually responsive before deciding whether to reuse it or launch a new window.

Fixes https://github.com/Dart-Code/Dart-Code/issues/3966.

Change-Id: I2fdcba036b8b63f7ab974e8fef5dd565c2917b64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257581
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-07 17:38:57 +00:00
Danny Tuppeny 94a64a01f6 [dds/dap] Handle duplicate breakpoints and failure to remove breakpoints 
Fixes https://github.com/flutter/flutter/issues/111045, along with another issue where multiple client breakpoints that map to the same VM breakpoint could cause an error during removal.

Change-Id: Ifb396b9cb9df4a0297a4b55b31494e229289191d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257962
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-07 13:50:27 +00:00
Danny Tuppeny 6c8bacc73a [dds] Remove unused parameter from DartDebugAdapter.connectDebugger 
Change-Id: Ib3d3edd4ca1f7a8491a98c764c78045abd075b3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257641
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-06 14:53:46 +00:00
Danny Tuppeny 56f8caa9d4 Mark env as required on DartAttachRequestArguments 
Fixes a TODO.

+ some minor comment improvements.

Change-Id: I1f6249376e3891e0d20f01269493ffcc4d9aec55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-08 13:33:20 +00:00
Danny Tuppeny 09bcc1f4ae [dartdev] [dds] Share DevTools arg parsing with serve_local script 
Change-Id: Ia8f95b205fda1201a7ec50805a84d374a6201f39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-04 20:32:14 +00:00
Helin Shiah 884cfae2c7 Make changes for internal debug 
- Convert to google3:/// scheme and call `lookupPackageUris` for setting
  breakpoints
- Return file:/// scheme URIs from DDS

Change-Id: If9a541be21f5830ec68dc39eb2f308f7ce90c5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252782
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-28 18:30:10 +00:00
Danny Tuppeny 627481bae1 [dds] Bump to version 2.2.6 and add changelog entry 
Change-Id: Ie3f4710c80129f43f556f62b9b733e2e04e32850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252361
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-27 17:18:13 +00:00
Danny Tuppeny 38dc6e7dc8 [dds] [dap] Ensure debug adapter shuts down on clean termination 
Change-Id: I1baa77dd933a49c1df435ccc31eb6cf8995e3ff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252660
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-25 19:18:49 +00:00
Ahmed Ashour 99f0fb5b70 Fix typos 
Fixes #49364

TEST=ci

Change-Id: Ic643819c9cdd7b56690981b96b854b1e8d622fff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-12 19:35:22 +00:00
Ben Konyi cc92eb0a7f [ CLI ] Fix LateInitializationError in DartDev when passed an invalid flag 
`log` was previously initialized after argument parsing had already
taken place, which caused an exception when an invalid flag was passed
to DartDev as `log` was referenced in the `dart fix` command
description, which is accessed when building the usage message.

Also fixes a minor test failure related to usage line lengths not being
set correctly for `dart devtools`.

Fixes https://github.com/dart-lang/sdk/issues/49437

Fixed: 49437
Change-Id: Ib367677db5f34d7b6da31e51dbe717c954298ecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251241
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-12 18:22:42 +00:00
Danny Tuppeny 2a440e14f1 [dds] Include exception text in DAP StoppedEvent text field 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4039.

Change-Id: Ibe362a3eaaea1ab9b6075501cb9a245d8daba737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250745
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-07 13:15:01 +00:00
Helin Shiah 4ac76c7f35 Update devtools_shared version 
Change-Id: I2082552f00fc1117c76eb675605f0cb0cd26d270
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249548
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-23 17:15:29 +00:00
Danny Tuppeny eb6aa221f0 [dds] [dap] Fix bug that tried to remove previously-removed breakpoints 
Fixes https://github.com/flutter/flutter/issues/106369.

Change-Id: I17fb46ad0ea0f30707ff6280f2e8269662e376f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249485
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-23 13:42:55 +00:00
Ben Konyi c75f794913 [ DDS ] Prepare for 2.2.3 release 
Change-Id: I348fe14a1a49a912688dfc68394a993c079770a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249341
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-06-21 15:34:24 +00:00
Danny Tuppeny fe8dd70d47 [dds] Extract sending debugger URIs into a method that can be called by other adapters 
Flutter needs to send Debugger URIs to the client in some cases where we're not connected ourselves (profile mode, where the IDE wants a VM Service for DevTools, but is not debugging).

Change-Id: I901ca02be7c0bfff5130f2e41b83923b1d518e76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249300
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-06-21 14:48:34 +00:00
Danny Tuppeny 51eed0cffd [dds] Fix code generation for type references to simple types 
Fixes https://github.com/dart-lang/sdk/issues/49268.

Change-Id: Iaeda8271d8cb922511958a71cf1300ba64df16da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248605
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-17 18:26:09 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00