dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
89,340 Commits 2 Branches 0 Tags
ec6fcf34bb11353882ce18ff032dbd4aede2ca06
Commit Graph

5218 Commits

Author SHA1 Message Date
Brian Wilkerson 0a0413aac8 Add completions for keywords in patterns 
I'm reasonably confident that there are missing test cases, so please
let me know if you see any that you think should be added.

Change-Id: I7d6780158a6fb1aa2fe64e8efcb24982a39d7f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278992
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-20 15:23:34 +00:00
Alexander Thomas b9b6511ca6 Spelling sdk 
Closes https://github.com/dart-lang/sdk/pull/50918

Co-authored-by: Josh Soref <jsoref@gmail.com>
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2023-01-20 12:37:49 +00:00
Keerti Parthasarathy ae5dc9e2a9 Wire up remove question mark and remove non null assert fixes for patterns 
Bug:49960
Change-Id: I6b0a94454e0f51c5fd15d4abef16d075dce54a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-20 00:30:48 +00:00
Josh Soref 84e3c8b50f Spelling tests 
Closes https://github.com/dart-lang/sdk/pull/50920

GitOrigin-RevId: fa87531bd0f52b69485c9d02ff9e44a4a29c6a91
Change-Id: I0ae8574a5b77087895e004079f221201bb550cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278535
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 16:24:29 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Kallen Tu 6e9556c3de [analysis_server] Add semantic highlighting for mixin class modifier. 
Added highlighting for the 'mixin' keyword on classes and fixed the BNF to be consistent with the spec.

Change-Id: Iaa5b32ba2d122f01d5ddaddc066ac8f4a50b9844
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279237
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2023-01-18 16:36:11 +00:00
Keerti Parthasarathy 2acdf0cb60 Add tests for patterns for fixes/assists. 
At this point the tests are failing, as either the fix processor has to be updated or there are issues blocking the analyzer generating the required diagnostics.

Bug:49960
Change-Id: Ifa445ef1bf459b401bda335672364e745267799a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-18 14:50:38 +00:00
Kaushik Iska 885457e1d3 Revert "[analyzer] new warning for nullable '==' parameter type" 
This reverts commit 48ee1f218d.

Reason for revert: https://github.com/flutter/flutter/issues/118632

Original change's description:
> [analyzer] new warning for nullable '==' parameter type
>
> This rule checks that a parameter to an `operator ==` implementation has
> a non-nullable type.
>
> I intentionally did not enforce, in this rule, that the parameter is
> exactly `Object`. It is legal to narrow the parameter type to a
> different non-nullable type, like `int`. I can't imagine doing it, but
> it seems to be unrelated to whether the type should be nullable or not.
>
> Fixes https://github.com/dart-lang/linter/issues/3441
>
> Replaces https://github.com/dart-lang/linter/pull/3923
>
> Change-Id: I61d4a7b1ab8318dc9403da1633c352de95bfac61
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277700
> Reviewed-by: Mark Zhou <markzipan@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6f96936b8d4e785b5f8e9719751e4b61c2a6ca2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279141
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-01-17 23:53:18 +00:00
Konstantin Shcheglov 7e6ad397b0 Resolve ForPartsWithPattern in ForElement and ForStatement. 
Change-Id: I66e91a31213a56f6cab1f7b0a826752ca4a13d96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2023-01-17 19:24:34 +00:00
Sam Rawlins 48ee1f218d [analyzer] new warning for nullable '==' parameter type 
This rule checks that a parameter to an `operator ==` implementation has
a non-nullable type.

I intentionally did not enforce, in this rule, that the parameter is
exactly `Object`. It is legal to narrow the parameter type to a
different non-nullable type, like `int`. I can't imagine doing it, but
it seems to be unrelated to whether the type should be nullable or not.

Fixes https://github.com/dart-lang/linter/issues/3441

Replaces https://github.com/dart-lang/linter/pull/3923

Change-Id: I61d4a7b1ab8318dc9403da1633c352de95bfac61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277700
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-13 19:51:29 +00:00
Ahmed Ashour cb8fbaf8ad [analysis_server] Fix AddMissingEnumCaseClauses with empty brackets 
Fixes #51004

Change-Id: Ieef1ba29d4cfba6a264f55193ed87767627f317a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-13 15:57:01 +00:00
Ahmed Ashour 052a6b4227 [analyzer] improve message of INVALID_OVERRIDE 
Bug #49355

Change-Id: I3dac4ede45aea217b7663994ad42004117ad967b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-12 00:41:38 +00:00
Konstantin Shcheglov 585b4da0e9 Restore noSoundNullSafety to true in tearDown(), remove try/finally. 
Change-Id: I0a37bb8c41a1d0292217f4d4b67c9c091476ed2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278891
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-11 22:30:30 +00:00
Brian Wilkerson 09e4ff60cc Add semantic highlighting support for patterns 
Change-Id: I232087c0ad59c95452aeef21754d76782cf24577
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278889
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-11 22:09:22 +00:00
Konstantin Shcheglov 97f5626a6f Issue 50960. Revert delaying removing file overlays. 
This reverts 6de7ea7432

This hurts our external users, and I got an impression that the
scenario for which we designed it initially is not the way our
internal developers works now.

Bug: https://github.com/dart-lang/sdk/issues/50960
Change-Id: I9b1ecf4860146d67963c5c99ecefc581e1526a89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278883
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-11 18:59:12 +00:00
Brian Wilkerson 14ff1f2d35 Generate a diagnostic for language overrides prior to 2.12 
Change-Id: Ia10cf89443208ef133dd1ce8d68ee7c6b4129fbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276800
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-10 05:27:48 +00:00
Ahmed Ashour 9ce724d9a8 [analysis_server] offer fix for always_put_required_named_parameters_first 
Fixes #50816

Change-Id: I5a43e01eba3010e220210a28a8b550a156e98f22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277100
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 21:18:38 +00:00
Ahmed Ashour 6ef8df0878 [analysis_server] Add ReplaceWithIsNan fix 
Bug #50481

Change-Id: Ibe49ab080263051f8894c27cb0afa5f347d60745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 20:42:47 +00:00
Brian Wilkerson 8f4b5a5d89 Support copying the file header in the move to file refactoring 
Change-Id: Ic352bd11d1c854976f408e273e63dc497de05811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278650
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 17:31:00 +00:00
pq 5b2d70625a process sdk constraints in options validation 
Change-Id: I3326d3b894939b26289416b66239bf98d31d8309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-06 23:50:48 +00:00
Ahmed Ashour 6664304545 [analysis_server] add fix for super_invocation_not_last 
Fixes #50829

Change-Id: I0428fc8118bc99f4df45c231f70b3de43faddb05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277140
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-06 02:08:05 +00:00
Ahmed Ashour a174b981e4 [analysis_server] associate RemoveAnnotation with some diagnostics 
Fixes #50788

Change-Id: Iea8753c00b61366e23301937a48fadaadb065082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 22:51:32 +00:00
Danny Tuppeny f11bec54e0 [analysis_server] Don't include default values when adding type annotations 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4312.

Change-Id: Id5376d6ad28b7af3a64c49014e4c32306a420d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 16:51:18 +00:00
Ahmed Ashour 4bf325dd90 [analysis_server] remove unneeded new 
Fixes #49901

Change-Id: I7729e29c1e7ca73a824762156fd68d5d8a2516fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258243
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-05 03:05:58 +00:00
Danny Tuppeny 792aedec74 [analysis_server] Add syntax highlights for error/stackTrace in catch clauses 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4320.

Change-Id: Iad269d0f5389d548a01717fbd0facd74d31acf50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278346
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-04 17:59:01 +00:00
Brian Wilkerson e2749d4949 Enhance the move to file refactoring to support moving multiple declarations 
Change-Id: I9df0717686746d351927268cbd4ac02174886315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-03 21:01:57 +00:00
pq 750ed0e50e remove analyzer/server support for the default List constructor 
See: https://github.com/dart-lang/sdk/issues/49529

Change-Id: Id52ac534405b3552812e6bb8ce49e09c60cbdfd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276770
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-03 17:40:19 +00:00
Sam Rawlins 166c54b4d9 analyzer: Mark implicit-casts and implicit-dynamic as deprecated 
Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.

Fixes #47902

This reverts 5050f31b29

Change-Id: Icd156b0dda78a50ed28272ddef7460018f511cc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276766
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-03 17:30:28 +00:00
Kallen Tu cdd9e43b2c [analysis_server] Add semantic highlighting for sealed class modifier. 
Enable the 'sealed-class' experiment for the highlighting test and add the highlighting for the modifier.

Change-Id: I6affdab506c29ab9d92b2d6315a93d09396bafaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277201
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2022-12-27 23:24:40 +00:00
Ahmed Ashour 60a8ba16de [analysis_server] offer fixes for TEXT_DIRECTION_CODE_POINT_* 
Fixes #50790

Change-Id: Id8f135e090406f235f488a497ba277032cb1e900
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-21 17:20:52 +00:00
Sam Rawlins e38a7046fb Revert "Revert "Remove preview-dart-2 option in analysis options"" 
This reverts commit 6d05f249ff.

Fixes https://github.com/dart-lang/sdk/issues/50680

Change-Id: I6f0d177708d88a4cfd52710684642d03fee8743a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276761
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-20 19:25:37 +00:00
Ahmed Ashour dc3b2025af [analysis_server] associate UNNECESSARY_QUESTION_MARK 
with `RemoveQuestionMark`

Fixes #50793

Change-Id: Idd2131c4a305c6d224bf80e79fd6986feb0a4587
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Oleh Prypin <oprypin@google.com>
 2022-12-20 17:03:04 +00:00
Ahmed Ashour 3b64ad278e [analysis_server] associate ReplaceColonWithEquals with OBSOLETE_COLON_FOR_DEFAULT_VALUE 
Fixes #50770

Change-Id: I77d14ad5ee8b491d1745220e927eab34edcb4485
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276500
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-19 21:18:49 +00:00
Danny Tuppeny 41b5ba1629 [analysis_server/lsp] Allow user to configure whether Workspace Symbols includes all files or just their workspace 
Fixes https://github.com/Dart-Code/Dart-Code/issues/1903.

Change-Id: I1b9221a1ebfa83e3089b4036e6d0d5446ac24461
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-19 19:07:26 +00:00
Danny Tuppeny c7cf83aa5d [analysis_server/lsp] Don't send Flutter outlines for non-Flutter projects 
Fixes https://github.com/dart-lang/sdk/issues/44628.

Change-Id: I38e6a9d336f1b90c0030a16b2897557053a7d469
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275942
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-19 17:41:00 +00:00
Ahmed Ashour 0c4c372d5e [analysis_server] associate RemoveNameFromDeclarationClause with various diagnostics 
Bug #50753

Change-Id: I3520a1ce3af3bfc651df582505835468705bdda2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 22:03:50 +00:00
Ahmed Ashour f12f1ad664 [analysis_server] ReplaceWithNullAware to handle IndexExpression 
Fixes #50691

Change-Id: I9bc6e1f72ff71623139ce94b3f3e94eba8ed4fd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 17:29:38 +00:00
Sam Rawlins 94f20d7731 Revert "Remove all support for all strong-mode analysis options" 
This reverts ea120b5d44

Change-Id: I97a1bf6ced06bf8bcab50a2fdb41732f13182a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276026
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 00:47:49 +00:00
Samuel Rawlins 6d05f249ff Revert "Remove preview-dart-2 option in analysis options" 
This reverts commit f30e5de558.

Reason for revert: https://dart-review.googlesource.com/c/sdk/+/274921 broke customer test, and this CL sits right on top of it.

Original change's description:
> Remove preview-dart-2 option in analysis options
>
> Fixes https://github.com/dart-lang/sdk/issues/50680
>
> AnalysisOptionsHintCode is moved from generated `option_codes.g.dart` to `option_codes.dart`, for non-generated diagnostics:
>
> * AnalysisOptionsHintCode.DEPRECATED_LINT_HINT and
> * AnalysisOptionsHintCode.DUPLICATE_RULE_HINT
>
> Change-Id: I131fb2901fca26ff971b6c9c519ab2f0b983a65c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275500
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia417aa5edc5b279a5fced43154de4cd5c9d3be2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276023
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-15 22:54:51 +00:00
pq ea1473e6cd linter 1.32.0 
See: https://github.com/dart-lang/linter/issues/3848

Change-Id: I73469ce43d52c1755875a39067b267f216ebd490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-12-15 22:51:28 +00:00
Ahmed Ashour a6f4fbe17b [analysis_server] ConvertToMapLiteral to handle types with typedef 
Fixes #50581

Change-Id: Ieeb4c6730036e112bcf37353a18535f342fd28a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-15 22:09:46 +00:00
Ahmed Ashour f652c7962b [analysis_server] fix AddNullCheck with null-aware operators 
Fixes #50506

Change-Id: I8f7564ec7aaaf32888e9979254e450cd2633e307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-15 21:13:41 +00:00
Sam Rawlins f30e5de558 Remove preview-dart-2 option in analysis options 
Fixes https://github.com/dart-lang/sdk/issues/50680

AnalysisOptionsHintCode is moved from generated `option_codes.g.dart` to `option_codes.dart`, for non-generated diagnostics:

* AnalysisOptionsHintCode.DEPRECATED_LINT_HINT and
* AnalysisOptionsHintCode.DUPLICATE_RULE_HINT

Change-Id: I131fb2901fca26ff971b6c9c519ab2f0b983a65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-12-14 21:04:29 +00:00
Jens Johansen 959f0a299c [analyzer] Report memory usage on Windows too 
Change-Id: I6a31370c51e40a9593f8875d365a43d9f4111aaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-12-14 18:11:25 +00:00
Sam Rawlins ea120b5d44 Remove all support for all 'strong-mode' analysis options 
Fixes https://github.com/dart-lang/sdk/issues/50679

Change-Id: I3572faf51276f5c7551d35b7725c799567189413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-13 21:32:24 +00:00
Sam Rawlins fdf59ad1eb Remove all support for super-mixins option 
Bug: https://github.com/dart-lang/sdk/issues/50680
Change-Id: I96409d02e64d3e198e0fae4a55f58f871ce2aeac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275142
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-13 18:13:37 +00:00
Brian Wilkerson 2fbb93fc11 Do not apply the fix for avoid_function_literals_in_foreach_calls when body is not sync 
Change-Id: I0482c0d35a01afffd26073383b137697b829249c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274943
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-12 18:12:57 +00:00
Sam Rawlins 315ff0b8a2 analysis_server: quick fixes for records 
* allow rename_to_camel_case to apply to record type field names
* allow replace_final_with_const to apply to record literals.

Change-Id: Id373180dae9f7a78677e30c4dbc535bbb87ce3f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272486
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-10 23:12:23 +00:00
Brian Wilkerson bb7e2c9b95 Remove some unnecessary ignores in test code 
Change-Id: I55e332132b9f3e435d79dd03a7aa7459d796599a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274800
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-12-10 00:19:30 +00:00
Brian Wilkerson d9482e35ce Remove some unnecessary ignore comments in analyzer packages 
Change-Id: I578285132f0d3f200cb2e9069750a1391940711d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-09 21:33:18 +00:00