dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
89,340 Commits 2 Branches 0 Tags
ec6fcf34bb11353882ce18ff032dbd4aede2ca06
Commit Graph

7538 Commits

Author SHA1 Message Date
Sam Rawlins 00a797b69e [analyzer] Move two more Hints to be Warnings, UNDEFINED_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ifa01985beba01298addacf58b576b049ce0918f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-20 16:05:59 +00:00
Brian Wilkerson 0a0413aac8 Add completions for keywords in patterns 
I'm reasonably confident that there are missing test cases, so please
let me know if you see any that you think should be added.

Change-Id: I7d6780158a6fb1aa2fe64e8efcb24982a39d7f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278992
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-20 15:23:34 +00:00
Alexander Thomas b9b6511ca6 Spelling sdk 
Closes https://github.com/dart-lang/sdk/pull/50918

Co-authored-by: Josh Soref <jsoref@gmail.com>
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2023-01-20 12:37:49 +00:00
Jens Johansen af0e2dd01e [analyzer] Create report from web interface 
This CL adds a page "Collect Report" on the
"Analysis Server Diagnostics" website, available from the top right,
between "Diagnostics" and "Feedback".

The created json report includes most data from the subpages of the
"Diagnostics" page as well as data fetched from the observatory
protocol which, if not already enabled, will be enabled while the report
is created.

Change-Id: Iec545fb8caf642088c47ccfc98f005598a462ada
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2023-01-20 11:42:29 +00:00
Keerti Parthasarathy ae5dc9e2a9 Wire up remove question mark and remove non null assert fixes for patterns 
Bug:49960
Change-Id: I6b0a94454e0f51c5fd15d4abef16d075dce54a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-20 00:30:48 +00:00
Sam Rawlins a4ca3ded5f [analyzer] Move two more Hints to be Warnings, EQUAL_* 
Bug: https://github.com/dart-lang/sdk/issues/50796

Change-Id: Id07ac5940eafed58b1473804248381dd933cb311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279229
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-19 20:04:17 +00:00
Josh Soref 84e3c8b50f Spelling tests 
Closes https://github.com/dart-lang/sdk/pull/50920

GitOrigin-RevId: fa87531bd0f52b69485c9d02ff9e44a4a29c6a91
Change-Id: I0ae8574a5b77087895e004079f221201bb550cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278535
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 16:24:29 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Sam Rawlins 305358e8ce [analyzer] Introduce WarningCode for non-spec warnings. 
Rename StaticWarningCode to WarningCode, leaving the spec ones as StaticWarningCode.

In this CL I do not introduce a new "type" for WarningCode, it is still "STATIC_WARNING". Later, we can make a new type, "WARNING", taking care for pkg/test_runner and DAS clients like IntelliJ.

Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ife856b2beb7e9b6bf8203f365634f49846d03bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278997
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-18 20:28:38 +00:00
Ahmed Ashour 49c7d93042 [cfe/analyzer] add CompileTimeErrorCode.CONTINUE_LABEL_INVALID 
Fixes #49852

Change-Id: Ic4d475d383dba51ad438de5ef7f928ce5d105e12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277481
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2023-01-18 19:10:46 +00:00
Kallen Tu 6e9556c3de [analysis_server] Add semantic highlighting for mixin class modifier. 
Added highlighting for the 'mixin' keyword on classes and fixed the BNF to be consistent with the spec.

Change-Id: Iaa5b32ba2d122f01d5ddaddc066ac8f4a50b9844
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279237
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2023-01-18 16:36:11 +00:00
Keerti Parthasarathy 2acdf0cb60 Add tests for patterns for fixes/assists. 
At this point the tests are failing, as either the fix processor has to be updated or there are issues blocking the analyzer generating the required diagnostics.

Bug:49960
Change-Id: Ifa445ef1bf459b401bda335672364e745267799a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-18 14:50:38 +00:00
Jens Johansen 2cfc0146e1 [analyzer] Keep stats about slow queries around longer 
This CL keeps slow (500+ ms) requests around for longer (to a total of
1000 of them), saves the start time of the request and prints a little
more on the details page.

The overall idea is that having a record of slow requests is better
for debugging performance related issues than only having the newest
50 requests which basically requires one to "catch it" as it's being
slow.
Currently the 500 ms deadline for "slow" and 1000 requests saved was
just grabbed from thin air; we can adjust them later if needed.

Change-Id: Ib0d6e1fc2daad215d8745249abdc82f831a83785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279087
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-18 08:26:58 +00:00
Kaushik Iska 885457e1d3 Revert "[analyzer] new warning for nullable '==' parameter type" 
This reverts commit 48ee1f218d.

Reason for revert: https://github.com/flutter/flutter/issues/118632

Original change's description:
> [analyzer] new warning for nullable '==' parameter type
>
> This rule checks that a parameter to an `operator ==` implementation has
> a non-nullable type.
>
> I intentionally did not enforce, in this rule, that the parameter is
> exactly `Object`. It is legal to narrow the parameter type to a
> different non-nullable type, like `int`. I can't imagine doing it, but
> it seems to be unrelated to whether the type should be nullable or not.
>
> Fixes https://github.com/dart-lang/linter/issues/3441
>
> Replaces https://github.com/dart-lang/linter/pull/3923
>
> Change-Id: I61d4a7b1ab8318dc9403da1633c352de95bfac61
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277700
> Reviewed-by: Mark Zhou <markzipan@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6f96936b8d4e785b5f8e9719751e4b61c2a6ca2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279141
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-01-17 23:53:18 +00:00
Konstantin Shcheglov 7e6ad397b0 Resolve ForPartsWithPattern in ForElement and ForStatement. 
Change-Id: I66e91a31213a56f6cab1f7b0a826752ca4a13d96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2023-01-17 19:24:34 +00:00
Sam Rawlins 0ab9f97844 [analyzer] Limit the number of plugins-per-context to one 
This accounts for included options files, and the three forms of 'plugins' values that are supported: scalar, list, and map.

This includes an analysis options warning which reports each plugin specified after the first.

Fixes https://github.com/dart-lang/sdk/issues/50981

Change-Id: Ib55f78f183565ad7129b735c0afeae1ed121ec4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278805
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-17 15:50:18 +00:00
Konstantin Shcheglov 9bb51aa043 Use 'LegacyHandler.performance' in CompletionGetSuggestions2Handler. 
So, we can see the performance on the diagnostics page.

Change-Id: I11cf4e08e12bc6b8af4e965b6aa674ec9607cedf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279070
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-17 15:12:58 +00:00
Jens Johansen f724d82067 [analyzer] Add timings to legacy protocol 
Change-Id: I672e2c6e01d03b528e4ddcda308e85e2317e554a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279006
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2023-01-16 08:12:49 +00:00
Sam Rawlins 48ee1f218d [analyzer] new warning for nullable '==' parameter type 
This rule checks that a parameter to an `operator ==` implementation has
a non-nullable type.

I intentionally did not enforce, in this rule, that the parameter is
exactly `Object`. It is legal to narrow the parameter type to a
different non-nullable type, like `int`. I can't imagine doing it, but
it seems to be unrelated to whether the type should be nullable or not.

Fixes https://github.com/dart-lang/linter/issues/3441

Replaces https://github.com/dart-lang/linter/pull/3923

Change-Id: I61d4a7b1ab8318dc9403da1633c352de95bfac61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277700
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-13 19:51:29 +00:00
Ahmed Ashour cb8fbaf8ad [analysis_server] Fix AddMissingEnumCaseClauses with empty brackets 
Fixes #51004

Change-Id: Ieef1ba29d4cfba6a264f55193ed87767627f317a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-13 15:57:01 +00:00
Sam Rawlins cba43447dd Move five HintCodes to into StaticWarningCode 
* DUPLICATE_EXPORT
* DUPLICATE_HIDDEN_NAME
* DUPLICATE_IGNORE
* DUPLICATE_IMPORT
* DUPLICATE_SHOWN_NAME

Change-Id: I5bf7f8737c8c00c8ef5ecf6a6973a2ea89877d45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-12 22:42:58 +00:00
Sam Rawlins b9a42c82bc Move seven more Hints to be StaticWarnings: 
* ARGUMENT_TYPE_NOT_ASSIGNABLE_TO_ERROR_HANDLER
* BODY_MIGHT_COMPLETE_NORMALLY_CATCH_ERROR
* BODY_MIGHT_COMPLETE_NORMALLY_NULLABLE
* DEPRECATED_EXTENDS_FUNCTION
* DEPRECATED_IMPLEMENTS_FUNCTION
* DEPRECATED_MIXIN_FUNCTION
* DEPRECATED_NEW_IN_COMMENT_REFERENCE

This requires allowing these warnings to be reported in language tests without being expected.

Also, observatory now must comply with BODY_MIGHT_COMPLETE_NORMALLY_NULLABLE (or we could ignore the diagnostic).

TESTED=unit tests

Change-Id: I8facfa48a8645bac5bf8037163076a8f0a0ad05e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275740
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-12 19:17:35 +00:00
Konstantin Shcheglov f486b00c9b Report INCONSISTENT_PATTERN_VARIABLE_SHARED_CASE_SCOPE. 
Change-Id: Icb7b38ed433d72962e59b2653341623f0f8af388
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278890
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-12 19:08:01 +00:00
Ahmed Ashour 052a6b4227 [analyzer] improve message of INVALID_OVERRIDE 
Bug #49355

Change-Id: I3dac4ede45aea217b7663994ad42004117ad967b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-12 00:41:38 +00:00
Konstantin Shcheglov 585b4da0e9 Restore noSoundNullSafety to true in tearDown(), remove try/finally. 
Change-Id: I0a37bb8c41a1d0292217f4d4b67c9c091476ed2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278891
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-11 22:30:30 +00:00
Brian Wilkerson 09e4ff60cc Add semantic highlighting support for patterns 
Change-Id: I232087c0ad59c95452aeef21754d76782cf24577
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278889
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-11 22:09:22 +00:00
Konstantin Shcheglov 97f5626a6f Issue 50960. Revert delaying removing file overlays. 
This reverts 6de7ea7432

This hurts our external users, and I got an impression that the
scenario for which we designed it initially is not the way our
internal developers works now.

Bug: https://github.com/dart-lang/sdk/issues/50960
Change-Id: I9b1ecf4860146d67963c5c99ecefc581e1526a89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278883
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-11 18:59:12 +00:00
Konstantin Shcheglov dcc27c757e Report DUPLICATE_PATTERN_ASSIGNMENT_VARIABLE 
Change-Id: Id42c5868e9face4e266fac8dd067270dd2ee042d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278814
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2023-01-11 17:41:58 +00:00
Konstantin Shcheglov 12e812c45d Report PATTERN_VARIABLE_ASSIGNMENT_INSIDE_GUARD 
Change-Id: I46c7dbf8213a6b35593135e0930f9ad1051eef63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278815
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-11 15:35:42 +00:00
Jens Johansen 82e1b443a6 [parser] Recover when there's space between metadata and parenthesis 
In https://dart-review.googlesource.com/c/sdk/+/272600 the change to
disallow spaces between metadata and parenthesis is the parenthesis
is supposed to be arguments for the metadata. Recovery was requested
on that CL and this is it.

Change-Id: I26c809f09cf8411365a2b758f635a494e7ebbd49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278516
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2023-01-11 07:56:47 +00:00
Konstantin Shcheglov 10c22134b3 Report UNNECESSARY_NULL_ASSERT_PATTERN and UNNECESSARY_NULL_CHECK_PATTERN. 
Change-Id: Icf2fcca95cb461e2e6bc1547acb8ee29a2df4148
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278687
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-10 18:37:40 +00:00
Brian Wilkerson 14ff1f2d35 Generate a diagnostic for language overrides prior to 2.12 
Change-Id: Ia10cf89443208ef133dd1ce8d68ee7c6b4129fbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276800
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-10 05:27:48 +00:00
Ahmed Ashour 9ce724d9a8 [analysis_server] offer fix for always_put_required_named_parameters_first 
Fixes #50816

Change-Id: I5a43e01eba3010e220210a28a8b550a156e98f22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277100
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 21:18:38 +00:00
Ahmed Ashour 6ef8df0878 [analysis_server] Add ReplaceWithIsNan fix 
Bug #50481

Change-Id: Ibe49ab080263051f8894c27cb0afa5f347d60745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 20:42:47 +00:00
Kallen Tu 30b9b20965 [analyzer] Report error if class mixed in outside of its library unless it's a mixin class. 
Classes can't be implicitly used as mixins outside of its library unless its in a language version prior to sealed classes.

See: https://github.com/dart-lang/language/blob/master/working/base-interface-final/feature-specification.md#mixin-classes
Change-Id: I77762a1c962e10f89430e2b4c6141d00ace1cb30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 20:22:14 +00:00
Brian Wilkerson 8f4b5a5d89 Support copying the file header in the move to file refactoring 
Change-Id: Ic352bd11d1c854976f408e273e63dc497de05811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278650
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 17:31:00 +00:00
Danny Tuppeny c09d47e8e9 [analysis_server] Simplify inclusion of default values when writing parameters 
Change-Id: I7261318ca05c263727c74744e96e03b237f1f5af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278517
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-09 17:17:54 +00:00
pq 5b2d70625a process sdk constraints in options validation 
Change-Id: I3326d3b894939b26289416b66239bf98d31d8309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-06 23:50:48 +00:00
Ahmed Ashour 11a25ca0b3 Reland "[analyzer] add UNNECESSARY_NAN_COMPARISON hint" 
This is a reland of commit 254da67495

Original change's description:
> [analyzer] add `UNNECESSARY_NAN_COMPARISON` hint
>
> Fixes #44649
>
> Change-Id: I3784f7222a217e5b6ca485c02e9a889964ffcc8c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269881
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: I868d46df69f178094742d9193de5d347ea2cc60b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278440
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-06 17:00:16 +00:00
Ahmed Ashour 6664304545 [analysis_server] add fix for super_invocation_not_last 
Fixes #50829

Change-Id: I0428fc8118bc99f4df45c231f70b3de43faddb05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277140
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-06 02:08:05 +00:00
Ahmed Ashour a174b981e4 [analysis_server] associate RemoveAnnotation with some diagnostics 
Fixes #50788

Change-Id: Iea8753c00b61366e23301937a48fadaadb065082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 22:51:32 +00:00
Konstantin Shcheglov 719a0629b1 Report DUPLICATE_REST_ELEMENT_IN_PATTERN-REST and REST_ELEMENT_NOT_LAST_IN_MAP_PATTERN. 
Change-Id: I4bf3446a10ab8e280f9b73220384f8daf96171c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278523
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 21:44:40 +00:00
Danny Tuppeny f11bec54e0 [analysis_server] Don't include default values when adding type annotations 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4312.

Change-Id: Id5376d6ad28b7af3a64c49014e4c32306a420d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 16:51:18 +00:00
Ahmed Ashour 4bf325dd90 [analysis_server] remove unneeded new 
Fixes #49901

Change-Id: I7729e29c1e7ca73a824762156fd68d5d8a2516fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258243
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-05 03:05:58 +00:00
Konstantin Shcheglov c7f509379d Report NON_CONSTANT_RELATIONAL_PATTERN_EXPRESSION 
Change-Id: I2ef6ad04d9dfcc51faa239ddeae3122bfe969672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278366
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-04 22:23:38 +00:00
Brian Wilkerson 1170c55eaa Update the checklist for new language features 
Change-Id: I4022bd3a79be25d006178ad681effd035ff7f9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277045
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-04 21:47:32 +00:00
Konstantin Shcheglov 445085471d Report NON_CONSTANT_MAP_PATTERN_KEY and EQUAL_KEYS_IN_MAP_PATTERN. 
Change-Id: I20922047abe62292b84798b7cf540d93f1b5f0d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-04 21:21:30 +00:00
Danny Tuppeny 792aedec74 [analysis_server] Add syntax highlights for error/stackTrace in catch clauses 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4320.

Change-Id: Iad269d0f5389d548a01717fbd0facd74d31acf50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278346
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-04 17:59:01 +00:00
pq 31a354fbf4 [WIP] migrate lint maturity to state 
See: https://github.com/dart-lang/linter/issues/3896

Change-Id: I83b5f1caf4036ea04c973fb2c43cdd37e4e5de31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-04 00:15:39 +00:00
Konstantin Shcheglov 8c3198638e Report PATTERN_CONSTANT_FROM_DEFERRED_LIBRARY 
Change-Id: I658ebec7f7dbe90742e9e417c1f01e0584e145c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278088
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-03 21:45:43 +00:00