dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
35,564 Commits 2 Branches 0 Tags
eadb59e4c191731444926888cbfa2172bb0984ed
Commit Graph

1752 Commits

Author SHA1 Message Date
Konstantin Shcheglov 9a2f5b298a Initial .analysis_options files with couple of lints enabled. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1566743002 .
 2016-01-06 09:14:18 -08:00
William Hesse 634e5a1d02 Refs #25328 Use a portable shebang 
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).

Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1552313002 .
 2016-01-05 16:26:28 +01:00
Konstantin Shcheglov e1c6faceb5 Issue 25316. Quick Fix for removing 'final' keyword. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25316

Review URL: https://codereview.chromium.org/1545323002 .
 2015-12-27 13:19:41 -08:00
Konstantin Shcheglov 78ae012d2d Issue 25313. Skip constructor names and named expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25313

Review URL: https://codereview.chromium.org/1547113002 .
 2015-12-27 12:05:05 -08:00
danrubel e13a49fdfa (TBR) "fix" test_no_duplicate_notifications 
Review URL: https://codereview.chromium.org/1542433002 .
 2015-12-19 11:41:32 -05:00
Dan Rubel e5bbeddf4d completion performance measurement for local status page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1536083002 .
 2015-12-19 11:12:45 -05:00
Dan Rubel 43ee7b5bc9 move OpType into dart folder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523243006 .
 2015-12-19 11:11:04 -05:00
Dan Rubel 99c3be6331 remove old completion API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1536073002 .
 2015-12-19 11:09:48 -05:00
Dan Rubel 48725225d3 stop caching state between completion requests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1539943002 .
 2015-12-18 10:53:16 -05:00
Dan Rubel 39d5abb662 remove internal streaming of results, remove obsolete test, cleanup unused code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1538883003 .
 2015-12-18 10:52:21 -05:00
Dan Rubel 1adabf4abc remove extraneous classes and cleanup code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1535643004 .
 2015-12-18 08:53:39 -05:00
pq 1f8eddcc21 Cache element docs (and add to completions) [#23694]. 
This does away with the expensive call to `computeDocumentationComment` in favor of cached comments.  Notably this makes adding doc content to code completion proposals performant (and so is done here).  It should also make `dartdoc` *much* faster for doc generation since there are no more trips to disk to fetch comments  for elements (still needed for source though).

For more on the desire for docs in completions see here: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1534043002 .
 2015-12-17 21:07:42 -08:00
Dan Rubel fbaba56375 move DartCompletionSorter to dart specific contributor 
consolidate common test code
remove duplicate test

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1539693002 .
 2015-12-17 17:54:29 -05:00
Konstantin Shcheglov e1455ce920 Stop using RESOLVED_UNIT_x for other libraries. 
This makes analysis of a command line Hello World application about 20% faster.
Even before summaries :-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1531393002 .
 2015-12-17 13:57:20 -08:00
Dan Rubel 4ee5173f42 move ReplacementRange into dart specific contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1531383002 .
 2015-12-17 16:24:49 -05:00
Dan Rubel baf03ebdfe merge completion suggestions based upon relevance 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1536823002 .
 2015-12-17 16:22:40 -05:00
Ivan Posva a3f816e75b - Fix usage of Platform.packageRoot. 
BUG=

Review URL: https://codereview.chromium.org/1533693003 .
 2015-12-17 13:08:19 -08:00
Dan Rubel b3fa2629bf remove CompletionCache and obsolete tests, and cleanup imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1533973002 .
 2015-12-17 16:00:34 -05:00
Dan Rubel 661cd4e9b9 report invalid param if offset is out of bounds 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1531353002 .
 2015-12-17 14:58:14 -05:00
Dan Rubel 5a8187987a remove unused suggestion builder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1537713002 .
 2015-12-17 11:50:03 -05:00
Dan Rubel 5e128e2544 suggest IDENTIFIER not INVOCATION for dartdoc refs 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1530393004 .
 2015-12-17 11:00:15 -05:00
Dan Rubel 6d5efd3175 remove unused DartCompletionCache 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1536683003 .
 2015-12-17 10:58:49 -05:00
Dan Rubel 0c6fb170dc Do not suggest loop variable when completing expression in ForEachStatement 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1534793002 .
 2015-12-17 10:57:51 -05:00
Dan Rubel 0de484bb8b convert ImportedReferenceContributor to new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1526303003 .
 2015-12-16 21:17:27 -05:00
pq 0a32c6b290 Status page diagnostics for elements and docs. 
Related to profiling the cost of storing element docs but the element counts themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1537503002 .
 2015-12-16 15:47:51 -08:00
Dan Rubel 3bf298760f extract InheritedReferenceContributor from imported reference contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1533613004 .
 2015-12-16 16:20:53 -05:00
Dan Rubel f13460e235 rename InheritedContributor to OverrideContributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523163004 .
 2015-12-16 12:15:34 -05:00
Dan Rubel 4cd376143f move functional argument check into manager 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1531473006 .
 2015-12-16 12:11:36 -05:00
Konstantin Shcheglov 70cd905c4d Issue 25253. Improve collecting names that may conflict with the extracted local variable. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25253

Review URL: https://codereview.chromium.org/1528013004 .
 2015-12-15 12:26:11 -08:00
danrubel 62f8832770 cleanup LocalLibraryContributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1527613008 .
 2015-12-15 13:03:41 -05:00
Konstantin Shcheglov f71ae984a9 Issue 25252. Stop collecting covering expressions at void invocations. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25252

Review URL: https://codereview.chromium.org/1528023002 .
 2015-12-15 09:55:48 -08:00
Brian Wilkerson 56fe38f0ab Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1527793003 .
 2015-12-14 19:31:46 -08:00
danrubel 6464160147 move LocalDeclarationVisitor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1529653003 .
 2015-12-14 20:36:57 -05:00
danrubel 5ff1ebe935 extract LocalLibraryContributor from imported reference contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1525753003 .
 2015-12-14 20:31:50 -05:00
danrubel 8a99902b94 suppress all dart contributor suggestions in comments 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1522003003 .
 2015-12-14 18:50:18 -05:00
Konstantin Shcheglov b44ed3e91e Issue 25251. Fix for extracting string literal part with zero length. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25251

Review URL: https://codereview.chromium.org/1522193002 .
 2015-12-14 12:56:59 -08:00
danrubel 5c3fcf81c0 fix CombinatorContributor to only suggest public members 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1525713002 .
 2015-12-14 14:21:01 -05:00
danrubel d8494d2f50 move LocalReferenceContributor to new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1528633002 .
 2015-12-14 13:57:51 -05:00
Konstantin Shcheglov 6824bd9b32 Fix for enum signatures. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1529593002 .
 2015-12-14 10:53:08 -08:00
Brian Wilkerson 1f3dabd9c7 Ensure that a complete library element has constants evaluated (issue 24890) 
R=danrubel@google.com, eernst@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1486663003 .
 2015-12-14 07:51:07 -08:00
Konstantin Shcheglov 38a4193b5f Issue 25244. Disable invalid overrides. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244

Review URL: https://codereview.chromium.org/1519413002 .
 2015-12-13 15:50:12 -08:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Brian Wilkerson 86472f32ce Move public API for elements into a public location 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1519283003 .
 2015-12-13 10:48:56 -08:00
Brian Wilkerson aca32e681a Updates to the stress test 
R=skybrian@google.com

Review URL: https://codereview.chromium.org/1514693013 .
 2015-12-12 07:28:45 -08:00
danrubel 7db8d0267d extract LocalConstructorContributor from local reference contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1521753002 .
 2015-12-12 10:01:22 -05:00
Brian Wilkerson 51c3d1d523 Clean up a couple of hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1518183003 .
 2015-12-11 16:46:56 -08:00
pq 2529c09fe5 Update analyzer dep lower-bound. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520823004 .
 2015-12-11 14:56:08 -08:00
danrubel 3a5a2d17ee extract LabelContributor from local reference contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514263004 .
 2015-12-11 17:46:41 -05:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover. 
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
 2015-12-11 14:25:46 -08:00
pq 63f24be16c Update server/cli linter pubspec deps. 
* bumps lower-bound to grab a `0.27.0`-compatible linter.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520973002 .
 2015-12-11 10:51:50 -08:00