sra@google.com
9f09fcbaac
Redo "Make dart2js typed_data implementation classes private"
...
This time with analyzer suppression for new library/
BUG=
Review URL: https://codereview.chromium.org//141653003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31935 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 23:01:26 +00:00
sra@google.com
9ceaef9d73
Revert "Redo "Make dart2js typed_data implementation classes private""
...
Revert while I figure out the correct analyzer suppression.
BUG=
Review URL: https://codereview.chromium.org//141523008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31933 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:54:18 +00:00
sra@google.com
42b1721927
Redo "Make dart2js typed_data implementation classes private"
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//138543005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31930 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:08:40 +00:00
blois@google.com
93b7001172
Making readonly fields on interfaces be readonly
...
This will be causing compilation warnings once https://codereview.chromium.org/140803002 is landed.
BUG=16105
R=vsm@google.com
Review URL: https://codereview.chromium.org//140903003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31892 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 18:13:48 +00:00
sra@google.com
8ffab76c82
Revert "Redo "Make dart2js typed_data implementation classes private""
...
Review URL: https://codereview.chromium.org//140543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31866 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:03:02 +00:00
sra@google.com
83ae5cfabf
Redo "Make dart2js typed_data implementation classes private"
...
The main library is now private, with the user visible library as small re-export library.
R=blois@google.com , floitsch@google.com , johnmccutchan@google.com
Review URL: https://codereview.chromium.org//130563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31865 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 04:27:50 +00:00
vsm@google.com
eebdf4ccf9
Revert "Revert "Revert "Fix dart2js type warnings"""
...
Hitting layout test failures in Dartium now....
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//134623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31702 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:27:09 +00:00
vsm@google.com
f236af9969
Revert "Revert "Fix dart2js type warnings""
...
Retrying with a fix. Patch 1 is initial change.
BUG=15954
R=blois@google.com
Review URL: https://codereview.chromium.org//126873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31699 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:00:03 +00:00
asiva@google.com
7ea7adfe16
Add more functions to the list of leaf functions which do not need an
...
auto generated dart scope. Resulting improvements in the Dromaeo benchmarks
getAttribute 1072.0 1529.0
element_property_access 1304.0 1987.0
setAttribute 305.38922155688624 422.1556886227545
element_property_assignment 509.4905094905095 668.0
getElementById 1012.0 1523.0
getElementById (not in document) 2440.0 3279.0
getElementsByTagName(div) 119232.0 155037.0
getElementsByTagName(p) 109280.0 148015.0
getElementsByTagName(a) 119869.0 156460.0
getElementsByTagName(*) 114050.0 146375.0
getElementsByTagName (not in document) 172848.0 238313.0
getElementsByName 1356.0 1724.0
getElementsByName (not in document) 2657.0 2891.0
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//113743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31582 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:48:17 +00:00
blois@google.com
dd84eacad7
Suppressing media events from list of global events.
...
Fixes analyzer issue
TBR
BUG=
Review URL: https://codereview.chromium.org//108943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31563 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 18:40:30 +00:00
blois@google.com
0e62a20627
Removing media events from Document and Element.
...
We were already doing this for Window, but they just got added to Element & Document in Chrome 32. Suppressing them as they aren't needed and can be used from MediaElement already.
TBR
BUG=
Review URL: https://codereview.chromium.org//109473009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31562 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 18:34:37 +00:00
vsm@google.com
6994ac20bb
Fix compile warning on mac
...
Chrome 32 flags appear to be stricter.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//115523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31493 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 18:01:32 +00:00
vsm@google.com
5e3937addf
Changes for Chrome 32
...
Once we're ready to switch ... some paths have changed from 31.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//93933014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31486 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 17:12:25 +00:00
asiva@google.com
1f9f8ecf7a
- Setup infrastructure to white list some native methods as not requiring
...
auto setup of Dart API scopes
- List some functions in the list to check out the infrastructure. Performance
gains from listing these:
firstChild 222.33 to 309.6903096903097
lastChild 217.56 to 306.0
nextSibling 363.00 to 514.0
previousSibling 357.64 to 506.0
nextSiblingDynamic 348.01 to 511.0
childNodes 309.38 to 444.5554445554446
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//119543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31342 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 19:02:04 +00:00
asiva@google.com
3b1902e54a
Add auto scope setup parameter to the native resolvers in preparation for
...
https://codereview.chromium.org/117723002/
R=vsm@google.com
Review URL: https://codereview.chromium.org//113913010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31287 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 17:48:14 +00:00
rmacnak@google.com
b149db19e3
Changes to generated code for templatized DartDOMWrapper::lookupWrapper.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//100923004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31050 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 00:21:46 +00:00
asiva@google.com
dd18f8d84f
Change generator to pass in domData in calls to createWrapper.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//110513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31034 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 18:36:10 +00:00
jacobr@google.com
4dd740e2de
Fix bug 15417
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//103933005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31032 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 18:25:41 +00:00
amouravski@google.com
275499f168
Clean up logging.conf file.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//66073005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30371 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 19:30:32 +00:00
whesse@google.com
7010c7b798
Don't write generated C++ bindings twice, only once.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//70453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30198 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 17:16:17 +00:00
whesse@google.com
82c29cbb7a
Avoid regenerating unchanged bindings files for Dartium.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//69343006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30192 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 12:44:24 +00:00
whesse@google.com
e7afc18bb9
Print more information when Dartium IDL bindings processing fails during build.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//63173005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30053 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 16:00:25 +00:00
blois@google.com
768e147559
Fixing comment constructor not functioning on IE
...
BUG=13943
R=efortuna@google.com
Review URL: https://codereview.chromium.org//56603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29777 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 22:45:11 +00:00
blois@google.com
cb0fa66a9b
Fixing BeforeUnloadEvent.returnValue
...
This is an update of https://codereview.chromium.org/54913005/ which was failing on the Dartium bots.
Original is patch #1 , fix is #2 (re-ordering the parts in html_dartium).
Issue with the original appears to be that parts have some order-dependency in the VM when executing with --error_on_bad_type, which is used in snapshotting.
Opened bug https://code.google.com/p/dart/issues/detail?id=14721
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//55903004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29766 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:53:45 +00:00
blois@google.com
7046fc201e
Revert "Fixing the BeforeUnloadEvent"
...
Causing problems with build on Dartium:
class _CustomEventStreamImpl<T extends Event> extends Stream<T>
^
'file:///mnt/data/b/build/slave/dartium-lucid32-full-be/build/src/dart/tools/dom/src/EventStreamProvider.dart': Error: line 334 pos 41: type '_CustomEventStreamImpl<KeyEvent>' has an out of bound type argument
class _CustomKeyEventStreamImpl extends _CustomEventStreamImpl<KeyEvent>
TBR
BUG=
Review URL: https://codereview.chromium.org//54923006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29754 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:37:33 +00:00
blois@google.com
a948d4384a
Fixing the BeforeUnloadEvent
...
Basically the last Blink upgrade introduced the BeforeUnloadEvent which conflicted with our previous polyfill. Our definition was removed, but the suppression remained for Event.returnValue.
The suppression is still needed since that's the incorrect type and on the wrong class, so I modified our metadata lookup to allow it to only target exact class matches (and not super classes).
BUG=
R=efortuna@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//54913005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29752 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:17:38 +00:00
kasperl@google.com
1bbe4d5452
Make sure that classes in dart:html do not implement both List and List<E>.
...
R=johnniwinther@google.com , blois@google.com
BUG=
Review URL: https://codereview.chromium.org//50263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29417 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:37:10 +00:00
jacobr@google.com
fa8b243f62
Add JsArray
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//41163005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29393 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 20:46:36 +00:00
amouravski@google.com
79b447a313
Renamed XmlHttpRequestEventTarget to remove Xml for consistency.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//49013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29385 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:54:00 +00:00
efortuna@google.com
45701cfb4b
Second round of deprecation removal.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29275 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:39:09 +00:00
sra@google.com
f41f6f6722
ImageData.data is a Uint8ClampedList
...
Review URL: https://codereview.chromium.org//41583005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29228 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 00:46:48 +00:00
efortuna@google.com
971dbf30ab
Supress list mixins for deprecated/removed class.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//42543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 00:23:06 +00:00
amouravski@google.com
c1eb44e3d0
Fix for getContextAttributes which wraps bare dictionary into a Dart type.
...
R=sra@google.com
Review URL: https://codereview.chromium.org//35863006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29221 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:32:46 +00:00
efortuna@google.com
9b40aca70c
Remove the low hanging deprecation fruit.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29219 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:13:51 +00:00
efortuna@google.com
7effd23744
Add DOMRect for Firefox Rectangle behavior.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29210 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:28:58 +00:00
efortuna@google.com
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
vsm@google.com
db97191375
Dartium fixes for latest Blink rolls.
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//37203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29085 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 15:00:32 +00:00
jmesserly@google.com
360ea42322
Rename mdv -> template_binding, remove experiemntal apis from dart:html
...
essentially, we trade off reduce dart:html API surface area for more annoying usage of these APIs. Since Polymer hides most of this, I suspect it won't be too annoying in practice.
Sample usage:
nodeBind(node).bind(...)
templateBind(node).model = ...;
R=sigmund@google.com
Review URL: https://codereview.chromium.org//34453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29057 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 02:11:49 +00:00
blois@google.com
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
efortuna@google.com
a4a2e26bde
Reapply lineDash with polyfill.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//35623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29050 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:15:36 +00:00
blois@google.com
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
blois@google.com
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
efortuna@google.com
8b4e5e92ba
"Reverting 29013"
...
TBR
BUG=
Review URL: https://codereview.chromium.org//35723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29017 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:25:40 +00:00
jacobr@google.com
c274135947
Revert "Revert breaking CL"
...
This reverts commit 582a7848d7ad11fe981257598124431e36a9c982.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//35513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29014 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:15:03 +00:00
efortuna@google.com
f4e40d6d9a
Make getLineDash return [] instead of null if it has not yet been set.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//27983005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29013 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:40:58 +00:00
vsm@google.com
e92900f914
Revert breaking CL
...
Revert "Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages."
TBR=jacobr@google.com
BUG=
Review URL: https://codereview.chromium.org//32643009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28981 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 04:30:23 +00:00
jacobr@google.com
c74e0cec97
Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//33993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28976 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:46:02 +00:00
amouravski@google.com
0177ed7ae4
CanvasRenderingContext2D.fillText now works correctly with null maxWidth.
...
BUG=13369
R=efortuna@google.com
Review URL: https://codereview.chromium.org//29273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28963 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 22:09:07 +00:00
jacobr@google.com
5ee178076a
A few API changes:
...
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
- Throw on types other than Map and Iterable.
- Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.
Still to do: Reach a conclusion on Serializable
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//27514003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
blois@google.com
e7aef33a2c
Fixing custom element type extensions in Dartium to have correct native type ID
...
This is in support of the recent change to write the native type ID to the Dart wrappers
Dart changes for https://codereview.chromium.org/27769002/
BUG=14190
R=vsm@google.com
Review URL: https://codereview.chromium.org//29033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 23:43:45 +00:00