ca69477f4e
Update co19 status and timing-out tests.
...
BUG=dartbug.com/22050
R=ricow@google.com
Review URL: https://codereview.chromium.org//851683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42803 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 12:24:30 +00:00
e50fd28ff7
Use closure conversion in new dart2js backend.
...
New instructions: CreateBox, SetField, GetField, CreateClosureClass.
The "old" instructions based on ref-cells are still in use by dart2dart:
GetClosureVariable, SetClosureVariable, CreateFunction.
dart2dart still does not support captured for-loop variables, but this
is a separate issue.
BUG=
R=floitsch@google.com , kmillikin@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//831133004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42802 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 11:57:15 +00:00
0192ea71fc
Emit to StreamCodeOutput instead of CodeBuffer.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//830703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42801 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 09:14:25 +00:00
a664d5d416
dart2js OldEmitter: Remove processing of old metadata encoding.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//849583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42800 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 08:46:50 +00:00
cebcc398f6
Add support for completion of case labels.
...
This change addresses completions like the following:
switch (...) {
foo: case 1:
...
bar: case 2:
continue ^;
baz: case 3:
...
}
Completion at the point marked "^" will show "foo", "bar", and "baz"
as possible completions.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//806473007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42799 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:11:46 +00:00
f6cbc73ac8
Remove redundant set of ResolvableLibrary.libraryElement.
...
LibraryElementBuilder.buildLibrary2() always sets it, so there's no
reason for the caller to set it as well.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//839463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42798 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:08:13 +00:00
1c24293cb1
Reset compilation unit in notification, as it might be damaged.
...
This should fix the navigation computer crash.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//846973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42792 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 23:07:32 +00:00
adcffd8bf5
Fix checking of generated directory contents.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//811973010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42789 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 22:19:58 +00:00
473438f940
Addition of AnalysisServer.isSocketOpen for clients to know if the server is still running.
...
Execution of generate_all for recent changes to the analyzer spec input, and resulting changes to have editor and the java server layer compile.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//845973006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42787 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 21:46:59 +00:00
14a97cafed
suggest fields rather than synthetic getters
...
and return dynamic returnType rather than null
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//791553007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 19:02:47 +00:00
e07125e634
Report incremental/full analysis performance via instrumentation.
...
R=brianwilkerson@google.com , lukechurch@google.com
BUG=
Review URL: https://codereview.chromium.org//844683003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42784 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 18:28:11 +00:00
3975cf30d0
Issue 22044. A changes in annotations should be considered as a mismatch.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22044
Review URL: https://codereview.chromium.org//832143007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42783 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:52:55 +00:00
1a92824c85
Update co19 status on firefox and chrome.
...
Update status for two timing out tests, and co19 on Android.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//825353007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42782 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:51:08 +00:00
531c591460
Completion support for loop labels.
...
Break and continue statements inside loops now have their targets
properly completed. Continue statements inside switch statements will
be addressed in a future CL.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//812593008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42781 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:37:46 +00:00
4a8c341ecf
Server clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//795833005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42780 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:34:14 +00:00
e908f30d46
Pluggable lint verifiers first step and basic lint task tests.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//848463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42778 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:44:57 +00:00
214a2380ca
Fix for NPE in the index store.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//823223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42777 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:38:52 +00:00
b161853940
Minor clean-ups and rename
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840473007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42776 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:36:14 +00:00
3df7d1b1e2
Remove coverage experiment.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//852433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42775 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:18:17 +00:00
63d8097fad
Use synthetic elements to recover from errors in signatures.dart.
...
BUG=https://code.google.com/p/dart/issues/detail?id=22021
R=karlklose@google.com , zarah@google.com
Review URL: https://codereview.chromium.org//845183004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42772 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 13:57:30 +00:00
f54164609b
Update invariant in class_members.dart.
...
Review URL: https://codereview.chromium.org//811933004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42770 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 12:45:21 +00:00
e2cbbcaef1
Non-fatal errors in compile-time constants.
...
BUG=https://code.google.com/p/dart/issues/detail?id=22018
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//829033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42768 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 10:17:36 +00:00
dc07285505
Non fatal errors on duplicated accessors.
...
BUG=https://code.google.com/p/dart/issues/detail?id=22019
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//841303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42767 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 10:15:29 +00:00
60e17ef3cd
Address comments from 820093006
...
R=zarah@google.com
Review URL: https://codereview.chromium.org//837563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42766 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 10:14:02 +00:00
95582bb710
Add deferred map info to dump-info.
...
I am not sure if we should bump the version property. That would require
an update of the viewer.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//831343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42763 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 08:25:29 +00:00
82d7224537
Style changes in assist and fix.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//825363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42760 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 23:18:03 +00:00
83ca7d2f30
Update errors offsets during incremental comment resolution.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42758 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:33:08 +00:00
e84aa1aa54
Fixes for linked and exit positions offsets.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//843163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42757 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:31:42 +00:00
11c0e607a0
Make domains plugable
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//846723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42756 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 22:15:20 +00:00
db4c9543ac
Remove computation with no effect from local completion computer.
...
The computation performed by _computeExcludeVoidReturn was always
being overwritten by the caller right after construction, so it had no
effect.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//830153004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42752 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 19:28:52 +00:00
7b3b86c38e
Fix flakiness in physical_resource_provider_test
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//840363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42751 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 19:20:53 +00:00
c63e50307a
Instrument file reads
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//825683005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42748 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 18:26:52 +00:00
f781ec6675
Add generateLints analysis option to the Server protocol API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//806943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42745 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:38:43 +00:00
ab9cc6e41e
dart2js: collect static-non-final fields in the task.
...
R=sigurdm@google.com , zarah@google.com
Review URL: https://codereview.chromium.org//830463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42744 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:23:53 +00:00
57ae728cf5
dart2js: Register constants in the model builder.
...
We need to make sure that constants are registered, as otherwise output units that only contain constants aren't generated.
R=zarah@google.com
Review URL: https://codereview.chromium.org//838643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42743 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:22:43 +00:00
9fb54ea3db
Capture log messages via instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42741 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:06:44 +00:00
c35a4acd9c
Fix order of operations dependencies in element_references_test
...
It's not safe for a single test to have two overlapping calls to
findElementReferences() because fields in the test class are used to
hold the search results and to keep track of whether more results are
pending.
Fixes a bogus test failure that arose after the relative ordering of
futures and microtasks was changed.
BUG=dartbug.com/22014
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42738 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 16:36:42 +00:00
86d9c01cd5
dart2js: Support new const operations on strings.
...
BUG= http://dartbug.com/21001
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//585173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42737 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 16:07:53 +00:00
b7de258068
Initial plugin API
...
R=danrubel@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//839833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42736 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:57:51 +00:00
2005b07aea
Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int
...
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//845553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:30:59 +00:00
1e3bca615b
Less fatal errors
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//820093006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42731 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 11:28:04 +00:00
3a66c29a6d
Add cleanUp function to Future.wait.
...
The cleanUp function is called on the values of successful futures,
so it can release any resources that were successfully allocated.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//815773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42730 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:52:15 +00:00
0803aae8df
Create erroneous element when resolution of initializer fails.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//821593004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42729 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:50:15 +00:00
e2b3d76994
Add option for outputting a deferred loading mapping.
...
With the option --deferred-map=<file> dart2js will output a json-file
describing which files will get loaded for a given deferred import.
The output looks like:
{
"_comment": "This mapping shows which compiled `.js` files are needed for a given deferred library import.",
"main.dart": {
"name": "mainLibrary",
"imports": {
"lib1": [
"out.js_2.part.js",
"out.js_1.part.js"
],
"lib2": [
"out.js_2.part.js",
"out.js_3.part.js"
],
"lib3": [
"out.js_5.part.js"
],
"lib4": [
"out.js_6.part.js"
]
}
},
"lib1.dart": {
"name": "<unnamed>",
"imports": {
"convert": [
"out.js_4.part.js"
]
}
}
}
BUG=dartbug.com/21869
R=floitsch@google.com
Review URL: https://codereview.chromium.org//785303003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42727 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:37:02 +00:00
04e6184abe
Handle platform access through prefix in dart2dart
...
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//839063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42726 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:29:59 +00:00
05ac43c3ea
Issue 22027. When parameters has function type alias type, use its name.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22027
Review URL: https://codereview.chromium.org//836413006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42720 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 22:10:36 +00:00
afc1893fc5
Use Logger instead of InstrumentationService.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//840083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42719 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 22:09:11 +00:00
501d449ecc
File-based and multicast InstrumentationServer implementations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//833633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42718 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 21:58:41 +00:00
3f6fc86c14
Remove remaining references to Angular and Polymer from the analysis server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//842753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42713 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:37:19 +00:00
46df250c5a
suggest fields rather than synthetic getters
...
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42712 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:35:52 +00:00
whesse@google.com