dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
43,463 Commits 2 Branches 0 Tags
e9915515e19b60d138d6eab8ae9fcbbf7900a137
Commit Graph

48 Commits

Author SHA1 Message Date
Jennifer Messerly 95d5bf471c fix analyzer failing resolve loop variable nodes 
for example: `var item; for (item in list) { ... }`

this happens anytime ResolutionCopier is used on these, because it drops the staticElement reference for `item` in the above example.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2612983002 .
 2017-01-05 10:47:43 -08:00
Jacob Richman 93fb5d8119 Fix cross-window JS interop on FireFox. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2610813003 .
 2017-01-04 14:15:20 -08:00
Jacob Richman 3659aaf181 Fix bug in Blob creation from workers. 
Fixes https://github.com/dart-lang/sdk/issues/28155

BUG=

Review-Url: https://codereview.chromium.org/2592813003 .
 2016-12-21 08:45:48 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Jennifer Messerly 77f53f609f fixes #27385, implement virtual fields in DDC 
If a field is marked @virtual in Analyzer, DDC will allow it to be overridden as well

also fixes #28114, abstract getters/setters broke generation of forwarding getters/setters

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2571363002 .
 2016-12-15 11:39:25 -08:00
Vijay Menon 392c242df9 Add dart:io stubs to ddc sdk, define dart.library.html 
Fixes #27302

R=brianwilkerson@google.com, jmesserly@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2578573003 .
 2016-12-14 12:34:33 -08:00
Bob Nystrom b900a39620 Implement messages in assert() in dev_compiler. 
Fix #27342.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2568313002 .
 2016-12-13 13:31:56 -08:00
Vijay Menon dd16c377fb Enable more async code on node 
This is primarily for easier testing/repro on node which has "global",
but not "self".

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2558133002 .
 2016-12-07 10:52:04 -08:00
Vijay Menon 201c5b9297 Fix runtime strong mode error in ListMixin 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2544163002 .
 2016-12-01 15:41:46 -08:00
Alan Knight 1ff09b431f Keep only a single active stack trace, enables traces for thrown non-exceptions 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2545923002 .
 2016-12-01 13:41:08 -08:00
Vijay Menon 106c623a9f Some fixes for lazy JS types 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2542833002 .
 2016-12-01 07:44:38 -08:00
Bob Nystrom aa749dbd8d Sprinkle some types on the SDK like the static typing fairy. 
When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.

This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)

R=vsm@google.com

Review URL: https://codereview.chromium.org/2542723003 .
 2016-11-30 17:04:54 -08:00
Alan Knight 667fc8dbe9 Make the dart:developer library available in DDC so debugger statement works 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2534263002 .
 2016-11-29 16:13:45 -08:00
Vijay Menon 88c5dd5745 Better mirrors support for mixins and private fields 
This is generally motivated by pageloader usage.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2535273002 .
 2016-11-29 14:00:01 -08:00
Jacob Richman 1b339deab2 Support lazy JS types. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2515353003 .
 2016-11-22 10:55:35 -08:00
Vijay Menon de9e3a3005 Set auto breakpoint at various errors 
Any reason not to do this?  I generally find when framework code wraps these errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger with the thought of making it configurable.

R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2519873004 .
 2016-11-21 14:40:46 -08:00
Jennifer Messerly 37029a22de fix #27336, ddc with recursive generic class type args 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2516483002 .
 2016-11-17 15:38:33 -08:00
Jacob Richman fb467ef68a Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2504733002 .
 2016-11-15 12:52:28 -08:00
Jacob Richman 27287baa57 Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2500283002 .
 2016-11-15 09:35:44 -08:00
Jennifer Messerly 3995146b55 fix #27775, enum declaration where "name" is a property 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2488543002 .
 2016-11-08 10:18:55 -08:00
Kevin Moore f05e2b0760 recompile for 4179bd7601 
Review URL: https://codereview.chromium.org/2484853002 .
 2016-11-07 11:02:36 -08:00
Bob Nystrom 8daf4cfb73 Get the basics of deferred libraries working. 
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.

The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.

BUG=#27343
R=vsm@google.com

Review URL: https://codereview.chromium.org/2477673006 .
 2016-11-07 10:41:23 -08:00
Vijay Menon 4874480d55 Move FF and Canary to green on travis 
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2467063002 .
 2016-11-03 07:44:27 -07:00
Vijay Menon 2d15b4ae74 Type-related fixes 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2468493003 .
 2016-10-31 15:01:29 -07:00
Jennifer Messerly 644c1dca75 fix #27429, html wrapper methods pass incorrect number of arguments 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2454173003 .
 2016-10-27 13:16:00 -07:00
Jennifer Messerly cc1ad8cdde fix #27532, implementing a native type with fields 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2430953006 .
 2016-10-20 15:59:18 -07:00
Jennifer Messerly 5111675810 fix #27631, get/set methods no longer shadow index operator 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2435163002 .
 2016-10-20 15:45:29 -07:00
Alan Knight 47150f50d5 Use dart:html prefixes (e.g. webkitAudioNode) on other browsers 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2431443002 .
 2016-10-19 16:43:41 -07:00
Jacob Richman 4f6ce11bc8 Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag that performs permissive dynamic calls on private members. Polish web_command.dart adding the ability to evaluate code in the context of an existing library. 
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2423313002 .
 2016-10-18 16:34:48 -07:00
Vijay Menon 852ef37f71 Some mirrors fixes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2415053004 .
 2016-10-14 12:19:24 -07:00
Vijay Menon 2495f6a060 Handle private members in dart:mirrors 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2410453002 .
 2016-10-10 15:55:20 -07:00
Bob Nystrom 9b6317d571 Stop using unittest in point_test and rectangle_test. 
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2407913002 .
 2016-10-10 11:02:37 -07:00
Bob Nystrom 20e402c43d Fix type errors in math.min() and math.max(). 
Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2386493003 .
 2016-09-30 13:18:07 -07:00
Bob Nystrom 2c313a43ac Fix some errors around []= in core types. 
- Get rid of JSMutableIndexable since it isn't useful.
- Make JSIndexable generic. (I think dart2js already did.)
- Add .length to NativeTypedArray since it no longer inherits it from
  JavaScriptIndexingBehavior.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2378423003 .
 2016-09-30 13:03:10 -07:00
John Messerly 1129d3d121 fix #27421, DDC did not generate implicit super calls in some cases 
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers

R=vsm@google.com

Review URL: https://codereview.chromium.org/2365053003 .
 2016-09-23 17:06:10 -07:00
John Messerly 361cd4c61c fix #27408, reverts "ignore dynamic in inference" 
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb

R=vsm@google.com

Review URL: https://codereview.chromium.org/2360973004 .
 2016-09-23 17:01:33 -07:00
John Messerly adc71ab396 re-land fix #27110 with proper DDC side of changes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2362563004 .
 2016-09-22 15:47:55 -07:00
Vijay Menon aae63b7e21 Regenerate DDC SDK 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2358323002 .
 2016-09-21 16:39:24 -07:00
Vijay Menon 8e943b8c59 Fix tests 
This fixed the original 5 static errors from this morning.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2356413002 .
 2016-09-21 13:59:55 -07:00
John Messerly aa85651820 fix #27403, use AST summaries in DDC 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2353133004 .
 2016-09-20 17:55:09 -07:00
Vijay Menon 9732138317 Testing support for FF and Safari 
Also travis support for testing FF.  See:

https://travis-ci.org/dart-lang/sdk/builds/159331789

On FF 48, 1965 out of 1979 tests are passing.  Run locally:
DDC_BROWSERS=Firefox npm test

On Safari 10 (tech preview), it fails immediately due to a static method named "caller".  We disallow it as a field, but not a method right now.  If I hack that out, 1972 out of 1979 tests appear to pass.

Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2334763002 .
 2016-09-14 08:41:43 -07:00
Bob Nystrom 33ff9a3d4f Fix type errors in sort(). 
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2311513002 .
 2016-09-08 17:14:36 -07:00
Bob Nystrom 8c7dd5cd04 Cast InternalMap to Map. 
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2304323002 .
 2016-09-08 16:23:45 -07:00
Jacob Richman 38724f0626 Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2303163002 .
 2016-09-06 09:57:05 -07:00
Vijay Menon 0c8cd45dea Regen and fix expectations 
Caught by travis :-)

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2300753006 .
 2016-09-01 15:11:40 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support 
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
 2016-09-01 10:13:31 -07:00
Vijay Menon 2bc19eaa64 Remove deprecated code 
Updating to the latest analyzer.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2289263004 .
 2016-08-30 15:39:38 -07:00
John Messerly c1139934a7 fix #626, add AMD module format and make it default 
R=nweiz@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2249233002 .
 2016-08-25 09:39:36 -07:00