dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
41,997 Commits 2 Branches 0 Tags
e984271b94de3d4a72d52a3722e8ffb58da25dde
Commit Graph

45 Commits

Author SHA1 Message Date
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
sra@google.com 904c18efcc Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45301

Committed: https://code.google.com/p/dart/source/detail?r=45303

Reverted: https://codereview.chromium.org/1096433006/

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45307 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 01:32:49 +00:00
sra@google.com 736007062a Revert "Enforce token syntax for CssClassSet arguments" 
TBR=terry@google.com
BUG=

Review URL: https://codereview.chromium.org//1096433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45306 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 01:14:32 +00:00
sra@google.com a1850bb69a Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45301

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45303 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 00:37:10 +00:00
sra@google.com ec484da9f6 Revert "Enforce token syntax for CssClassSet arguments" 
Review URL: https://codereview.chromium.org//1098073003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45302 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 00:25:54 +00:00
sra@google.com 01d3e99f18 Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45301 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 23:44:11 +00:00
sra@google.com efc7d09945 Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45266 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 01:58:20 +00:00
sra@google.com 08676965c4 Enforce token syntax for CssClassSet arguments 
Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45265 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 01:53:21 +00:00
sra@google.com 2956fd8739 - Fork implementation for Dartium and dart2js. Dartium is working fine. 
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44888

Committed: https://code.google.com/p/dart/source/detail?r=44897

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44898 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 23:00:28 +00:00
sra@google.com 3080315805 - Fork implementation for Dartium and dart2js. Dartium is working fine. 
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44888

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44897 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:38:56 +00:00
sra@google.com ade70628de - Fork implementation for Dartium and dart2js. Dartium is working fine. 
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44888 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:48:10 +00:00
sra@google.com b68a69329f Add type annotations to some dart:html closures 
This helps code quality when the types can be trusted or verified.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//891583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43349 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-30 23:08:39 +00:00
amouravski@google.com fce5971f4f o/~ Y muchos maaaaaaas... o/~ 
Review URL: https://codereview.chromium.org//68513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30175 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 22:10:12 +00:00
kevmoo@j832.com cf134382a1 Set.add returns true if item has been added, otherwise false 
BUG= https://code.google.com/p/dart/issues/detail?id=3546
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26280002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28863 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 17:24:24 +00:00
jacobr@google.com 1fdd1a34b2 Utility methods used for dartium debugger integration. 
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.

This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//18125007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25032 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-15 22:57:04 +00:00
efortuna@google.com 7c20ac6514 Added boolean to toggle. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//18583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24938 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 02:00:38 +00:00
efortuna@google.com 6f7ef4126d Reapply "Aggregate CSS manipulation functions in html lib." (r22400) 
BUG=

Review URL: https://codereview.chromium.org//14931008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22424 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 16:27:16 +00:00
efortuna@google.com 33b4567f83 "Reverting 22400" 
BUG=

Review URL: https://codereview.chromium.org//14965003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22401 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:12:34 +00:00
efortuna@google.com 5e07799aba Aggregate CSS manipulation functions in html lib. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//14941002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22400 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:04:15 +00:00
ajohnsen@google.com 044f0d02eb Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove. 
BUG=

Review URL: https://codereview.chromium.org//14173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21338 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-12 09:34:52 +00:00
lrn@google.com f41508d33b Added new version of reduce. 
Removed min/max and uses of min/max.

Review URL: https://codereview.chromium.org//14071002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21258 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-11 08:32:31 +00:00
floitsch@google.com 62358bf5e2 Make default argument to Iterable.join be "". 
Review URL: https://codereview.chromium.org//13945009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21193 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-10 11:28:32 +00:00
floitsch@google.com bef8ebb5f6 Add Iterable.fold (and Stream.fold) which replace reduce. 
For now this is just a copy. In a next step we will change the behavior of
`reduce`.

BUG= http://dartbug.com/9536

Review URL: https://codereview.chromium.org//13548002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20978 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 16:12:40 +00:00
efortuna@google.com f364ed048a Add toggleAll to CSSClassSet. 
BUG=

Review URL: https://codereview.chromium.org//12851014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20263 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-20 00:39:40 +00:00
lrn@google.com 9de16edc1c Fix CssClassSet methods to accept Set, not Collection. 
Review URL: https://codereview.chromium.org//12493014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20006 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 11:54:04 +00:00
lrn@google.com 5768211906 Make Set.containsAll accept Iterable. Deprecate Set.isSubsetOf. 
This is a recommit of the earlier reverted CL with updated test expectations.

Review URL: https://codereview.chromium.org//12544024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19993 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 09:32:30 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere. 
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 17:34:49 +00:00
blois@google.com a94084913c Fixing a number of dart:html analyzer issues 
A couple of real bugs, rotten code and deprecated APIs.

BUG=

Review URL: https://codereview.chromium.org//12510003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19588 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-06 22:46:34 +00:00
lrn@google.com f4300b84a2 Make List.from and Iterable.toList default to not growable. 
Review URL: https://codereview.chromium.org//12401002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19391 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-04 14:55:40 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list. 
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-27 08:45:04 +00:00
floitsch@google.com ecce8a6293 Remove deprecated Strings class. 
Review URL: https://codereview.chromium.org//12295014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-19 13:57:03 +00:00
lrn@google.com 03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. 
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-18 10:35:51 +00:00
rnystrom@google.com 0e0473d33a Unbreak pub: 
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Review URL: https://codereview.chromium.org//12286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 18:38:42 +00:00
floitsch@google.com 0672317bec Remove deprecated mappedBy. 
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy." 
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy. 
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:18:17 +00:00
lrn@google.com 77f96ff103 Fix type bug in CssClassSet. 
Review URL: https://codereview.chromium.org//12225009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18130 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-05 11:44:22 +00:00
lrn@google.com 2a7fb1c733 Added expand method to iterables. 
Review URL: https://codereview.chromium.org//12188011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18123 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-05 09:48:05 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map." 
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map." 
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map. 
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 12:37:13 +00:00
lrn@google.com 0e934a631e Add methods to Collection. 
Methods are:
- void add(E)
- void addAll(Iterable<E>)
- void remove(Object)
- void removeAll(Iterable)
- void retainAll(Iterable)
- void removeMatching(bool test(E))
- void retainMatching(bool test(E))

They have been implemented for List and Set only.

Default implementations of removeX methods in Collections assume an efficient
remove method, which Lists won't have.

Review URL: https://codereview.chromium.org//11931034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17257 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 10:13:51 +00:00
blois@google.com e723b69be9 Fixes for a number of dart analyzer issues in dart:html. 
These are mostly just adding missing methods fixing a few typos from the experimental merge.

BUG=

Review URL: https://codereview.chromium.org//11817059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17035 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-14 23:36:14 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge. 
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-07 11:23:16 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools. 
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-28 22:26:48 +00:00