Harry Terkelsen
1d749a2fec
record that Gamepad.buttons creates GamepadButtons
...
This also extends the html generator to be able to generate List implementations with nullable element types
Fixes https://github.com/dart-lang/sdk/issues/27073
R=sra@google.com , terry@google.com
Review URL: https://codereview.chromium.org/2242203002 .
2016-08-16 13:56:32 -07:00
Jacob Richman
f26e522f84
Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1987073002 .
2016-05-18 12:49:09 -07:00
Alan Knight
810faa31b9
Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)
...
BUG=
Review URL: https://codereview.chromium.org/1885943002 .
2016-04-16 16:26:14 -07:00
Alan Knight
a718c8dac9
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383 .
BUG=
Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Jacob Richman
c65854d2e4
Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
...
BUG=
Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Terry Lucas
e1a33e9981
Moved ChromiumSubscribeUniform to web_gl
...
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting
TBR=alanknight@google.com ,jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc
Review URL: https://codereview.chromium.org/1752983003 .
2016-03-02 08:15:45 -08:00
Terry Lucas
a3350d9b06
Generation of sdk/lib files from 45 roll
...
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1720743005 .
2016-02-22 10:59:12 -08:00
Jacob Richman
f478562b0a
Dartium 45 roll
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1682783002 .
2016-02-09 10:50:43 -08:00
Terry L. Lucas
7b322c246c
Dartium JS Enabled take 2
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas
09c804aa78
Revert "Dartium JS Interop enabled."
...
This reverts commit 403bd1698d .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas
403bd1698d
Dartium JS Interop enabled.
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas
9b0d2582fc
Revert "Dartium w/ JsInterop enabled"
...
This reverts commit 346af54711 .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas
346af54711
Dartium w/ JsInterop enabled
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas
012c998f64
Revert "Patched in Dartium JsInterop"
...
This reverts commit 4bb2e617db .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas
4bb2e617db
Patched in Dartium JsInterop
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
Terry L. Lucas
cec5812335
Fixed Dictionary and Event hookup w/o --gen-interop
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//1233083004 .
2015-07-14 14:18:48 -07:00
Terry L. Lucas
4947e570d4
Changed to use JSInterop
...
Review URL: https://codereview.chromium.org//1173403004 .
2015-07-13 12:38:16 -07:00
alanknight@google.com
5397482fcc
Make dartj2s do type conversions on constructor arguments
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1023363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:39:49 +00:00
sra@google.com
904433bd7c
Revert "Annotate dart:html constructor expressions with precise non-nullable types."
...
Need to fix some html/element_types_test cases.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//904663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43579 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:35:32 +00:00
sra@google.com
f74e57786d
Annotate dart:html constructor expressions with precise non-nullable types.
...
This addresses issue http://dartbug.com/22264
R=alanknight@google.com
Review URL: https://codereview.chromium.org//896723009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43578 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 23:24:19 +00:00
leafp@google.com
6de1786199
Arity indexing in dart:blink entry points
...
This CL replaces type mangling on the blink entry points with arity indexing. So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types). This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/ ). For the time being, the dart side overload resolution code is left in place.
Resolver strings now have no type or arity info as well.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//667983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41236 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 20:46:55 +00:00
vsm@google.com
8a39ccb8df
Fix for web_gl statics
...
This was fixed on trunk / 1.7 separately. Here's the same for bleeding_edge:
BUG=https://code.google.com/p/dart/issues/detail?id=21173
R=leafp@google.com
Review URL: https://codereview.chromium.org//618323004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41045 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 16:40:01 +00:00
terry@google.com
42a229cbb7
Fixed removing of pure interface (implements) operations
...
Reviewers:vsm@google.com ,leafp@google.com
R=vsm@google.com
Review URL: https://codereview.chromium.org//560263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40227 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 23:50:35 +00:00
vsm@google.com
e379d380bc
Migrate to Chrome 37 IDL
...
This enables terry's new scripts with fixes from vsm and leafp (tested in the dartium_integration branch).
R=leafp@google.com
Review URL: https://codereview.chromium.org//569783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40219 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:18:06 +00:00
terry@google.com
ecceb75d35
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39948
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 13:18:24 +00:00
leafp@google.com
8e3aaa4e75
Blink uses types in entry points
...
This CL changes the way that blink entry points are named to
use the type signature uniformly. This makes us somewhat
more robust against changes in the idl.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//552533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40006 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 00:17:15 +00:00
terry@google.com
ac72bce2f1
"Reverting 39948"
...
BUG=
Review URL: https://codereview.chromium.org//554853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 20:58:19 +00:00
terry@google.com
cf0c6a3565
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 02:33:50 +00:00
leafp@google.com
445e8fda3d
Eliminate the old non blink code paths from idl generation
...
During the transition to the dart:html dart:blink split, we needed to support generating the old style and the new style. This CL eliminates the code paths for the old style generation now that they're no longer needed.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//450693005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39005 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 20:04:18 +00:00
leafp@google.com
a20d4b09d2
Remove dart:blink dependency on dart:html. This CL moves all of the
...
overload resolution (dependent on dart specific types) over to the
dart:html side, along with the type resolution maps. This is a first
step to generating dart:blink from the dartium idl. There is a paired
blink CL which switches the type map lookup from dart:blink to dart:html.
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//446193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38993 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 16:12:50 +00:00
leafp@google.com
851e41a408
Fix overloading for IDBDatabase transaction
...
Use the underlying dart implementation class in overloading resolution
checks, rather than the dart interface which is presented to the
user. This resolves an issue with IDBDatabase in which DOMStringList
and sequence<DOMString> have the same Dart interface type
(List<String>), even though the underlying implementation types differ
(List<String> vs DomStringList).
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//368433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37883 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 17:24:47 +00:00
leafp@google.com
476278985c
Refactor dart:_blink into classes to improve startup time.
...
This CL reduces the snapshot size by about 20% (580kb).
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//319283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37189 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 17:38:29 +00:00
vsm@google.com
b8464a3dde
Suppress cloning EventTarget methods in subtypes when using blink
...
I have an forthcoming Blink CL to safely cast to EventTarget*.
Not sure this is the right path long term.
Review URL: https://codereview.chromium.org//283043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36166 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 13:46:10 +00:00
leafp@google.com
d1f0594840
Initial overloading implementation in _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//260893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
leafp@google.com
5e0688e1ec
This CL contains all of the changes for splitting off all of the native
...
calls from dart:html into dart:blink. As currently configured, the
dart:blink library will be empty and unused. The only changes in the
idl generated dart and C++ code in the default configuration should
be cosmetic. The global variable "dart_use_blink" in systemnative.py
currently controls whether or not the real blink library is
generated. Enabling this requires as yet unchecked in changes to
blink. These changes are expected to land as part of the chrome
35 roll.
Support for building with/without blink
DOM changes for checked receivers
Dartium native call generation refactor
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//254463006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35430 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:22:08 +00:00
jacobr@google.com
e9bcf2ddca
Make the Dart code generators handle the Image constructor specified in the IDL without crashing or generating multiple constructors.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//142563006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32621 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 20:47:13 +00:00
vsm@google.com
eebdf4ccf9
Revert "Revert "Revert "Fix dart2js type warnings"""
...
Hitting layout test failures in Dartium now....
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//134623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31702 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:27:09 +00:00
vsm@google.com
f236af9969
Revert "Revert "Fix dart2js type warnings""
...
Retrying with a fix. Patch 1 is initial change.
BUG=15954
R=blois@google.com
Review URL: https://codereview.chromium.org//126873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31699 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:00:03 +00:00
kasperl@google.com
1bbe4d5452
Make sure that classes in dart:html do not implement both List and List<E>.
...
R=johnniwinther@google.com , blois@google.com
BUG=
Review URL: https://codereview.chromium.org//50263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29417 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:37:10 +00:00
efortuna@google.com
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
blois@google.com
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
blois@google.com
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
blois@google.com
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
efortuna@google.com
035e04fb2d
Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
...
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com
Review URL: https://codereview.chromium.org//27033009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
blois@google.com
f51dad91fd
Untyping List types
...
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.
BUG=
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27227002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
efortuna@google.com
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
blois@google.com
d312cbbd08
Exposing document.createElement
...
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//24084004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
asiva@google.com
4d8651f8af
1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
...
2. Fix templateloader to deal with nested 'if' conditions
R=vsm@google.com
Review URL: https://codereview.chromium.org//23534050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00