Commit Graph

7 Commits

Author SHA1 Message Date
lrn@google.com 1ffd31fcde Fix assert in dart:math/Rectangle.
Didn't pass NaN down the correct path, and failed an assertion.
Added tests.

BUG= http://dartbug.com/17734
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//228533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34822 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:12:21 +00:00
lrn@google.com e314fc2671 Make Rectangle and MutableRectangle constructors handle negative lengths.
Now handles negative width/height so that it's equivalent to
   new Rectangle.fromPoints(new Point(left, top),
                            new Point(left + width, top + height))

BUG= http://dartbug.com/16167
R=efortuna@google.com

Review URL: https://codereview.chromium.org//135273009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32736 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 10:12:23 +00:00
lrn@google.com 1c27022d7c Change Rectangle.operator== to compare right/bottom instead of width/height.
BUG= http://dartbug.com/16245
R=efortuna@google.com

Review URL: https://codereview.chromium.org//145973005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32155 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 09:54:44 +00:00
efortuna@google.com 4a8d13f0f6 Fix Rectangle test with method name.
BUG=

Review URL: https://codereview.chromium.org//41073004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29205 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 20:48:44 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
efortuna@google.com 0b53b15b7d "Reverting 28184"
TBR=blois

BUG=

Review URL: https://codereview.chromium.org//25785003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28186 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 22:13:16 +00:00
efortuna@google.com 837c6b6ee3 Move Point and Rect over to dart:math, to be re-exported by dart:html.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28184 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:54:02 +00:00