Commit Graph

53 Commits

Author SHA1 Message Date
Johnni Winther 614cde5b1c Split World usage into open, inference, and closed world.
This is a step towards separating the backend element model from the frontend model.

Main changes in world.dart.

R=het@google.com

Review URL: https://codereview.chromium.org/2314703002 .
2016-09-21 10:54:34 +02:00
Harry Terkelsen 3d31aa2ff7 dart2js: run dartfmt on tests
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2345083003 .
2016-09-16 15:49:23 -07:00
Johnni Winther 380c0bf3cb Make Enqueuer a pure interface.
R=sra@google.com

Review URL: https://codereview.chromium.org/2289353003 .
2016-09-02 09:00:12 +02:00
Harry Terkelsen c5728623b9 remove dependency on compiler from resolution
This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2123073003 .
2016-07-18 10:40:21 -07:00
Sigmund Cherem b741e3f0df Make CompilerTask independent of compiler.
Now this base class only has logic for measuring time.

R=het@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org/2000323006 .
2016-05-25 09:11:08 -07:00
Johnni Winther 50b85640b3 Change dart2js.dart to use compiler_new.dart
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1973753004 .
2016-05-17 12:27:23 +02:00
Johnni Winther 0e537d8086 Refactor unittests
Move serialization tests into subfolder
Move data files into data subfolders
Move tests with errors/warnings into quarantined subfolder
Skip packages/ folder in test

The latter three improves workflow in IntelliJ; providing error/warning free analysis of unittests (by exclusion of folders).

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1934883002 .
2016-05-03 10:44:13 +02:00
Harry Terkelsen ce37fbcb3d Refactor Parsing to remove compiler dependency
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1892183002 .
2016-04-15 13:03:02 -07:00
Harry Terkelsen 9f8427d041 Begin refactoring compiler out of diet parser and scanner
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1867243004 .
2016-04-08 14:11:19 -07:00
Erik Ernst 586c43ac7e Repeats and fixes the changes landed & reverted as CL 1789553003.
When landed, CL 1789553003 turned out to cause bot failures because
some libraries outside the compiler are importing compiler libraries
which have been updated. For instance, the tests in 'compiler/dart2js'
depend on several internal elements of the 'dart2js' compiler.

This CL updates these external dependents to work with the modified
library structure and class APIs of the compiler. A small adjustment
was applied to 'dart2js_incremental' as well.

No further dependents are believed to exist: Grepping in sdk for
relevant imports does not reveal any further imports of any of the
libraries in the compiler where the "interface" has changed, and
external clients are not supported (that is, imports in arbitrary
github repositories may or may not break if they use the compiler
internals, but we do not support this type of dependency so we won't
do anything to protect them against that type of breakage).

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1864433004 .
2016-04-05 17:26:07 +02:00
Johnni Winther ff31372564 Fix exit_code_test after refactoring.
The test was broken by https://codereview.chromium.org/1819053002

Review URL: https://codereview.chromium.org/1836033003 .
2016-03-29 11:18:01 +02:00
Sigmund Cherem 4f3a7cb86e Move all flags to CompilerOptions (first step to stop passing the compiler to
just get the options in the future).

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1803303002 .
2016-03-17 16:42:02 -07:00
Sigurd Meldgaard e3b926849f Rename apiimpl.Compiler to CompilerImpl.
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1409803006 .
2015-10-29 13:23:55 +01:00
Johnni Winther 5a956826a5 Move WorldImpact to universe/world_impact.dart
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1394793004.
2015-10-14 15:22:40 +02:00
Johnni Winther 76b7203c19 Extract DiagnosticReporter implementation from Compiler.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1383483006.
2015-10-06 10:24:44 +02:00
Johnni Winther 1590970ccc Report info messages together with their error, warning, or hint.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1363993004.
2015-09-24 15:08:29 +02:00
Johnni Winther f5a7be0c17 Split scannerlib.dart into several libraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1315483006.
2015-09-01 15:39:31 +02:00
Johnni Winther 930bc75c0d Move diagnostic_listener.dart and messages.dart to the diagnostics folder
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1286143003.
2015-08-12 12:05:36 +02:00
Johnni Winther a7c720f61b Remove dart2jslib.dart
dart2jslib.dart is deleted
compiler.dart is a library containing mainly Compiler
other parts of compiler.dart move according to the listing in https://codereview.chromium.org/1280343002/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1284593003.
2015-08-12 08:42:46 +02:00
Johnni Winther dab1aaae45 Move dart2jslib parts into separate libraries.
BUG=
R=karlklose@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4474acf36bb3b7d10a6fcce0c03de499055401e2

Reverted: https://github.com/dart-lang/sdk/commit/5af48434320f973bd8ae0fd402d9e33f5765420a

Review URL: https://codereview.chromium.org//1284673003.
2015-08-11 09:56:49 +02:00
William Hesse 5af4843432 Revert "Move dart2jslib parts into separate libraries."
This reverts commit 4474acf36b.

BUG=

Review URL: https://codereview.chromium.org//1278503004 .
2015-08-10 16:57:07 +02:00
Johnni Winther 4474acf36b Move dart2jslib parts into separate libraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1284673003.
2015-08-10 16:19:02 +02:00
Johnni Winther 0da5b34305 Add interfaces for a new compiler API.
Main changes are in the added files, compiler/compiler.dart, src/compiler.dart and src/apiimpl.dart.

Start by looking at compiler/compiler_new.dart and compiler/compiler.dart.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1235563003.
2015-07-13 21:15:23 +02:00
Harry Terkelsen 63681d5b59 Support Package Resolution Configuration files.
BUG=http://dartbug.com/23371
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/36c29d05bcc1dfe43a2f95698df5b41857f93221

Review URL: https://codereview.chromium.org//1162363004.
2015-06-09 11:07:11 -07:00
Harry Terkelsen fcd407b0cf Revert "Support Package Resolution Configuration files."
This reverts commit 36c29d05bc.

BUG=

Review URL: https://codereview.chromium.org//1165943005
2015-06-04 15:55:13 -07:00
Harry Terkelsen 36c29d05bc Support Package Resolution Configuration files.
BUG=http://dartbug.com/23371
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1162363004
2015-06-04 15:15:09 -07:00
Johnni Winther 96efb7bde8 Introduce WorldImpact
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1146813009
2015-06-01 14:43:30 +02:00
johnniwinther@google.com 62167b954f Move constant systems into their own libraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1091443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45241 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 16:29:44 +00:00
sigmund@google.com fd35f3cbfe Add fatal-warnings flag, that turns warnings into compilation errors (the name
fatal-warnings was choosen to match the flag in dartanalyzer)

BUG= http://dartbug.com/8803
R=johnniwinther@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//1077373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45190 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 23:17:21 +00:00
ahe@google.com 5ec13e7ab7 Remove CompilerCancelledException.
Review URL: https://codereview.chromium.org//848003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42862 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 12:51:41 +00:00
ahe@google.com b4bce1d537 Remove dependencies on reportFatalError from tests.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//836313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42679 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 08:38:07 +00:00
johnniwinther@google.com a2dddc825a Remove Compiler.assembledCode.
BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42592

Review URL: https://codereview.chromium.org//832363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42623 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 11:06:23 +00:00
johnniwinther@google.com f4b878129c Revert "Remove Compiler.assembledCode."
This reverts commit r42592.

BUG=

Review URL: https://codereview.chromium.org//824103005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42594 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 14:38:00 +00:00
johnniwinther@google.com fbc1274183 Remove Compiler.assembledCode.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//832363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42592 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 14:06:51 +00:00
johnniwinther@google.com 798f0417e5 Emit warning on import of dart:mirrors.
BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41688

Review URL: https://codereview.chromium.org//588183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41822 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 09:20:14 +00:00
floitsch@google.com fa10f0b77d Revert "Emit warning on import of dart:mirrors."
This reverts commit r41688.

Review URL: https://codereview.chromium.org//717103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41692 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-12 15:28:40 +00:00
johnniwinther@google.com 88c7dfa8f7 Emit warning on import of dart:mirrors.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//588183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41688 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-12 13:19:59 +00:00
johnniwinther@google.com 09fbe78e71 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//694353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:51:01 +00:00
johnniwinther@google.com 8637cfd322 Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
This reverts commit r41512.

BUG=

Review URL: https://codereview.chromium.org//693183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
johnniwinther@google.com 2b336e17f0 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//690103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00
karlklose@google.com e4dd01b833 Cleanup warnings in unit tests.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//368833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38080 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 09:29:01 +00:00
johnniwinther@google.com 2e4b3bd874 Load patches via callback.
This CL is a prerequisite for moving patching to the JavaScript backend.

BUG=
R=ahe@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//350693007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37651 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 10:40:17 +00:00
ahe@google.com 98523c01f8 Update imports to use package:compiler and package:try.
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//341923005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37538 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 10:33:46 +00:00
johnniwinther@google.com 35b9debf90 Remove scanBuiltinLibraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//339563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37391 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 12:58:39 +00:00
johnniwinther@google.com fbe2b8bcc7 Compute frontend/backend specific constants.
BUG=
R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34811

Review URL: https://codereview.chromium.org//221873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34862 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 07:40:54 +00:00
johnniwinther@google.com eb2cc7614b Revert "Compute frontend/backend specific constants."
This reverts commit r34811.

BUG=

Review URL: https://codereview.chromium.org//226953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34816 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 10:18:09 +00:00
johnniwinther@google.com 33c86b9fcd Compute frontend/backend specific constants.
BUG=
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//221873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34811 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 07:11:45 +00:00
johnniwinther@google.com 7c9b135629 Remove cancel and make crash exit with code 253.
BUG=http://dartbug.com/17557
R=karlklose@google.com

Review URL: https://codereview.chromium.org//206193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34238 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:44:42 +00:00
karlklose@google.com 138e83a682 Remove InstanceMirrorMixin from type mirrors and add argument checks in isSubclassOf.
This makes dart2js/mirrors/relation_subclass_test pass in unchecked mode and removes warnings about a missing InstanceMirror.type from two implementation of TypeMirror.

This CL also marks the exit_code_test as Skip, because it does not work in unchecked mode.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//195893030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33740 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 12:21:54 +00:00
johnniwinther@google.com 083d2e5e7f Clean up dart2js diagnostics to prepare for filtering.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//169763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32847 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 09:32:37 +00:00