8061bd5a8a
Add local variable declaration token position to service protocol
...
- [x] Add three public fields to the "BoundVariable" service type: declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function parameters, and closure captured variables.
Fixes https://github.com/dart-lang/sdk/issues/25569
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2419013004 .
2016-10-17 11:18:24 -07:00
d483b0d2af
Mark reload_sources_test as slow
...
BUG=
Review URL: https://codereview.chromium.org/2416013002 .
2016-10-13 11:02:36 -07:00
2d0a08baf9
Make reloadSources service RPC public
...
- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true, the isolate will enter the debug pause loop immediately after reloading sources and before resuming execution. This makes it possible for debugger clients to set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2411153002 .
2016-10-13 07:45:56 -07:00
25e3b30560
Update status for failing tests
...
BUG=https://github.com/dart-lang/sdk/issues/27557
R=floitsch@google.com
Review URL: https://codereview.chromium.org/2405843002 .
2016-10-10 16:26:55 +02:00
8b37da82ef
Support paths which are encoded with base64 in http put devfs server code
...
- [x] Add a new header 'dev_fs_path_b64' which is used over 'dev_fs_path' when present.
- [x] 'dev_fs_path_b64' expects the path encoded as UTF8 and then BASE64.
- [x] Add unit test case.
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2386123005 .
2016-10-04 15:31:09 -07:00
1a802d3517
Fix random test failures for issue_27238_test
...
BUG=27238
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2378923006 .
2016-09-30 11:14:03 -07:00
1b5533fe8f
Use a larger sleep time in get_allocation_profile_rpc_test so that the test doesn't flake on Windows
...
Fixes #27444
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org/2378813002 .
2016-09-28 12:45:02 -07:00
e8a9a06528
Fix status file for debugger_location_test.
...
BUG=
Review URL: https://codereview.chromium.org/2371283002 .
2016-09-27 15:51:58 -07:00
2ed4f4725a
Status file tweak
...
BUG=
Review URL: https://codereview.chromium.org/2377743002 .
2016-09-27 13:02:39 -07:00
52f9fac257
Split debugger_location_test into two separate tests
...
Fixes #27434
R=asiva@google.com
Review URL: https://codereview.chromium.org/2376433003 .
2016-09-27 10:59:46 -07:00
ce596133ad
Skip service/debugger_location_test see Issue 27434.
...
BUG=
Review URL: https://codereview.chromium.org/2370193002 .
2016-09-26 21:15:45 -07:00
48c6f19600
Respect setLibraryDebuggable
...
- [x] Mark all libraries debuggable by default
- [x] Mark all dart:_* libraries as not debuggable by default
- [x] Respect setLibraryDebuggable
- [x] Add set library debuggable test case
- [x] Do not allow dart:_* libraries to be marked debuggable
Fixes https://github.com/dart-lang/sdk/issues/27370
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2361183002 .
2016-09-23 10:45:51 -07:00
74e779d4fe
Fix stepping over await statements
...
When async-stepping over an await statement that follows a previous
async-step command, ensure that the synthetic breakpoint at the
beginning of the async closure is not accidentally deleted.
Removing a test that depends on minute details of the internal
implementation of async-step commands.
Adding new test that checks for multiple consecutive async-step
commands.
Note that debugger.cc seems to contain a memory leak. Breakpoint
objects are not deleted (deallocated) when RemoveBreakpoint()
is called. Will address this in a separate CL.
BUG=#27238
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2366463002 .
2016-09-22 14:06:24 -07:00
92cd3e10f5
Fix test.py and tests to use an explicit --packages flag.
...
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2361813003 .
2016-09-22 17:51:09 +02:00
0dd760092d
Add debugger safe point on assignment to global variables
...
Just like we do for local variables, add a debug step check (and
thus a breakpoint location) to global variable assignment if
the right side of the assignment has no possible breakpoint locations.
BUG=#27287
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2354773002 .
2016-09-20 14:05:45 -07:00
80572c4038
Update status for browser tests
...
BUG=
R=eernst@google.com
Review URL: https://codereview.chromium.org/2358583002 .
2016-09-20 16:36:01 +02:00
699e328105
Fix VM connect element test
...
BUG=
Review URL: https://codereview.chromium.org/2348313002 .
2016-09-19 07:33:44 -07:00
d5f138e459
Fix async_generator_breakpoint_test so it awaits on isolate resume requests
...
BUG=
Review URL: https://codereview.chromium.org/2344253002 .
2016-09-16 11:24:53 -07:00
e2b922b4c5
Fix service test websocket error edge case
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2343183002 .
2016-09-16 10:31:05 -07:00
0d831bd5c8
Use Chain.capture instead of runZoned
...
- [x] Swap all calls of runZoned to Chain.capture.
Chain.capture is a wrapper around runZoned that tracks stack traces across asynchronous gaps.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2349753002 .
2016-09-16 09:44:06 -07:00
5177c2bca9
Removed polymer & mirror from Observatory
...
web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version
Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2310003004 .
2016-09-07 14:15:27 -07:00
2eab4de315
Converted Observatory logging-page element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2299893003 .
2016-09-02 10:27:48 -07:00
63f1261064
Update status file for issue 27225.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2301263002 .
2016-09-01 15:57:39 -07:00
741d99f100
Converted Observatory code-view element
...
Not fully testable
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2306483002 .
2016-09-01 13:56:45 -07:00
90c50c52f2
Converted Observatory vm-view && isolate-view elements
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2304463002 .
2016-09-01 10:46:36 -07:00
7bceafd11e
Update all packages in third_party/pkg to latest compatible version
...
Packages markdown and stack_trace are not updated, because of their high impact.
They will be updated in separate CLs.
BUG=
R=nweiz@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2297213002 .
2016-09-01 10:12:23 +02:00
1341e94321
Converted Observatory class-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2294073003 .
2016-08-31 17:03:38 -07:00
cd8292d175
Don't return negative token positions in stack traces.
...
Closes #27128
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2294883004 .
2016-08-31 16:22:18 -07:00
8561986221
Removed warnings from service tests
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2296043002 .
2016-08-30 17:01:05 -07:00
c80b23b7ff
Fix evaluating in async/sync*/async* methods.
...
Fixes #27167 .
R=hausner@google.com
Review URL: https://codereview.chromium.org/2291293003 .
2016-08-30 15:16:57 -07:00
bf7d220741
Converted Observatory instance-view element
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2291233002 .
2016-08-30 14:53:24 -07:00
19e9627ea0
Converted Observatory library-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2289953003 .
2016-08-30 13:58:15 -07:00
b63546ac57
Converted Observatory function-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2291823002 .
2016-08-29 16:39:38 -07:00
a326a56eb1
Converted Observatory object-pool-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2283863003 .
2016-08-29 11:14:18 -07:00
8e7725a8b4
Converted Observatory field-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2287793002 .
2016-08-29 10:47:05 -07:00
f6680d13a2
One more round of status file updates to get the bots green.
...
TBR=sra@google.com
Review URL: https://codereview.chromium.org/2285213003 .
2016-08-29 08:14:33 -07:00
342eb3f296
Additional status file fixes
...
TBR=sra@google.com
Review URL: https://codereview.chromium.org/2283273002 .
2016-08-26 18:29:19 -07:00
5e1b224ef8
Converted Observatory megamorphiccache-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2279203003 .
2016-08-26 15:22:51 -07:00
07a0034bac
Fix status of observatory test with fast-startup emitter
...
TBR=sra@google.com
Review URL: https://codereview.chromium.org/2280183003 .
2016-08-26 13:54:31 -07:00
13a090a879
More status fixes
...
TBR=sra@google.com ,het@google.com
Review URL: https://codereview.chromium.org/2280193002 .
2016-08-26 13:46:14 -07:00
2dbd1b2158
Converted Observatory error-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2286503002 .
2016-08-26 10:23:34 -07:00
12e8f86cf6
Converted Observatory persistent-hangles-page element
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2273203004 .
2016-08-26 10:15:34 -07:00
4f96ad0440
Converted Observatory objectstore-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2274013006 .
2016-08-26 09:44:24 -07:00
c39868c8a5
Converted script-inset, source-inset and eval-box elements
...
Testing postponed
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2277543004 .
2016-08-26 09:27:56 -07:00
93432ec751
Disabled allocation-profile & cpu-profile-table tests on firefox & safari
...
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org/2282543002 .
2016-08-25 17:03:39 -07:00
942918347c
Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField
...
Fixes=https://github.com/dart-lang/sdk/issues/27146
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2277093002 .
2016-08-24 16:56:57 -07:00
3d415d5ac0
Converted Observatory icdata-view element
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2271083002 .
2016-08-24 09:33:37 -07:00
44d2b85d3d
Converted Observatory cpu-profile-table element
...
Fixes=https://github.com/dart-lang/sdk/issues/27116
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2273993002 .
2016-08-24 08:51:37 -07:00
fc6954171e
Converted Observatory context-view element
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2270013002 .
2016-08-23 13:16:23 -07:00
547d71add7
Converted Observatory heap-snapshot element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2266343002 .
2016-08-23 12:55:43 -07:00
John McCutchan