dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
78,814 Commits 2 Branches 0 Tags
e97f1bdbf0649fc37ffabff94de8c9bd5c50096d
Commit Graph

36 Commits

Author SHA1 Message Date
Alexander Thomas 12f09896db [homebrew] Modify the version string when updating the version 
This is a follow-up to a96b4f6 which changed the script but introduced
the bug that it no longer updated the version string in the formula.

Fixes https://github.com/dart-lang/sdk/issues/40990.

Change-Id: I272d21d2c4a44161f697ba52da6bb74b1cc7c5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142147
Reviewed-by: William Hesse <whesse@google.com>
 2020-04-03 10:32:34 +00:00
Alexander Thomas a96b4f6dfe [homebrew] Add support for the beta channel formula 
This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.

Also adds a dry-run mode for local testing.

https://github.com/dart-lang/sdk/issues/40990

Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com>
 2020-03-27 14:17:40 +00:00
Kevin Moore b801e603d3 update_homebrew: fix single audit error 
Found via `brew audit --strict --online dart`

Change-Id: Ib38873f51b169526bf10253422ddf79804930984
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136703
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-02-20 18:33:19 +00:00
Kevin Moore 7784ed1b9e update_homebrew: fix Dart homepage url 
Follow-up to https://github.com/dart-lang/homebrew-dart/pull/72

Change-Id: I79fb0e7cea714974fd63e7516f11e2c55e3af1ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136702
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-02-20 18:24:18 +00:00
Alexander Thomas 7373347c7c [release/homebrew] Always use x64 binaries on macOS 
We no longer support ia32 Macs (see linked issue).

Bug: https://github.com/dart-lang/sdk/issues/39810
Change-Id: I5fc6ab6a9074e54a90e8480d0ede416a237733cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130360
Reviewed-by: William Hesse <whesse@google.com>
 2020-01-06 09:11:32 +00:00
St?phane Este-Gracias d22f5122a1 Support Linux ARM on homebrew 
I forgot ARM architecture in previous PR ( #38512 )

Thanks to @eji for reporting

Closes #38893
https://github.com/dart-lang/sdk/pull/38893

GitOrigin-RevId: 8378fb1caa1c47312c7234e807c67f591b18cd85
Change-Id: Idaa49f0e4cc38bd58a91c4a2430a893ff0dc029c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121740
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-10-15 14:13:54 +00:00
St?phane Este-Gracias 6aa415841c Support homebrew on Linux 
Fix dart-lang/homebrew-dart#42

Closes #38512
https://github.com/dart-lang/sdk/pull/38512

GitOrigin-RevId: 561d002a18d95b97f217904f0f024c71fad0cb3d
Change-Id: I6ab2ef15e4220d641848bec15a12d9b64e375cb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118376
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-10-08 18:34:25 +00:00
Kevin Moore 8719fb3a7b Generate homebrew script compatible with latest changes 
Fixes https://github.com/dart-lang/homebrew-dart/issues/58

Change-Id: I23e38db5448c5d8ceb55d57689eda0eecf80c630
Reviewed-on: https://dart-review.googlesource.com/c/88883
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-01-10 16:43:34 +00:00
Kevin Moore d908743de1 update_homebrew: initial cleanup 
Before fixing https://github.com/dart-lang/homebrew-dart/issues/58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
 2019-01-10 13:05:58 +00:00
William Hesse 8e2f28e264 Update homebrew to drop the @2 tab and fix for 2.0 
Change-Id: I1ece391c9c7cdcec9fd0662841bdbdaee7a7a373
Reviewed-on: https://dart-review.googlesource.com/69101
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-08-09 11:49:32 +00:00
Alexander Thomas 5a45b2a62b [infra] Upgrade homebrew dependencies to work on Dart 2 
Change-Id: I1f6cb435d4b57aef3bf5b60e4a8254dfe5ecc77d
Reviewed-on: https://dart-review.googlesource.com/67121
Reviewed-by: William Hesse <whesse@google.com>
 2018-07-30 10:52:00 +00:00
Alexander Thomas a16ad6d9de [infra] Make update_homebrew script work on Dart2 
Change-Id: Ieb4d5131273dfe85f29b7f9916a5d3be3c7fe461
Reviewed-on: https://dart-review.googlesource.com/62146
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-26 10:04:58 +00:00
Alexander Thomas b6cea45ee8 [infra] Escape $ in new homebrew script string 
Change-Id: I9f4f675372589929c117e73cfc445e7b13c30f0f
Reviewed-on: https://dart-review.googlesource.com/59740
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-11 16:58:00 +00:00
Andrew Janke 61e57e2012 update_homebrew🎯 also make a dart@2, for Dart 2 migration 
This PR modifies update_homebrew to also generate a dart@2 versioned formula. The new file is dropped out right next to the old `dart.rb` file.

The dart@2 formula is a temporary measure to aid application developers
migrating from Dart 1 to Dart 2.

Supersedes https://github.com/dart-lang/homebrew-dart/pull/52.

This looks right by inspection, but I haven't been able to test it yet: my local `dart` environment is all messed up, and I am a Dart newbie. Still, I'm putting this out here as a PR so the discussion from https://github.com/dart-lang/homebrew-dart/pull/52 can proceed.

Closes #33318
https://github.com/dart-lang/sdk/pull/33318

GitOrigin-RevId: 5230782aabf4f45199cff9b1fb9c5304e5dcb21c
Change-Id: I78cf5b066d85ac8b0ef51ed44e6eb1a15192b23c
Reviewed-on: https://dart-review.googlesource.com/58120
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-07 10:17:22 +00:00
Kevin Moore ed4733e6fc homebrow: Remove notes on Dartium – looking towards the future 
Change-Id: I8f37818ee530e6c0fb3f40d7b382a7329bc82543
Reviewed-on: https://dart-review.googlesource.com/52423
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-04-24 18:27:33 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code. 
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-16 16:11:57 +00:00
Kevin Moore 970b03986d Update homebrew formula to fail with dartium on dev releases 
Closes https://github.com/dart-lang/sdk/issues/32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
 2018-03-23 01:45:34 +00:00
Tom Sullivan ded230959d Fix Homebrew undent warning 
Update the generated `dart.rb` formula file to fix:

```
Warning: Calling <<-EOS.undent is deprecated!
Use <<~EOS instead.
/usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats'
Please report this to the dart-lang/dart tap!
```

being reported by `brew`.

Fixes https://github.com/dart-lang/homebrew-dart/issues/48

Credit for original patch to @fsouza:

https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4

Closes #32346
https://github.com/dart-lang/sdk/pull/32346

GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71
Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e
Reviewed-on: https://dart-review.googlesource.com/44100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-01 13:50:38 +00:00
William Hesse 7643dc86fc Update the homebrew recipe to not have Dartium dev versions. 
BUG=
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2977223002 .
 2017-07-17 18:31:09 +02:00
Kevin Moore 4b0384c899 Homebrew cleanup (#28899) 
* basic cleanup to home-brew script
* avoid global variables
* Up a more typical package layout
* add generate binary – make it easy to test the output without dealing with git
* Update output to pass brew audit `brew audit --strict --online dart.rb`
 2017-03-09 12:35:36 -08:00
William Hesse 9aec21c3cc Update homebrew updater script to use 64-bit dartium 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/2321393002 .
 2016-09-09 13:45:33 +02:00
William Hesse 634e5a1d02 Refs #25328 Use a portable shebang 
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).

Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1552313002 .
 2016-01-05 16:26:28 +01:00
keertip 18b68f7290 remove docgen remnants from repo, update CHANGELOG 
BUG=
R=alanknight@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1361163002 .
 2015-09-23 10:27:15 -07:00
William Hesse c4f359fd9f Remove dartium formula from homebrew updater. 
The dart formula has options --with-dartium and --with-content-shell, and
the dartium formula has been showing the deprecation message for months.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1284633002 .
 2015-08-10 15:39:17 +02:00
William Hesse feade0551f Flag --with-dartium should install dartium 
Although the --with-dartium flag was documented, the flag
--with-content-shell was used for installing dartium instead.

Chromium path in caveats should be version agnostic
Fixes https://github.com/dart-lang/homebrew-dart/issues/32

R=whesse@google.com

Review URL: https://codereview.chromium.org//1211743002.
 2015-07-01 10:25:03 +02:00
Kevin Moore 90b656946b homebrew: Include version information in resources 
Ensures cached files are unique

R=whesse@google.com

Review URL: https://codereview.chromium.org//1179033002.
 2015-06-12 09:24:05 +01:00
Kevin Moore 09e8210c47 update_homebrew: add optional resources content-shell and dartium to dart formula 
deprecate dartium formula
make -k optional
remove extra version sets

R=whesse@google.com

Review URL: https://codereview.chromium.org//1170953004.
 2015-06-09 13:43:29 +02:00
Kevin Moore 2e6d2a6224 update_homebrew: more fixes 
normalize top-level constants
simplify file writing
pop out variables to top-level constants

R=whesse@google.com

Review URL: https://codereview.chromium.org//1170973002.
 2015-06-09 11:17:18 +02:00
Kevin Moore 856248f135 update_homebrew: support version-formatted revisions 
fix for running in checked mode

R=whesse@google.com

Review URL: https://codereview.chromium.org//1160383002
 2015-06-02 10:02:10 -07:00
Kevin Moore ebb0d0100d update_homebrew: use async/await 
R=whesse@google.com

Review URL: https://codereview.chromium.org//1156473004
 2015-06-01 09:51:51 -07:00
kevmoo@google.com 3c9dbbb49a homebrew: use exec to run shimmed command 
R=whesse@google.com

Review URL: https://codereview.chromium.org//1133383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45764 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-13 14:38:04 +00:00
whesse@google.com 7ba45adfab Add MacOS content_shell download to homebrew formula update app. 
BUG=dartbug.com/21717
R=ricow@google.com

Review URL: https://codereview.chromium.org//788043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42251 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-10 17:04:32 +00:00
whesse@google.com 3430239194 Add additional check to vmservice/websocket_client test. 
Fix type errors in update_homebrew script.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//652833005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41166 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-17 12:11:27 +00:00
whesse@google.com b98c02e1b8 Change update_homebrew script to work with single-file homebrew formulas. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//654653007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41125 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-15 12:45:57 +00:00
whesse@google.com 7514534b79 Fix update_homebrew script for releasing Dart on Mac using homebrew. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//621743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40837 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-01 14:23:37 +00:00
whesse@google.com 84679c0055 Add tools script to update homebrew, the MacOS SDK updating solution. 
BUG=dartbug.com/20210
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//608693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40801 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-30 09:14:43 +00:00