Commit Graph

5 Commits

Author SHA1 Message Date
Srujan Gaddam 983f882180 [dart:html] Play videos in draw_image_video_element_test
draw_image_video_element_test creates VideoElements, which the current
frame is taken from when drawing to a CanvasElement. The test was
waiting on the onCanPlay event of the VideoElement before drawing,
although this might mean the video won't actually start playing. This
fixes that issue by enabling autoplay and then awaiting the play Event.

Change-Id: I100a552a1eb8e88b6b368d88e499f62f2db8e831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143621
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-04-16 00:23:23 +00:00
Srujan Gaddam 09e47b6177 [dart:html] Copy test resources from lib_2 to lib
Some none Dart files were not copied over in the migration. Tests
are refactored to use the lib version over lib_2.

Change-Id: I21053d81770c4f83b01f27af99cec11f08577c7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143330
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-04-13 23:56:08 +00:00
Srujan Gaddam a925f4770f [dart:html] Remove 2.7 annotation from lib/html
Strips out the temporary annotation so all the tests without
NNBD related changes can run in strong mode.

Change-Id: I88f18916f0c5a45a80eddb73941db19984f0bfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140652
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-04-06 20:41:14 +00:00
Srujan Gaddam 5b2482004b [dart:html] Migrate tests that need changes to NNBD
Remaining tests that don't belong to any real test suite, but
need some changes beyond just null asserts to be migrated.

Change-Id: I91c0cb02eb72ada572a10c567b5d8bac596b16a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142445
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-04-06 20:41:14 +00:00
Srujan Gaddam 1d44ef07c1 [dart:html] Copy and rename lib_2/html to NNBD.
Added annotations such that these tests won't fail when submitted.
Added copyright notices if there isn't a copyright notice.

Change-Id: I51ae347d44875cdfa1c6d0dad1bc41e00ea443bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139963
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-04-03 00:36:56 +00:00