 Konstantin Shcheglov
|
e5d5a0f345
|
Don't report INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_* when null safety.
https://github.com/dart-lang/language/pull/1389/files#diff-2f9dda5244b707ca3b6d5988c6e5257d6025a99a5fa08ce0dc171c94bdc8ce0dR665
Change-Id: Iccc90f8f9bb877da604d5a5774a931b71a185b91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178928
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
|
2021-01-13 21:19:04 +00:00 |
|
|
Mark Zhou
|
9ea431c158
|
Simplifying and recategorizing cyclic imports test
This bug doesn't depend on exports and instead of the constructed class hierarchy.
See: https://dart-review.googlesource.com/c/sdk/+/162383/comment/9196db98_412d446d/
Change-Id: Ib107d3fa3ab7782bee5db59754583b20976832a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162785
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
|
2020-09-14 20:20:49 +00:00 |
|
|
Jens Johansen
|
e6ffc0b285
|
[parser] Issue different warnings for missing identifier based on whether the token is used or not.
E.g. "var = 42;" now has a different error message than "var default = 42;".
Fixes #22553
Change-Id: I58affe988569d8e79190b63f7267b471a1b0ebc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162182
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
2020-09-14 08:55:18 +00:00 |
|
|
Konstantin Shcheglov
|
ba92b78acd
|
Move errors from StaticWarningCode to CompileTimeErrorCode.
Bug: https://github.com/dart-lang/sdk/issues/42821
Change-Id: I153c48d7a2e4a02026928e6203aacf8f2dc029ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
2020-07-26 04:19:25 +00:00 |
|
|
Konstantin Shcheglov
|
86ec742832
|
Switch to new Scope(s).
No much changes to resolution itself, only to the way how we create
scopes. But we still use `lookupIdentifier` that is basically the old
approach to resolution.
This also moves the fix of https://github.com/dart-lang/sdk/issues/42620
to TypeNameResolver.
I will continue improving in following CLs.
Change-Id: I89bae5afe0a7978aba9fe9bf7c8bf08fb59b1440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
2020-07-21 01:37:34 +00:00 |
|
|
Paul Berry
|
9f8aaf65c7
|
Issue an error if a prefix in a type name is shadowed by a local variable.
See #42620.
Change-Id: Ifd18c939082935390df0c2aa0bd724cf6f76c27c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153705
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
|
2020-07-09 23:09:18 +00:00 |
|
|
Brian Wilkerson
|
46a2fa6b99
|
Unify two error codes for diagnostics
Change-Id: I5714cec5e47b67e1a4be2f2895fa9cc96e869c45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152732
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
|
2020-06-29 18:58:03 +00:00 |
|
|
Konstantin Shcheglov
|
b7efcd276c
|
Report NO_COMBINED_SUPER_SIGNATURE.
https://github.com/dart-lang/language/pull/975
Change-Id: I8ecd191efa84f17d36ea09ef1db33a401c67fda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
|
2020-06-15 17:42:45 +00:00 |
|
|
Lasse Reichstein Holst Nielsen
|
6428bab7ed
|
Add tests for override inherited inference.
Change-Id: I636682c38e2ba97826420f6f6bbb8e54aa29e21f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148761
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
|
2020-06-11 17:13:21 +00:00 |
|
|
Konstantin Shcheglov
|
571f564eda
|
Rewrite TypeName to ConstructorName in one place, consolidate error reporting.
Change-Id: I5ea1369d65c5eb47e920f68806d28f34931d372e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
|
2020-05-26 21:32:22 +00:00 |
|
|
Robert Nystrom
|
2eed35d650
|
Migrate language_2/class to NNBD.
Change-Id: I5f9aa5799cf88a320675debb919011f8a19b6faa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141742
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
|
2020-03-31 18:16:55 +00:00 |
|