dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
78,814 Commits 2 Branches 0 Tags
e97f1bdbf0649fc37ffabff94de8c9bd5c50096d
Commit Graph

83 Commits

Author SHA1 Message Date
Brian Wilkerson 7f54fc96e5 Add documentation for several more codes 
Change-Id: I012db56773acee6a81fbb6a33958beb686793ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-28 21:16:11 +00:00
Brian Wilkerson 0599056cb2 Add another example to invalid_null_aware_operator to explain a confusing case 
Change-Id: I11319c8075179890400f87cc5a8706e4569e39dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191420
Reviewed-by: Kathy Walrath <kathyw@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-17 23:03:57 +00:00
Konstantin Shcheglov beb216035f Regenerate diagnostics.md 
R=brianwilkerson@google.com

Change-Id: Ib5a1d21905d403304bdf3312894ed3d069c1ee66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-03 21:21:16 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Emmanuel Pellereau ba0159688e Revert "Analyzer: Report on return types of Future.catchError function" 
This reverts commit d5ee021819.

Reason for revert:
Breaks google3: b/178222419

Original change's description:
> Analyzer: Report on return types of Future.catchError function
>
> The type of the `onError` parameter of Future<T>.catchError is just Function,
> but the function can either have signature `FutureOr<T> Function(dynamic)` or
> `FutureOr<T> Function(dynamic, StackTrace)`. This change adds checks for return
> statements in a function literal passed to `onError`, and the return type of a
> function-typed expression passed to `onError`.
>
> We still need to check parameter types.
>
> https://github.com/dart-lang/sdk/issues/35825
>
> Change-Id: I3a1d1c444e298c5816fcd1d4bc537f7b87fa3da1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176221
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I8ebbaac0a4b44293576809baa2dc2c3fdcf35379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180822
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
 2021-01-25 12:04:52 +00:00
Sam Rawlins d5ee021819 Analyzer: Report on return types of Future.catchError function 
The type of the `onError` parameter of Future<T>.catchError is just Function,
but the function can either have signature `FutureOr<T> Function(dynamic)` or
`FutureOr<T> Function(dynamic, StackTrace)`. This change adds checks for return
statements in a function literal passed to `onError`, and the return type of a
function-typed expression passed to `onError`.

We still need to check parameter types.

https://github.com/dart-lang/sdk/issues/35825

Change-Id: I3a1d1c444e298c5816fcd1d4bc537f7b87fa3da1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176221
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-22 20:56:09 +00:00
Sam Rawlins f849384456 analyzer: Remove extra space in RETURN_WITHOUT_VALUE 
Change-Id: Iba0d7f88b1640ab7c07c71ac529b18633834b0d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180601
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-22 18:15:23 +00:00
Brian Wilkerson bf595ef8bd Remove two diagnostic codes as discussed 
Change-Id: I9b76b1b2a4a1ff54cec91add510d11d6708f8fd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-20 05:17:36 +00:00
Brian Wilkerson a8ef9f4df1 Add documentation for more diagnostics 
Change-Id: I8a2e328fef54e77378558514bf2b62f186fe3451
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-19 18:15:13 +00:00
Brian Wilkerson 11e7cdcfd1 Unify two error codes for documentation purposes 
Change-Id: I730a0ee287e7d54bace9fdf84a02be5c3f4da017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178520
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-11 23:12:20 +00:00
Danny Tuppeny c818059287 [Analyzer] Report EXTRA_POSITIONAL_ARGUMENTS and EXTRA_POSITIONAL_ARGUMENTS_COULD_BE_NAMED against first unmatched argument 
Fixes #44598.

Change-Id: I6bccf4f5448de024f27d0ed1ba51c730e22b6fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178020
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-11 18:46:26 +00:00
Sam Rawlins 897235204e Split use_of_nullable_value into separate codes with more friendly 
messages.

* UNCHECKED_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_METHOD_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_OPERATOR_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_CONDITION
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_ITERATOR
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_SPREAD
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_YIELD_EACH

Additionally, improve the ADD_NULL_CHECK quick fix by supporting
expressions which need to be null-checked in a for-each, a yield-each,
and a spread.

Bug: https://github.com/dart-lang/sdk/issues/44603
Change-Id: Ie493a2dc1c05b64a16fd17c77d3468e8d562c497
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178080
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-08 21:07:02 +00:00
Brian Wilkerson 6143fb5668 Improve some diagnostic messages 
Change-Id: Ic351c2addff76dea8fe49c7e2ce68b46043f0814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-04 16:43:08 +00:00
Brian Wilkerson 6905e30446 Improve the message for missing_default_value_for_parameter 
Change-Id: I7bc453853716c24a4e1b6cacd44202656dabd743
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-27 21:21:45 +00:00
Paul Berry 7d3bc4862d Rename pkg/analysis_tool to pkg/analyzer_utilities. 
It's no longer just for the tools in the `tool` directory; it also
contains test utilities for use by the analyzer and related packages.

Change-Id: I0f8cf57f24ea7aad8e2177e43ee2bcb2ab3030da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171704
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 17:46:30 +00:00
Brian Wilkerson 236399ee5e Fix a typo that caused part of the documentation to be dropped 
Change-Id: Ie685e019d6df60ba7d336b550e5c1cc1efbd6f68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171810
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 00:53:55 +00:00
Paul Berry 596198fb74 Share logic of package_root.dart 
This CL unifies the implementations of `package_root.dart` found in
packages `analysis_server`, `analysis_server_client`, `analyzer`, and
`analyzer_plugin`.

This should make it easier to re-use this logic in other packages,
such as `nnbd_migration`.

Change-Id: I0da44edb379b8e929dd0b1c16a6989c1e9418acb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-11 18:09:18 +00:00
Sam Rawlins 9e6486fe3f Analyzer: Make test fields late, late final, or hinted for migration. 
Many fields can be late or late final, so adding hints for the migration tool.

In SnippetTester, the fields are all set in the constructor. Added a factory
constructor so the fields can be final. Renamed them to be private.

Change-Id: I559e7ba92c7c6749038630b03f67f8a77bdc704a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170406
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-05 17:45:17 +00:00
Brian Wilkerson b499c76516 Add documentation for some additional diagnostics 
Change-Id: Ideb16c6a4c20ebb8e474e8beae841d7bd15afe13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-04 17:58:32 +00:00
Brian Wilkerson 195820ec10 Update the message for sdk_version_never and comment in previously reviewed docs 
Change-Id: I505e4a577feecbb4deb25eaaeb863a80c7e71602
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-30 23:17:12 +00:00
Brian Wilkerson 740857152a Fix the wording of a warning 
Because this is only a warning the user can ignore it and the code will
compile and run without problem. Hence, the previous wording was a bit
strong.

Bug: https://github.com/dart-lang/sdk/issues/43189
Change-Id: Ibe4f048191b28230fede8e7e5d76943c5b56f31b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169962
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-30 22:57:32 +00:00
Jens Johansen 5a6129406f [parser] Consistently disallow 'late' without 'var', 'final' or type 
Fixes https://github.com/dart-lang/sdk/issues/43811
Fixes https://github.com/dart-lang/sdk/issues/43812
Fixes https://github.com/dart-lang/sdk/issues/43813

Change-Id: I39de527883d33459694ec0f91b769676eb52d54b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168641
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-10-23 06:28:51 +00:00
Brian Wilkerson 9d1883c290 Remove duplicate messages from the generated documentation 
Change-Id: I621f737faf08784faae5d7715ed4b5603a564985
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-12 17:54:02 +00:00
Brian Wilkerson e98f5db3c4 Use the correct quote in markdown 
Change-Id: If2fe99b7d1d9880674be294b08b352982b9c6c45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-11 15:56:42 +00:00
Brian Wilkerson dfc3e2666e Fix the formatting of a header 
Change-Id: I9f0b7b564d71cf30fe3d5ac41e67c71ae3e3ee40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165146
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2020-09-29 23:42:08 +00:00
Brian Wilkerson 597588f698 Make additional requested changes to the diagnostic documentation 
Change-Id: I30b1f44c957b0f7bc4d629e62e0d9aeca7560203
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-29 19:42:07 +00:00
Brian Wilkerson 2c4bee37c0 Add documentation for some additional diagnostics 
Change-Id: Ib6dc3740de759d820421fa3a899c72302de64c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-25 04:35:33 +00:00
Konstantin Shcheglov 67c56a7ebe Update diagnostics for EXTENSION_OVERRIDE_WITH_CASCADE. 
Somehow bots did not catch it.

R=brianwilkerson@google.com

Change-Id: I4fa29f662ffbf541b2fb76d3449c3e69cc1e48bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160783
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-28 15:38:28 +00:00
Devon Carew 690d04e146 [analyzer] update a dignostic message to refernce the new name for NNBD 
Change-Id: I6edf67f88005b7745b8c0f875e1ce333134f1a2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159146
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 04:42:11 +00:00
Brian Wilkerson 819af72908 Use "receiver" rather than "target" in messages and docs 
Change-Id: I08fdc928c72035a04dc2bb731ce8a2e95a81f9df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158803
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-17 23:11:35 +00:00
Brian Wilkerson e224540b1c Unify four diagnostic codes for the purpose of documentation 
I would have prefered to have renamed them all to undefined_super_member,
but that would have broken existing links. Some day we should add the
support necessary to allow for forwarding so that we can rename codes.

Change-Id: I81e416407e3464b5b60a4dbbfe60a375eb47bb84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-11 01:07:44 +00:00
Brian Wilkerson 276f10aaf6 Unify const_field_initializer_not_assignable with field_initializer_not_assignable for documentation purposes 
Change-Id: I7b008febe4210d08768b81c59bf0ee6b2663fafd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-10 19:48:03 +00:00
Brian Wilkerson 363c72111d Update docs to use markdown styled links 
Change-Id: Id5b966ee41c75ee02c7ce10609033b81d930697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157120
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2020-08-05 00:20:32 +00:00
Konstantin Shcheglov f4c3c31530 Fix new hints in analyzer. 
Change-Id: I6bba1448a522355dff14ff8ac81b2568e4dcbfe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-20 16:26:02 +00:00
Brian Wilkerson d4ac7066b7 Improve diagnostic message when short circuiting (issue 42599) 
Change-Id: I456bc50792dfdb30c281578d0d54ffa9e2af6474
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154161
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-15 21:19:49 +00:00
Brian Wilkerson 8cc3d415e7 Integrate suggested changes from the PR to publish the docs 
Please look this over carefully; all of your changes have been integrated,
but not all of the changes are yours. While itegrating your suggestions I
found a few more occurrances of 'is not' and 'are not' that I converted.
I also found a couple of other things that needed to be updated.

Change-Id: Iddaaa22d7e584506bc3c16606166771fd5a75caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152942
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2020-07-01 15:58:11 +00:00
Brian Wilkerson ab73158758 Fix the windows bot and update MockSdk 
Fixing the test that's causing the Windows bot to fail required updating
the MockSdk, which cause a lot of other changes. I would have done this
in two separate CLs if I'd known how big this was going to get, but I'm
hoping it isn't too big.

Change-Id: Idee56bab5e73a78ab7857e81177090493aa08b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151874
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-22 14:34:25 +00:00
Brian Wilkerson 197308560a Add documentation for more diagnostics 
Change-Id: Ib63182c67dfa0bef475871aa2104811c3a44dac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151882
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-19 20:46:32 +00:00
Konstantin Shcheglov 69843a8f04 Record performance with CiderOperationPerformance hierarchy. 
This does not include breakdown for resolution yet.

I wonder if this more general information could replace specialized
CiderCompletionPerformance fields 'resolution', 'suggestions', etc.
WDYT?

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4685dc2a8de8028ce84cc2640943f45c8cf047e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151811
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-06-19 17:33:03 +00:00
Sam Rawlins 28231a790b Analyzer: regenerate diagnostics.md 
Change-Id: If0d916b01d802fbdf614ee031f240094fb077931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151167
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 17:24:35 +00:00
Brian Wilkerson 9e2f11251c Improve the message for default_list_constructor 
Change-Id: Id2514bd9aab667939396b26f677577ff3b6695fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150692
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-11 14:00:56 +00:00
Konstantin Shcheglov 7deb5a3874 Fix documentation for EXPORT_LEGACY_SYMBOL. 
With https://dart-review.googlesource.com/c/sdk/+/145220 specifying
the current language version using `// @dart=` does not opt-out from
experiments.

Change-Id: Ibee76c35af8e829bef7d14347fe155ba876c1033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 20:36:39 +00:00
Brian Wilkerson 88876d5642 Add documentation for most of the Null Safety diagnostics 
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.

Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-19 15:24:59 +00:00
Brian Wilkerson 60a81b0f51 Add hints to find equal elements in literal sets and maps 
Change-Id: Ib930b49b338d7cb088b17909991934b16c4f1538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-06 14:22:44 +00:00
Konstantin Shcheglov 9e4000e44b Issue 40603. Update MockSdk to stop returning null from factories. 
Bug: https://github.com/dart-lang/sdk/issues/40603
Change-Id: Id1060773d303527424bde02785a5c21651df4c85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-27 00:47:06 +00:00
Brian Wilkerson 4ef4371891 Replace "generates" with "produces" in the diagnostic docs for consistency 
Change-Id: I231467cb2186d81068e99215a6e94d6f76a31666
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2020-02-20 17:22:19 +00:00
Brian Wilkerson d0e779ff71 Improve some diagnostic documentation 
This recpatures some documentation lost in
https://dart-review.googlesource.com/c/sdk/+/129833.

Change-Id: Ie8355533bd0c42360c9d7dd2138813c83391d7c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-09 20:57:33 +00:00
Sam Rawlins 637a801e64 Use 'enum' and 'mixin' with undefined getters, methods, operators, setters 
Fixes #40177

Change-Id: I0b416a4e77d3d1c5afc1712301c5cf1ea4cfc8d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133043
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-30 17:01:58 +00:00
Brian Wilkerson 7d7643c2ad Add newly reviewed docs and change section header everywhere 
Change-Id: I337fe5764b9167240b42cf75f908a3d36ef08cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133407
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-26 22:56:45 +00:00
Konstantin Shcheglov 7b7d8789ca Use WRONG_NUMBER_OF_TYPE_ARGUMENTS instead of two other equivalent error codes. 
R=brianwilkerson@google.com

Change-Id: Ibb5ea7d65df75655eaf2d43fba1110740be39912
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129833
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-31 20:27:03 +00:00