Konstantin Shcheglov
7374f441f3
Add TypeProvider.isNonSubtypableClass, deprecate TypeProvider.nonSubtypableClasses.
...
Change-Id: I78beaaeb763c33420d84c33b0e87cd5310f99fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193094
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-29 02:33:52 +00:00
Konstantin Shcheglov
11e922f761
Update a few documentation comments for elements to remove null.
...
https://github.com/dart-lang/sdk/issues/45236#issuecomment-800564647
Change-Id: Ic9aa0b120cb0796ad1796c6f34aef8fc5360700a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-16 21:39:41 +00:00
Konstantin Shcheglov
fd92cd4ce1
Add Expression.inConstantContext to API.
...
Change-Id: I13f96d2123e96eea11ccdcef2bb9a301a8afd26a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-16 19:28:30 +00:00
Konstantin Shcheglov
ff14547a20
Make AnalysisSession.getResolvedUnit() and getUnitElement() non-nullable.
...
Change-Id: I779fe40d1c565f9d4d71ba6a809497d26cae8def
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-09 00:42:23 +00:00
Konstantin Shcheglov
5794e716ab
Make AnalysisSession.getErrors() non-nullable.
...
Change-Id: Ib5971e4c7327d96bf7a08b576b487833615d4ae6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189622
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-08 08:38:51 +00:00
Konstantin Shcheglov
0506b1b2d3
Deprecate setters in API of AST.
...
Change-Id: Ib2ec164ef87b3a5a4bf028d592552e37451abd35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189520
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-07 21:48:50 +00:00
Konstantin Shcheglov
3f5694c827
Issue 45141. Check for loadLibrary() using namespace.
...
Bug: https://github.com/dart-lang/sdk/issues/45141
Change-Id: Ifb0825d66a560d0136873942f9666d3dc630b6c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-05 22:21:54 +00:00
Konstantin Shcheglov
959adec89d
Deprecate FunctionTypeAliasElement.
...
Change-Id: I52b49ecadc7217416341b7d7474ded5b36a8ca73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-25 19:08:36 +00:00
Konstantin Shcheglov
e4643d5809
Deprecate ElementVisitor.visitFunctionTypeAliasElement()
...
Change-Id: Ib5d364b77af7974d757626a0719604fa7ec1fec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-19 22:21:15 +00:00
Konstantin Shcheglov
9bfd416c45
Add ContextRoot.workspace, deprecated AnalysisContext.workspace, support included excludes in ContextLocatorImpl
...
Change-Id: Iecd324ad45b926ca6b0626f8bea4f479409154e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185499
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-19 02:15:40 +00:00
Konstantin Shcheglov
51950ab881
Add Resource.parent2 that returns non-null Folder, add Folder.isRoot
...
A bigger version of than https://dart-review.googlesource.com/c/sdk/+/184381
This is breaking change, so we do this in steps.
Change-Id: I0c7212a073b605ade56657036543c604651810c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-12 19:09:20 +00:00
Konstantin Shcheglov
5ba061c4e1
Un-experiment null safety APIs.
...
Change-Id: Ib1d0502458625e5569b057140b9a066cc9c0f0b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184642
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-12 18:23:12 +00:00
Konstantin Shcheglov
875af7c991
Deprecated TypeProvider.futureType2/listType2/etc
...
Change-Id: Ia994be1e29b4d96b89d714beafcb9256a0cb4de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-12 17:26:07 +00:00
Konstantin Shcheglov
c749c0e3a9
ConstructorDeclaration always has a body, at least EmptyFunctionBody.
...
Change-Id: I5cbc5317256d02cd1422233107ce469e8d8935f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184341
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 18:08:15 +00:00
Konstantin Shcheglov
3d8d4b4c2b
FunctionExpression always has a body, at least EmptyFunctionBody.
...
Change-Id: I0d09df2571436f30a7706e657a98056a021e25e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 18:00:11 +00:00
Konstantin Shcheglov
b4409ea3b4
Deprecate FunctionType.element/typeArguments
...
Bug: https://github.com/dart-lang/sdk/issues/44629
Change-Id: I5009a1abd456f33738d3b5e2ecae24b269b20000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-10 17:17:58 +00:00
Loren Van Spronsen
c426bc5eff
Correct the inline grammar in the SimpleStringLiteral dartdoc.
...
Change-Id: I03956ea2e7f2dfba45bab265b0ab7a7b86559224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-06 01:46:48 +00:00
Konstantin Shcheglov
a7f84dc626
Make NodeList fields in AST final not lazy.
...
Change-Id: Ia145ea52a7a13ce8d97708a135099ef064ec3397
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-05 00:25:02 +00:00
Konstantin Shcheglov
9cbe1cafe0
Element.session can be nullable
...
This is not convenient, and not nice, but it can be.
We have to accept that it can for now, and plan to make it better.
Bug: https://github.com/dart-lang/sdk/issues/44837
Change-Id: Icbd2d55b6690ed817b38a7768198c41ce36cf002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182960
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-04 22:02:29 +00:00
Paul Berry
ba5064fa31
Analyzer AST changes for generic metadata
...
Bug: https://github.com/dart-lang/sdk/issues/44838
Change-Id: I55b8dacc571570568c1b3f101a1a4e1f517f7f6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182581
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-04 09:45:47 +00:00
Sam Rawlins
43e4536ebb
analyzer: Fix documentation for TypeProvider
...
Text like "Future<Null>" turns into an HTML tag. Referencing the elements with
[] escapes the HTML and creates links for the user.
Change-Id: Ib20020f879ec1eef4a5d98e896f72b00242deac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-02-03 21:53:59 +00:00
Konstantin Shcheglov
7313f905e3
Remove 'functionTypeAliasElement' from 'TypeSystem.instantiateToBounds2'.
...
Change-Id: I402d55b1ccdc0178680406c5f6135b497115a1c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182603
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-03 19:54:29 +00:00
Paul Berry
0427342228
Add flag for generic metadata
...
See implementation plan PR:
https://github.com/dart-lang/language/pull/1417
Change-Id: Ib75026d7008d313f3dad94d9ccf47e341f945dc9
Bug: https://github.com/dart-lang/language/issues/1297
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182301
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-02-03 13:54:48 +00:00
Konstantin Shcheglov
4c6f5f7658
Remove NullSafetyUnderstandingFlag.
...
Bug: https://github.com/dart-lang/sdk/issues/40531
Change-Id: I197cfdf64c697a09bb9e0e3896f3ee5ac1967757
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168160
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-02 18:03:24 +00:00
Konstantin Shcheglov
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
Konstantin Shcheglov
aa03d4a8e0
Add AnalysisContext.sdkRoot
...
Change-Id: I5895b4bb9ba797c93b22f20ee1f2185066de9365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180622
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-22 20:19:44 +00:00
Konstantin Shcheglov
7f95c18812
Deprecate CompilationUnitElement.functionTypeAliases
...
Change-Id: I0f13761adf3d1dfd18798d5b7549e64462be0b65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179360
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 22:38:23 +00:00
Konstantin Shcheglov
9717c775e4
Deprecate FunctionTypeAliasElement.function
...
Change-Id: Id629afa92c6681ba796aed75b24c4251fd86810f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176140
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-12-14 22:26:29 +00:00
Konstantin Shcheglov
6606edee3c
Add ElementVisitor.visitTypeAliasElement
...
R=brianwilkerson@google.com
Change-Id: Id2e2fa118d5d9f363201aeb5384806bc6536c973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-12-14 21:20:29 +00:00
Konstantin Shcheglov
dee85df64d
Basic support for elements/types of non-function type aliases.
...
Change-Id: Ide8f2fff98f7f03375efad23df3ed79795c33a23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-12-04 23:32:02 +00:00
Konstantin Shcheglov
19652ae5ad
Use binary format for summaries.
...
Change-Id: Ibf0221a3c233c958e5065b64207faf9dfae33083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-12-01 21:30:35 +00:00
Sam Rawlins
19a96e4d5e
Analyzer: override element type in ExportDirective and ImportDirective
...
This reduces the number of explicit casts needed for null safety.
Change-Id: I8ad0ab9cddbbe81e5fbf66b95ae4ae1cb57efebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172743
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-11-20 15:22:46 +00:00
Erik Ernst
9045077b35
Add ast support for non-function type aliases
...
Change-Id: I5883ce6e80d451b52073f3770fbdf971e7dcf18c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170692
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-11-11 07:59:18 +00:00
Konstantin Shcheglov
77f2019f00
Use the current SDK language version by default.
...
Change-Id: I317ad3858b0f023cdf2fd02a1a28a9c22742b74c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-31 00:20:22 +00:00
Konstantin Shcheglov
619e388a1d
Breaking changes for analyzer version 0.41.
...
Change-Id: Ib16351e05b498fa9879e6bb4c117638cde276bfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-29 17:08:16 +00:00
Erik Ernst
f506071e34
Add DartType.alias{Element,Arguments} and class TypeAliasElement
...
First step in implementing non-function type aliases in the analyzer:
Just add the new back-references in types, such that they can refer to
a type alias which was used to obtain the type, if any.
Next step: Preserve the aliasElement and aliasArguments in summaries,
next again: Create `TypeAliasElementImpl` and ensure that the parser
can create them.
Change-Id: I1bfbc2c3893e32c5b1826552361a0238aa2b4058
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-10-29 14:39:33 +00:00
Konstantin Shcheglov
b155af2442
Update documentation for ElementAnnotation.element
...
R=brianwilkerson@google.com
Change-Id: I166545cd2359370d2bfff5fdfaa36c5ce6950f52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168129
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-17 17:37:15 +00:00
Konstantin Shcheglov
aad1a677c0
Deprecate GenericTypeAliasElement
...
See also https://dart-review.googlesource.com/c/sdk/+/166680
Change-Id: I6018f3bf5796dcc8ab059aab5b29d01e7336581b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-15 16:03:26 +00:00
Konstantin Shcheglov
31e673d80c
Deprecate SimpleIdentifier.auxiliaryElements
...
Change-Id: Ie1e92cc61b7018d503cdf44c37611ea55b4b5391
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-28 16:00:44 +00:00
Konstantin Shcheglov
ffbe30f890
Deprecate IndexExpression.auxiliaryElements
...
Change-Id: I7359527db5bbf161a35296678ff2bd43052c1794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-27 18:28:46 +00:00
Sam Rawlins
51840c501a
Analyzer: add two checks for the @internal annotation.
...
The meta package does not yet have an `internal` constant;
this CL just adds one to the mock packages for testing.
Two checks are implemented:
* Hint if an @internal annotation is found on an element which is
already part of a package's public API (based on file path).
* Hint if an element annotated with @internal is exported from a
package's public API.
The notion of "public API" is also implemented for each type of Package:
BasicPackage, BazelPackage, GnPackage, PackageBuildPackage,
and PubPackage.
Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Ifc2709028afcd241f59e802f5952539f717704c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163126
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-18 23:04:06 +00:00
Konstantin Shcheglov
ba78db411a
Remove DartSdk.analysisContext
...
Change-Id: I6a67344d928e6182a851741bbbc862284af710c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-13 00:56:36 +00:00
Konstantin Shcheglov
c71ce5234d
Remove DartSdk.analysisOptions getter/setter.
...
Change-Id: I6bdcd1d8c2e998bf4adbf26ddf533f5d649c73c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162620
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-12 21:33:26 +00:00
Mike Fairhurst
000f3135a5
[analyzer] Remove unused dart:async imports
...
Change-Id: If21c3a30f3bc521586ad01f8f9e241038e7aa7eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161448
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-09-02 17:14:22 +00:00
Konstantin Shcheglov
8ae9842e12
Deprecate ElementAnnotation.constantValue
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Ifae6a614c20b703d9614d7ccc2f8b254bafcb070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-08-28 21:52:19 +00:00
Konstantin Shcheglov
893481591a
Store readElement/Type and writeElement/Type in AssignmentExpression.
...
Change-Id: Ibe0eea6126c7e85cdfefa09652228b5a89b522cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160444
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-08-27 20:22:14 +00:00
Konstantin Shcheglov
a46f6cb570
Support for SDK 2.9 and null safety.
...
Change-Id: I3e5cd4d8d3794c164d46c8b9eb59a376070edbd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-08-25 23:03:53 +00:00
Brian Wilkerson
d5088c0a8f
Reland the CL to "Add a hint for the new Target annotation".
...
This reverts commit 50946855dc .
The bug that caused dartdoc to fail has been fixed by restoring the
creation of the invalid field. An issue has been created to update the
dartdoc package to stop using the invalid field, and the field will
need to be removed after dartdoc has been updated and pulled into the
SDK.
Change-Id: Ia7e282972e541a33b379872fbcd57a137a9c8a25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-08-25 16:53:10 +00:00
David Morgan
50946855dc
Revert "Add a hint for the new Target annotation"
...
This reverts commit 351a1cc489 .
Reason for revert: caused a generator to fail, b/166257389
Original change's description:
> Add a hint for the new Target annotation
>
> Change-Id: I5d8723eead20bb68407ce2a23e8de6cb9ae8a4de
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159921
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I16af4403867d31f731d1efafce2c0c2be405df9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160102
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2020-08-25 14:20:52 +00:00
Brian Wilkerson
351a1cc489
Add a hint for the new Target annotation
...
Change-Id: I5d8723eead20bb68407ce2a23e8de6cb9ae8a4de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-08-24 18:04:47 +00:00