dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
78,814 Commits 2 Branches 0 Tags
e97f1bdbf0649fc37ffabff94de8c9bd5c50096d
Commit Graph

143 Commits

Author SHA1 Message Date
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Brian Wilkerson 84cafbde9d Remove some unused code from analysis_server 
Change-Id: I369a93a9d67cf6a9346e0edcc439d34a8e959e3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189161
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-04 21:13:29 +00:00
Danny Tuppeny d901f7326a [Analyzer] Add code completion for Pub package names 
Change-Id: I0fa8fb1c2801e2acb2d2cf75f7efecf4f9058eeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-03 17:12:58 +00:00
Devon Carew 8cba879f46 Add additional validations to the pkg/ package pubspecs. 
TEST=these are additional validations that we run on the bots

Redux of https://dart-review.googlesource.com/c/sdk/+/161040

Change-Id: Ia32ced5d48fbfeafacfa9e51dc4774d2e9425091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-12-02 17:27:18 +00:00
Devon Carew f5e26456bf Remove the --completion-model flag from the analysis server. 
Change-Id: I6bedbb0b5c4b8bedba18d2e3b788db0a9686f6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172026
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-16 03:31:18 +00:00
Paul Berry 7d3bc4862d Rename pkg/analysis_tool to pkg/analyzer_utilities. 
It's no longer just for the tools in the `tool` directory; it also
contains test utilities for use by the analyzer and related packages.

Change-Id: I0f8cf57f24ea7aad8e2177e43ee2bcb2ab3030da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171704
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 17:46:30 +00:00
Sam Rawlins ae466ef7d5 analysis_server: Bump to pedantic 1.9 
Change-Id: Iec6c21abe09ecfbd74c4e1b18c0f519c0416467b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163304
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-07 13:41:35 +00:00
Brian Wilkerson 8db2ade176 Clean up the pubspec.yaml in analysis_server 
There is already a normal dependency on html, so the dev dependency isn't
needed.

Change-Id: Ib4c599c5894022a8bbeca4374cdd3c9a77d3fea1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 15:41:22 +00:00
Devon Carew 932712b602 update pubspec to reflect actual packages used 
Change-Id: I02b10f92d858d0303f1a71e649395fb013f437aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-08-18 17:11:30 +00:00
Michael Thomsen f0c87e9f21 Clean up no-publish comments in pubspecs 
Change-Id: I6cc1ab404de75cd02183b862842198c85b6d9256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152005
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-06-23 10:34:09 +00:00
Paul Berry c38742cdbc Migration: remove references from analysis_server to nnbd_migration. 
Change-Id: I90b562b8b3e82b770f197d7ef2c4e10ac9f99100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148160
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-15 16:49:32 +00:00
Sam Rawlins 4f2e21b351 migrator: Update pubspec.yaml, not analysis_options.yaml 
Fixes #38347

Change-Id: I201a02ad467401e8277631947dcdf3a19f74ddb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143440
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-16 17:35:34 +00:00
Janice Collins da1d9eb1bd Add a way for analysis_server to open communication via a IsolateChannel. 
The idea is to pass a SendPort as an optional parameter to
ServerStarter.start(), and if present, key server behavior around
behaving well as an isolate.

Bug: https://github.com/dart-lang/sdk/issues/41056
Change-Id: Ifc6ac2fefcf6aae8bce712e470524d1c06fa2ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140373
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-26 21:37:59 +00:00
Devon Carew 3a8264cb35 [nnbd preview] iteration on the nnbd preview tool ui; fix layout and scrolling 
Change-Id: I1d5ddc855c3f47971436668d3d64f8ff63e377e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134872
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-02-07 23:52:00 +00:00
Sam Rawlins 147ed9e9e1 Load navigation programatically; use badges for edit counts; #40115 
Change-Id: I83b1db7c95ea0edb8a8d3af0f125219659c6df1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134080
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-01-31 22:06:12 +00:00
Sam Rawlins 344b30e8ce Enable pedantic 1.8.0 in analyzer, analysis_server 
Since some pedantic issues were individually enabled, this CL turns our
analysis_options files into something more like "pedantic lints,
except ...". Effectively, this _adds_ the following lint rules:

* avoid_empty_else
* avoid_relative_lib_imports
* avoid_shadowing_type_parameters
* avoid_types_as_parameter_names
* library_names
* library_prefixes
* null_closures
* prefer_contains
* recursive_getters
* type_init_formals
* unnecessary_null_in_if_null_operators
* unrelated_type_equality_checks
* use_rethrow_when_possible

It also documents (for some rules) how many violations certain rules have.

Change-Id: I79a2c101ae4d10215d3f232d9e511bf8e6c7faa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118720
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-25 19:08:03 +00:00
Sam Rawlins 97346ff476 Initial migration i13n HTML output 
Change-Id: If614fa0719d8ffdaa7a41cca6d0df249772c2437
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117928
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-09-19 22:56:44 +00:00
pq 6e3498cd08 bump server SDK constraint lower bound 
Change-Id: I1d3c690ef011eb2a5468e7e5d9ce00c973e1992d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-05 18:14:42 +00:00
Ari Aye 5d5a0c0164 Check in token-level language model via tflite ffi 
Local test run after running `gclient sync`:

ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!


Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-25 18:39:51 +00:00
Paul Berry 51046368c5 Move NNBD migration tool to a fresh package. 
This gives us more flexibility for how we want to publish and deploy
the tool.  We now have the option, for example, of making a command
line app that invokes the tool and does not depend on analysis_server.

Note that some testing infrastructure had to be duplicated.  I plan to
consolidate this infrastructure in follow-up CLs.

Change-Id: I046506bc2bb5c3e467e15885f198ee0632351ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105463
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-06-09 17:45:35 +00:00
Konstantin Shcheglov d6f9d2da6f Add pkg/analysis_server/pubspec.yaml so that it is identified as a pub package. 
We use this file to get regular and dev dependencies, and suggest
available declarations in correct parts of packages, e.g. lib/ can
only access declarations from regular dependencies, but test/ can
access both regular and dev dependencies.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id92cae07485b21af750318a58056a11262cf1799
Reviewed-on: https://dart-review.googlesource.com/c/91762
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-31 22:26:59 +00:00
Paul Berry b5e294595a Remove analysis_server's pubspec. 
The analysis server package isn't published on pub, so it doesn't need
a pubspec.  Removing it should help avoid the package getting
published by accident.

Change-Id: I8cf56a16fe0ad99836f192125cdfe84d757e93fb
Reviewed-on: https://dart-review.googlesource.com/c/86400
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-06 18:28:18 +00:00
Kevin Moore 4d5c5ecdbf Update synced version of pkg:test 
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK

Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2018-10-16 16:12:38 +00:00
Devon Carew 89cfa2edd7 Update package:test_reflective_loader. 
Change-Id: If23bb61ef03efe62282ba2e163d3a830d6e0bfad
Reviewed-on: https://dart-review.googlesource.com/67700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-08-01 00:20:45 +00:00
Kevin Moore 902b6db749 Mark analyzer_cli, analysis_server pubspecs as not-to-publish 
Closes https://github.com/dart-lang/sdk/pull/33828

Change-Id: I3693f4b0315c4cb8f8d757dc53a9b49c0a38b0e0
Reviewed-on: https://dart-review.googlesource.com/64721
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2018-07-12 17:04:43 +00:00
Devon Carew 3a5fcf5a87 Upgrade the dep on package:isolate. 
Change-Id: Ie9c52c6dd24672e2469787220505bd85a50ed5ff
Reviewed-on: https://dart-review.googlesource.com/51241
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-04-16 17:08:48 +00:00
Paul Berry b4e176b570 Adjust timeout for reanalyze_concurrent_test.dart. 
Change-Id: Ic1cb4aa69cfeec14109b9503db140f85fcfab06b
Reviewed-on: https://dart-review.googlesource.com/48445
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-26 20:20:52 +00:00
Brian Wilkerson db6e377e6d Make analysis_server_client Dart 2 safe 
Change-Id: Iab06cb5b779599a1a107fa6fdf832345950fa84c
Reviewed-on: https://dart-review.googlesource.com/48322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-25 15:20:36 +00:00
Zachary Anderson 74fc14dad7 Update args deps in analysis_server pubspec 
Change-Id: I10090757fa7b6d776b9ab6948cdaee60ef4129c4
Reviewed-on: https://dart-review.googlesource.com/35802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-01-18 22:16:44 +00:00
P.Y. Laligand 56feddec9e Bump the version of intl used by analysis-server. 
This aligns it with the version in third_party.

Change-Id: I0246f321e6540b6061e0b9f6c804c669f3a9596f
Bug:
Reviewed-on: https://dart-review.googlesource.com/14020
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2017-10-16 20:09:57 +00:00
Konstantin Shcheglov b1589bf879 Replace typed_mock with mockito in analysis_server. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2991773002 .
 2017-07-26 08:14:25 -07:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
 2017-07-05 23:29:46 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
 2017-05-31 07:15:20 -07:00
Mike Fairhurst e9edd2e568 Fix pubspecs for new analyzer plugin arch dependencies 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2877863002 .
 2017-05-11 14:37:46 -07:00
Lasse R.H. Nielsen 83298690b0 Fix static typing problem in analysis_server tests. 
After changing argument of `Future` constructor to be `()->FutureOr<T>`,
the `()->Future<dynamic>` argument didn't work.
Problem compounded by return type of `Stream<T>.firstWhere` being `dynamic`.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2794503002 .
 2017-03-31 14:12:32 +02:00
Devon Carew 9793406f08 Switch to using expectAsync0() to address some deprecation warnings. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2701473009 .
 2017-02-17 09:39:23 -08:00
Kevin Moore c1a0b12159 use latest pkg/isolate 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662723002 .
 2017-01-28 13:53:17 -08:00
Konstantin Shcheglov 2e2b92932a Move analysis_server dependency on analyzer back to 0.28.0 
The dart_style change to widen version was landed, but now pub says
that there is the same problem with 'linter'. I don't know why
analysis_server is tested as a package at all.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2391263007 .
 2016-10-06 20:38:35 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Konstantin Shcheglov ac81124b8c Revert "Use dependency_overrides / analyzer in analysis_server." 
This reverts commit 72f5463631.

Yes, we do have bot failures :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2298423002 .
 2016-08-31 15:01:10 -07:00
Konstantin Shcheglov 72f5463631 Use dependency_overrides / analyzer in analysis_server. 
RFC

We always do this locally, but until analysis_server is published,
we could just keep this change in repo.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2298973002 .
 2016-08-31 14:44:09 -07:00
Konstantin Shcheglov cc6beaf56d Pull in test_reflective_loader 0.0.4 and switch analyzer to it. 
There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2298913003 .
 2016-08-31 13:46:39 -07:00
Kevin Moore 17a2ddfd42 Update dependency on pkg/package_compiler 
For analysis_server, analyzer, analyzer_cli, compiler packages

Progress on https://github.com/dart-lang/sdk/issues/26711

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2172683002 .
 2016-07-27 08:42:05 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
 2016-07-08 15:01:05 -07:00
pq 40b03d2261 Server and CLI pubspec updates [TBR]. 
Should address version constraint issues introduced by dep on new plugin API.

BUG=

Review URL: https://codereview.chromium.org/1972193002 .
 2016-05-12 06:21:46 -07:00
Brian Wilkerson d87f9c09de Update to use the latest version of the plugin package 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1965083002 .
 2016-05-11 09:54:29 -07:00
pq 2529c09fe5 Update analyzer dep lower-bound. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520823004 .
 2015-12-11 14:56:08 -08:00
pq 63f24be16c Update server/cli linter pubspec deps. 
* bumps lower-bound to grab a `0.27.0`-compatible linter.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520973002 .
 2015-12-11 10:51:50 -08:00
pq 3b296c3d1c Analyzer version bump. 
Version bump pre publishing of `_embedder.yaml` support.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1466663003 .
 2015-11-20 16:40:36 -08:00
Konstantin Shcheglov dee2660831 Publish new analyzer version and use in analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1408943008 .
 2015-11-04 10:33:38 -08:00