dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
104,069 Commits 2 Branches 0 Tags
e94de78d2bb73240999163a264b0fcf6605f026a
Commit Graph

173 Commits

Author SHA1 Message Date
Moritz 220a82ae41 Prepare package:meta for publish 
This makes the `@RecordUse` annotation available. Also pull in the latest package:native rev for keeping usage recording synced.

Change-Id: Iedc01bf309ae36eb803a281595c8e69eeb923da7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385422
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Moritz Sümmermann <mosum@google.com>
 2024-09-19 20:21:20 +00:00
Moritz 81daf8e563 Use package:record_use 
- Rename resource identifiers in the VM to usage recordings.
- Use package:record_use for serialization.
- Rename and use the experimental flag for this feature.
- Recognize tear-offs and top-level methods as well.

Next steps:

- Add constant instance recording.
- Expose API in package:native_assets_cli's link callback.

TEST=pkg/vm/test/transformations/record_use_test.dart

Change-Id: I8af3625165f78925ae943711245af93a239d1012
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383040
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Moritz Sümmermann <mosum@google.com>
 2024-09-12 08:47:53 +00:00
Matan Lurey 5c69448186 Allow representation types to be considered parameters by TargetKind.parameter. 
Bug: https://github.com/dart-lang/sdk/issues/55486
Change-Id: Ib4a7d46da12baf93412bf4dbfae63969d2acc18a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Matan Lurey <matanl@google.com>
Commit-Queue: Matan Lurey <matanl@google.com>
 2024-07-03 18:24:19 +00:00
Matan Lurey 15f666c3eb Fixed @doNotSubmit to prohibit same-library, allow nested functions. 
Bug: https://github.com/dart-lang/sdk/issues/55558
Change-Id: Ib0aa786e81e6fc9fecc8af7a3edbbd541cabcaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364382
Commit-Queue: Matan Lurey <matanl@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Sam Rawlins <srawlins@google.com>
 2024-07-02 00:10:23 +00:00
Sarah Zakarias 5e76f788a5 [pkg:meta] Add topics to pubspec.yaml 
Closes https://github.com/dart-lang/sdk/pull/55923

GitOrigin-RevId: e4322c06820f99013464cc37dfa291f345aad686
Change-Id: I6bb9e7c9c6c2d8c823d49c098acf4c62fd2181b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369528
Commit-Queue: Sarah Zakarias <zarah@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-06-10 10:27:36 +00:00
Sam Rawlins e04c53d5ac meta: add TargetKind to @factory 
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I5c0608637f2feb9986e890f3c83cf02884bef7f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369789
Commit-Queue: Sam Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-06-06 15:39:56 +00:00
Sam Rawlins 8029fdf79a meta: Add a TargetKind for _Sealed 
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Ibac1f71f6cbb9432150b49b8565bf740efa1be32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Sam Rawlins <srawlins@google.com>
 2024-06-05 20:28:57 +00:00
Sam Rawlins a451edf978 meta: Use TargetKind.overridableMember on MustBeOverridden 
Change-Id: I6f19eeac5efac2c56eabecd32bc6e2032d1ba764
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369526
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-06-04 17:29:09 +00:00
Sam Rawlins 28be4efd8f meta: require that @mustCallSuper only annotates overridable members. 
Previously, this behavior was custom-wired into the Dart analyzer, but
now it is specified with TargetKinds.

In the analyzer we remove special annotation-target-verification for
`mustCallSuper`.

Change-Id: Ibd3ada0a612069c5286facffaad557671c7a85b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-05-31 21:41:43 +00:00
Sam Rawlins 97d4d12dc0 meta: Add TargetKinds for @immutable; narrow error range for "invalid annotation" warnings. 
This change looks big, and this is because we change the range of all
of the "INVALID_x_ANNOTATION" from the whole annotation (like
`@Immutable("...")`) to just the annotation identifier (like
`Immutable`). This affects many tests.

The error range is changed so that we can consistently use the
`RemoveAnnotation` fix to fix these warnings; it just needs a
consistent error node, so that it can find the Annotation node above.

All this to support `TargetKind`s for `@immutable`, so that we can
remove the custom "INVALID_IMMUTABLE_ANNOTATION" message.

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Ifd64e154986b6cbcbafeb9420ca8d0949653e618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367881
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-05-28 18:28:49 +00:00
Sam Rawlins 0d5830e541 meta: Support @doNotStore on constructors and mixins 
There were no tests of this component of the annotation's description:

> The annotation can also be applied to a class to implicitly
> annotate all of the valid members of the class

So I add those as well.

Bug: https://github.com/dart-lang/sdk/issues/48476
Change-Id: If5f0f4c6057f57b4dfd01d8f648110d69fbc5eb4
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-05-23 16:26:39 +00:00
Sam Rawlins 1bfae529f7 meta: Sort TargetKinds 
Change-Id: I9ecc0ac8050bdac6dd61b8e67e889a57cb0a0fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365622
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-05-08 18:30:19 +00:00
Sam Rawlins f2d8cd15c9 Bump package meta to 1.15.0 
Change-Id: I53f7e0d9601f1e51f8bce874b449f063926b2001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365281
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-05-06 18:01:32 +00:00
Sam Rawlins 73f5417b23 meta: introduce TargetKind.overridableMember 
Fixes https://github.com/dart-lang/sdk/issues/55387

Change-Id: I379035f89ca3df7f6062a2f45da7b9a230f9c750
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-05-02 14:43:58 +00:00
Sam Rawlins f759281cd8 meta: introduce TargetKind.optionalParameter 
Fixes https://github.com/dart-lang/sdk/issues/55567

Change-Id: I45a1b6af9d9522b2f374ee627cc07f1d3fb47817
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-04-25 18:55:59 +00:00
Matan Lurey dbd8e3fe32 Ignore abstract classes, mixins, sealed classes. 
Bug: https://github.com/dart-lang/sdk/issues/52965, https://github.com/dart-lang/sdk/issues/55550
Change-Id: I8ec70f909f55663eb299764f0402c5a992729846
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364206
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Matan Lurey <matanl@google.com>
 2024-04-24 18:37:15 +00:00
Sam Rawlins 34e29fbefb analyzer: add CHANGELOG entry regarding doNotSubmit and mustBeConst 
Change-Id: I368481b88135cd0f9440cfbe10d1b990a7610d13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364205
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-04-23 22:53:29 +00:00
Sam Rawlins eb7ba49329 analyzer: Allow @useResult on constructors 
I also want to allow `@doNotStore` on constructors (kind of weird, but
sound, and just to be consistent). But that annotation currently has
no functional tests.

Change-Id: I66d276008294c03d9720809c4418294bd0c416ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361284
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-04-08 16:28:33 +00:00
Matan Lurey 497b861187 Add TargetKind.constructor to _DoNotSubmit. 
Change-Id: If5ecd6bf015ef6e90761aa5d6d940cd8b021b30d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361280
Auto-Submit: Matan Lurey <matanl@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-04-04 17:45:01 +00:00
Moritz b321254093 Add @mustBeConst annotation for parameters which should be 
constant.

As const-only parameters are not planned, see
https://github.com/dart-lang/language/issues/1684, an annotation with analyzer support could help a bit at least, see
https://github.com/dart-lang/sdk/issues/29381.

The motivation is to enforce const arguments for methods annotated with
`@ResourceIdentifier`, to be able to record the argument values at build time, see https://dart-review.googlesource.com/c/sdk/+/329961.

Tested: pkg/analyzer/test/src/diagnostics/const_argument_test.dart
Change-Id: I2b8d2dce0c899fc0caa4985d892a5d031c747521
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357701
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
 2024-04-04 15:22:31 +00:00
Sam Rawlins 198339c824 meta: Bump to 1.14.0 
Change-Id: I2b1270c3db2031740bbe08587382f04a0f9a63bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361020
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-04-03 20:53:38 +00:00
Sam Rawlins 9680d387ec meta: Add TargetKind.enumValue 
In
[the spec](https://github.com/dart-lang/language/blob/main/accepted/2.17/enhanced-enums/feature-specification.md),
these are referred to as "values", so I went with that wording here. In
the analyzer, I found one case where we call them the "constants"
(EnumDeclaration.constants). I'd prefer to stick with the more common
term, "values."

Fixes https://github.com/dart-lang/sdk/issues/47312

Change-Id: I3ea4650fdeb15d3d23fb7ca42bcf6e0ec0e511f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-04-03 18:20:59 +00:00
Sam Rawlins c9474ebaaa meta: Introduce TargetKind.directive 
Fixes https://github.com/dart-lang/sdk/issues/52274

Change-Id: I67884caf86502d4edd848eb32a30097488e09db9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-04-02 17:29:29 +00:00
Matan Lurey a7c57c327c Initial implementation and tests of @doNotSubmit. 
This is my first time contributing something like this, so I mostly went with my gut and tried to refer to similar annotations and diagnostics.

Happy to make adjustments.

R=pquitslund@google.com,brianwilkerson@google.com
CC=​yjbanov@google.com

Bug: https://github.com/dart-lang/sdk/issues/28113
Change-Id: I628311ed99f62b04c37bd1e0ec82ae0b1652d7f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360481
Commit-Queue: Matan Lurey <matanl@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-04-02 05:09:31 +00:00
Sam Rawlins cd90f27317 meta: Introduce TargetKind.constructor 
Fixes https://github.com/dart-lang/sdk/issues/47421

Doc nits while I was looking:

* wrap CHANGELOG to 80 characters
* correct docs on field, getter, method, parameter, setter, typedef,
  type parameter,

Change-Id: I97476e08b6773be53dbce190007443f22626d498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-03-29 19:15:40 +00:00
Sam Rawlins a70ee07cc2 Add TargetKind.typeParameter 
Fixes https://github.com/dart-lang/sdk/issues/49796

Change-Id: I434c3bba20cbcf26177db4f0dc199bb696ab04de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-03-29 06:40:43 +00:00
Moritz f1c285937a Fix metadata for @ResourceIdentifier annotation 
The annotation takes metadata of type `Object?`, to allow for custom
data such as strings, ints, double, or bool. The parser, however,
assumed only strings.

Tested:pkg/vm/test/transformations/resource_identifier_test.dart
Change-Id: If813b2b0e5f002306bcfa6eb6195a666d1a72972
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355922
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Moritz Sümmermann <mosum@google.com>
 2024-03-11 17:08:24 +00:00
Moritz 502e8e0960 Prepare package:meta for publish 
Change-Id: I28615dd6eae807bd585218e343b11d490058c89b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350241
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Moritz Sümmermann <mosum@google.com>
 2024-02-05 14:05:29 +00:00
Parker Lougheed bcfab01e87 [meta] Cleanup API docs and clarify superseded annotation status 
This CL standardizes some comment formats, adds a few missing doc comments, and updates a few others.

It also adds text to a few annotations indicating they are likely to be deprecated in a future release and what the migration path is.

Contributes to https://github.com/dart-lang/sdk/issues/54389

Change-Id: I4fc6d9767378b855a1ab2a1978747fbe18850605
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342281
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-01-10 02:10:36 +00:00
pq b17d4cb14b Fix a few typos 
Change-Id: I461ea0c88c257c630577d21bd94c08a3fadb3ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-12-12 19:16:13 +00:00
Moritz a3568286ff Adding the resource-identifier functionality from the compiler to the 
vm.

This identifies all calls to static methods annotated with
`@ResourceIdentifier`, collects the constant arguments passed to the
method, and writes the results into a file.

The purpose of this feature is to be able to pass the recorded
information to packages in a post-compilation step, allowing them to
remove or modify assets based on the actual usage in the code prior to
bundling in the final application.

Tested: pkg/vm/test/transformations/resource_identifier_test.dart
Change-Id: I58cb313b66ee23c1d154dcc242547723a1ced359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329961
Commit-Queue: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2023-11-21 15:05:35 +00:00
pq f962700302 + flutter_style_todos 
Enabled `flutter_style_todos` in analyzer packages:

* `analyzer_cli`
* `analyzer_plugin`
* `analyzer_utilities`
* `meta`


Change-Id: I5fcd76bfa5a3bdeb14d6a81b8193129c6d83d0e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335405
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-11-13 00:14:09 +00:00
pq 62515563eb meta 1.11.0 
(prep for publishing)

Change-Id: I666a084216877883b9c0c3e954c23c96656587e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329801
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-10-10 22:21:05 +00:00
pq 8a5ddecfb3 + extension type target kind (and @optionalTypeArgs support) 
Adds a new TargetKind for extension types and adds it to `@optionalTypeArgs`.

Change-Id: I7254c1299c296451b9adc5d1f8eceb50af66f039
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324769
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-09-08 18:09:01 +00:00
pq f064b6149b Add changelog entry for TargetKind refactor 
See: https://github.com/dart-lang/sdk/issues/53368

Change-Id: I68a8a564db8491def160da27e625779769c81154
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-09-05 20:42:20 +00:00
pq 813339e28a refactor TargetKind enum to class 
A trimmed down version of https://dart-review.git.corp.google.com/c/sdk/+/258200 which was reverted (https://dart-review.git.corp.google.com/c/sdk/+/268380) for (undiagnosed) performance reasons.

See: https://github.com/dart-lang/sdk/issues/53368


Change-Id: Iecd00a4483a4b6904b8b281eec49228620e1e943
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322981
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-28 23:09:27 +00:00
pq c41bd0326d meta 1.10.0 
Change-Id: I14e701e49d04cc8eb32dd2885af52fcbce03cc49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319384
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-09 18:07:32 +00:00
pq 98070ec188 Add @redeclare 
See: https://github.com/dart-lang/sdk/issues/53121

Change-Id: I812bc49b58cdf15e9c0c8bcc62a846b51f5dff70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319100
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-08-09 16:59:00 +00:00
pq eb2af1a41a +implicit_reopen link 
Change-Id: I7e4468ab77b86437bd0483698cf2be873b9f57c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319002
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-09 15:43:19 +00:00
pq dfe1093849 meta 1.9.1 
Fixes: https://github.com/dart-lang/sdk/issues/51059

Change-Id: I7f28741ad0d1507cc1140da6c7c0bccb31d6946b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-03-22 20:58:58 +00:00
pq 4c7e87888d update @reopendocs 
Fixes: https://dart-review.googlesource.com/c/sdk/+/286860

Feedback welcome. I expect we'll want to iterate more on this but I see Erik's new content as a distinct improvement.


Change-Id: Iba385be6c411f2e5e3f1bd490b437dbea86e07aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286860
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-03-07 21:21:01 +00:00
Sam Rawlins 2c9e918308 Bump meta to 1.9.0 
Bug: https://github.com/dart-lang/sdk/issues/51154
Change-Id: I04c02476f0b7ac8e64486ba09b956e4cc9b4d5c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280073
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-30 21:07:30 +00:00
Josh Soref 77978889eb Spelling 
Closes https://github.com/dart-lang/sdk/pull/51143

GitOrigin-RevId: 9e21c99a222d588e4fc95980725a2f8c9784965c
Change-Id: If0870e8936c7649935dce7e23cd783d62aa5610c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279916
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-30 18:29:59 +00:00
Sam Rawlins b1525bcf19 Deprecate alwaysThrows 
Fixes https://github.com/dart-lang/sdk/issues/49583

Change-Id: Icc10dbba642703098708202537c733ff1d48b9db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279651
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-01-26 16:42:08 +00:00
pq c8df5570bc + @reopen 
See: https://github.com/dart-lang/sdk/issues/50977

Change-Id: I8bc6547a3f5e2cf4bb8913b1d6dfb8a618fc2022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278888
Reviewed-by: Kallen Tu <kallentu@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-23 21:33:53 +00:00
Samuel Rawlins 813ca7faf6 Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 
This reverts commit 82143e6c95.

Reason for revert: This commit appears to have negatively affected the analyze benchmark:

* https://golem.corp.goog/Revision?repository=flutter-analyze&team=dartanalyzer&revision=114193

We need to revert and analyze it.

Original change's description:
> [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter
>
> Bug: https://github.com/dart-lang/sdk/issues/49796
> Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: I6ec04ffe8d85c417d138626ffa4f1a7ac7dafe2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 20:17:09 +00:00
Mateus Felipe C. C. Pinto 82143e6c95 [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter 
Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 23:38:40 +00:00
Sam Rawlins d77ded508e Report invalid mustCallSuper annotation targets 
Fixes https://github.com/dart-lang/sdk/issues/49499

Change-Id: Ibea55a78b58ee83b9290c33bca5e69039c995d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252865
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-07-28 17:48:15 +00:00
Sam Rawlins aee2e21de8 Correct mustCallSuper documentation as per analyzer impl 
See must_call_super_test.dart for tests covered by this documentation.

Bug: https://github.com/dart-lang/sdk/issues/49499
Change-Id: I50e6546dda155cb133b8ad314db27a266a94fa00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-27 00:58:37 +00:00
Sam Rawlins 7280525117 Implement mustBeOverridden annotation and enforcement 
Fixes https://github.com/dart-lang/sdk/issues/30175
Fixes https://github.com/dart-lang/sdk/issues/28250

Change-Id: Id9c62448da9ade81258c2ae2355d05117057a8f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-25 22:17:18 +00:00