8d925319ca
Copy the file header comment when creating a new file
...
Change-Id: I5d864c0d138f6d9389c56a312c111da1f9671081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265186
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-10-24 21:14:22 +00:00
18acd0e44c
[analysis_server] Include target locations in Inlay Hints
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4156 .
Change-Id: I8713bccbded828d0753c7dd277b3f8da12c0f68e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-24 15:17:13 +00:00
664c021374
Deprecate xyz2 in elements.
...
Change-Id: I0dbf25882cf66670ce2d69dd22aceb053be9feb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265182
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 22:07:47 +00:00
7840c54107
Report EXPECTED_ONE_LIST_PATTERN_TYPE_ARGUMENTS.
...
Change-Id: I59f2227dea39f13660e360815b1cf7d60c995a0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-21 21:52:18 +00:00
3817a4ab66
[analysis_server] TransformSetManager to use cache
...
Fixes #50252
Change-Id: I0e29af6d5e718459c8dbf6bbce81a1652c1b51bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 17:04:05 +00:00
671bb192ab
Remove domain 'kythe' from DAS.
...
Change-Id: I66f0e538dce6eead6ba1c98b9cf0e3d747450130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264895
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 17:03:29 +00:00
470f394424
[analysis_server] don't remove empty statement when in dead code
...
Bug #50188
Change-Id: I19abc92900f6c939778e240e3df2d17ae4068967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-20 19:21:37 +00:00
eea6fb106d
Look for BUILD.gn files to identify ContextRoot(s) with GnWorkspace.
...
This rehabilitates language server support for Fuchsia.
This makes GnWorkspace more like PubWorkspace, not like BlazeWorkspace. The workspace is the location of `BUILD.gn` file (and is identical to the package, although I did not change this in this CL). And there must be also `.jiri_root` somewhere above it.
We don't look for `pubspec.yaml` files to decide that we have a new `ContextRoot`, instead we rely on `.dart_tool/package_config.json` created by `Pub` from `pubspec.yaml`. For GN, I had to specialize it to look for `BUILD.gn` files.
With this change `BUILD.gn` takes preference over any other signal, so we don't care if there are `pubspec.yaml` files.
Fixed: fuchsia:109640
Change-Id: I2277336bd377abb9d8c8c33529183e21b2f51c4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-19 17:57:50 +00:00
3785d6f59a
Convert RefactoringProducer to use coveringNode
...
Change-Id: Iab2296aeba88085b1ec97afd755e03d4bf8de002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 21:05:26 +00:00
ffe4a8c864
[analysis_server] Prevent convert method<->getter refactors on SDK/external package files
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4221 .
Change-Id: I1a017f098d3d72bc19c91cead4c68b2666c5fe01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 16:24:16 +00:00
8436076fe4
[analysis_server] AddExplicitCast to handle type arguments
...
Bug #49896
Change-Id: Ib024d40c1291ecb219f235fabf3dcc2305a82368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263741
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-13 21:34:03 +00:00
6f8d1e4859
[analysis_server] Add LSP Type Hierarchy
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3313 .
Fixes https://github.com/Dart-Code/Dart-Code/issues/2527 .
Change-Id: I9f471fd3d7d55999795fee7ab4761e906566bd10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-13 19:39:18 +00:00
b5846d8aba
[analysis_server] Fix renaming of enum constants
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4215 .
Change-Id: Ia55d7ffe5230c483218729e2c51c360dbb24bb57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264003
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-13 19:32:56 +00:00
54d7847787
[analysis_server] Fix relationships for subtypes that provide type arguments
...
Change-Id: I655f7bff036a17ee79a1d0f9f163125112766f2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264001
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-13 18:07:19 +00:00
a93b073d27
[analysis_server] Add interfaces+superclassConstraints to type hierarchy computer
...
+ return relationship between each item and the target.
Change-Id: I426c84acf16caee0d0c5b5f69224c7ad894ee955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-13 17:00:50 +00:00
eab05710b4
[analysis_server] Add a lazy computer for type hierarchies
...
Change-Id: Ieb71cea26214e3b790b80e905b3d581f297512d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263760
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-12 19:22:17 +00:00
20af356c79
[analysis_server] Trigger reanalysis when LSP TODO settings change
...
Previously the setting only applied to future analysis, but this triggers reanalysis immediately.
Change-Id: Ia5687e2bbf5f5a48d9659645c5b15976e712f44f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-12 17:43:01 +00:00
0b5d908221
[analyzer] NOT_ENOUGH_POSITIONAL_ARGUMENTS
...
To report at the token of the expected positional argument
Fixes #50127
Change-Id: I5eb31c6d354fb15d482c2046f7faaa4505658f4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262603
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-11 17:56:11 +00:00
7432006bd7
[analyzer] handle dead code with do statement
...
Bug: #43511
Change-Id: Iddae879e5343ccdafc33258495771bd6a60afef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260110
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-10 23:03:34 +00:00
20218dfe15
[analysis_server] DataDriven to handle MISSING_REQUIRED_ARGUMENT
...
Fixes #45475
Change-Id: Ibe5e3b393183affb15ed5fd3449f7c497acec14d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-10 21:26:19 +00:00
0a23e439e9
[analysis_server] AddExplicitCast for as
...
Bug: #49896
Change-Id: Iddbe616db0edadf57ad76637863ad7a29533a77b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260111
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-10 21:26:15 +00:00
ecb992586a
[analyzer] change range of dead code of the RHS of binary operator
...
Bug: #43511
Change-Id: I1b1562c0262101900dabea3544bfc28293d5c7f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260109
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-10 21:07:42 +00:00
172bcc33dd
[analysis_server] Fix hover on constructor name declarations
...
Change-Id: I6254a8a8d82a1f2b12e8fa3589fbe114d9945af6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-10 16:43:57 +00:00
8d1297628a
More tests for ExtractorPattern resolution, report errors.
...
Change-Id: I800f909a1d58e8bebcbfa30e52f09a16906b1e07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-07 18:35:35 +00:00
5ef329cf74
Report CompileTimeErrorCode.DUPLICATE_VARIABLE_PATTERN
...
Change-Id: I07cb697c9c517f0d4eb67100f0ae134aa821d25d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263002
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-07 00:16:27 +00:00
a1eec6be31
[analysis_server] RemoveLeadingUnderscore to handle conflicting names
...
Fixes #50142
Change-Id: I68c225e0528c643a29f2454607464d3896f25d36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262606
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-06 19:29:24 +00:00
57a619bcb7
Report diagnostics for relational patterns.
...
Change-Id: I1a3e02e36679599e0240f74108a5e91db6269b1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-06 16:33:41 +00:00
ad334d85e1
[analysis_server] Don't allow Extract Method on directives
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4202 .
Change-Id: I273d88f3dc5cfd76f01f268485c06916bbd74e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262430
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-06 15:39:15 +00:00
e860cf241b
[parser] Empty record
...
https://github.com/dart-lang/language/pull/2535
Change-Id: I8241119ee858ce39673472056b88c9393799e1a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262600
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2022-10-06 06:34:58 +00:00
d485d1a3aa
[analysis_server] Allow clients to tell server which refactor field kinds they support prompting for
...
Change-Id: Idcd79cb36344b95904184ca8c61be15cf1d2e3a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-05 21:08:42 +00:00
615252b4e7
[analysis_server] enabled AddKeyToConstructors for bulk fix
...
Fixes #50056
Change-Id: Ib6bff33a79860425027ac7b6ee3fc394b8d1200a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2022-10-05 17:03:52 +00:00
683e2419da
Deprecate 'DartType.element2' use 'element' instead.
...
Change-Id: I6986a058616db489987789cfab09d53a450e3ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262666
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-05 16:30:09 +00:00
6ec291c2ea
[analysis_server] AddKeyToConstructors to handle named constructors
...
Fixes #50118
Change-Id: I0a2921b2929d359164005d3943f35abfe3d3414e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-04 20:18:57 +00:00
15be61ed9a
Remove INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES warnings
...
Fixes https://github.com/dart-lang/sdk/issues/49112
It was decided to remove the "override with equal default value"
restriction both for null safe code, and for pre-null safe code.
CFE had never issued this static warning, and her we remove it from
analyzer.
Change-Id: I1244e4fe46da8bb4bd8c3a77ec8beb95811e30a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-04 18:23:10 +00:00
fcc9473dab
Deprecate CatchClause.exceptionParameter2/stackTraceParameter2
...
Change-Id: I3f0ae9367f35fe514a125cb0f06ccbdc8fa0dc18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262502
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-04 15:58:11 +00:00
6da33ae60f
[analyzer] add HintCode.DUPLICATE_EXPORT
...
Fixes #49439
Change-Id: I511205c6b0960f6b19a2ac45211bc1348568f52c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-03 23:22:18 +00:00
8a5725ad38
Deprecate 'Directive.element2', use 'element' instead.
...
Change-Id: I2326b43381d1d3f84d74f69409bc688516f6a0d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262500
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-03 21:10:58 +00:00
8941837fb7
[analysis_server] Prevent "Extract Method" refactor showing up for function declarations
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4165 .
Change-Id: I799220fffabfa39af1b2fd3039cb2de903f90c72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-03 15:08:48 +00:00
578e350fd4
Reduce the use of streams in data-driven fixes
...
In addition to making the code cleaner, I expect that this will also
improve performance. Unfortunately, we don't have anything in place to
measure or monitor the performance of correction producers, so I can't
prove that.
Change-Id: Iac640c57ccafe68ef522fd3fe807abc4f66f6a86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262263
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-30 19:31:48 +00:00
c73228abaf
Report an error when a variable pattern binds in one branch of logical-or, but not in another.
...
Only check for if-case is implements for now.
Change-Id: I57d1b8b33fbe2bf7adc848b5d607ff99b878b479
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-09-30 18:53:26 +00:00
74a5cf758f
Enhance create-local-variable to work with records
...
Change-Id: Iedbcdebe79b3c4ef2ce1205fb7605c1106ac852d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262262
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-30 18:24:16 +00:00
53447c990f
Enhance add-type-annotation to handle record types
...
Change-Id: I684820c9368f282039a93f34571afb014fb476a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-30 17:04:46 +00:00
06c5592b9c
Enhance change-type-annotation to support record types
...
Change-Id: Ib5bbdec16c88858cda4f1739ad92a4c68e598a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262261
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-30 17:04:16 +00:00
9b4cda1bfd
[analysis_server] DataDriven: allow replacedBy from a package to another one
...
Bug: #48204
Change-Id: Id13f038e39e9e150e1d6b21bcdde25bb815b15a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-30 15:30:57 +00:00
4b134e4b14
Simplify TypeMemberContributor.
...
There is no need to put data into local variables, and invoke
something for the InterfaceType. We can call it directly at the end
of each branch.
Change-Id: Iee0d2304fb45b526604f2c6bd6a81363820d5909
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262103
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-30 14:32:41 +00:00
a30a4dc860
Update make_variable_nullable fix to work with records
...
Change-Id: I77d6db6f79d2bc83e16b406c9b2804cbe2164974
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262021
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-30 14:19:51 +00:00
8eb8e61e1e
[analysis_server] DataDrive replacedByto handle removed constructors
...
Fixes #50011
Change-Id: I30670f88562216ffe057b0e4de7e93d50a414fe0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260761
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-30 13:58:08 +00:00
4b4f58b674
Suggest members from Object when completing a record property access
...
Looks like we might need a feature to cause record fields to be suggested
before Object members. Hard to say though without tests. Anyway, that's
a task for another CL.
Change-Id: I123d6953b1ed10ac926885ce2b1a4d5926a908ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262024
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-30 00:04:58 +00:00
ae435d7cfc
[analysis_server] associate UNDEFINED_IDENTIFIER with ImportLibrary.forExtensionMember
...
Fixes #50042
Change-Id: Id714445c50bbe1df1db873179772b42b08b72560
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260706
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-29 21:50:48 +00:00
eb9554d70e
Evaluate more fixes
...
I also noted how many ParserErrorCodes are 'needsEvaluation'
Change-Id: I487976c918038903ef49a87a3cb97d1af2327398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-09-29 20:37:59 +00:00
Brian Wilkerson