dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
84,072 Commits 2 Branches 0 Tags
e6ff207cf82aedbfeaa4e29df7ede0d1a55cbebd
Commit Graph

5045 Commits

Author SHA1 Message Date
Konstantin Shcheglov 309941c101 Implement analysis.implemented for enums. 
Change-Id: I166703b652eb341f18d4b9442acdfc341cd20170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234446
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-25 23:34:32 +00:00
Konstantin Shcheglov a3cf4c1e0f Implement analysis.overrides for enums. 
Change-Id: Ie84219ad88c2601dea974d20892c3fedb3065f00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-25 22:35:32 +00:00
Sam Rawlins 98361461f0 Add remove_leading_underscore fix for lint 
Change-Id: I2db240604580f270980296c07296a1336d45ff90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-25 15:57:33 +00:00
Danny Tuppeny 84806572e0 [analysis_server] Allow Flutter "Wrap" assists to work with constructor names selected 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2492.

Change-Id: I5347e3ade842c3a155809e5224ca0ab40dd8651b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-24 20:04:30 +00:00
Konstantin Shcheglov 69c8eccfc2 Implement outline for enum members. 
Change-Id: I1f117d20b23206e192b3fb3286581aaa2d46b942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-24 18:56:43 +00:00
Brian Wilkerson 494b45d453 Convert error fix status from text to yaml 
I did not make any changes to the data other than to reformat it. I'll
integrate my analysis in a follow-on CL. I'll also start adding tests at
some point unless someone else gets to it first.

Change-Id: Id659b0ccc31d1e66f345a99df6a58b44ecb7fbae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234111
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-24 05:10:28 +00:00
Ilya Yanok 6e3153ba11 Don't use server.currentSessions to init workspace in bulkFixes 
edit.bulkFixes are supposed to be called without starting analysis and
server.currentSessions only appear after the analisys is started.

bulkFixes creates AnalisysContextCollectionImpl locally, so we should
reuse the sessions from contexts inside it instead.

This enables not starting the analysis from `dart fix`.

Change-Id: I6aa045ed9ce00b3bee56301ea71dc84a71be01b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-23 19:05:43 +00:00
Danny Tuppeny 62c138bbc4 [analysis_server] Add Flutter snippet for Widget with AnimationController 
Change-Id: Icea1af510e65bdfbc395089184452ddb91d7446e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-23 17:23:42 +00:00
Danny Tuppeny 729b2e5d34 Basic support for folders in MOVE_FILE refactor 
Change-Id: If960592199526df3dcd7f35c8a2396060b27e46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-23 17:22:42 +00:00
Brian Wilkerson 581f71eee2 Update the error_fix_status document 
Do we want a test to ensure that this document is kept up to date as we
change the list of error codes, or do we want to manually maintain it
through periodic CLs like this one?

Change-Id: I0e22841b1e7dd165bd0c96d1024e102e95c3586b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233724
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-22 22:17:03 +00:00
Brian Wilkerson d41b7d73b0 Support converting classes with factory constructors to enums 
Change-Id: If42ca118ade6750ecb88f09ce7e18a338e8255ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233761
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-20 21:27:44 +00:00
Danny Tuppeny 37ae0d5648 [analysis_server] Add snippet for Flutter StatefulWidget 
Change-Id: I64e5b34217d7f89b20122573299c2fab2ae3f0b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-20 00:24:12 +00:00
Brian Wilkerson ab6d76844a Attempt to fix the windows bot 
Change-Id: Ifbe570282c99441c3b80926ae4d615e142b27480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233657
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-19 05:20:32 +00:00
Brian Wilkerson 0b12b2c5a4 Unify the two copies of IndexRange 
Change-Id: I3836c680b71404c157814eb5c3c234b026587be9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233654
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-19 02:20:32 +00:00
Brian Wilkerson 0921dceaef Add a quick assist to convert a class to an enum 
Change-Id: Iebd83940c85e778132132bfe483df08193f574ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-18 20:00:21 +00:00
Danny Tuppeny bf491f87cd [analysis_server] Add support for snippets in LSP completion 
Change-Id: Ife64add884c310e4d0b5413ef91665aef2375648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-18 19:43:21 +00:00
Konstantin Shcheglov aec9bccdd9 Update 'mightBeTypeIdentifier' to return the type name, or null. 
This way, instead of implicit result that the given node is a
SimpleIdentifier and requiring a cast in the client, or a
PrefixedIdentifier - so we have to check whether it is one or another
again; we now prove the result by returning the actual value, not
just a flag.

Change-Id: I65f0a21e5d3c1e7be06e621a0f7fb6a5e6b2db2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232780
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 17:04:30 +00:00
Konstantin Shcheglov beddd6f2cd Rename refactoring for enum constructors. 
Change-Id: I35fd6ba07b911862c76d58aa7a58d226d2ff050f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:21:23 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Danny Tuppeny 55fd24e6a6 [analysis_server] Refactor LSP snippet building in preparation for Snippet completions 
Change-Id: Ie39e2e803d17435b31246da07ed69eba7d7aba21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-16 20:01:00 +00:00
Jaime Wren a2f887ea59 New optional enum input, CompletionCaseMatchingMode, in DAS getSuggestions2 request. 
Change-Id: Ibddcd7db4f51266c29a104d2b46e93c29ddf5465
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232422
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2022-02-15 00:15:00 +00:00
Danny Tuppeny 4bd312d1e6 [analysis_server] Improve LSP server error messages for invalid paths/parse failures 
Change-Id: I1a72ee62e282991b0071d0135c9a658bc5f7e14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-14 17:07:48 +00:00
Konstantin Shcheglov 582bf2f230 Completion for constructors in enum constants. 
Change-Id: I3a68db8045d249f7459ec0dbf0fbd9c203fccade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 21:41:37 +00:00
Konstantin Shcheglov b62949ea1d Semantic highlighting for enums. 
Change-Id: Ib3e4aceec56b6bdd28b38a317c4c3981db87b7d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 18:50:57 +00:00
Konstantin Shcheglov 8b67b90016 A few tests for completion in class body and similar. 
Change-Id: Id8749e4c45d26a5e56de31ce0d8b117db60150a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 18:04:57 +00:00
Devon Carew 1a72a4ca8f [analysis server] remove the dep on package:cli_util 
Change-Id: I9a3b7b8c23dc324ad62f0d9b456e608d365133c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232423
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 21:27:34 +00:00
Konstantin Shcheglov 4a122c0b5a Add completion tests inside enum declaration. 
As we discussed some time ago, it is not clear to me where some
tests should go. Here, I put it into "location" tests, and checked
locations that seem strongly associated with the enum - its header,
its body; including the `WithClause` on the enum.

It is less clear where tests for completion inside the header or
the body of a method inside of an enum should go. I initially
planned to put them into `declaration/enum_test.dart`, but now
starting to doubt. The tests there are currently for using an
enum from outside.

Change-Id: Ife091f82bbb0ad1f26df984be42aa93a78595816
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 20:26:01 +00:00
Danny Tuppeny 74248dc6db [analysis_server] Use ConvertToPackageImport fix for always_use_package_imports lint 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3823.

Change-Id: I33d1448b36de1927e3e3cc5628d0d822d4f21786
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 19:45:31 +00:00
Sai Sandeep Mutyala 7605a36ab3 Add fix for sort_constructors_first lint. 
Bug: https://github.com/dart-lang/sdk/issues/47953
Change-Id: I0c927714f55eddd30d0c3770a3315118f64a160b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 06:03:59 +00:00
Sam Rawlins efe0af4cae Add functionality and tests for super-parameters in fixes for Hints and Errors 
Change-Id: I8e2c9754f65368ee5d1a243160e844b742506509
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232229
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-10 02:53:19 +00:00
Konstantin Shcheglov 96f5385295 Tests for searching enum children in analysis_server. 
Change-Id: I52b43a606cdac5165aa5ddd6c97741f276c1ebf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 19:12:56 +00:00
Sai Sandeep Mutyala 3de72ec6b0 Add fix for sort_unnamed_constructors_first lint. 
Change-Id: I08decb3d05612d0899c570597ce0a3b8e1eb1c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-09 06:51:07 +00:00
Nate Bosch 33e174084a Replace Uri.scheme == with Uri.isScheme 
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.

TEST=No behavior changes.

Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-02-08 21:38:57 +00:00
Danny Tuppeny afe70b7432 [analysis_server] Reduce the scope of a non-null-assertion to prevent errors during large renames 
This assertion is not sound and needs removing, but that requires additional changes to ensure callers (including plugins) provide line/col information. This change reduces the chance of it triggering (by avoiding it being used for context messages) in the meantime.

Change-Id: I73c861b69a795212ae0d59e30da6aa6bdd1bb3af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-08 16:47:56 +00:00
Brian Wilkerson 867e155ff6 Merge two error codes 
I was thinking about unifying these two codes for documentation purposes,
but then I wondered whether we might not want to unify them for reporting
purposes too. The reason I think it might be better to unify them is
because (a) they really represent a single problem (missing required
arguments) and (b) we were previously reporting the same problem multiple
times.

Change-Id: Iecf2865e67d61b03a1e1f56781e94e283d2a08e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 23:10:06 +00:00
fredbroz da97de73cb [analyzer] Add fix for avoid_void_async lint 
Closes https://github.com/dart-lang/sdk/issues/47959

Change-Id: I32838d7889cbaf9491d24672f19995cd6f75c2fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 19:57:35 +00:00
Konstantin Shcheglov 5198169e1a Suggest the exception and stack trace as local variables. 
Change-Id: Icffb93295db3be2e0b83c1ff2dd5dc01f1ce901d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 19:49:45 +00:00
Konstantin Shcheglov 52290eba28 Add CompletionSuggestion.libraryUri, keep isNotImported. 
Change-Id: I1bce246c2d8eaa968a47ae6ba82114592b991a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 22:49:10 +00:00
Konstantin Shcheglov f69d1f887f Use CompletionSuggestionBuilder, and HasCompletionData to store location independent data. 
Change-Id: I767bfc1c31b5aebc8f4e27267520f705701e7724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 17:33:19 +00:00
Brian Wilkerson a4b3b8edec Add an assist to convert a normal parameter to a super initializing parameter 
Change-Id: Icf5d44a3a155e67f76165eca711094d368cdca64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-04 01:03:36 +00:00
Konstantin Shcheglov ddff5ac88c Tests for completion in NamedExpression. 
Change-Id: I5a7ba57a1279797f7e625890a64c42091708f60e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-03 22:24:16 +00:00
fredbroz d48a637bf5 [Analyzer] Add fix for use_raw_strings lint 
Closes https://github.com/dart-lang/sdk/issues/47955

Bug: https://github.com/dart-lang/sdk/issues/47955
Change-Id: If321097598fcdcd79c246032f64332e91ee7f57c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-03 15:55:56 +00:00
Danny Tuppeny 4a5b0b3030 [analysis_server] Fix slash direction in auto-import details for LSP completions 
Fixes some failing tests on the Windows bots that were getting backslashes but expecting forward.

Change-Id: Idd89a45d7be87385d497e221a1941e4c48d597af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-02 17:26:09 +00:00
Keerti Parthasarathy eb4f5077ab Check for private elements while rename 
Change-Id: I3423cd746e675315a3abd1b728bc6cd978384beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-02-02 03:08:46 +00:00
Sam Rawlins 7a6326e49c Update fix statuses for 2.15, 2.16, 2.17 codes 
* many super-parameter codes can have a fix of "remove 'super.'"
* many constructor-tearoff codes can have a fix of "remove type
  arguments"
* did not evaluate the FfiCodes or PubspecWarningCodes

Change-Id: I3421f226ec88621d9927970cb607e13577c8f234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-01-28 17:19:22 +00:00
Sam Rawlins c49ccf09f1 Add a file to track all codes and fix status 
Also sort a few files.

In general only "has fix(es)" and "needs evaluation" has been marked so far.

Evaluations will come later.

Change-Id: Ibc2207a17ac158db795920216af2a7e9f376658c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-01-28 06:13:21 +00:00
Konstantin Shcheglov 6dd2790b57 Use cached enclosingClassElement for extension completion. 
This improves time to compute completion metrics from 61 to 48 seconds.

We used to spend 21% of all time in `[Stub] InstanceOf`.
Now 2%, unfortunately it does not show back pointers.

Change-Id: I3c6c62cabfa86bac138d95d4830b605693e086d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 23:34:42 +00:00
Danny Tuppeny 7a4c3c1c46 [analysis_server] Handle workspace folders with trailing slashes in LSP server 
Fixes https://github.com/dart-lang/sdk/issues/48234.

Change-Id: Ic10ab8054681779dd5ea6a1617e2f8a4057aee57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 17:09:30 +00:00
Danny Tuppeny 7ad1786e45 [analysis_server] Refactor completion handlers in preparation for using NotImportedContributor 
Change-Id: I18608b110093e87887f8e9118340e323fe829248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-26 20:07:28 +00:00
Konstantin Shcheglov 540c053ca8 Add HighlightRegionType.EXTENSION 
Change-Id: I375df19b8ee5f6570fcc7d440b9d71b148bcef73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-26 16:11:59 +00:00