0b349e8c0a
Compensate classic suggestions rather than penalizing cached ones
...
After a bit of manual testing it seems that subtracting 9 from
the relevanceBoost values given to the included suggestion tags
is overpenalizing them for any base suggestion set relevance
they might be holding on the client. We can compensate instead
by adding a medium size base relevance for classic completion
suggestions. The intention here is to make it so that neither
suggestion kind is universally preferred over the other for
ranking.
Change-Id: Ibaacbb35fc56c269271339df08d85b82fe6b6284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112150
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-08-07 01:19:37 +00:00
a62de52d04
Insert new named arguments before 'child' or 'children'.
...
R=brianwilkerson@google.com
Change-Id: Idbe5bb7efbeaa81a8f2319fab929944e7b3492d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112027
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-06 01:31:27 +00:00
211d7f2993
Do not throw away analysis server suggestions when inside quotes
...
Although analysis server does not suggest literals in general,
there are specific cases like import uris where it will make
suggestions.
Change-Id: I72cba31617adffdd4d7327d1963d115fbadf0bc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 23:38:29 +00:00
8b2993568e
implement dartfix --pedantic
...
This CL adds a new --pedantic option to dartfix for applying all fixes
marked as pedantic. In addition, this addresses comments in
https://dart-review.googlesource.com/c/sdk/+/111840
Change-Id: Ia2e7a792911f19edb698c126c8fd77cd8f8f77cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-08-05 20:18:05 +00:00
1c5911982e
add includePedanticFixes flag to dartfix protocol
...
Change-Id: I43c40eacf038beed6245ec873e746dcbb1ed80df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 20:18:05 +00:00
cdf6103b38
Support for free-form 'expression' in FlutterWidgetPropertyValue.
...
Also add ENUM_LIKE property editor, that is like ENUM, but allows
such free-form expressions.
R=brianwilkerson@google.com
Change-Id: I3910b6bea98110c192b6cc9fb716b73270e1d97c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111985
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-05 18:43:29 +00:00
3011ca2da7
Include "import function" fixes for UNDEFINED_IDENTIFIER
...
Change-Id: I66ad76e82f419ed19ca8e47574d1ec8335571bd5
Bug: https://github.com/Dart-Code/Dart-Code/issues/1898
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111738
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-08-05 16:27:07 +00:00
be581f69db
Move search.getDeclarations to available declarations.
...
So, we keep this feature working when switch to summary2.
IntelliJ does not use it though.
Change-Id: I11f71443dc7354de8a593442de470fa91aa228e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111870
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:10:06 +00:00
ed2764d055
remove unused import
...
Change-Id: I59a1d2ba11baed58ce60517c2c402f811eabd8f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111820
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-08-02 16:33:21 +00:00
f8f77eb4c0
Add keyword completion suggestions
...
Change-Id: I2ec6de7a68397aa9e43b155db52c5473e3d7035d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111667
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-02 15:09:01 +00:00
c0f23ce8bc
[nnbd_migration] fix kind -> description, drop empty, tests
...
Change-Id: I7224167ae26344336f665827b145c57319076d73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111382
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-08-02 07:35:41 +00:00
fc5b4e3cef
Rework dartfix lint fixes to remove race condition
...
This refactors the way that dartfix finds lints to fix to be based on
error codes rather than manually running the lints. This prevents
a race condition that occurs between calling setAnalysisRoots and
requesting fixes.
Fix https://github.com/dart-lang/sdk/issues/37558
Change-Id: I35817a9b152a28db9e78662a5ea5096f275f68bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-08-02 02:04:57 +00:00
42e978ca54
Fix Windows bot.
...
Change-Id: I4a92643e2007818555c96cd782c7ef9b6b17c42d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111670
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 21:31:32 +00:00
86bdb3e3fa
Clean up some warnings in analysis server code
...
This also sorts the content of these files. The analyzer team uses the Sort Members function on all of the source code in our packages.
Change-Id: Id0700954aefe63f6c7d2e43df021997f95ad7e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111663
Reviewed-by: Ari Aye <ariaye@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 21:24:00 +00:00
6123dbdae5
Support for extensions in available declarations.
...
R=brianwilkerson@google.com
Change-Id: Id173e18fb7e7167cae6677318cc6fca68889c8ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 02:26:22 +00:00
6a4d805df4
Implement 'Import Library' quick fix using DeclarationsTracker.
...
This reverts commit 143e5ef556https://dart-review.googlesource.com/c/sdk/+/111305
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-31 22:14:21 +00:00
3f22f1f5df
do not include double-to-int fix by default
...
This changes the default fixes applied by dartfix so that it no longer
converts doubles to ints by default. The fix can still be applied
by specifying '--fix double-to-int' on the command line.
Change-Id: I751a42a9c6ae6589259e0b7ac5c769fd4efc4313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-30 18:05:50 +00:00
8dc24d0919
report dartfix error for unknown fix
...
Change-Id: I0ebc73423d46ad5c07f4755847fe2ec68020428f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-30 18:05:50 +00:00
33ce54e45d
Don't try to start ML completion isolate on 32 bit systems
...
Instead of asking tflite_native to try to load a 32 bit dynamic library only to have it notice that none exist, we can simply disable ML ranking in analysis server.
Change-Id: Ibd001430d3e37f2fe854c72ef9f3f5466c96f46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-07-30 15:03:47 +00:00
db796d5b96
Fix for bad handling of predict response from model isolate
...
I also went ahead and updated the CIPD dart/language_model version to the latest model version.
Change-Id: I4522209150a90acfba210885316e78381c2aee45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-07-29 20:41:35 +00:00
1a0fe21fb2
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
This reverts commit b8614ca613https://dart-review.googlesource.com/c/sdk/+/110941
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-29 19:02:24 +00:00
fc82ed2286
Isolate-based CompletionRanking
...
Screenshots: https://i.imgur.com/IOLKOCU.png , https://i.imgur.com/dM9VsNr.png
Change-Id: Ieae0f9066b7a349bb4adff6b327b67bcae49aab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-29 13:45:23 +00:00
ec5bf35152
Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: If7365bd82b97bd692af9508697307976ea7c69e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-29 00:19:37 +00:00
b8614ca613
Revert InheritanceManager3 changes.
...
These changes were inadvertenly rolled out in a way that breaks
clients, so we need to stage them out more gradually. See discussion
at
https://dart-review.googlesource.com/c/sdk/+/110552/2/pkg/analyzer/lib/src/generated/resolver.dart#3768
This reverts commit 5b5ddeda92e76879acc427bec56744https://dart-review.googlesource.com/c/sdk/+/110841
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-07-28 13:54:09 +00:00
e57b7f2101
Update member sorter to sort extensions
...
Change-Id: I710123e389adfdd5191ff7538be17982d8f3630c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110767
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-27 14:06:30 +00:00
4c34d5825b
[analyzer] change listPostfixCompletionTemplates to not be async
...
Change-Id: I8a1ae029fde59a5bb8242c0578ebc44f40bae9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-07-26 21:43:31 +00:00
e76879acc4
Add 'inheritanceManager' to LinterContext.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I3cb4061afe1d2330494ac90c961e26c468eb5c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-26 21:35:26 +00:00
27bec56744
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
Initial: 5d6bab4ed239afa4e555https://dart-review.googlesource.com/c/sdk/+/110552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-26 16:16:11 +00:00
5d5a0c0164
Check in token-level language model via tflite ffi
...
Local test run after running `gclient sync`:
ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!
Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-25 18:39:51 +00:00
939cce78b9
Create analysis server flag --completion-model
...
This flag will take a path to a folder where completion language model
files can be located. Omitting this flag will signal to analysis server
that it should not use ML ranking for code completion, and the plan is
for this capability to initially be opt-in / disabled by default.
Change-Id: Ied18cd1e378c11607778fc116a7e0c3d72091e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-07-24 23:15:39 +00:00
eb057fe495
Send the correction as part of the diagnostic message in LSP
...
Change-Id: I894c90b7a895d36c3e9bee7623d1301c8c390b69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
2019-07-24 16:02:13 +00:00
eebbed2d7a
Make PropertyDescription constructor parameters named.
...
Also move next property id to PropertyDescription.
R=brianwilkerson@google.com
Change-Id: I96773a1c3e5c46c3111102aab03f8fff92fcd9a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109896
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-23 00:05:58 +00:00
17e15ee9a4
Add outline support for extensions
...
Change-Id: I1b7145e899614b3d73d3fc2bfbe3dd7f773d38d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 21:12:40 +00:00
1e04ff86b0
Mutate Aling(...) and Padding(...) into Container().
...
R=brianwilkerson@google.com
Change-Id: I5d15b93f3262cafe6915c5681c4baede87e7699a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 20:09:47 +00:00
1390201177
Support for 'padding' property, and EdgeInsets type.
...
R=brianwilkerson@google.com
Change-Id: I536ee3952d6e280a56b048773a3a5696bc508b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 17:15:28 +00:00
65d544edea
[analyzer] update the analysis server's diagnostic page
...
Change-Id: I22d58002a3753c7f3e5d5a218ca76a4de7560fce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-07-22 16:11:18 +00:00
1014272f3b
Extent 'alignment' property, copy from Align, virtual Container.
...
R=brianwilkerson@google.com
Change-Id: I9bec5b32e91f3cb77c4996f0ba0e7c2dd424316b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-19 21:41:03 +00:00
c1bb024479
Basic support for Container.alignment property.
...
R=brianwilkerson@google.com
Change-Id: I509df0b9c5d97e00a2f6ec50f31db1d07396f4ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-19 14:42:36 +00:00
07e5b20ec9
Insert new named arguments sorted.
...
R=brianwilkerson@google.com
Change-Id: I56d321160f21ebe20219fcc61288a0ebde1a21f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 22:16:58 +00:00
d57ebb0e1c
Fix reporting FLUTTER_GET_WIDGET_DESCRIPTION_NO_WIDGET.
...
R=brianwilkerson@google.com
Change-Id: Id4d84ab6240b4eb9444201c7cb7fca5d1743dacc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 21:55:00 +00:00
2d4973ca17
Format the function body containing the updated property.
...
R=brianwilkerson@google.com
Change-Id: I7f4f1bfa07b663d6079b639bc9003f2828c04e13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-18 21:07:00 +00:00
89a17f218b
Make getDescription() async.
...
We need to request additional elements for editors, and this is async
operation.
R=brianwilkerson@google.com
Change-Id: I451e80e32cf00fa0070f93123b33f0ee4b0ef759
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 19:58:10 +00:00
ddafed27cb
Support for enum values.
...
R=brianwilkerson@google.com
Change-Id: I1f95bfb8bd469981a9a6b4444670189a6619405a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 17:12:15 +00:00
ff03f01759
null_closures dartfix
...
EDIT: this is not working as is but puzzled as to why.
Dan: perhaps you could take a look?
Tracking issue: https://github.com/dart-lang/sdk/issues/37558
Thanks!
Change-Id: I7498159568807e05c22ba23550b6b0f74cf86e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-07-18 00:07:59 +00:00
b4e66ed3d0
Add highlighting for extensions
...
Change-Id: Ifa790e8e0830276cd794aa903aa5b2a9c1e03a97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-17 22:03:07 +00:00
9d204ca5d8
Start adding 'Container' properties.
...
R=brianwilkerson@google.com
Change-Id: I88c8194545dc3944318b897616e5a500c97ae4d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-17 20:03:54 +00:00
d14d5f1a0c
Better check for TextStyle opt-in for nested properties.
...
Not a huge different, just closer to what we might want in the future.
I decided to make it explicit opt-in for now, until we kow better.
R=brianwilkerson@google.com
Change-Id: Ied8defe87bfd8b35117af085389cbab7e9b7d589
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-17 01:04:27 +00:00
202379aaee
Implement getWidgetDescription and setPropertyValue in Flutter domain.
...
R=brianwilkerson@google.com
Change-Id: I45fdb0121bdd067856e5c9e72466d9a5c1a00e55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109313
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-16 21:32:37 +00:00
46eaf4b039
Extract PropertyDescription, support for nested properties.
...
R=brianwilkerson@google.com
Change-Id: I3bf4938136120d640aaddc64854973714db33265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109309
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-16 20:24:06 +00:00
65f8cd4365
Start implementing widget properties.
...
Only self properties for now.
No compound properties.
No virtual Container properties.
R=brianwilkerson@google.com
Change-Id: Icd61f45ecc95c45037c3998a927eb267fd13c4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-15 21:06:56 +00:00
Ari Aye
