dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
65,477 Commits 2 Branches 0 Tags
e59a4a2b42a61ba10600e63a80e665db6fdb3dc2
Commit Graph

4183 Commits

Author SHA1 Message Date
Ari Aye 0b349e8c0a Compensate classic suggestions rather than penalizing cached ones 
After a bit of manual testing it seems that subtracting 9 from
the relevanceBoost values given to the included suggestion tags
is overpenalizing them for any base suggestion set relevance
they might be holding on the client. We can compensate instead
by adding a medium size base relevance for classic completion
suggestions. The intention here is to make it so that neither
suggestion kind is universally preferred over the other for
ranking.

Change-Id: Ibaacbb35fc56c269271339df08d85b82fe6b6284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112150
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-08-07 01:19:37 +00:00
Konstantin Shcheglov e04dc4dd63 Update statuses and expectations with summary2 for some tests. 
R=brianwilkerson@google.com

Change-Id: I48eeb07a5423bb35512b4b583a9b2a942cb2d83a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-06 17:42:39 +00:00
Konstantin Shcheglov a62de52d04 Insert new named arguments before 'child' or 'children'. 
R=brianwilkerson@google.com

Change-Id: Idbe5bb7efbeaa81a8f2319fab929944e7b3492d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112027
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-06 01:31:27 +00:00
Ari Aye 211d7f2993 Do not throw away analysis server suggestions when inside quotes 
Although analysis server does not suggest literals in general,
there are specific cases like import uris where it will make
suggestions.

Change-Id: I72cba31617adffdd4d7327d1963d115fbadf0bc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-05 23:38:29 +00:00
danrubel 8b2993568e implement dartfix --pedantic 
This CL adds a new --pedantic option to dartfix for applying all fixes
marked as pedantic. In addition, this addresses comments in
https://dart-review.googlesource.com/c/sdk/+/111840

Change-Id: Ia2e7a792911f19edb698c126c8fd77cd8f8f77cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-05 20:18:05 +00:00
danrubel 1c5911982e add includePedanticFixes flag to dartfix protocol 
Change-Id: I43c40eacf038beed6245ec873e746dcbb1ed80df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-05 20:18:05 +00:00
Konstantin Shcheglov cdf6103b38 Support for free-form 'expression' in FlutterWidgetPropertyValue. 
Also add ENUM_LIKE property editor, that is like ENUM, but allows
such free-form expressions.

R=brianwilkerson@google.com

Change-Id: I3910b6bea98110c192b6cc9fb716b73270e1d97c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111985
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-05 18:43:29 +00:00
Danny Tuppeny 3011ca2da7 Include "import function" fixes for UNDEFINED_IDENTIFIER 
Change-Id: I66ad76e82f419ed19ca8e47574d1ec8335571bd5
Bug: https://github.com/Dart-Code/Dart-Code/issues/1898
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111738
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-08-05 16:27:07 +00:00
Konstantin Shcheglov be581f69db Move search.getDeclarations to available declarations. 
So, we keep this feature working when switch to summary2.
IntelliJ does not use it though.

Change-Id: I11f71443dc7354de8a593442de470fa91aa228e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111870
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-03 15:10:06 +00:00
pq ed2764d055 remove unused import 
Change-Id: I59a1d2ba11baed58ce60517c2c402f811eabd8f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111820
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-08-02 16:33:21 +00:00
Brian Wilkerson f8f77eb4c0 Add keyword completion suggestions 
Change-Id: I2ec6de7a68397aa9e43b155db52c5473e3d7035d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111667
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-02 15:09:01 +00:00
Mike Fairhurst c0f23ce8bc [nnbd_migration] fix kind -> description, drop empty, tests 
Change-Id: I7224167ae26344336f665827b145c57319076d73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111382
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-08-02 07:35:41 +00:00
danrubel fc5b4e3cef Rework dartfix lint fixes to remove race condition 
This refactors the way that dartfix finds lints to fix to be based on
error codes rather than manually running the lints. This prevents
a race condition that occurs between calling setAnalysisRoots and
requesting fixes.

Fix https://github.com/dart-lang/sdk/issues/37558

Change-Id: I35817a9b152a28db9e78662a5ea5096f275f68bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-02 02:04:57 +00:00
Konstantin Shcheglov 42e978ca54 Fix Windows bot. 
Change-Id: I4a92643e2007818555c96cd782c7ef9b6b17c42d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111670
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-01 21:31:32 +00:00
Brian Wilkerson 86bdb3e3fa Clean up some warnings in analysis server code 
This also sorts the content of these files. The analyzer team uses the Sort Members function on all of the source code in our packages.

Change-Id: Id0700954aefe63f6c7d2e43df021997f95ad7e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111663
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-01 21:24:00 +00:00
Alexander Markov 136aee0655 [analysis_server] Fix flaky hanging in analysis server benchmark 
This hanging was exposed when running analysis server benchmark on the VM
with bytecode due to different timings.

Benchmark was sending a request to analysis server and then subscribing to
a broadcast stream, which was populated from the output of analysis server
process.

Before the fix it was possible that benchmark wouldn't see
CompletionResultsParams which was posted to test.onCompletionResults
between sending a request and subscribing to test.onCompletionResults.
As a result, benchmark was waiting on a Future for a skipped
CompletionResultsParams indefinitely.

Change-Id: I6f282b504437d687ccac3e96fada201bf25dbd10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111484
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-08-01 16:30:13 +00:00
Konstantin Shcheglov 6123dbdae5 Support for extensions in available declarations. 
R=brianwilkerson@google.com

Change-Id: Id173e18fb7e7167cae6677318cc6fca68889c8ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-01 02:26:22 +00:00
Konstantin Shcheglov 6a4d805df4 Implement 'Import Library' quick fix using DeclarationsTracker. 
This reverts commit 143e5ef556.

Change-Id: I3c575ff690fd8c8d93a90e50a451a6ec993c4164
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111305
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-31 22:14:21 +00:00
danrubel 3f22f1f5df do not include double-to-int fix by default 
This changes the default fixes applied by dartfix so that it no longer
converts doubles to ints by default. The fix can still be applied
by specifying '--fix double-to-int' on the command line.

Change-Id: I751a42a9c6ae6589259e0b7ac5c769fd4efc4313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-30 18:05:50 +00:00
danrubel 8dc24d0919 report dartfix error for unknown fix 
Change-Id: I0ebc73423d46ad5c07f4755847fe2ec68020428f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-30 18:05:50 +00:00
Jaime Wren 871c66cad7 Remove the experimental flag on edit.getPostfixCompletion in the Analysis Server spec 
Change-Id: Ia3561dd6c80385e939a555c6d55c1460bda55835
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111308
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-07-30 17:38:11 +00:00
lambdabaa 33ce54e45d Don't try to start ML completion isolate on 32 bit systems 
Instead of asking tflite_native to try to load a 32 bit dynamic library only to have it notice that none exist, we can simply disable ML ranking in analysis server.

Change-Id: Ibd001430d3e37f2fe854c72ef9f3f5466c96f46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-30 15:03:47 +00:00
lambdabaa 8f0b6c89e2 Fix uri of dart_completion_ranking_internal_test.dart import 
Change-Id: Iafaff006e6b2d52b88498d3674e854fe284ae927
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-30 00:44:04 +00:00
Ari Aye 752f06fff5 Make sure to import and run completion_ranking_test_internal.dart in test_all.dart 
Change-Id: I410521737c7c7c2bd45377408769b3b6cbcb8425
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-29 20:41:43 +00:00
Ari Aye db796d5b96 Fix for bad handling of predict response from model isolate 
I also went ahead and updated the CIPD dart/language_model version to the latest model version.

Change-Id: I4522209150a90acfba210885316e78381c2aee45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-29 20:41:35 +00:00
Konstantin Shcheglov 1a0fe21fb2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
This reverts commit b8614ca613.

Change-Id: Ic31ee323b21311d8a89f50bcb533316eb55f75e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110941
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-29 19:02:24 +00:00
Ari Aye a650cb67f7 Make sure that completion_ranking_test.dart is loaded in test_all.dart 
Change-Id: I9933282a9e137c8a3014d1698bfaf50914b72cc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-29 17:01:52 +00:00
lambdabaa fc82ed2286 Isolate-based CompletionRanking 
Screenshots: https://i.imgur.com/IOLKOCU.png, https://i.imgur.com/dM9VsNr.png

Change-Id: Ieae0f9066b7a349bb4adff6b327b67bcae49aab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-29 13:45:23 +00:00
Konstantin Shcheglov ec5bf35152 Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If7365bd82b97bd692af9508697307976ea7c69e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-29 00:19:37 +00:00
Paul Berry b8614ca613 Revert InheritanceManager3 changes. 
These changes were inadvertenly rolled out in a way that breaks
clients, so we need to stage them out more gradually.  See discussion
at
https://dart-review.googlesource.com/c/sdk/+/110552/2/pkg/analyzer/lib/src/generated/resolver.dart#3768

This reverts commit 5b5ddeda92.
This reverts commit e76879acc4.
This reverts commit 27bec56744.

Change-Id: Ic80a577b1cdc4a6c89ca06afceae01af6621d3e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110841
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-28 13:54:09 +00:00
lambdabaa a9ebb5c3c8 Enable running language model unit tests on windows 
Change-Id: I63457934fcd23510f6a2848fbb00361ebb40a40f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-27 20:57:59 +00:00
Brian Wilkerson 306a592fe4 Add a test for hovers now that doc comments are preserved 
Change-Id: I7ee4397bcbf328aa41e96cd444470eb6fcaa7dbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-27 14:06:38 +00:00
Brian Wilkerson e57b7f2101 Update member sorter to sort extensions 
Change-Id: I710123e389adfdd5191ff7538be17982d8f3630c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110767
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-27 14:06:30 +00:00
Devon Carew 4c34d5825b [analyzer] change listPostfixCompletionTemplates to not be async 
Change-Id: I8a1ae029fde59a5bb8242c0578ebc44f40bae9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-07-26 21:43:31 +00:00
Konstantin Shcheglov e76879acc4 Add 'inheritanceManager' to LinterContext. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3cb4061afe1d2330494ac90c961e26c468eb5c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-26 21:35:26 +00:00
Brian Wilkerson 6241ea1788 Disable running a test from test_all that breaks when run from a parent directory 
Change-Id: I08c45f2e54c483e0cbe4bc46a9759c019c8d3f17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110743
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ari Aye <ariaye@google.com>
 2019-07-26 18:22:39 +00:00
Brian Wilkerson 8b81bb8115 Remove some unused imports 
Change-Id: I516b544b3bdff07e67f444024789093907369959
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110760
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-26 16:32:01 +00:00
Konstantin Shcheglov 27bec56744 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
Initial: 5d6bab4ed2.
Reverted: 39afa4e555
Change-Id: If611f96e6b0156ec218831dd64305e6ccf02e312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-26 16:16:11 +00:00
Ari Aye 5d5a0c0164 Check in token-level language model via tflite ffi 
Local test run after running `gclient sync`:

ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!


Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-25 18:39:51 +00:00
Ari Aye 939cce78b9 Create analysis server flag --completion-model 
This flag will take a path to a folder where completion language model
files can be located. Omitting this flag will signal to analysis server
that it should not use ML ranking for code completion, and the plan is
for this capability to initially be opt-in / disabled by default.

Change-Id: Ied18cd1e378c11607778fc116a7e0c3d72091e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-24 23:15:39 +00:00
Brian Wilkerson eb057fe495 Send the correction as part of the diagnostic message in LSP 
Change-Id: I894c90b7a895d36c3e9bee7623d1301c8c390b69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <dantup@google.com>
 2019-07-24 16:02:13 +00:00
Konstantin Shcheglov eebbed2d7a Make PropertyDescription constructor parameters named. 
Also move next property id to PropertyDescription.

R=brianwilkerson@google.com

Change-Id: I96773a1c3e5c46c3111102aab03f8fff92fcd9a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109896
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 00:05:58 +00:00
Brian Wilkerson 17e15ee9a4 Add outline support for extensions 
Change-Id: I1b7145e899614b3d73d3fc2bfbe3dd7f773d38d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 21:12:40 +00:00
Konstantin Shcheglov 1e04ff86b0 Mutate Aling(...) and Padding(...) into Container(). 
R=brianwilkerson@google.com

Change-Id: I5d15b93f3262cafe6915c5681c4baede87e7699a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 20:09:47 +00:00
Konstantin Shcheglov 1390201177 Support for 'padding' property, and EdgeInsets type. 
R=brianwilkerson@google.com

Change-Id: I536ee3952d6e280a56b048773a3a5696bc508b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 17:15:28 +00:00
Devon Carew 65d544edea [analyzer] update the analysis server's diagnostic page 
Change-Id: I22d58002a3753c7f3e5d5a218ca76a4de7560fce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-07-22 16:11:18 +00:00
Konstantin Shcheglov 1014272f3b Extent 'alignment' property, copy from Align, virtual Container. 
R=brianwilkerson@google.com

Change-Id: I9bec5b32e91f3cb77c4996f0ba0e7c2dd424316b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-19 21:41:03 +00:00
Konstantin Shcheglov c1bb024479 Basic support for Container.alignment property. 
R=brianwilkerson@google.com

Change-Id: I509df0b9c5d97e00a2f6ec50f31db1d07396f4ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-19 14:42:36 +00:00
Konstantin Shcheglov 07e5b20ec9 Insert new named arguments sorted. 
R=brianwilkerson@google.com

Change-Id: I56d321160f21ebe20219fcc61288a0ebde1a21f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-18 22:16:58 +00:00
Konstantin Shcheglov d57ebb0e1c Fix reporting FLUTTER_GET_WIDGET_DESCRIPTION_NO_WIDGET. 
R=brianwilkerson@google.com

Change-Id: Id4d84ab6240b4eb9444201c7cb7fca5d1743dacc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-18 21:55:00 +00:00